Re: md/dm-crypt: Rename a jump label in crypt_message() ?

2016-09-30 Thread Bjørn Mork
SF Markus Elfring writes: >> When someone tells you that you are wasting their time, > > This information can be useful to some degree Yes. If you continue discussing after that point, then you make a clear statement that it isn't an accident. You are

Re: md/dm-crypt: Rename a jump label in crypt_message() ?

2016-09-30 Thread Bjørn Mork
SF Markus Elfring writes: >> go around bothering everyone with waste of time cleanup patches. > > I find it still debatable if the shown software development efforts > are really "wasted". When someone tells you that you are wasting their time, then that is not a

Re: [PATCH V3] leds: trigger: Introduce an USB port trigger

2016-08-25 Thread Bjørn Mork
Greg KH writes: > On Thu, Aug 25, 2016 at 07:14:52AM +0200, Rafał Miłecki wrote: >> >> Good question. I would like to extend this USB port trigger in the >> future by reacting to USB activity. This involves playing with URBs >> and I believe that at that point it'd be

Re: [PATCH RFC V3.5] leds: trigger: Introduce an USB port trigger

2016-08-24 Thread Bjørn Mork
Rafał Miłecki writes: > The last big missing thing is Documentation update (this is why I'm > sending RFC). Greg pointed out we should have some entries in > Documentation/ABI, but it seems none of triggers have it. There's a lot missing, but there is at least one exception:

Re: [PATCH] CodingStyle: add some more error handling guidelines

2016-08-23 Thread Bjørn Mork
Dan Carpenter writes: > Hike up the mountain, then if you get stuck hike back down using the > exact same path. OK, I understand what you say. I just can't resist objecting to that example ;) In my experience, finding the exact same path back after hiking up a

Re: [PATCH] CodingStyle: add some more error handling guidelines

2016-08-23 Thread Bjørn Mork
"Michael S. Tsirkin" writes: > foo = kmalloc(SIZE, GFP_KERNEL); > if (!foo) > goto err_foo; > > foo->bar = kmalloc(SIZE, GFP_KERNEL); > if (!foo->bar) > goto err_bar;