Re: [PATCH V2 7/7] PCI: make reset poll time adjustable

2017-11-28 Thread Bjorn Helgaas
On Mon, Nov 27, 2017 at 01:20:28AM -0500, Sinan Kaya wrote: > Introduce pci=resetpolltime= argument to override 60 seconds poll time in > units of milliseconds. I resist adding kernel parameters because they really complicate the user experience. Obviously you added this for a reason, but I

Re: [PATCH v2 2/6] PCI / PM: Support for LEAVE_SUSPENDED driver flag

2017-11-08 Thread Bjorn Helgaas
l.j.wyso...@intel.com> > Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> Acked-by: Bjorn Helgaas <bhelg...@google.com> > --- > Documentation/power/pci.txt | 11 +++ > drivers/pci/pci-driver.c| 19 +-- > 2 files changed,

Re: [PATCH v2 5/6] PCI / PM: Take SMART_SUSPEND driver flag into account

2017-10-31 Thread Bjorn Helgaas
s > "suspended" at the same time, which is done quite often in the new > code (and will be done elsewhere going forward too). > > Signed-off-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com> > Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.or

Re: [PATCH 0/12] PM / sleep: Driver flags for system suspend/resume

2017-10-20 Thread Bjorn Helgaas
On Mon, Oct 16, 2017 at 03:12:35AM +0200, Rafael J. Wysocki wrote: > Hi All, > > Well, this took more time than expected, as I tried to cover everything I had > in mind regarding PM flags for drivers. For the parts that touch PCI, Acked-by: Bjorn Helgaas <bhelg...@google.com>

Re: [GIT PULL] PCI: Support for configurable PCI endpoint

2017-04-11 Thread Bjorn Helgaas
On Mon, Apr 10, 2017 at 10:43:28AM -0500, Bjorn Helgaas wrote: > On Wed, Apr 05, 2017 at 02:22:20PM +0530, Kishon Vijay Abraham I wrote: > > Hi Bjorn, > > > > Please find the pull request for PCI endpoint support below. I've > > also included all the history h

Re: [GIT PULL] PCI: Support for configurable PCI endpoint

2017-04-10 Thread Bjorn Helgaas
On Wed, Apr 05, 2017 at 02:22:20PM +0530, Kishon Vijay Abraham I wrote: > Hi Bjorn, > > Please find the pull request for PCI endpoint support below. I've > also included all the history here. Thanks, I applied these (with v7 of the first patch) to pci/host-designware for v4.12. > Changes from

Re: [PATCH v6 01/23] PCI: endpoint: Add EP core layer to enable EP controller and EP functions

2017-04-05 Thread Bjorn Helgaas
On Wed, Apr 05, 2017 at 02:22:21PM +0530, Kishon Vijay Abraham I wrote: > Introduce a new EP core layer in order to support endpoint functions in > linux kernel. This comprises the EPC library (Endpoint Controller Library) > and EPF library (Endpoint Function Library). EPC library implements >

Re: [GIT PULL] PCI: Support for configurable PCI endpoint

2017-04-04 Thread Bjorn Helgaas
s not able to access the +The PCIe programming sequence in TRM suggests CLKSTCTRL of PCIe should be +set to SW_WKUP. There are no issues when CLKSTCTRL is set to HW_AUTO in RC +mode. However in EP mode, the host system is not able to access the MEMSPACE and setting the CLKSTCTRL to S

Re: [PATCH 9/9] kernel-api.rst: fix a series of errors when parsing C files

2017-03-30 Thread Bjorn Helgaas
de/linux/clk.h:134: WARNING: Inline emphasis start-string without > end-string. > ./ipc/util.c:477: ERROR: Unknown target name: "s". > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Bjorn Helgaas <bhelg...@google.com> # for d

Re: [PATCH v7 0/4] New Microsemi PCI Switch Management Driver

2017-03-09 Thread Bjorn Helgaas
On Thu, Mar 02, 2017 at 04:24:30PM -0700, Logan Gunthorpe wrote: > Because getting it right correctly the first time is appearantly hard > and I caught this mistake while reading the email I had just sent :( > > I'm very sorry about the extra noise. > > Logan > > -- > > Changes since v6: > >

Re: [PATCH v5 0/4] New Microsemi PCI Switch Management Driver

2017-03-01 Thread Bjorn Helgaas
On Tue, Feb 28, 2017 at 10:11:56AM -0700, Logan Gunthorpe wrote: > > > This driver doesn't have anything to do with the PCI core, other than > > using the pci_register_driver() interface (just like all other drivers > > for PCI-connected devices), so drivers/pci doesn't really feel like > > the

Re: [PATCH v5 0/4] New Microsemi PCI Switch Management Driver

2017-03-01 Thread Bjorn Helgaas
On Sat, Feb 25, 2017 at 11:53:13PM -0700, Logan Gunthorpe wrote: > Changes since v4: > > * Turns out pushing the pci release code into the device release > function didn't work as I would have liked. If you try to unbind the > device with an instance open, then you hit a kernel bug at >

Re: [PATCH v5 0/4] New Microsemi PCI Switch Management Driver

2017-02-28 Thread Bjorn Helgaas
Hi Logan, On Sat, Feb 25, 2017 at 11:53:13PM -0700, Logan Gunthorpe wrote: > ... > This is a continuation of the RFC we posted lasted month [1] which > proposes a management driver for Microsemi's Switchtec line of PCI > switches. This hardware is still looking to be used in the Open > Compute

Re: [PATCH v2 3/4] switchtec: Add sysfs attributes to the Switchtec driver

2017-02-24 Thread Bjorn Helgaas
On Thu, Feb 23, 2017 at 03:56:21PM -0700, Logan Gunthorpe wrote: > > > On 23/02/17 03:43 PM, Bjorn Helgaas wrote: > > This path seems a little generic. I don't see other cases where a > > product brand name ("Switchtec") appears at the top level of >

Re: [PATCH v2 1/4] MicroSemi Switchtec management interface driver

2017-02-23 Thread Bjorn Helgaas
[+cc Peter, Ingo, Arnaldo, Alexander, Christoph] On Thu, Feb 02, 2017 at 11:06:00AM -0700, Logan Gunthorpe wrote: > Microsemi's "Switchtec" line of PCI switch devices is already well > supported by the kernel with standard PCI switch drivers. However, the > Switchtec device advertises a special

Re: [PATCH v2 3/4] switchtec: Add sysfs attributes to the Switchtec driver

2017-02-23 Thread Bjorn Helgaas
On Thu, Feb 02, 2017 at 11:06:02AM -0700, Logan Gunthorpe wrote: > This patch adds a few read-only sysfs attributes which provide > some device information that is exposed from the devices. Primarily > component and device names and versions. These are documented in >

Re: [PATCH v2 0/4] New Microsemi PCI Switch Management Driver

2017-02-23 Thread Bjorn Helgaas
On Thu, Feb 23, 2017 at 01:36:51PM -0700, Logan Gunthorpe wrote: > Hello, > > We're still waiting on any kind of response from Bjorn. (If you're > listening please say something!) > > Does anyone have any suggestions for dealing with an unresponsive > maintainer? Or a way for us to move forward

Re: two small PCI documentation fixups

2017-02-15 Thread Bjorn Helgaas
On Wed, Feb 15, 2017 at 08:58:21AM +0100, Christoph Hellwig wrote: > Avoid mentioning deprecated APIs and make the text a little > easier to understand. Applied to pci/msi for v4.11, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to

Re: [PATCH 00/37] PCI: Support for configurable PCI endpoint

2017-02-14 Thread Bjorn Helgaas
On Wed, Feb 01, 2017 at 06:01:58PM +0530, Kishon Vijay Abraham I wrote: > - list > > Hi Bjorn, > > How do you want to handle this series? I'll send one more version of the > series > including the directory restructuring in the same series. Should it be based > on > your -next? I think if you

Re: [PATCH v2] pci: drop link_reset

2017-02-09 Thread Bjorn Helgaas
On Tue, Jan 24, 2017 at 07:35:56PM +0200, Michael S. Tsirkin wrote: > No hardware seems to actually call link_reset, and > no driver implements it as more than a nop stub. > > This drops the mentions of the callback from everywhere. > It's dropped from the documentation as well, but > the doc

Re: [PATCH] CodingStyle: Expand IS_ENABLED() documentation

2016-09-27 Thread Bjorn Helgaas
On Tue, Sep 27, 2016 at 09:32:08PM +0200, Paul Bolle wrote: > On Tue, 2016-09-27 at 14:08 -0500, Bjorn Helgaas wrote: > > > --- a/Documentation/CodingStyle > > +++ b/Documentation/CodingStyle > > > +Because the compiler processes the block, you have to use an #ifdef

[PATCH] CodingStyle: Expand IS_ENABLED() documentation

2016-09-27 Thread Bjorn Helgaas
CodingStyle recommends IS_ENABLED(CONFIG_FOO) over #ifdef. Add an example of the #ifdef, since it's not completely obvious that in many cases the #ifdef needs to test both CONFIG_FOO and CONFIG_FOO_MODULE. Signed-off-by: Bjorn Helgaas <bhelg...@google.com> --- Documentation/CodingStyle

Re: [RESEND PATCH v2 4/4] PCI: Add support for enforcing all MMIO BARs to be page aligned

2016-06-20 Thread Bjorn Helgaas
On Thu, Jun 02, 2016 at 01:46:51PM +0800, Yongji Xie wrote: > When vfio passthrough a PCI device of which MMIO BARs are > smaller than PAGE_SIZE, guest will not handle the mmio > accesses to the BARs which leads to mmio emulations in host. > > This is because vfio will not allow to passthrough

Re: [RESEND PATCH v2 2/4] PCI: Do not Use IORESOURCE_STARTALIGN to identify bridge resources

2016-06-20 Thread Bjorn Helgaas
On Thu, Jun 02, 2016 at 01:46:49PM +0800, Yongji Xie wrote: > Now we use the IORESOURCE_STARTALIGN to identify bridge resources > in __assign_resources_sorted(). That's quite fragile. We can't > make sure that the PCI devices' resources will not use > IORESOURCE_STARTALIGN any more. Can you

Re: [RESEND PATCH v2 3/4] PCI: Add a new option for resource_alignment to reassign alignment

2016-06-20 Thread Bjorn Helgaas
On Thu, Jun 02, 2016 at 01:46:50PM +0800, Yongji Xie wrote: > When using resource_alignment kernel parameter, the current > implement reassigns the alignment by changing resources' size > which can potentially break some drivers. For example, the driver > uses the size to locate some register

Re: [RESEND PATCH v2 1/4] PCI: Ignore resource_alignment if PCI_PROBE_ONLY was set\\

2016-06-20 Thread Bjorn Helgaas
On Thu, Jun 02, 2016 at 01:46:48PM +0800, Yongji Xie wrote: > The resource_alignment will releases memory resources allocated > by firmware so that kernel can reassign new resources later on. > But this will cause the problem that no resources can be > allocated by kernel if PCI_PROBE_ONLY was

Re: [RFC PATCH v4 0/7] vfio-pci: Allow to mmap sub-page MMIO BARs and MSI-X table

2016-03-19 Thread Bjorn Helgaas
On Wed, Mar 16, 2016 at 06:51:56PM +0800, Yongji Xie wrote: > > Ping. This is mainly VFIO stuff, and Alex had some security concerns, so I'm not going to spend much time looking at this until he's satisfied. When I do, I'll be looking hard at the resource_alignment kernel parameter. I'm

Re: [RFC PATCH] arm: kernel: pci: remove pci=firmware command line parameter handling

2016-02-29 Thread Bjorn Helgaas
h the kernel code > currently handling them in that they have just become obsolete. > > This patch removes the pci=firmware command line parameter handling > from ARM code and the related kernel parameters documentation > section. > > Signed-off-by: Lorenzo Pieralisi <loren