Re: [RESEND PATCH v5] input: pxrc: new driver for PhoenixRC Flight Controller Adapter

2018-03-17 Thread Dmitry Torokhov
On Sun, Feb 18, 2018 at 05:17:46PM +0100, Marcus Folkesson wrote: > This driver let you plug in your RC controller to the adapter and > use it as input device in various RC simulators. > > Signed-off-by: Marcus Folkesson Applied, thank you. > --- > > v5: > -

Re: [PATCH v1] Input: docs - use PROPERTY_ENTRY_U32() directly

2018-01-22 Thread Dmitry Torokhov
On Mon, Jan 22, 2018 at 02:54:57PM +0200, Andy Shevchenko wrote: > Instead of using PROPERTY_ENTRY_INTEGER() with explicitly supplied type, > use PROPERTY_ENTRY_U32() dedicated macro. > > It will help modify internals of built-in device properties API. > > No functional change intended. > >

Re: [PATCH v3] input: pxrc: new driver for PhoenixRC Flight Controller Adapter

2018-01-19 Thread Dmitry Torokhov
On Wed, Jan 17, 2018 at 02:58:40PM +0100, Marcus Folkesson wrote: > Hello Dmitry, > > On Tue, Jan 16, 2018 at 03:16:25PM -0800, Dmitry Torokhov wrote: > > Hi Marcus, > > > > On Sat, Jan 13, 2018 at 09:15:32PM +0100, Marcus Folkesson wrote: > > > This drive

Re: [RESEND PATCH] Documentation: input: ff: fix small typos

2018-01-19 Thread Dmitry Torokhov
On Thu, Jan 18, 2018 at 04:49:03PM -0500, Jean-François Têtu wrote: > Fix small typos in the Instructions and Uploading sections. Fix a typo in > the start/stop effect example usage code. > > Signed-off-by: Jean-François Têtu Applied, thank you. > --- >

Re: [PATCH v3] input: pxrc: new driver for PhoenixRC Flight Controller Adapter

2018-01-16 Thread Dmitry Torokhov
Hi Marcus, On Sat, Jan 13, 2018 at 09:15:32PM +0100, Marcus Folkesson wrote: > This driver let you plug in your RC controller to the adapter and > use it as input device in various RC simulators. > > Signed-off-by: Marcus Folkesson > --- > v3: > - Use RUDDER

Re: [RESEND PATCH v2] input: pxrc: new driver for PhoenixRC Flight Controller Adapter

2018-01-12 Thread Dmitry Torokhov
On Thu, Jan 11, 2018 at 01:07:42PM +0100, Marcus Folkesson wrote: > Hi Dmitry, > > Thank you for your review! > > On Wed, Jan 10, 2018 at 04:37:14PM -0800, Dmitry Torokhov wrote: > > Hi Marcus, > > > > On Wed, Jan 10, 2018 at 02:11:39PM +0100, Marcus Folkesson

Re: [RESEND PATCH v2] input: pxrc: new driver for PhoenixRC Flight Controller Adapter

2018-01-10 Thread Dmitry Torokhov
Hi Marcus, On Wed, Jan 10, 2018 at 02:11:39PM +0100, Marcus Folkesson wrote: > This driver let you plug in your RC controller to the adapter and > use it as input device in various RC simulators. > > Signed-off-by: Marcus Folkesson > --- > v2: > - Change module

Re: [PATCH v5] HID: hid-multitouch: support fine-grain orientation reporting

2017-11-29 Thread Dmitry Torokhov
-> v5: > > - Improve multi-touch-protocol.rst documentation. > > > > Signed-off-by: Wei-Ning Huang <wnhu...@chromium.org> > > Signed-off-by: Wei-Ning Huang <wnhu...@google.com> > > Reviewed-by: Dmitry Torokhov <d...@chromium.org> > >

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-10-04 Thread Dmitry Torokhov
On Thu, Sep 28, 2017 at 12:22:13PM -0700, David Lin wrote: > On Wed, Sep 27, 2017 at 10:43 PM, Dmitry Torokhov > <dmitry.torok...@gmail.com> wrote: > >>One thing I noticed is that input_ff_create_memless() also does not > >>use high-resolution timer hence it al

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-27 Thread Dmitry Torokhov
On September 27, 2017 10:03:28 PM PDT, David Lin <dtw...@google.com> wrote: >Dmitry, > >On Fri, Sep 15, 2017 at 3:30 PM, Dmitry Torokhov ><dmitry.torok...@gmail.com> wrote: >> On Fri, Sep 15, 2017 at 2:55 PM, Jacek Anaszewski >> <jacek.anaszew...@gmail

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-19 Thread Dmitry Torokhov
On Tue, Sep 19, 2017 at 1:45 PM, Jacek Anaszewski <jacek.anaszew...@gmail.com> wrote: > On 09/19/2017 12:29 AM, Dmitry Torokhov wrote: >> On Mon, Sep 18, 2017 at 1:50 PM, Jacek Anaszewski >> <jacek.anaszew...@gmail.com> wrote: >>> Hi, >>> >>&g

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-18 Thread Dmitry Torokhov
On Mon, Sep 18, 2017 at 1:50 PM, Jacek Anaszewski wrote: > Hi, > > On 09/17/2017 08:22 PM, Pavel Machek wrote: >> Hi! >> If your objection is that FF is not easily engaged from the shell - yes, but I do not think that actual users who want to do vibration do

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-15 Thread Dmitry Torokhov
On Fri, Sep 15, 2017 at 2:55 PM, Jacek Anaszewski <jacek.anaszew...@gmail.com> wrote: > On 09/15/2017 08:34 PM, Dmitry Torokhov wrote: >> On Thu, Sep 14, 2017 at 1:58 PM, Pavel Machek <pa...@ucw.cz> wrote: >>> On Thu 2017-09-14 21:31:31, Jacek Anaszewski

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-15 Thread Dmitry Torokhov
On Thu, Sep 14, 2017 at 1:58 PM, Pavel Machek wrote: > On Thu 2017-09-14 21:31:31, Jacek Anaszewski wrote: >> Hi David and Pavel, >> >> On 09/13/2017 10:20 PM, Pavel Machek wrote: >> > Hi! >> > >> >> These patch series add the LED_BRIGHTNESS_FAST flag support for >> >>

Re: [PATCH v2 2/5] kmod: reduce atomic operations on kmod_concurrent

2017-05-25 Thread Dmitry Torokhov
On Thu, May 25, 2017 at 05:16:27PM -0700, Luis R. Rodriguez wrote: > When checking if we want to allow a kmod thread to kick off we increment, > then read to see if we should enable a thread. If we were over the allowed > limit limit we decrement. Splitting the increment far apart from decrement >

Re: [PATCH v2 4/5] kmod: add helpers for getting kmod limit

2017-05-25 Thread Dmitry Torokhov
On Thu, May 25, 2017 at 05:16:29PM -0700, Luis R. Rodriguez wrote: > This adds helpers for getting access to the kmod limit from > userspace. This knob should help userspace more gracefully and > deterministically handle module loading. I think more details is needed before we add a new ABI to

Re: [PATCH 1/6] kmod: add dynamic max concurrent thread count

2017-05-25 Thread Dmitry Torokhov
On Thu, May 25, 2017 at 08:06:03PM +0200, Luis R. Rodriguez wrote: > On Thu, May 25, 2017 at 10:38:40AM -0700, Luis R. Rodriguez wrote: > > On Thu, May 25, 2017 at 10:30 AM, Dmitry Torokhov > > > There is > > > no slippery slope for systems to move away, no need to backp

Re: [PATCH 1/6] kmod: add dynamic max concurrent thread count

2017-05-25 Thread Dmitry Torokhov
On Thu, May 25, 2017 at 09:50:15AM -0700, Luis R. Rodriguez wrote: > On Thu, May 25, 2017 at 9:38 AM, Dmitry Torokhov > <dmitry.torok...@gmail.com> wrote: > > On Thu, May 25, 2017 at 06:22:01PM +0200, Luis R. Rodriguez wrote: > >> On Fri, May 19, 2017 at 02:58:29PM -

Re: [PATCH 5/6] kmod: preempt on kmod_umh_threads_get()

2017-05-25 Thread Dmitry Torokhov
On Thu, May 25, 2017 at 01:19:31PM +0200, Petr Mladek wrote: > On Wed 2017-05-24 19:27:38, Dmitry Torokhov wrote: > > On Thu, May 25, 2017 at 03:00:17AM +0200, Luis R. Rodriguez wrote: > > > On Wed, May 24, 2017 at 05:45:37PM -0700, Dmitry Torokhov wrote: > > > > On T

Re: [PATCH 1/6] kmod: add dynamic max concurrent thread count

2017-05-25 Thread Dmitry Torokhov
On Thu, May 25, 2017 at 06:22:01PM +0200, Luis R. Rodriguez wrote: > On Fri, May 19, 2017 at 02:58:29PM -0700, Dmitry Torokhov wrote: > > On Fri, May 19, 2017 at 02:45:29PM -0700, Luis R. Rodriguez wrote: > > > On May 19, 2017 1:45 PM, "Dmitry Torokhov" <dmitry.

Re: [PATCH 5/6] kmod: preempt on kmod_umh_threads_get()

2017-05-24 Thread Dmitry Torokhov
On Thu, May 25, 2017 at 03:00:17AM +0200, Luis R. Rodriguez wrote: > On Wed, May 24, 2017 at 05:45:37PM -0700, Dmitry Torokhov wrote: > > On Thu, May 25, 2017 at 02:14:52AM +0200, Luis R. Rodriguez wrote: > > > On Fri, May 19, 2017 at 03:27:12PM -0700, Dmitry Torokhov wrote: >

Re: [PATCH 5/6] kmod: preempt on kmod_umh_threads_get()

2017-05-24 Thread Dmitry Torokhov
On Thu, May 25, 2017 at 02:14:52AM +0200, Luis R. Rodriguez wrote: > On Fri, May 19, 2017 at 03:27:12PM -0700, Dmitry Torokhov wrote: > > On Thu, May 18, 2017 at 08:24:43PM -0700, Luis R. Rodriguez wrote: > > > In theory it is possible multiple concurren

Re: [PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter

2017-05-22 Thread Dmitry Torokhov
On Mon, May 08, 2017 at 11:11:46AM -0500, Rob Herring wrote: > On Tue, May 02, 2017 at 05:00:59PM +0200, Martin Kepplinger wrote: > > The datasheet and application note does not mention an allowed range for > > the M09_REGISTER_THRESHOLD parameter. One of our customers needs to set > > lower

Re: [PATCH 5/6] kmod: preempt on kmod_umh_threads_get()

2017-05-19 Thread Dmitry Torokhov
On Thu, May 18, 2017 at 08:24:43PM -0700, Luis R. Rodriguez wrote: > In theory it is possible multiple concurrent threads will try to > kmod_umh_threads_get() and as such atomic_inc(_concurrent) at > the same time, therefore enabling a small time during which we've > bumped kmod_concurrent but

Re: [PATCH 6/6] kmod: use simplified rate limit printk

2017-05-19 Thread Dmitry Torokhov
On Thu, May 18, 2017 at 08:24:44PM -0700, Luis R. Rodriguez wrote: > Just use the simplified rate limit printk when the max modprobe > limit is reached, while at it throw out a bone should the error > be triggered. > > Reviewed-by: Petr Mladek > Signed-off-by: Luis R. Rodriguez

Re: [PATCH 1/6] kmod: add dynamic max concurrent thread count

2017-05-19 Thread Dmitry Torokhov
On Fri, May 19, 2017 at 02:45:29PM -0700, Luis R. Rodriguez wrote: > On May 19, 2017 1:45 PM, "Dmitry Torokhov" <dmitry.torok...@gmail.com> > wrote: > > On Thu, May 18, 2017 at 08:24:39PM -0700, Luis R. Rodriguez wrote: > > We currently statically limit the numbe

Re: [PATCH 1/6] kmod: add dynamic max concurrent thread count

2017-05-19 Thread Dmitry Torokhov
On Thu, May 18, 2017 at 08:24:39PM -0700, Luis R. Rodriguez wrote: > We currently statically limit the number of modprobe threads which > we allow to run concurrently to 50. As per Keith Owens, this was a > completely arbitrary value, and it was set in the 2.3.38 days [0] > over 16 years ago in

Re: [PATCH v6] Documentation: Input: Add uinput documentation

2017-04-25 Thread Dmitry Torokhov
On Sun, Apr 23, 2017 at 03:40:50PM -0300, Marcos Paulo de Souza wrote: > Signed-off-by: Marcos Paulo de Souza > --- I adjusted wording a bit here and there and applied, thank you. > > v5 -> v6: > Resend v5, but now include a change into input_uapi.rst (added by

[PATCH] Input: xpad - do not suggest writing to Dominic

2017-04-17 Thread Dmitry Torokhov
Do not recommend people write to Dominic, rather everyone should be using linux-input mailing list. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- Documentation/input/devices/xpad.rst | 6 -- 1 file changed, 6 deletions(-) diff --git a/Documentation/input/devices/xpad.

Re: [PATCH 1/4] input: xpad.rst: usb/devices is now at /sys/kernel/debug/

2017-04-17 Thread Dmitry Torokhov
On Mon, Apr 17, 2017 at 09:46:13AM -0300, Mauro Carvalho Chehab wrote: > The /proc/bus/usb/devices got moved to sysfs. It is now > sitting at: > /sys/kernel/debug/usb/devices > > Signed-off-by: Mauro Carvalho Chehab Applied, thank you. > --- >

Re: [PATCH 2/4] input: xpad.rst: Don't use literal blocks inside footnotes

2017-04-17 Thread Dmitry Torokhov
On Mon, Apr 17, 2017 at 09:46:14AM -0300, Mauro Carvalho Chehab wrote: > Unfortunately, Sphinx (or LaTeX) can't handle literal blocks > inside footnotes. So, just use normal text for the two > literal code-blocks that documents the output of > /sys/kernel/debug/usb/devices for xpad devices. > >

Re: [PATCH 3/4] input: xpad.rst: proc/bus/usb was renamed to dev/bus/usb

2017-04-17 Thread Dmitry Torokhov
Hi Mauro, On Mon, Apr 17, 2017 at 09:46:15AM -0300, Mauro Carvalho Chehab wrote: > xpad.rst requests a dump of the USB description, as found > on the USB character device. When we got rid of usbfs, > its location change. Update it. I have not heard from Dom ever so I think the best option is to

[PATCH 2/8] Input: rotary-encoder - remove references to platform data from docs

2017-04-15 Thread Dmitry Torokhov
The driver has been converted to use generic device properties, so stop referring to platform data. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- Documentation/input/rotary-encoder.rst | 85 ++ 1 file changed, 44 insertions(+), 41 del

[PATCH 3/8] Input: fix "Game console" heading level in joystick documentation

2017-04-15 Thread Dmitry Torokhov
The heading level should be the same as for other devices. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- Documentation/input/joystick.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/input/joystick.rst b/Documentation/input/joystick.rst

[PATCH 1/8] Input: move documentation for Amiga CD32

2017-04-15 Thread Dmitry Torokhov
Move the documentation for Amiga CD32 together with other parallel port joysticks. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- Documentation/input/cd32.rst | 24 - Documentation/input/index.rst| 1 - Documentation/input/jo

[PATCH 6/8] Input: docs - note that MT-A protocol is obsolete

2017-04-15 Thread Dmitry Torokhov
Everyone should be using multitouch protocol B (slotted) now. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- Documentation/input/multi-touch-protocol.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/input/multi-touch-protocol.

[PATCH 4/8] Input: docs - remove disclaimer/GPL notice

2017-04-15 Thread Dmitry Torokhov
This is just a part of kernel documentation, it does not require explicit license notice. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- Documentation/input/index.rst | 21 - 1 file changed, 21 deletions(-) diff --git a/Documentation/input/index

[PATCH 5/8] Input: docs - update joystick documentation a bit

2017-04-15 Thread Dmitry Torokhov
Consolidate use instructions and userspace API notes into the same chapter; remove completely obsolete references, move into a separate subdirectory. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- Documentation/input/index.rst | 6 +- Documentation

[PATCH 8/8] Input: docs - freshen up introduction

2017-04-15 Thread Dmitry Torokhov
Stop saying that API is experimental and that only USB is supported, acknowledge that evdev is the preferred interface, and remove paragraph encouraging people sending snail mail to Vojtech :) along with his email. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- Documen

Re: [PATCH v4 3/5] input: add a EV_SW event for ratchet switch

2017-04-15 Thread Dmitry Torokhov
Hi Mauro, On Tue, Apr 11, 2017 at 10:29:40AM -0300, Mauro Carvalho Chehab wrote: > Some mice have a switch on their wheel, allowing to switch > between ratchet and free wheel mode. Add support for it. > > Signed-off-by: Mauro Carvalho Chehab > --- >

[PATCH v2] rapidio: use is_visible() to hide switch-specific attributes

2017-02-15 Thread Dmitry Torokhov
of files that are scanned when compiling RapiodIO documentations as it no longer has any structured comments, and leaving it in leads to warning when building docs. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- v2: drop rio-sysfs.c from Documentation/DocBook/rapidio.tmpl to

Re: [PATCH v4 8/8] Input: elan_i2c - add Host Notify support

2016-10-11 Thread Dmitry Torokhov
On Tue, Oct 11, 2016 at 04:20:52PM +0200, Benjamin Tissoires wrote: > On Oct 10 2016 or thereabouts, Dmitry Torokhov wrote: > > Hi Benjamin, > > > > On Mon, Oct 10, 2016 at 9:42 AM, Benjamin Tissoires > > <benjamin.tissoi...@redhat.com> wrote: > > &g

Re: [PATCH v4 8/8] Input: elan_i2c - add Host Notify support

2016-10-10 Thread Dmitry Torokhov
Hi Benjamin, On Mon, Oct 10, 2016 at 9:42 AM, Benjamin Tissoires wrote: > The Thinkpad series 13 uses Host Notify to report the interrupt. > Add elan_smb_alert() to handle those interrupts and disable the irq > handling on this case. > > Signed-off-by: Benjamin

Re: [RFC] fs: add userspace critical mounts event support

2016-09-24 Thread Dmitry Torokhov
On Fri, Sep 23, 2016 at 6:37 PM, Herbert, Marc <marc.herb...@intel.com> wrote: > On 03/09/2016 11:10, Dmitry Torokhov wrote: >> I was thinking if we kernel could post >> "conditions" (maybe simple stings) that it waits for, and userspace >> could unlock

Re: [RFC] fs: add userspace critical mounts event support

2016-09-03 Thread Dmitry Torokhov
On Sat, Sep 3, 2016 at 11:01 AM, Linus Torvalds <torva...@linux-foundation.org> wrote: > On Sat, Sep 3, 2016 at 10:49 AM, Dmitry Torokhov > <dmitry.torok...@gmail.com> wrote: >> >> Unfortunately module loading and availability of firmware is very >> loosely cou

Re: [RFC] fs: add userspace critical mounts event support

2016-09-03 Thread Dmitry Torokhov
On Fri, Sep 02, 2016 at 09:41:18PM -0700, Linus Torvalds wrote: > On Sep 2, 2016 9:20 PM, "Dmitry Torokhov" <dmitry.torok...@gmail.com> wrote: > > > > Like what? Some devices do need to have firmware loaded so we know > > their capabilities, so we r

Re: [RFC] fs: add userspace critical mounts event support

2016-09-02 Thread Dmitry Torokhov
On Fri, Sep 2, 2016 at 9:11 PM, Linus Torvalds wrote: > On Fri, Sep 2, 2016 at 5:20 PM, Luis R. Rodriguez wrote: >> >> Thoughts ? > > I really think this is a horrible hack. > > It's basically the kernel giving up, and relying on user space to

Re: [PATCH v8 4/4] Input: synaptics-rmi4 - add SMBus support

2016-06-24 Thread Dmitry Torokhov
On Fri, Jun 24, 2016 at 09:19:32AM +0200, Benjamin Tissoires wrote: > On Jun 23 2016 or thereabouts, Dmitry Torokhov wrote: > > On Thu, Jun 09, 2016 at 04:53:50PM +0200, Benjamin Tissoires wrote: > > > + > > > +static struct i2c_driver rmi_smb_driver = { > > >

Re: [PATCH v8 4/4] Input: synaptics-rmi4 - add SMBus support

2016-06-23 Thread Dmitry Torokhov
Hi Benjamin, On Thu, Jun 09, 2016 at 04:53:50PM +0200, Benjamin Tissoires wrote: > + > +struct mapping_table_entry { > + u16 rmiaddr; Should be __le16 rmiaddr, otherwise: CHECK drivers/input/rmi4/rmi_smbus.c drivers/input/rmi4/rmi_smbus.c:116:33: warning: incorrect type in assignment

Re: [PATCH v8 3/4] i2c: i801: add support of Host Notify

2016-06-23 Thread Dmitry Torokhov
On Thu, Jun 23, 2016 at 11:46:55PM +0200, Wolfram Sang wrote: > On Thu, Jun 23, 2016 at 01:55:52PM -0700, Dmitry Torokhov wrote: > > On Thu, Jun 16, 2016 at 08:09:42AM +0200, Wolfram Sang wrote: > > > > > - removed the .resume hook as upstream chan

Re: [PATCH v8 3/4] i2c: i801: add support of Host Notify

2016-06-23 Thread Dmitry Torokhov
On Thu, Jun 16, 2016 at 08:09:42AM +0200, Wolfram Sang wrote: > > > - removed the .resume hook as upstream changed suspend/resume hooks and > > > there > > > is no need in the end to re-enable host notify on resume (tested on > > > Lenovo > > > t440 and t450). > > > > Actually, this hook

Re: [PATCH v5 13/24] input: misc: max8997: explicitly apply PWM config extracted from pwm_args

2016-04-17 Thread Dmitry Torokhov
On Thu, Apr 14, 2016 at 09:17:33PM +0200, Boris Brezillon wrote: > Call pwm_apply_args() just after requesting the PWM device so that the > polarity and period are initialized according to the information provided > in pwm_args. > > This is an intermediate state, and pwm_apply_args() should be

Re: [PATCH v5 32/46] pwm: deprecate pwm_config(), pwm_enable() and pwm_disable()

2016-03-31 Thread Dmitry Torokhov
Hi Boris, On Wed, Mar 30, 2016 at 10:03:55PM +0200, Boris Brezillon wrote: > Prefix those function as deprecated to encourage all existing users to > switch to pwm_apply_state(). Why not keep at least some of them as wrappers where we do not need to chnage several parameters at once? It is much