Re: [PATCH v5 3/5] i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller

2018-05-22 Thread Karthik Ramasubramanian
On 5/21/2018 2:49 PM, Wolfram Sang wrote: > Hi, > > On Fri, Mar 23, 2018 at 02:20:59PM -0600, Karthikeyan Ramasubramanian wrote: >> This bus driver supports the GENI based i2c hardware controller in the >> Qualcomm SOCs. The Qualcomm Generic Interface (GENI) is a programmable >> module supportin

Re: [PATCH v6 0/5] Introduce GENI SE Controller Driver

2018-04-05 Thread Karthik Ramasubramanian
Hi Maintainers, Sorry if I am stepping in too soon. Since all the patches in this series have been reviewed and remaining silent for some time, would you please mind pulling in these patches as part of your next pull request. Thanks and Regards, Karthik. On 3/30/2018 11:08 AM, Karthikeyan Ramasu

Re: [PATCH v4 4/6] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

2018-03-22 Thread Karthik Ramasubramanian
On 3/21/2018 11:20 AM, Stephen Boyd wrote: > Quoting Karthik Ramasubramanian (2018-03-20 15:53:25) >> >> >> On 3/20/2018 9:37 AM, Stephen Boyd wrote: >>> Quoting Karthikeyan Ramasubramanian (2018-03-14 16:58:49) >>>> diff --git a/drivers/tty/serial/qco

Re: [PATCH v4 4/6] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

2018-03-20 Thread Karthik Ramasubramanian
On 3/20/2018 12:39 PM, Evan Green wrote: > Hi Karthik, > > On Wed, Mar 14, 2018 at 4:59 PM Karthikeyan Ramasubramanian < > krama...@codeaurora.org> wrote: > >> + >> +static bool qcom_geni_serial_poll_bit(struct uart_port *uport, >> + int offset, int field, bool set

Re: [PATCH v4 4/6] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

2018-03-20 Thread Karthik Ramasubramanian
On 3/20/2018 9:37 AM, Stephen Boyd wrote: > Quoting Karthikeyan Ramasubramanian (2018-03-14 16:58:49) >> diff --git a/drivers/tty/serial/qcom_geni_serial.c >> b/drivers/tty/serial/qcom_geni_serial.c >> new file mode 100644 >> index 000..1442777 >> --- /dev/null >> +++ b/drivers/tty/serial/qc

Re: [PATCH v4 3/6] i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller

2018-03-20 Thread Karthik Ramasubramanian
On 3/19/2018 3:08 PM, Doug Anderson wrote: > Hi, > > On Wed, Mar 14, 2018 at 4:58 PM, Karthikeyan Ramasubramanian > wrote: >> This bus driver supports the GENI based i2c hardware controller in the >> Qualcomm SOCs. The Qualcomm Generic Interface (GENI) is a programmable >> module supporting a w

Re: [PATCH v3 4/4] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

2018-03-13 Thread Karthik Ramasubramanian
On 3/2/2018 5:11 PM, Evan Green wrote: >> + >> +#ifdef CONFIG_CONSOLE_POLL >> +#define RX_BYTES_PW 1 >> +#else >> +#define RX_BYTES_PW 4 >> +#endif > > This seems fishy to me. Does either setting work? If so, why not just > have one value? Yes, either one works. In the interrupt driven mode, som

Re: [PATCH v3 2/4] soc: qcom: Add GENI based QUP Wrapper driver

2018-03-09 Thread Karthik Ramasubramanian
On 3/6/2018 2:56 PM, Stephen Boyd wrote: Quoting Karthik Ramasubramanian (2018-03-02 16:58:23) On 3/2/2018 1:41 PM, Stephen Boyd wrote: Quoting Karthikeyan Ramasubramanian (2018-02-27 17:38:07) +/** + * geni_se_read_proto() - Read the protocol configured for a Serial Engine + * @se

Re: [v3, 3/4] i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller

2018-03-08 Thread Karthik Ramasubramanian
On 3/7/2018 2:16 PM, Doug Anderson wrote: Hi, On Tue, Feb 27, 2018 at 5:38 PM, Karthikeyan Ramasubramanian wrote: This bus driver supports the GENI based i2c hardware controller in the Qualcomm SOCs. The Qualcomm Generic Interface (GENI) is a programmable module supporting a wide range of se

Re: [PATCH v3 4/4] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

2018-03-08 Thread Karthik Ramasubramanian
On 3/8/2018 3:32 PM, Stephen Boyd wrote: Quoting Karthik Ramasubramanian (2018-03-07 22:06:29) On 3/6/2018 2:45 PM, Stephen Boyd wrote: Quoting Karthik Ramasubramanian (2018-03-05 16:51:23) On 3/2/2018 3:11 PM, Stephen Boyd wrote: Ok. I've seen similar designs in some mmc drivers

Re: [PATCH v3 2/4] soc: qcom: Add GENI based QUP Wrapper driver

2018-03-08 Thread Karthik Ramasubramanian
On 3/8/2018 6:24 AM, Robin Murphy wrote: On 08/03/18 06:46, Karthik Ramasubramanian wrote: On 3/6/2018 2:56 PM, Stephen Boyd wrote: Quoting Karthik Ramasubramanian (2018-03-02 16:58:23) +   return iova; +} +EXPORT_SYMBOL(geni_se_tx_dma_prep); + +/** + * geni_se_rx_dma_prep

Re: [PATCH v3 2/4] soc: qcom: Add GENI based QUP Wrapper driver

2018-03-07 Thread Karthik Ramasubramanian
On 3/6/2018 2:56 PM, Stephen Boyd wrote: Quoting Karthik Ramasubramanian (2018-03-02 16:58:23) + return iova; +} +EXPORT_SYMBOL(geni_se_tx_dma_prep); + +/** + * geni_se_rx_dma_prep() - Prepare the Serial Engine for RX DMA transfer + * @se:Pointer to the

Re: [PATCH v3 4/4] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

2018-03-07 Thread Karthik Ramasubramanian
On 3/6/2018 2:45 PM, Stephen Boyd wrote: Quoting Karthik Ramasubramanian (2018-03-05 16:51:23) On 3/2/2018 3:11 PM, Stephen Boyd wrote: Quoting Karthikeyan Ramasubramanian (2018-02-27 17:38:09) + size_t chars_to_write = 0; + size_t avail = DEF_FIFO_DEPTH_WORDS

Re: [PATCH v3 1/4] dt-bindings: soc: qcom: Add device tree binding for GENI SE

2018-03-06 Thread Karthik Ramasubramanian
On 3/6/2018 6:22 AM, Rob Herring wrote: On Mon, Mar 5, 2018 at 6:55 PM, Karthik Ramasubramanian wrote: On 3/5/2018 4:58 PM, Rob Herring wrote: On Tue, Feb 27, 2018 at 06:38:06PM -0700, Karthikeyan Ramasubramanian wrote: Add device tree binding support for the QCOM GENI SE driver

Re: [PATCH v3 1/4] dt-bindings: soc: qcom: Add device tree binding for GENI SE

2018-03-05 Thread Karthik Ramasubramanian
On 3/5/2018 4:58 PM, Rob Herring wrote: On Tue, Feb 27, 2018 at 06:38:06PM -0700, Karthikeyan Ramasubramanian wrote: Add device tree binding support for the QCOM GENI SE driver. Signed-off-by: Karthikeyan Ramasubramanian Signed-off-by: Sagar Dharia Signed-off-by: Girish Mahadevan --- ...

Re: [PATCH v3 4/4] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

2018-03-05 Thread Karthik Ramasubramanian
On 3/2/2018 3:11 PM, Stephen Boyd wrote: Quoting Karthikeyan Ramasubramanian (2018-02-27 17:38:09) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index 3682fd3..c6b1500 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -1104,6 +1104,17 @@ config

Re: [PATCH v3 2/4] soc: qcom: Add GENI based QUP Wrapper driver

2018-03-02 Thread Karthik Ramasubramanian
On 3/2/2018 1:41 PM, Stephen Boyd wrote: Quoting Karthikeyan Ramasubramanian (2018-02-27 17:38:07) This driver manages the Generic Interface (GENI) firmware based Qualcomm Universal Peripheral (QUP) Wrapper. GENI based QUP is the next generation programmable module composed of multiple Serial

Re: [PATCH v2 7/7] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

2018-02-27 Thread Karthik Ramasubramanian
On 1/19/2018 12:12 AM, Bjorn Andersson wrote: On Fri 12 Jan 17:05 PST 2018, Karthikeyan Ramasubramanian wrote: This driver supports GENI based UART Controller in the Qualcomm SOCs. The Qualcomm Generic Interface (GENI) is a programmable module supporting a wide range of serial interfaces incl

Re: [PATCH v2 6/7] dt-bindings: serial: Add bindings for GENI based UART Controller

2018-02-27 Thread Karthik Ramasubramanian
On 1/16/2018 11:35 PM, Bjorn Andersson wrote: On Fri 12 Jan 17:05 PST 2018, Karthikeyan Ramasubramanian wrote: Add device tree binding support for GENI based UART Controller in the QUP Wrapper. Signed-off-by: Karthikeyan Ramasubramanian Signed-off-by: Girish Mahadevan --- .../devicetree/

Re: [v2, 7/7] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

2018-02-27 Thread Karthik Ramasubramanian
On 2/23/2018 11:06 AM, Guenter Roeck wrote: On Fri, Jan 12, 2018 at 06:05:47PM -0700, Karthikeyan Ramasubramanian wrote: This driver supports GENI based UART Controller in the Qualcomm SOCs. The Qualcomm Generic Interface (GENI) is a programmable module supporting a wide range of serial interf

Re: [PATCH v2 5/7] i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller

2018-02-27 Thread Karthik Ramasubramanian
On 1/17/2018 10:23 PM, Bjorn Andersson wrote: On Fri 12 Jan 17:05 PST 2018, Karthikeyan Ramasubramanian wrote: This bus driver supports the GENI based i2c hardware controller in the Qualcomm SOCs. The Qualcomm Generic Interface (GENI) is a programmable module supporting a wide range of serial

Re: [PATCH v2 4/7] dt-bindings: i2c: Add device tree bindings for GENI I2C Controller

2018-02-26 Thread Karthik Ramasubramanian
On 1/16/2018 11:31 PM, Bjorn Andersson wrote: On Fri 12 Jan 17:05 PST 2018, Karthikeyan Ramasubramanian wrote: Add device tree binding support for I2C Controller in GENI based QUP Wrapper. Signed-off-by: Sagar Dharia Signed-off-by: Karthikeyan Ramasubramanian --- .../devicetree/bindings/

Re: [PATCH v2 2/7] dt-bindings: soc: qcom: Add device tree binding for GENI SE

2018-02-26 Thread Karthik Ramasubramanian
On 1/16/2018 11:25 PM, Bjorn Andersson wrote: On Fri 12 Jan 17:05 PST 2018, Karthikeyan Ramasubramanian wrote: Add device tree binding support for the QCOM GENI SE driver. Signed-off-by: Karthikeyan Ramasubramanian Better describe the entire GENI, with it's functions in the same binding.

Re: [PATCH v2 3/7] soc: qcom: Add GENI based QUP Wrapper driver

2018-02-16 Thread Karthik Ramasubramanian
On 2/14/2018 4:07 AM, Amit Kucheria wrote: On Sat, Jan 13, 2018 at 6:35 AM, Karthikeyan Ramasubramanian wrote: This driver manages the Generic Interface (GENI) firmware based Qualcomm Universal Peripheral (QUP) Wrapper. GENI based QUP is the next generation programmable module composed of mul

Re: [PATCH v2 3/7] soc: qcom: Add GENI based QUP Wrapper driver

2018-01-31 Thread Karthik Ramasubramanian
On 1/19/2018 3:57 PM, Rob Herring wrote: On Thu, Jan 18, 2018 at 08:57:45AM -0800, Bjorn Andersson wrote: On Thu 18 Jan 01:13 PST 2018, Rajendra Nayak wrote: [].. diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c new file mode 100644 index 000..3f43582 ---

Re: [PATCH v2 0/7] Introduce GENI SE Controller Driver

2018-01-31 Thread Karthik Ramasubramanian
On 1/19/2018 11:32 AM, Randy Dunlap wrote: On 01/12/2018 05:05 PM, Karthikeyan Ramasubramanian wrote: Generic Interface (GENI) firmware based Qualcomm Universal Peripheral (QUP) Wrapper is a next generation programmable module for supporting a wide range of serial interfaces like UART, SPI, I2

Re: [PATCH v2 3/7] soc: qcom: Add GENI based QUP Wrapper driver

2018-01-31 Thread Karthik Ramasubramanian
On 1/16/2018 11:20 PM, Bjorn Andersson wrote: On Fri 12 Jan 17:05 PST 2018, Karthikeyan Ramasubramanian wrote: This driver manages the Generic Interface (GENI) firmware based Qualcomm Universal Peripheral (QUP) Wrapper. GENI based QUP is the next generation programmable module composed of mul

Re: [PATCH v2 1/7] qcom-geni-se: Add QCOM GENI SE Driver summary

2018-01-29 Thread Karthik Ramasubramanian
On 1/16/2018 9:55 AM, Bjorn Andersson wrote: On Fri 12 Jan 17:05 PST 2018, Karthikeyan Ramasubramanian wrote: Generic Interface (GENI) firmware based Qualcomm Universal Peripheral (QUP) Wrapper is a programmable module that is composed of multiple Serial Engines (SE) and can support various Se

Re: [PATCH RFC 4/7] i2c: Add device tree bindings for GENI I2C Controller

2018-01-12 Thread Karthik Ramasubramanian
On 1/11/2018 8:19 AM, Rob Herring wrote: On Mon, Jan 8, 2018 at 6:33 PM, Karthik Ramasubramanian wrote: On 1/2/2018 8:51 AM, Rob Herring wrote: On Wed, Dec 27, 2017 at 09:27:23AM -0700, Karthikeyan Ramasubramanian wrote: Add device tree binding support for I2C Controller in GENI based

Re: [PATCH RFC 6/7] serial: Add device tree bindings for GENI based UART Controller

2018-01-12 Thread Karthik Ramasubramanian
On 1/11/2018 8:12 AM, Rob Herring wrote: On Tue, Jan 9, 2018 at 12:36 PM, Karthik Ramasubramanian wrote: On 1/2/2018 8:55 AM, Rob Herring wrote: On Wed, Dec 27, 2017 at 09:27:25AM -0700, Karthikeyan Ramasubramanian wrote: Add device tree binding support for GENI based UART Controller

Re: [PATCH RFC 6/7] serial: Add device tree bindings for GENI based UART Controller

2018-01-09 Thread Karthik Ramasubramanian
On 1/2/2018 8:55 AM, Rob Herring wrote: On Wed, Dec 27, 2017 at 09:27:25AM -0700, Karthikeyan Ramasubramanian wrote: Add device tree binding support for GENI based UART Controller in the QUP Wrapper. Signed-off-by: Karthikeyan Ramasubramanian Signed-off-by: Girish Mahadevan --- .../device

Re: [PATCH RFC 4/7] i2c: Add device tree bindings for GENI I2C Controller

2018-01-08 Thread Karthik Ramasubramanian
On 1/2/2018 8:51 AM, Rob Herring wrote: On Wed, Dec 27, 2017 at 09:27:23AM -0700, Karthikeyan Ramasubramanian wrote: Add device tree binding support for I2C Controller in GENI based QUP Wrapper. Signed-off-by: Sagar Dharia Signed-off-by: Karthikeyan Ramasubramanian --- .../devicetree/bind

Re: [PATCH RFC 2/7] soc: qcom: Add device tree binding for GENI SE

2018-01-08 Thread Karthik Ramasubramanian
On 1/2/2018 8:47 AM, Rob Herring wrote: On Wed, Dec 27, 2017 at 09:27:21AM -0700, Karthikeyan Ramasubramanian wrote: Add device tree binding support for the QCOM GENI SE driver. Also, "dt-bindings: ..." is the preferred subject prefix. Same for the rest of the series. I will update the subj

Re: [PATCH RFC 2/7] soc: qcom: Add device tree binding for GENI SE

2018-01-08 Thread Karthik Ramasubramanian
On 1/2/2018 8:46 AM, Rob Herring wrote: On Wed, Dec 27, 2017 at 09:27:21AM -0700, Karthikeyan Ramasubramanian wrote: Add device tree binding support for the QCOM GENI SE driver. Signed-off-by: Karthikeyan Ramasubramanian --- .../devicetree/bindings/soc/qcom/qcom,geni-se.txt | 15 ++