Re: [PATCH 3/3 v11] printk: Add monotonic, boottime, and realtime timestamps

On 09/15/2017 06:28 AM, Petr Mladek wrote: I am still slightly nervous that external tools would need updating. Also they might have troubles to interpret the time stamps especially when the source is changed at runtime via /sys/module/printk/parameters/time. My comment below is a

Re: [PATCH 3/3 v11] printk: Add monotonic, boottime, and realtime timestamps

On 09/05/2017 05:06 AM, Prarit Bhargava wrote: printk.time=1/CONFIG_PRINTK_TIME=1 adds a unmodified local hardware clock timestamp to printk messages. The local hardware clock loses time each day making it difficult to determine exactly when an issue has occurred in the kernel log, and making

Re: [PATCH 2/2 v7] printk: Add monotonic, boottime, and realtime timestamps

On 08/17/2017 06:15 AM, Prarit Bhargava wrote: printk.time=1/CONFIG_PRINTK_TIME=1 adds a unmodified local hardware clock timestamp to printk messages. The local hardware clock loses time each day making it difficult to determine exactly when an issue has occurred in the kernel log, and making

Re: [PATCH 2/2 v6] printk: Add monotonic, boottime, and realtime timestamps

On 08/16/2017 08:17 AM, Prarit Bhargava wrote: . . . diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index fc47863f629c..f627a9bb97d1 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -576,6 +576,9 @@ static u32 truncate_msg(u16 *text_len, u16 *trunc_msg_len,

Re: [PATCH v4] printk: Add monotonic, boottime, and realtime timestamps

On 08/07/2017 08:52 AM, Prarit Bhargava wrote: diff --git a/arch/arm/configs/aspeed_g4_defconfig b/arch/arm/configs/aspeed_g4_defconfig index cfc2465e8b77..5f3c50914e92 100644 --- a/arch/arm/configs/aspeed_g4_defconfig +++ b/arch/arm/configs/aspeed_g4_defconfig @@ -162,7 +162,7 @@

Re: [PATCH v3] printk: Add boottime and real timestamps

On 08/03/2017 06:18 PM, Prarit Bhargava wrote: + /* +* Only allow enabling and disabling of the current printk_time +* setting. Changing it from one setting to another confuses +* userspace. +*/ We should allow a debug option to permit this (but that can be

Re: [PATCH v3] printk: Add boottime and real timestamps

On 08/03/2017 06:18 PM, Prarit Bhargava wrote: diff --git a/arch/arm/configs/aspeed_g4_defconfig b/arch/arm/configs/aspeed_g4_defconfig index cfc2465e8b77..6c73c305ad17 100644 --- a/arch/arm/configs/aspeed_g4_defconfig +++ b/arch/arm/configs/aspeed_g4_defconfig @@ -162,7 +162,9 @@

Re: [PATCH v2] printk: Add boottime and real timestamps

ally thought much about using BOOT TBH because MONO seemed to work just fine. Mark Salyzyn, did you want BOOT or MONO? P. You must IMHO include MONO (default when on?), BOOT and REAL if you are offering the ability for the kernel to switch time base. [TL;DR] I had a partner request for Boottime

Re: [PATCH 2/2] printk: Add boottime and real timestamps

On 07/25/2017 06:00 AM, Peter Zijlstra wrote: On Tue, Jul 25, 2017 at 08:17:27AM -0400, Prarit Bhargava wrote: diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 5b1662ec546f..6cd38a25f8ea 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1,8 +1,8 @@ menu "printk and dmesg

[PATCH v3] mmc: Add CONFIG_MMC_SIMULATE_MAX_SPEED

When CONFIG_MMC_SIMULATE_MAX_SPEED is enabled, Expose max_read_speed, max_write_speed and cache_size default module parameters and sysfs controls to simulate a slow eMMC device. Default values are 0 (off), 0 (off) and 4 MB respectively. Signed-off-by: Mark Salyzyn <saly...@android.

[PATCH v2] mmc: Add CONFIG_MMC_SIMULATE_MAX_SPEED

CONFIG_MMC_SIMULATE_MAX_WRITE_SPEED CONFIG_MMC_SIMULATE_CACHE_SIZE respectively; and if not defined are 0 (off), 0 (off) and 4 MB also respectively. Signed-off-by: Mark Salyzyn <saly...@android.com> --- changes in v2: change from CONFIG_MMC_BLOCK_MAX_SPEED to CONFIG_MMC_SIMULATE_MAX_SPEED. Add documentation. Documen