Re: [PATCH v1 3/3] docs: driver-model: Add documentation for sync_state

2019-10-14 Thread Saravana Kannan
On Mon, Oct 14, 2019 at 4:28 PM Stephen Boyd wrote: > > Quoting Saravana Kannan (2019-10-11 12:15:21) > > The sync_state() driver callback was added recently, but the > > documentation was missing. Adding it now. > > > > Signed-off-by: Saravana Kannan > >

[PATCH v1 1/3] of: property: Minor code formatting/style clean ups

2019-10-11 Thread Saravana Kannan
Better variable and function names. Remove "," after the sentinel in an array initialization list. Signed-off-by: Saravana Kannan --- drivers/of/property.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/of/property.c b/drivers/of/proper

[PATCH v1 2/3] driver: core: Improve documentation for fwnode_operations.add_links()

2019-10-11 Thread Saravana Kannan
hy this is necessary. Signed-off-by: Saravana Kannan --- include/linux/fwnode.h | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h index 6ae05b9ce359..97223e2410bd 100644 --- a/include/linux/fwnode.h +++ b/inc

[PATCH v1 3/3] docs: driver-model: Add documentation for sync_state

2019-10-11 Thread Saravana Kannan
The sync_state() driver callback was added recently, but the documentation was missing. Adding it now. Signed-off-by: Saravana Kannan --- .../driver-api/driver-model/driver.rst| 43 +++ 1 file changed, 43 insertions(+) diff --git a/Documentation/driver-api/driver-model

[PATCH v1 0/3] Documentation/minor coding style fix ups

2019-10-11 Thread Saravana Kannan
Addressing a few coding style comments and adding a bunch of documentation. Saravana Kannan (3): of: property: Minor code formatting/style clean ups driver: core: Improve documentation for fwnode_operations.add_links() docs: driver-model: Add documentation for sync_state .../driver-api

Re: [PATCH v11 3/6] of: property: Add functional dependency link from DT bindings

2019-10-08 Thread Saravana Kannan
On Tue, Oct 8, 2019 at 7:53 AM Stephen Boyd wrote: > > Quoting Greg Kroah-Hartman (2019-10-04 08:37:50) > > On Wed, Sep 11, 2019 at 03:29:25AM -0700, Stephen Boyd wrote: > > > Quoting Saravana Kannan (2019-09-04 14:11:22) > > > > + int ret = 0; > >

Re: [PATCH v11 3/6] of: property: Add functional dependency link from DT bindings

2019-10-04 Thread Saravana Kannan
On Fri, Oct 4, 2019 at 8:37 AM Greg Kroah-Hartman wrote: > > On Wed, Sep 11, 2019 at 03:29:25AM -0700, Stephen Boyd wrote: > > Quoting Saravana Kannan (2019-09-04 14:11:22) > > > Add device links after the devices are created (but before they are > > > probed) by

[PATCH v11 6/6] of: property: Create device links for all child-supplier depencencies

2019-09-04 Thread Saravana Kannan
#x27;s sync_state() callback because all its consumers have probed. 9. None of the devices malfunction. Signed-off-by: Saravana Kannan --- drivers/of/property.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/of/property.c b/drivers/of/property.c index 23b5ee5b0570..923d6f88a9

[PATCH v11 5/6] of/platform: Pause/resume sync state during init and of_platform_populate()

2019-09-04 Thread Saravana Kannan
called prematurely, pause and resume sync_state() callbacks across of_platform_populate(). Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index b47a2292fe8e..d93891a05f60 100644

[PATCH v11 4/6] driver core: Add sync_state driver/bus callback

2019-09-04 Thread Saravana Kannan
. kbuild test robot reported missing documentation for device.state_synced Reported-by: kbuild test robot Signed-off-by: Saravana Kannan --- drivers/base/core.c| 72 ++ include/linux/device.h | 24 ++ 2 files changed, 96 insertions(+)

[PATCH v11 1/6] driver core: Add fwnode_to_dev() to look up device from fwnode

2019-09-04 Thread Saravana Kannan
It's often useful to look up a device that corresponds to a fwnode. So add an API to do that irrespective of the bus on which the device has been added to. Signed-off-by: Saravana Kannan --- drivers/base/core.c| 7 +++ include/linux/fwnode.h | 2 ++ 2 files changed, 9 inser

[PATCH v11 3/6] of: property: Add functional dependency link from DT bindings

2019-09-04 Thread Saravana Kannan
ssing const Reported-by: kbuild test robot Signed-off-by: Saravana Kannan --- .../admin-guide/kernel-parameters.rst | 1 + .../admin-guide/kernel-parameters.txt | 6 + drivers/of/property.c | 241 ++ 3 files changed, 248 insertions

[PATCH v11 2/6] driver core: Add support for linking devices during device addition

2019-09-04 Thread Saravana Kannan
consumer devices are added, they might not have a supplier device to link to despite needing mandatory resources/functionality from one or more suppliers. A waiting_for_suppliers list is created to track such consumers and retry linking them when new devices get added. Signed-off-by: Saravana Kannan

[PATCH v11 0/6] Solve postboot supplier cleanup and optimize probe ordering

2019-09-04 Thread Saravana Kannan
@google.com/ [3] - https://lore.kernel.org/lkml/cagetcx_psnc_2d7uflryfe3b8urc814xef8zu+spntt7_z8...@mail.gmail.com/ -Saravana Saravana Kannan (6): driver core: Add fwnode_to_dev() to look up device from fwnode driver core: Add support for linking devices during device addition of: proper

Re: [PATCH v10 0/7] Solve postboot supplier cleanup and optimize probe ordering

2019-08-29 Thread Saravana Kannan
On Thu, Aug 29, 2019 at 9:43 AM Rob Herring wrote: > > On Thu, Aug 29, 2019 at 2:46 AM Saravana Kannan wrote: > > > > Add device-links to track functional dependencies between devices > > after they are created (but before they are probed) by looking at > > their

[PATCH v10 7/7] of: property: Add "depends-on" parsing support to of_fwnode_add_links()

2019-08-29 Thread Saravana Kannan
that platforms with cyclic dependencies can use "depends-on" to break the cycle and continue successfully probing devices. Signed-off-by: Saravana Kannan --- drivers/of/property.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/of/property.c b/drivers/of/

[PATCH v10 3/7] driver core: Add sync_state driver/bus callback

2019-08-29 Thread Saravana Kannan
. kbuild test robot reported missing documentation for device.state_synced Reported-by: kbuild test robot Signed-off-by: Saravana Kannan --- drivers/base/core.c| 65 ++ include/linux/device.h | 24 2 files changed, 89 insertions(+)

[PATCH v10 6/7] dt-bindings: Add depends-on property to break cyclic inferred dependencies

2019-08-29 Thread Saravana Kannan
ds-on property that can override inferred dependencies by explicitly listing the suppliers of a device and thereby allow breaking any cyclic inferred depenencies. Signed-off-by: Saravana Kannan --- .../devicetree/bindings/depends-on.txt| 46 +++ 1 file changed, 46 inser

[PATCH v10 0/7] Solve postboot supplier cleanup and optimize probe ordering

2019-08-29 Thread Saravana Kannan
inor comments update - Added 2 new patches 6/7 and 7/7 to handle cyclic dependencies using depends-on [1] - https://lore.kernel.org/lkml/2305283.AStDPdUUnE@kreacher/ [2] - https://lore.kernel.org/lkml/20190724001100.133423-2-sarava...@google.com/ [3] - https://lore.kernel.org/lkml/cagetcx_psnc_2d7uflr

[PATCH v10 1/7] driver core: Add support for linking devices during device addition

2019-08-29 Thread Saravana Kannan
consumer devices are added, they might not have a supplier device to link to despite needing mandatory resources/functionality from one or more suppliers. A waiting_for_suppliers list is created to track such consumers and retry linking them when new devices get added. Signed-off-by: Saravana Kannan

[PATCH v10 4/7] of/platform: Pause/resume sync state during init and of_platform_populate()

2019-08-29 Thread Saravana Kannan
called prematurely, pause and resume sync_state() callbacks across of_platform_populate(). Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index b47a2292fe8e..d93891a05f60 100644

[PATCH v10 2/7] of: property: Add functional dependency link from DT bindings

2019-08-29 Thread Saravana Kannan
ssing const Reported-by: kbuild test robot Signed-off-by: Saravana Kannan --- .../admin-guide/kernel-parameters.rst | 1 + .../admin-guide/kernel-parameters.txt | 6 + drivers/of/property.c | 241 ++ 3 files changed, 248 insertions

[PATCH v10 5/7] of: property: Create device links for all child-supplier depencencies

2019-08-29 Thread Saravana Kannan
#x27;s sync_state() callback because all its consumers have probed. 9. None of the devices malfunction. Signed-off-by: Saravana Kannan --- drivers/of/property.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/of/property.c b/drivers/of/property.c index 82052172f508..420c2d4281

Re: [PATCH v7 3/7] of/platform: Add functional dependency link from DT bindings

2019-08-20 Thread Saravana Kannan
On Mon, Aug 19, 2019 at 9:26 PM Frank Rowand wrote: > > On 8/19/19 5:09 PM, Saravana Kannan wrote: > > On Mon, Aug 19, 2019 at 2:30 PM Frank Rowand wrote: > >> > >> On 8/19/19 1:49 PM, Saravana Kannan wrote: > >>> On Mon, Aug 19, 2019 at 10:16 AM Frank R

Re: [PATCH v7 3/7] of/platform: Add functional dependency link from DT bindings

2019-08-19 Thread Saravana Kannan
On Mon, Aug 19, 2019 at 2:30 PM Frank Rowand wrote: > > On 8/19/19 1:49 PM, Saravana Kannan wrote: > > On Mon, Aug 19, 2019 at 10:16 AM Frank Rowand > > wrote: > >> > >> On 8/15/19 6:50 PM, Saravana Kannan wrote: > >>> On Wed, Aug 7, 2019 at 7:06

Re: [PATCH v7 3/7] of/platform: Add functional dependency link from DT bindings

2019-08-19 Thread Saravana Kannan
On Mon, Aug 19, 2019 at 10:16 AM Frank Rowand wrote: > > On 8/15/19 6:50 PM, Saravana Kannan wrote: > > On Wed, Aug 7, 2019 at 7:06 PM Frank Rowand wrote: > >> > >> On 7/23/19 5:10 PM, Saravana Kannan wrote: > >>> Add device-links after the devices are

Re: [PATCH v7 3/7] of/platform: Add functional dependency link from DT bindings

2019-08-15 Thread Saravana Kannan
On Wed, Aug 7, 2019 at 7:06 PM Frank Rowand wrote: > > On 7/23/19 5:10 PM, Saravana Kannan wrote: > > Add device-links after the devices are created (but before they are > > probed) by looking at common DT bindings like clocks and > > interconnects. > > > > A

[PATCH v9 3/7] of/platform: Add functional dependency link from DT bindings

2019-07-31 Thread Saravana Kannan
ssing const Reported-by: kbuild test robot Signed-off-by: Saravana Kannan --- .../admin-guide/kernel-parameters.txt | 5 + drivers/of/platform.c | 165 ++ 2 files changed, 170 insertions(+) diff --git a/Documentation/admin-guide/kernel-

Re: [PATCH] of/platform: Add missing const qualifier in of_link_property

2019-07-31 Thread Saravana Kannan
On Wed, Jul 31, 2019 at 11:19 AM Nathan Chancellor wrote: > > Clang errors: > > drivers/of/platform.c:632:28: error: initializing 'struct > supplier_bindings *' with an expression of type 'const struct > supplier_bindings [4]' discards qualifiers > [-Werror,-Wincompatible-pointer-types-discards-qu

[PATCH v8 3/7] of/platform: Add functional dependency link from DT bindings

2019-07-29 Thread Saravana Kannan
efault we just add device-links to track "driver presence" (probe succeeded) of the supplier device. If any other functionality provided by device-links are needed, it is left to the consumer/supplier devices to change the link when they probe. Signed-off-by: Saravana Kannan --- .

[PATCH v7 3/7] of/platform: Add functional dependency link from DT bindings

2019-07-23 Thread Saravana Kannan
efault we just add device-links to track "driver presence" (probe succeeded) of the supplier device. If any other functionality provided by device-links are needed, it is left to the consumer/supplier devices to change the link when they probe. Signed-off-by: Saravana Kannan --- .

Re: [PATCH v6 3/7] of/platform: Add functional dependency link from DT bindings

2019-07-23 Thread Saravana Kannan
On Tue, Jul 23, 2019 at 3:18 PM Rob Herring wrote: > > On Tue, Jul 23, 2019 at 2:49 PM Saravana Kannan wrote: > > > > On Tue, Jul 23, 2019 at 11:06 AM Rob Herring wrote: > > > > > > On Sat, Jul 20, 2019 at 12:17 AM Saravana Kannan > > > wrot

Re: [PATCH v6 3/7] of/platform: Add functional dependency link from DT bindings

2019-07-23 Thread Saravana Kannan
On Tue, Jul 23, 2019 at 11:06 AM Rob Herring wrote: > > On Sat, Jul 20, 2019 at 12:17 AM Saravana Kannan wrote: > > > > Add device-links after the devices are created (but before they are > > probed) by looking at common DT bindings like clocks and > > interconnect

[PATCH v6 3/7] of/platform: Add functional dependency link from DT bindings

2019-07-19 Thread Saravana Kannan
efault we just add device-links to track "driver presence" (probe succeeded) of the supplier device. If any other functionality provided by device-links are needed, it is left to the consumer/supplier devices to change the link when they probe. Signed-off-by: Saravana Kannan --- .

Re: [PATCH v5 02/11] of/platform: Add functional dependency link from DT bindings

2019-07-17 Thread Saravana Kannan
On Wed, Jul 17, 2019 at 7:35 AM Rob Herring wrote: > > On Tue, Jul 16, 2019 at 5:54 PM Saravana Kannan wrote: > > > > On Tue, Jul 16, 2019 at 4:43 PM Rob Herring wrote: > > > > > > On Fri, Jul 12, 2019 at 5:52 PM Saravana Kannan > > > wrote: >

Re: [PATCH v5 02/11] of/platform: Add functional dependency link from DT bindings

2019-07-16 Thread Saravana Kannan
On Tue, Jul 16, 2019 at 4:43 PM Rob Herring wrote: > > On Fri, Jul 12, 2019 at 5:52 PM Saravana Kannan wrote: > > > > Add device-links after the devices are created (but before they are > > probed) by looking at common DT bindings like clocks and > > interconnects

[PATCH v5 02/11] of/platform: Add functional dependency link from DT bindings

2019-07-12 Thread Saravana Kannan
efault we just add device-links to track "driver presence" (probe succeeded) of the supplier device. If any other functionality provided by device-links are needed, it is left to the consumer/supplier devices to change the link when they probe. Signed-off-by: Saravana Kannan ---

[PATCH v4 2/8] of/platform: Add functional dependency link from DT bindings

2019-07-08 Thread Saravana Kannan
efault we just add device-links to track "driver presence" (probe succeeded) of the supplier device. If any other functionality provided by device-links are needed, it is left to the consumer/supplier devices to change the link when they probe. Signed-off-by: Saravana Kannan ---

Re: [PATCH 1/7] cpufreq: remove redundant CPUFREQ_INCOMPATIBLE notifier event

2016-04-06 Thread Saravana Kannan
On 04/06/2016 02:45 PM, Rafael J. Wysocki wrote: On Wed, Apr 6, 2016 at 11:29 PM, Saravana Kannan wrote: On 04/06/2016 02:21 PM, Rafael J. Wysocki wrote: On Wed, Apr 6, 2016 at 10:30 PM, Saravana Kannan wrote: On 09/09/2015 05:53 PM, Rafael J. Wysocki wrote: [cut] Well, nobody was

Re: [PATCH 1/7] cpufreq: remove redundant CPUFREQ_INCOMPATIBLE notifier event

2016-04-06 Thread Saravana Kannan
On 04/06/2016 02:21 PM, Rafael J. Wysocki wrote: On Wed, Apr 6, 2016 at 10:30 PM, Saravana Kannan wrote: On 09/09/2015 05:53 PM, Rafael J. Wysocki wrote: Hi, On Thu, Sep 10, 2015 at 2:39 AM, Viresh Kumar wrote: On 10-09-15, 01:26, Rafael J. Wysocki wrote: On Monday, August 03, 2015 08