Re: [GIT PULL] Compiler Attributes for v4.20-rc1

2018-11-05 Thread Steven Rostedt
sm/processor.h. Without the option it is possible > to trace __load_psw_mask which leads to kernel stack overflow. Acked-by: Steven Rostedt (VMware) -- Steve > > Signed-off-by: Martin Schwidefsky > --- > arch/s390/include/asm/processor.h | 4 ++-- > include/linux/compiler-gcc.h

Re: [PATCH 1/5] PCI/AER: Define and allocate aer_stats structure for AER capable devices

2018-05-23 Thread Steven Rostedt
On Wed, 23 May 2018 09:33:30 -0500 "Alex G." wrote: > > Well I'll agree to disagree with Linus on this one. It's ugly as fsck > > and allows for ambiguous statements in the code. > > You misspelled "fuck". No, Jes is Danish. That's how they spell it. -- Steve -- To

Re: [PATCH v2 11/11] docs: fix broken references with multiple hints

2018-05-15 Thread Steven Rostedt
cepoint.h > +++ b/include/linux/tracepoint.h > @@ -4,7 +4,7 @@ > /* > * Kernel Tracepoint API. > * > - * See Documentation/trace/tracepoints.txt. > + * See Documentation/trace/tracepoints.rst. > * > * Copyright (C) 2008-2014 Mathieu Desnoyers <mathieu.desnoy...

Re: [PATCH v3 2/9] mm: Prefix vma_ to vaddr_to_offset() and offset_to_vaddr()

2018-05-03 Thread Steven Rostedt
On Tue, 17 Apr 2018 10:02:37 +0530 Ravi Bangoria wrote: > From: Ravi Bangoria > > Make function names more meaningful by adding vma_ prefix > to them. Actually, I would have done this patch before the first one, since the first

Re: [PATCH] linux-next: ftrace/docs: Fix spelling typos in ftrace-users.rst

2018-04-27 Thread Steven Rostedt
I just noticed that this was never applied. Jon, can you take this? -- Steve On Mon, 27 Nov 2017 22:46:36 -0500 Steven Rostedt <rost...@goodmis.org> wrote: > On Tue, 28 Nov 2017 12:26:13 +0900 > Masanari Iida <standby2...@gmail.com> wrote: > > > This patch

Re: [PATCH] Documentation: updates for new syscall stub naming convention

2018-04-20 Thread Steven Rostedt
On Fri, 20 Apr 2018 07:44:25 +0200 Dominik Brodowski wrote: > For v4.17-rc1, the naming of syscall stubs changed. Update stack > traces and similar instances in the documentation to avoid sources > for confusion. > > Signed-off-by: Dominik Brodowski

Re: [PATCH v2] Documentation: ftrace: clarify filters with dynamic ftrace and graph

2018-04-13 Thread Steven Rostedt
pected, > which was the full unabridged graph recursion. > > Signed-off-by: Steffen Maier <ma...@linux.ibm.com> > Cc: Steven Rostedt <rost...@goodmis.org> Looks good. Reviewed-by: Steven Rostedt (VMware) <rost...@goodmis.org> > Cc: Ingo Molnar <mi...@redhat.com>

Re: [PATCH] Documentation: ftrace: clarify filters with dynamic ftrace and graph

2018-04-13 Thread Steven Rostedt
pected, > which was the full unabridged graph recursion. I didn't realize that the documentation doesn't state this. I mention it in all my talks that talk about function and function_graph tracer and set_ftrace_filter. > > Signed-off-by: Steffen Maier <ma...@linux.ibm.com> > Cc: St

Re: [PATCH 5/8] trace_uprobe: Support SDT markers having reference count (semaphore)

2018-03-15 Thread Steven Rostedt
On Tue, 13 Mar 2018 18:26:00 +0530 Ravi Bangoria wrote: > +static void sdt_increment_ref_ctr(struct trace_uprobe *tu) > +{ > + struct uprobe_map_info *info; > + struct vm_area_struct *vma; > + unsigned long vaddr; > + > + uprobe_start_dup_mmap();

Re: [PATCH 3/8] Uprobe: Rename map_info to uprobe_map_info

2018-03-15 Thread Steven Rostedt
On Tue, 13 Mar 2018 18:25:58 +0530 Ravi Bangoria wrote: > -static inline struct map_info *free_map_info(struct map_info *info) > +static inline struct uprobe_map_info * > +uprobe_free_map_info(struct uprobe_map_info *info) > { > - struct map_info *next =

Re: [PATCH 4/8] Uprobe: Export uprobe_map_info along with uprobe_{build/free}_map_info()

2018-03-15 Thread Steven Rostedt
On Tue, 13 Mar 2018 18:25:59 +0530 Ravi Bangoria wrote: > These exported data structure and functions will be used by other > files in later patches. I'm reluctantly OK with the above. > > No functionality changes. Please remove this line. There are

Re: [PATCH 2/8] mm: Prefix vma_ to vaddr_to_offset() and offset_to_vaddr()

2018-03-15 Thread Steven Rostedt
On Tue, 13 Mar 2018 18:25:57 +0530 Ravi Bangoria wrote: > No functionality changes. Again, please add an explanation to why this patch is done. -- Steve > > Signed-off-by: Ravi Bangoria -- To unsubscribe from this list:

Re: [PATCH 1/8] Uprobe: Export vaddr <-> offset conversion functions

2018-03-15 Thread Steven Rostedt
On Tue, 13 Mar 2018 18:25:56 +0530 Ravi Bangoria wrote: > No functionality changes. Please add a detailed explanation why this patch is needed. All commits should be self sufficient and stand on their own. If I were to come up to this patch via a git blame, I

Re: [PATCH 5/8] trace_uprobe: Support SDT markers having reference count (semaphore)

2018-03-14 Thread Steven Rostedt
On Tue, 13 Mar 2018 18:26:00 +0530 Ravi Bangoria wrote: > include/linux/uprobes.h | 2 + > kernel/events/uprobes.c | 6 ++ > kernel/trace/trace_uprobe.c | 172 > +++- I'm currently traveling, but I'll try to

Re: [PATCH 00/17] Include linux trace docs to Sphinx TOC tree

2018-03-07 Thread Steven Rostedt
On Wed, 7 Mar 2018 10:46:49 -0700 Jonathan Corbet wrote: > Anyway, with that, the patch series is applied. Thanks for helping to > improve the docs, and my apologies for taking so long to get to this. Thanks for doing this Jon. I'm going to have to find some time to revisit all

Re: [PATCH 00/17] Include linux trace docs to Sphinx TOC tree

2018-02-27 Thread Steven Rostedt
On Tue, 27 Feb 2018 17:34:22 +0800 "Du, Changbin" wrote: > Hello Steven and Corbet, > Ten days past, will you accept this serias? Thank you! > > On Sat, Feb 17, 2018 at 01:39:33PM +0800, changbin...@intel.com wrote: > > From: Changbin Du > > > >

Re: [PATCH 05/17] trace doc: convert trace/ftrace.txt to rst format

2018-02-20 Thread Steven Rostedt
On Tue, 20 Feb 2018 21:27:00 +0800 "Du, Changbin" <changbin...@intel.com> wrote: > > > @@ -0,0 +1,3332 @@ > > > + > > > +ftrace - Function Tracer > > > + > > > + > > > +Copyr

Re: [PATCH 2/3] Documentation: convert trace/ftrace-design.txt to rst format

2018-02-16 Thread Steven Rostedt
On Fri, 16 Feb 2018 05:49:52 -0700 Jonathan Corbet <cor...@lwn.net> wrote: > On Thu, 15 Feb 2018 22:57:05 -0500 > Steven Rostedt <rost...@goodmis.org> wrote: > > > This document is out of date, and I rather have it updated before we > > make it more &quo

Re: [PATCH 2/3] Documentation: convert trace/ftrace-design.txt to rst format

2018-02-16 Thread Steven Rostedt
On Fri, 16 Feb 2018 17:07:26 +0800 "Du, Changbin" wrote: > > This document is out of date, and I rather have it updated before we > > make it more "available" elsewhere. > > > Got you. I plan to convert below docs. Are they out of date, too? > > events-msr.txt,

Re: [PATCH 2/3] Documentation: convert trace/ftrace-design.txt to rst format

2018-02-15 Thread Steven Rostedt
On Fri, 16 Feb 2018 11:12:18 +0800 changbin...@intel.com wrote: > From: Changbin Du > > Signed-off-by: Changbin Du > --- > .../trace/{ftrace-design.txt => ftrace-design.rst} | 248 > +++-- > Documentation/trace/index.rst

Re: [PATCH] docs: ftrace-uses.rst fix varios code-block directives

2017-12-13 Thread Steven Rostedt
k directives results in a less noisy build, but the 'not > included' WARNING will be stay: > > - trace/ftrace-uses.rst: WARNING: document isn't included in any toctree > > Signed-off-by: Markus Heiser <markus.hei...@darmarit.de> Acked-by: Steven Rostedt (VMware) <ros

Re: [PATCH] linux-next: ftrace/docs: Fix spelling typos in ftrace-users.rst

2017-11-27 Thread Steven Rostedt
xtra care to what can be done inside a callback. A callback > can be called outside the protective scope of RCU. > > -The ftrace infrastructure has some protections agains recursions and RCU > +The ftrace infrastructure has some protections against recursions and RCU > but o

Re: [PATCH 1/3] printk: Introduce per-console loglevel setting

2017-11-03 Thread Steven Rostedt
On Fri, 3 Nov 2017 13:00:05 +0100 Petr Mladek wrote: > On Thu 2017-09-28 17:43:55, Calvin Owens wrote: > > This patch introduces a new per-console loglevel setting, and changes > > console_unlock() to use max(global_level, per_console_level) when > > deciding whether or not to

Re: [PATCH 2/2 v8] printk: Add monotonic, boottime, and realtime timestamps

2017-08-25 Thread Steven Rostedt
On Fri, 25 Aug 2017 10:46:21 -0400 Prarit Bhargava wrote: > np. I'm going to copy the code for > > u64 notrace ktime_get_boot_fast_ns(void) > > but I'm unsure why the function is marked "notrace", and if > __ktime_get_real_fast_ns_unsafe() must be as well? I don't see

Re: [PATCH v4 resend 1/2] rtmutex: update rt-mutex-design

2017-08-15 Thread Steven Rostedt
: > >>> -Reviewers: Ingo Molnar, Thomas Gleixner, Thomas Duetsch, and Randy > >>> Dunlap > >>> +Original Reviewers: Ingo Molnar, Thomas Gleixner, Thomas Duetsch, and > >>> + Randy Dunlap > >>> +Update (7/6/2017) Reviewe

Re: [PATCH 3/3] rtmutex: remove unnecessary adjust prio

2017-07-12 Thread Steven Rostedt
change. > > > > Signed-off-by: Alex Shi <alex@linaro.org> > > Cc: Steven Rostedt <rost...@goodmis.org> > > Cc: Sebastian Siewior <bige...@linutronix.de> > > Cc: Mathieu Poirier <mathieu.poir...@linaro.org> > > Cc: Juri Lelli <ju

Re: [PATCH v3 1/3] rtmutex: update rt-mutex-design

2017-07-06 Thread Steven Rostedt
you on Reviewers, since you are author already. :) Actually, I probably should be. Comment below. > > > Best regards > Alex > > > On 07/04/2017 02:49 AM, Steven Rostedt wrote: > >> +In the first case, the task will try again to acquire the lock. If it > >

Re: [PATCH v3 1/3] rtmutex: update rt-mutex-design

2017-07-03 Thread Steven Rostedt
e highest prio task get lock") > and priority list 'plist' changed to rbtree. And Peter Zijlstra did some > clean up and fix for deadline task changes on tip tree. > > So update it to latest code and make it meaningful. > > Signed-off-by: Alex Shi <alex@linaro.org

Re: [PATCH v3 1/3] rtmutex: update rt-mutex-design

2017-06-20 Thread Steven Rostedt
On Tue, 20 Jun 2017 08:22:52 +0800 Alex Shi <alex@linaro.org> wrote: > On 05/25/2017 01:26 PM, Alex Shi wrote: > > > > Author: Steven Rostedt <rost...@goodmis.org> > > +Updated: Alex Shi <alex@linaro.org>- 5/20/2017 > > > >

Re: [PATCH 1/3] rtmutex: comments update

2017-04-14 Thread Steven Rostedt
On Fri, 14 Apr 2017 16:52:11 +0800 Alex Shi wrote: > >> -Plist > >> -- > >> - > >> -Before I go further and talk about how the PI chain is stored through > >> lists > >> -on both mutexes and processes, I'll explain the plist. This is similar to > >> -the struct

Re: [PATCH 1/3] rtmutex: comments update

2017-04-13 Thread Steven Rostedt
On Thu, 13 Apr 2017 22:02:52 +0800 Alex Shi wrote: > The rt-mutex documents didn't gotten meaningful update from its first > version. Even after owner's pending bit was removed in commit 8161239a8bcc > ("rtmutex: Simplify PI algorithm and make highest prio task get lock") >

Re: [PATCH v3] tracing/kprobes: expose maxactive for kretprobe in kprobe_events

2017-04-04 Thread Steven Rostedt
On Tue, 4 Apr 2017 20:24:59 +0900 Masami Hiramatsu wrote: > On Mon, 3 Apr 2017 12:36:22 +0200 > Alban Crequy wrote: > > > From: Alban Crequy > > > > When a kretprobe is installed on a kernel function, there is a maximum > >

Re: [PATCH v1] tracing/kprobes: expose maxactive for kretprobe in kprobe_events

2017-03-28 Thread Steven Rostedt
On Wed, 29 Mar 2017 00:23:35 +0900 Masami Hiramatsu wrote: > > @@ -598,8 +601,10 @@ static int create_trace_kprobe(int argc, char **argv) > > { > > /* > > * Argument syntax: > > -* - Add kprobe: p[:[GRP/]EVENT] [MOD:]KSYM[+OFFS]|KADDR [FETCHARGS] > > -* -

Re: [PATCH v1] tracing/kprobes: expose maxactive for kretprobe in kprobe_events

2017-03-28 Thread Steven Rostedt
"[PATCH v1]" I like your confidence, or lack of, that there isn't going to be a v2 or v3 ;-) Masami, what do you think of this? -- Steve On Tue, 28 Mar 2017 15:52:22 +0200 Alban Crequy wrote: > When a kretprobe is installed on a kernel function, there is a maximum >

Re: [PATCH] documentation: fix broken lkml archive links in RCU requirements

2016-09-15 Thread Steven Rostedt
; with this requirement; > he also kindly surprised me with > href="https://lkml.kernel.org/g/CALCETrXSY9JpW3uE6H8WYk81sg56qasA2aqmjMPsq5dOtzso=g...@mail.gmail.com;>an > algorithm Strange that this one still works. Anyway... Acked-by: Steven Rostedt <rost...@goodmis.org> -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] documentation: fix broken lkml archive links in RCU requirements

2016-09-09 Thread Steven Rostedt
On Fri, 9 Sep 2016 16:17:14 +0200 Richard Weinberger wrote: > > Signed-off-by: Michael Opdenacker > > --- > > Documentation/RCU/Design/Requirements/Requirements.html | 8 > > 1 file changed, 4 insertions(+), 4

Re: [PATCH v2] doc: clarify that trace_events= takes a comma-separated list

2016-05-23 Thread Steven Rostedt
version looks good to me. Jonathan, you want to take this patch? Acked-by: Steven Rostedt <rost...@goodmis.org> -- Steve > Signed-off-by: Brian Norris <computersforpe...@gmail.com> > --- > v2: remove language about /sys/kernel/debug/tracing/set_event, to avoid > imp

Re: [PATCH] doc: clarify that trace_events= takes a comma-separated list

2016-05-23 Thread Steven Rostedt
On Mon, 23 May 2016 13:08:31 -0700 Brian Norris wrote: Hi Brian, > It took me browsing through the source code to determine that I was, > indeed, using the wrong delimiter in my command lines. So I might as > well document it for the next person. > >