Re: [PATCH] Documentation/livepatch: remove the limitation for schedule() patching

2017-01-10 Thread Jiri Kosina
On Fri, 6 Jan 2017, Miroslav Benes wrote: > The Limitations section of the documentation describes the impossibility > to livepatch anything that is inlined to __schedule() function. This had > been true till 4.9 kernel came. Thanks to commit 0100301bfdf5 > ("sched/x86: Rewrite the switch_to()

Re: [PATCH] Documentation/livepatch: remove the limitation for schedule() patching

2017-01-09 Thread Josh Poimboeuf
On Mon, Jan 09, 2017 at 01:50:19PM +0100, Miroslav Benes wrote: > There is still one thing which I don't understand. Why __schedule() > (patched or the original) is not on the stack. The actual "sleep" > should happen in __switch_to_asm() which is C function now. And there is a > call to

Re: [PATCH] Documentation/livepatch: remove the limitation for schedule() patching

2017-01-09 Thread Miroslav Benes
On Fri, 6 Jan 2017, Josh Poimboeuf wrote: > On Fri, Jan 06, 2017 at 03:00:45PM +0100, Miroslav Benes wrote: > > > > 2. reversion of the process does not work as expected. The kernel > > crashes after the removal of the module. A task very likely slept in > > schedule and was not migrated

Re: [PATCH] Documentation/livepatch: remove the limitation for schedule() patching

2017-01-06 Thread Josh Poimboeuf
On Fri, Jan 06, 2017 at 03:00:45PM +0100, Miroslav Benes wrote: > The Limitations section of the documentation describes the impossibility > to livepatch anything that is inlined to __schedule() function. This had > been true till 4.9 kernel came. Thanks to commit 0100301bfdf5 > ("sched/x86:

Re: [PATCH] Documentation/livepatch: remove the limitation for schedule() patching

2017-01-06 Thread Miroslav Benes
On Fri, 6 Jan 2017, Petr Mladek wrote: > On Fri 2017-01-06 15:00:45, Miroslav Benes wrote: > > The Limitations section of the documentation describes the impossibility > > to livepatch anything that is inlined to __schedule() function. This had > > been true till 4.9 kernel came. Thanks to commit

Re: [PATCH] Documentation/livepatch: remove the limitation for schedule() patching

2017-01-06 Thread Petr Mladek
On Fri 2017-01-06 15:00:45, Miroslav Benes wrote: > The Limitations section of the documentation describes the impossibility > to livepatch anything that is inlined to __schedule() function. This had > been true till 4.9 kernel came. Thanks to commit 0100301bfdf5 > ("sched/x86: Rewrite the

[PATCH] Documentation/livepatch: remove the limitation for schedule() patching

2017-01-06 Thread Miroslav Benes
The Limitations section of the documentation describes the impossibility to livepatch anything that is inlined to __schedule() function. This had been true till 4.9 kernel came. Thanks to commit 0100301bfdf5 ("sched/x86: Rewrite the switch_to() code") from Brian Gerst there is __switch_to_asm