Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-17 Thread Rafael J. Wysocki
On Tuesday, October 17, 2017 9:15:43 AM CEST Greg Kroah-Hartman wrote: > On Tue, Oct 17, 2017 at 12:05:11AM +0200, Rafael J. Wysocki wrote: > > On Monday, October 16, 2017 8:28:52 AM CEST Greg Kroah-Hartman wrote: > > > On Mon, Oct 16, 2017 at 03:29:02AM +0200, Rafael J. Wysocki wrote: > > > >

Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-17 Thread Greg Kroah-Hartman
On Tue, Oct 17, 2017 at 12:07:37AM +0200, Rafael J. Wysocki wrote: > On Monday, October 16, 2017 8:31:22 AM CEST Greg Kroah-Hartman wrote: > > On Mon, Oct 16, 2017 at 03:29:02AM +0200, Rafael J. Wysocki wrote: > > > +static inline void dev_pm_set_driver_flags(struct device *dev, unsigned > > >

Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-16 Thread Rafael J. Wysocki
On Monday, October 16, 2017 8:31:22 AM CEST Greg Kroah-Hartman wrote: > On Mon, Oct 16, 2017 at 03:29:02AM +0200, Rafael J. Wysocki wrote: > > +static inline void dev_pm_set_driver_flags(struct device *dev, unsigned > > int flags) > > +{ > > + dev->power.driver_flags = flags; > > +} > > Should

Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-16 Thread Rafael J. Wysocki
On Monday, October 16, 2017 8:28:52 AM CEST Greg Kroah-Hartman wrote: > On Mon, Oct 16, 2017 at 03:29:02AM +0200, Rafael J. Wysocki wrote: > > struct dev_pm_info { > > pm_message_tpower_state; > > unsigned intcan_wakeup:1; > > @@ -561,6 +580,7 @@ struct dev_pm_info

Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-16 Thread Rafael J. Wysocki
On Monday, October 16, 2017 7:34:52 AM CEST Lukas Wunner wrote: > On Mon, Oct 16, 2017 at 03:29:02AM +0200, Rafael J. Wysocki wrote: > > + :c:func:`dev_pm_set_driver_flags` helper function.] If the first of > > + tese flags is set, the PM core will not apply the direct-complete > ^ >

Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-16 Thread Alan Stern
On Mon, 16 Oct 2017, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The motivation for this change is to provide a way to work around > a problem with the direct-complete mechanism used for avoiding > system suspend/resume handling for devices in runtime

Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-16 Thread Greg Kroah-Hartman
On Mon, Oct 16, 2017 at 03:29:02AM +0200, Rafael J. Wysocki wrote: > +static inline void dev_pm_set_driver_flags(struct device *dev, unsigned int > flags) > +{ > + dev->power.driver_flags = flags; > +} Should this function just set the specific bit? Or is it going to be ok to set the whole

Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-16 Thread Greg Kroah-Hartman
On Mon, Oct 16, 2017 at 03:29:02AM +0200, Rafael J. Wysocki wrote: > struct dev_pm_info { > pm_message_tpower_state; > unsigned intcan_wakeup:1; > @@ -561,6 +580,7 @@ struct dev_pm_info { > boolis_late_suspended:1; > bool

Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-15 Thread Lukas Wunner
On Mon, Oct 16, 2017 at 03:29:02AM +0200, Rafael J. Wysocki wrote: > + :c:func:`dev_pm_set_driver_flags` helper function.] If the first of > + tese flags is set, the PM core will not apply the direct-complete ^ these > + proceudre described above to the given device

[PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-15 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The motivation for this change is to provide a way to work around a problem with the direct-complete mechanism used for avoiding system suspend/resume handling for devices in runtime suspend. The problem is that some middle layer code (the PCI