Re: [PATCH 01/20] mfd: Add devm_ apis for mfd_add_devices and mfd_release_devices

2016-04-07 Thread Laxman Dewangan
On Thursday 07 April 2016 05:12 PM, Lee Jones wrote: On Thu, 07 Apr 2016, Laxman Dewangan wrote: + * Normally this function will not need to be called and the resource + * management code will ensure that the resource is freed. Then what is the purpose of providing it? Do you have a user?

Re: [PATCH 01/20] mfd: Add devm_ apis for mfd_add_devices and mfd_release_devices

2016-04-07 Thread Laxman Dewangan
Hi Lee, Thanks for review. I will send another patch with incorporating your comments. On Thursday 07 April 2016 04:14 PM, Lee Jones wrote: On Tue, 05 Apr 2016, Laxman Dewangan wrote: + if (!ret) { + *ptr = dev; + devres_add(dev, ptr); + } else { +

Re: [PATCH 01/20] mfd: Add devm_ apis for mfd_add_devices and mfd_release_devices

2016-04-07 Thread Lee Jones
On Tue, 05 Apr 2016, Laxman Dewangan wrote: > Add device managed APIs devm_mfd_add_devices() and > devm_mfd_remove_devices() for the APIs mfd_add_devices() > and mfd_remove_devices(). Nit: Line wrap after "devm_mfd_remove_devices()" instead. > This helps in reducing code in error path and

[PATCH 01/20] mfd: Add devm_ apis for mfd_add_devices and mfd_release_devices

2016-04-05 Thread Laxman Dewangan
Add device managed APIs devm_mfd_add_devices() and devm_mfd_remove_devices() for the APIs mfd_add_devices() and mfd_remove_devices(). This helps in reducing code in error path and sometimes removal of .remove callback for driver unbind. Signed-off-by: Laxman Dewangan ---