Re: [PATCH 4/4] serial: doc: .break_ctl() may sleep

Hi Jon, On Sat, Apr 16, 2016 at 6:47 PM, Jonathan Corbet wrote: > On Fri, 15 Apr 2016 16:07:39 -0700 > Peter Hurley wrote: > >> > I'm missing something here. >> >> Yes. >> >> The analysis above is required to show that the API contract asserted by >>

Re: [PATCH 4/4] serial: doc: .break_ctl() may sleep

On 04/15/2016 03:41 PM, Jonathan Corbet wrote: > On Fri, 15 Apr 2016 15:31:30 -0700 > Peter Hurley wrote: > >> The only caller of the uart driver's break_ctl() method is >> uart_break_ctl(), which is serial core's proxy tty driver break_ctl() >> method. uart_break_ctl()

Re: [PATCH 4/4] serial: doc: .break_ctl() may sleep

On Fri, 15 Apr 2016 15:31:30 -0700 Peter Hurley wrote: > The only caller of the uart driver's break_ctl() method is > uart_break_ctl(), which is serial core's proxy tty driver break_ctl() > method. uart_break_ctl() claims the struct tty_port::mutex to prevent >

Re: [PATCH 4/4] serial: doc: .break_ctl() may sleep

On 04/15/2016 03:01 PM, Jonathan Corbet wrote: > On Thu, 14 Apr 2016 11:08:11 +0200 > Geert Uytterhoeven wrote: > >> As mutex_lock() must not be called with interrupts disabled, >> .break_ctl() may sleep. > > So I've applied the first three to the docs tree, but this

Re: [PATCH 4/4] serial: doc: .break_ctl() may sleep

On Thu, 14 Apr 2016 11:08:11 +0200 Geert Uytterhoeven wrote: > As mutex_lock() must not be called with interrupts disabled, > .break_ctl() may sleep. So I've applied the first three to the docs tree, but this one stopped me. The changelog doesn't really say why the

[PATCH 4/4] serial: doc: .break_ctl() may sleep

As mutex_lock() must not be called with interrupts disabled, .break_ctl() may sleep. Reported-by: Peter Hurley Signed-off-by: Geert Uytterhoeven --- Documentation/serial/driver | 1 - 1 file changed, 1 deletion(-) diff --git