Re: [PATCH linux 2/6] hwmon: occ: Add sysfs interface

2017-01-10 Thread Guenter Roeck
On Tue, Jan 10, 2017 at 11:41:44AM -0600, Benjamin Herrenschmidt wrote: > On Sat, 2017-01-07 at 09:15 -0800, Guenter Roeck wrote: > > > Instead of the "online" attribute, what do you think about using the > > > "bind"/"unbind" API to probe the device from user space once the system > > > is powered

Re: [PATCH linux 2/6] hwmon: occ: Add sysfs interface

2017-01-10 Thread Benjamin Herrenschmidt
On Mon, 2017-01-09 at 10:22 +1030, Andrew Jeffery wrote: > Alternatively, in the style of your first para, we could push the > host > CPU state management into the kernel and expose a boot/reboot/power- > off  > API to userspace. That would give us a place to hook calls for > configuring and cleani

Re: [PATCH linux 2/6] hwmon: occ: Add sysfs interface

2017-01-10 Thread Benjamin Herrenschmidt
On Sat, 2017-01-07 at 09:15 -0800, Guenter Roeck wrote: > > Instead of the "online" attribute, what do you think about using the > > "bind"/"unbind" API to probe the device from user space once the system > > is powered on? All the hwmon registration would take place in the probe > > function, it w

Re: [PATCH linux 2/6] hwmon: occ: Add sysfs interface

2017-01-08 Thread Andrew Jeffery
On Sat, 2017-01-07 at 09:15 -0800, Guenter Roeck wrote: > On 01/06/2017 02:17 PM, Edward James wrote: > > [ ... ] > > > > > +} > > > > + > > > > +static DEVICE_ATTR(online, S_IWUSR | S_IRUGO, show_occ_online, > > > > + store_occ_online); > > > > + > > > > +struct occ_sysfs *occ_sysfs_star

Re: [PATCH linux 2/6] hwmon: occ: Add sysfs interface

2017-01-07 Thread Guenter Roeck
On 01/06/2017 02:17 PM, Edward James wrote: [ ... ] > +} > + > +static DEVICE_ATTR(online, S_IWUSR | S_IRUGO, show_occ_online, > + store_occ_online); > + > +struct occ_sysfs *occ_sysfs_start(struct device *dev, struct occ *occ, > + struct occ_sysfs_config *config) > +{ > +

Re: [PATCH linux 2/6] hwmon: occ: Add sysfs interface

2016-12-30 Thread Guenter Roeck
On Fri, Dec 30, 2016 at 11:56:04AM -0600, eajames@gmail.com wrote: > From: "Edward A. James" > > Add a generic mechanism to expose the sensors provided by the OCC in > sysfs. > > Signed-off-by: Edward A. James > Signed-off-by: Andrew Jeffery > Reviewed-by: Andrew Jeffery > --- > Document

[PATCH linux 2/6] hwmon: occ: Add sysfs interface

2016-12-30 Thread eajames . ibm
From: "Edward A. James" Add a generic mechanism to expose the sensors provided by the OCC in sysfs. Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery Reviewed-by: Andrew Jeffery --- Documentation/hwmon/occ | 48 + drivers/hwmon/occ/Makefile| 2 +- drivers/hwmon/oc