Re: [PATCH v7 net-next 08/15] tcp: sack option handling improvements

2025-05-20 Thread Paolo Abeni
On 5/14/25 3:56 PM, chia-yu.ch...@nokia-bell-labs.com wrote: > From: Ilpo Järvinen > > 1) Don't early return when sack doesn't fit. AccECN code will be >placed after this fragment so no early returns please. > > 2) Make sure opts->num_sack_blocks is not left undefined. E.g., >tcp_current

[PATCH v7 net-next 08/15] tcp: sack option handling improvements

2025-05-14 Thread chia-yu . chang
From: Ilpo Järvinen 1) Don't early return when sack doesn't fit. AccECN code will be placed after this fragment so no early returns please. 2) Make sure opts->num_sack_blocks is not left undefined. E.g., tcp_current_mss() does not memset its opts struct to zero. AccECN code checks if SA