Re: [PATCH 3/4] agents: add coding style documentation and rules

2025-07-30 Thread Steven Rostedt
On Wed, 30 Jul 2025 11:31:35 +0200 Krzysztof Kozlowski wrote: > I pop up there a lot, but there is no confusion. I am (and maybe we are > all?) well aware that checkpatch hard limit is 100 as explained also here: > https://lore.kernel.org/all/df2e466a-cdaa-4263-ae16-7bf56c0ed...@kernel.org/ > >

Re: [PATCH 3/4] agents: add coding style documentation and rules

2025-07-30 Thread Jakub Kicinski
On Wed, 30 Jul 2025 11:31:35 +0200 Krzysztof Kozlowski wrote: > I pop up there a lot, but there is no confusion. I am (and maybe we are > all?) well aware that checkpatch hard limit is 100 as explained also here: > https://lore.kernel.org/all/df2e466a-cdaa-4263-ae16-7bf56c0ed...@kernel.org/ > > Bu

Re: [PATCH 3/4] agents: add coding style documentation and rules

2025-07-30 Thread Krzysztof Kozlowski
On 28/07/2025 08:03, Sasha Levin wrote: > On Sun, Jul 27, 2025 at 10:21:40PM -0700, Kees Cook wrote: >> On Mon, Jul 28, 2025 at 01:10:25AM -0400, Sasha Levin wrote: >>> On Sun, Jul 27, 2025 at 07:40:36PM -0700, Kees Cook wrote: On Sun, Jul 27, 2025 at 03:58:01PM -0400, Sasha Levin wrote: >

Re: [PATCH 3/4] agents: add coding style documentation and rules

2025-07-27 Thread Sasha Levin
On Sun, Jul 27, 2025 at 10:21:40PM -0700, Kees Cook wrote: On Mon, Jul 28, 2025 at 01:10:25AM -0400, Sasha Levin wrote: On Sun, Jul 27, 2025 at 07:40:36PM -0700, Kees Cook wrote: > On Sun, Jul 27, 2025 at 03:58:01PM -0400, Sasha Levin wrote: > > +**80 character line limit** > > + The preferred

Re: [PATCH 3/4] agents: add coding style documentation and rules

2025-07-27 Thread Kees Cook
On Mon, Jul 28, 2025 at 01:10:25AM -0400, Sasha Levin wrote: > On Sun, Jul 27, 2025 at 07:40:36PM -0700, Kees Cook wrote: > > On Sun, Jul 27, 2025 at 03:58:01PM -0400, Sasha Levin wrote: > > > +**80 character line limit** > > > + The preferred limit on the length of a single line is 80 columns. >

Re: [PATCH 3/4] agents: add coding style documentation and rules

2025-07-27 Thread Sasha Levin
On Sun, Jul 27, 2025 at 07:40:36PM -0700, Kees Cook wrote: On Sun, Jul 27, 2025 at 03:58:01PM -0400, Sasha Levin wrote: +++ b/Documentation/agents/coding-style.rst All of this is redundant. +**No trailing whitespaces** + Never leave whitespace at the end of lines. Git will warn about patche

Re: [PATCH 3/4] agents: add coding style documentation and rules

2025-07-27 Thread Kees Cook
On Sun, Jul 27, 2025 at 03:58:01PM -0400, Sasha Levin wrote: > +++ b/Documentation/agents/coding-style.rst All of this is redundant. > +**No trailing whitespaces** > + Never leave whitespace at the end of lines. Git will warn about patches > that introduce trailing whitespace. If this isn't co