Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-10-06 Thread Jacek Anaszewski
On 10/06/2017 01:48 PM, Pavel Machek wrote: > On Wed 2017-09-20 22:08:42, Jacek Anaszewski wrote: >> On 09/20/2017 01:29 PM, Pavel Machek wrote: >>> I'd leave the decision to the user. We could add a note to the >>> Documentation/leds/ledtrig-transient.txt that force feedback interface

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-10-06 Thread Pavel Machek
On Wed 2017-09-20 22:08:42, Jacek Anaszewski wrote: > On 09/20/2017 01:29 PM, Pavel Machek wrote: > > I'd leave the decision to the user. We could add a note to the > > Documentation/leds/ledtrig-transient.txt that force feedback interface > > should be preferable choice for driving

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-10-04 Thread Dmitry Torokhov
On Thu, Sep 28, 2017 at 12:22:13PM -0700, David Lin wrote: > On Wed, Sep 27, 2017 at 10:43 PM, Dmitry Torokhov > wrote: > >>One thing I noticed is that input_ff_create_memless() also does not > >>use high-resolution timer hence it also does not have the stop-time >

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-28 Thread David Lin
On Wed, Sep 27, 2017 at 10:43 PM, Dmitry Torokhov wrote: >>One thing I noticed is that input_ff_create_memless() also does not >>use high-resolution timer hence it also does not have the stop-time >>precision that I'm looking for. > > I'll take patches for high

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-27 Thread Dmitry Torokhov
On September 27, 2017 10:03:28 PM PDT, David Lin wrote: >Dmitry, > >On Fri, Sep 15, 2017 at 3:30 PM, Dmitry Torokhov > wrote: >> On Fri, Sep 15, 2017 at 2:55 PM, Jacek Anaszewski >> wrote: >>> On 09/15/2017 08:34 PM,

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-27 Thread David Lin
Dmitry, On Fri, Sep 15, 2017 at 3:30 PM, Dmitry Torokhov wrote: > On Fri, Sep 15, 2017 at 2:55 PM, Jacek Anaszewski > wrote: >> On 09/15/2017 08:34 PM, Dmitry Torokhov wrote: >>> On Thu, Sep 14, 2017 at 1:58 PM, Pavel Machek

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-20 Thread Jacek Anaszewski
On 09/20/2017 01:29 PM, Pavel Machek wrote: > I'd leave the decision to the user. We could add a note to the > Documentation/leds/ledtrig-transient.txt that force feedback interface > should be preferable choice for driving vibrate devices. > However only if following conditions

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-20 Thread Jacek Anaszewski
On 09/19/2017 11:07 PM, Dmitry Torokhov wrote: > On Tue, Sep 19, 2017 at 1:45 PM, Jacek Anaszewski > wrote: >> On 09/19/2017 12:29 AM, Dmitry Torokhov wrote: >>> On Mon, Sep 18, 2017 at 1:50 PM, Jacek Anaszewski >>> wrote: Hi,

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-20 Thread Jacek Anaszewski
Hi, On 09/20/2017 01:15 PM, Pavel Machek wrote: > On Mon 2017-09-18 22:43:40, Jacek Anaszewski wrote: >> Hi, >> >> On 09/17/2017 07:50 PM, Pavel Machek wrote: >>> Hi! >>> >> Do you think such an improvement could be harmful in some way, >> even if it was made optional? > > Of

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-20 Thread Pavel Machek
> >>> I'd leave the decision to the user. We could add a note to the > >>> Documentation/leds/ledtrig-transient.txt that force feedback interface > >>> should be preferable choice for driving vibrate devices. > >>> However only if following conditions are met: > >> > >> What I meant is that it is

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-20 Thread Pavel Machek
Hi! > >> However only if following conditions are met: > >> - force feedback driver supports gpio driven devices > >> - there is sample application in tools/input showing how to > >> setup gpio driven vibrate device with use of ff interface > >> - it will be possible to setup vibrate interval

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-20 Thread Pavel Machek
On Mon 2017-09-18 22:43:40, Jacek Anaszewski wrote: > Hi, > > On 09/17/2017 07:50 PM, Pavel Machek wrote: > > Hi! > > > Do you think such an improvement could be harmful in some way, > even if it was made optional? > >>> > >>> Of course, we can make LED timing accurate down to

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-19 Thread Dmitry Torokhov
On Tue, Sep 19, 2017 at 1:45 PM, Jacek Anaszewski wrote: > On 09/19/2017 12:29 AM, Dmitry Torokhov wrote: >> On Mon, Sep 18, 2017 at 1:50 PM, Jacek Anaszewski >> wrote: >>> Hi, >>> >>> On 09/17/2017 08:22 PM, Pavel Machek wrote: Hi!

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-19 Thread Jacek Anaszewski
On 09/19/2017 12:29 AM, Dmitry Torokhov wrote: > On Mon, Sep 18, 2017 at 1:50 PM, Jacek Anaszewski > wrote: >> Hi, >> >> On 09/17/2017 08:22 PM, Pavel Machek wrote: >>> Hi! >>> > If your objection is that FF is not easily engaged from the shell - > yes, but I

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-18 Thread Dmitry Torokhov
On Mon, Sep 18, 2017 at 1:50 PM, Jacek Anaszewski wrote: > Hi, > > On 09/17/2017 08:22 PM, Pavel Machek wrote: >> Hi! >> If your objection is that FF is not easily engaged from the shell - yes, but I do not think that actual users who want to do vibration do

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-18 Thread Jacek Anaszewski
Hi, On 09/17/2017 08:22 PM, Pavel Machek wrote: > Hi! > >>> If your objection is that FF is not easily engaged from the shell - >>> yes, but I do not think that actual users who want to do vibration do >>> that via shell either. On the other hand, can you drop privileges and >>> still allow a

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-18 Thread Jacek Anaszewski
Hi, On 09/17/2017 07:50 PM, Pavel Machek wrote: > Hi! > Do you think such an improvement could be harmful in some way, even if it was made optional? >>> >>> Of course, we can make LED timing accurate down to microseconds. It will >>> mean increased overhead -- for "improvement" human

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-17 Thread Pavel Machek
Hi! > >> Do you think such an improvement could be harmful in some way, > >> even if it was made optional? > > > > Of course, we can make LED timing accurate down to microseconds. It will > > mean increased overhead -- for "improvement" human can not perceive. > > > > If someone has problems

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-17 Thread Jacek Anaszewski
Hi, On 09/16/2017 03:58 AM, Pavel Machek wrote: > Hi! > >> These patch series add the LED_BRIGHTNESS_FAST flag support for >> ledtrig-transient to use hrtimer so that platforms with high-resolution >> timer >> support can have better accuracy in the trigger duration timing. The

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-17 Thread Jacek Anaszewski
On 09/16/2017 12:30 AM, Dmitry Torokhov wrote: > On Fri, Sep 15, 2017 at 2:55 PM, Jacek Anaszewski > wrote: >> On 09/15/2017 08:34 PM, Dmitry Torokhov wrote: >>> On Thu, Sep 14, 2017 at 1:58 PM, Pavel Machek wrote: On Thu 2017-09-14 21:31:31, Jacek

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-16 Thread Pavel Machek
Hi! > >> If we want to have discussion "how to make vibrations in input > >> easier to use", well that's fair. But I don't think it is particulary hard. > >> > > > > I would like to know more about why you find the FF interface hard, > > led-transient trigger can be activated using only

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-16 Thread Pavel Machek
Hi! > These patch series add the LED_BRIGHTNESS_FAST flag support for > ledtrig-transient to use hrtimer so that platforms with high-resolution > timer > support can have better accuracy in the trigger duration timing. The > need for ... > > If we want to say "lets move

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-15 Thread Dmitry Torokhov
On Fri, Sep 15, 2017 at 2:55 PM, Jacek Anaszewski wrote: > On 09/15/2017 08:34 PM, Dmitry Torokhov wrote: >> On Thu, Sep 14, 2017 at 1:58 PM, Pavel Machek wrote: >>> On Thu 2017-09-14 21:31:31, Jacek Anaszewski wrote: Hi David and Pavel,

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-15 Thread Jacek Anaszewski
On 09/15/2017 08:34 PM, Dmitry Torokhov wrote: > On Thu, Sep 14, 2017 at 1:58 PM, Pavel Machek wrote: >> On Thu 2017-09-14 21:31:31, Jacek Anaszewski wrote: >>> Hi David and Pavel, >>> >>> On 09/13/2017 10:20 PM, Pavel Machek wrote: Hi! > These patch series add the

Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-15 Thread Dmitry Torokhov
On Thu, Sep 14, 2017 at 1:58 PM, Pavel Machek wrote: > On Thu 2017-09-14 21:31:31, Jacek Anaszewski wrote: >> Hi David and Pavel, >> >> On 09/13/2017 10:20 PM, Pavel Machek wrote: >> > Hi! >> > >> >> These patch series add the LED_BRIGHTNESS_FAST flag support for >> >>

Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

2017-09-14 Thread Pavel Machek
On Thu 2017-09-14 21:31:31, Jacek Anaszewski wrote: > Hi David and Pavel, > > On 09/13/2017 10:20 PM, Pavel Machek wrote: > > Hi! > > > >> These patch series add the LED_BRIGHTNESS_FAST flag support for > >> ledtrig-transient to use hrtimer so that platforms with high-resolution > >> timer > >>