[PATCH 45/50] pinctrl: st: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration. Signed-off-by: Laxman Dewangan Cc: Srinivas Kandagatla Cc: Maxime Coquelin Cc: Patrice Chotard Cc: ker...@stlinux.com ---

[PATCH 44/50] pinctrl: rockchip: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration. Signed-off-by: Laxman Dewangan Cc: Heiko Stuebner Cc: linux-rockc...@lists.infradead.org --- drivers/pinctrl/pinctrl-rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 47/50] pinctrl: tz1090-pdc: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration and remove the need of .remove callback. Signed-off-by: Laxman Dewangan --- drivers/pinctrl/pinctrl-tz1090-pdc.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git

Re: [PATCHv6 2/3] IB/core: added support to use rdma cgroup controller

2016-02-24 Thread Haggai Eran
On 20/02/2016 13:00, Parav Pandit wrote: > +/** > + * ib_device_unregister_rdmacg - unregister with rdma cgroup. > + * @device: device to unregister. > + * > + * Unregister with the rdma cgroup. Should be called after > + * all the resources are deallocated, and after a stage when any > + * other

[PATCH v6 4/8] kmsg: add additional buffers support to memory class

2016-02-24 Thread Kazimierz Krosman
From: Marcin Niesluchowski Memory class does not support additional kmsg buffers. Add additional kmsg buffers support to: * devnode() callback of "mem" class * file operations of major "mem" character device Signed-off-by: Marcin Niesluchowski

[PATCH v6 3/8] kmsg: introduce additional kmsg devices support

2016-02-24 Thread Kazimierz Krosman
From: Marcin Niesluchowski kmsg device provides operations on cyclic logging buffer used mainly by kernel but also in userspace by privileged processes. Additional kmsg devices keep the same log format but may be added dynamically with custom size. Signed-off-by:

[PATCH v6 8/8] kmsg: selftests

2016-02-24 Thread Kazimierz Krosman
From: Paul Osmialowski This patch adds selftests framework and four test scenarios for kmsg. The framework shape and code was inspired by similar selftests framework for kdbus. Signed-off-by: Paul Osmialowski [Fixed multithreaded test bug:

[PATCH v6 1/8] printk: extract kmsg-related routines from printk.c to kmsg.c

2016-02-24 Thread Kazimierz Krosman
From: Paul Osmialowski Following suggestions regarding printk.c code bloat, I prepared this patch which moves kmsg-related routines to new file, kmsg.c This is premilinary step needed for an attempt to extent kmsg interface with ability to dynamically create (and

[PATCH 38/50] pinctrl: digicolor: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration and clean error path. Signed-off-by: Laxman Dewangan Cc: Baruch Siach --- drivers/pinctrl/pinctrl-digicolor.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

[PATCH 34/50] pinctrl: amd: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration and clean error path. Signed-off-by: Laxman Dewangan --- drivers/pinctrl/pinctrl-amd.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/pinctrl-amd.c

[PATCH 36/50] pinctrl: at91-pio4: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration and clean error path. Signed-off-by: Laxman Dewangan Cc: linux-arm-ker...@lists.infradead.org --- drivers/pinctrl/pinctrl-at91-pio4.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-)

[PATCH 20/50] pinctrl: ssbi-mpp: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration and clean the error path. Signed-off-by: Laxman Dewangan Cc: Bjorn Andersson --- drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-)

[PATCH 19/50] pinctrl: ssbi-gpi: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration and clean the error path. Signed-off-by: Laxman Dewangan Cc: Bjorn Andersson --- drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 9 ++--- 1 file changed, 2 insertions(+), 7

[PATCH 21/50] pinctrl: msm: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration and clean the error path. Signed-off-by: Laxman Dewangan Cc: Bjorn Andersson Cc: Thomas Gleixner Cc: Lee Jones Cc: Stephen Boyd

[PATCH 17/50] pinctrl: spmi-gpio: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration and clean the error path. Signed-off-by: Laxman Dewangan Cc: "Björn Andersson" Cc: "Ivan T. Ivanov" Cc: Lee Jones Cc: Stephen Boyd

[PATCH 14/50] pinctrl: meson: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration. Signed-off-by: Laxman Dewangan Cc: Carlo Caione Cc: Beniamino Galvani Cc: Lee Jones --- drivers/pinctrl/meson/pinctrl-meson.c | 2 +- 1 file changed,

[PATCH v6 2/8] printk: add one function for storing log in proper format

2016-02-24 Thread Kazimierz Krosman
From: Marcin Niesluchowski Preparation commit for future changes purpose. Separate code responsible for storing log message in proper format from operations on consoles by putting it in another function. Signed-off-by: Marcin Niesluchowski

[PATCH v6 7/8] kmsg: add ioctl for kmsg* devices operating on buffers

2016-02-24 Thread Kazimierz Krosman
From: Marcin Niesluchowski There is no possibility to clear additional kmsg buffers, get size of them or know what size should be passed to read file operation (too small size causes it to retrun -EINVAL). Add following ioctls which solve those issues: *

[PATCH 37/50] pinctrl: at91: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration and remove the need of .remove callback. Signed-off-by: Laxman Dewangan Cc: Jean-Christophe Plagniol-Villard Cc: linux-arm-ker...@lists.infradead.org --- drivers/pinctrl/pinctrl-at91.c | 13

Re: custom ioctl-based interface to control LED in networking (was Re: [PATCHv2 09/10] rfkill: Userspace control for airplane mode)

2016-02-24 Thread Johannes Berg
On Wed, 2016-02-24 at 13:14 +0100, Pavel Machek wrote: >  > Why would it need to? It could look at default triggers for the led > if it really wanted to. And then it needs to change them; if anything goes wrong error recovery is practically impossible since the trigger information is lost

[PATCH 26/50] pinctrl: spear: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration and remove need of .remove callback. Signed-off-by: Laxman Dewangan Cc: Viresh Kumar Cc: spear-de...@list.st.com Cc: linux-arm-ker...@lists.infradead.org --- drivers/pinctrl/spear/pinctrl-spear.c

[PATCH 22/50] pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration and clean the error path. Signed-off-by: Laxman Dewangan Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Cc:

[PATCH 28/50] pinctrl: ssbi-mpp: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration and clean the error path. Signed-off-by: Laxman Dewangan Cc: Maxime Ripard Cc: Chen-Yu Tsai --- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 13 - 1 file

[PATCH 08/50] pinctrl: berlin: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration. Signed-off-by: Laxman Dewangan Cc: Antoine Ténart --- drivers/pinctrl/berlin/berlin.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 29/50] pinctrl: tegra: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration and remove need of .remove callback. Signed-off-by: Laxman Dewangan Cc: Stephen Warren Cc: Thierry Reding Cc: Alexandre Courbot ---

[PATCH 24/50] pinctrl: samsung: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration. Signed-off-by: Laxman Dewangan Cc: Tomasz Figa Cc: Kukjin Kim Cc: Krzysztof Kozlowski --- drivers/pinctrl/samsung/pinctrl-samsung.c | 3 ++- 1

[PATCH 27/50] pinctrl: stm32: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration. Signed-off-by: Laxman Dewangan Cc: Maxime Coquelin Cc: Patrice Chotard --- drivers/pinctrl/stm32/pinctrl-stm32.c | 7 --- 1 file changed, 4 insertions(+), 3

Re: [PATCH 38/50] pinctrl: digicolor: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Baruch Siach
Hi Laxman Dewangan, On Wed, Feb 24, 2016 at 06:46:03PM +0530, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration and clean > error path. > > Signed-off-by: Laxman Dewangan > Cc: Baruch Siach > --- >

Re: custom ioctl-based interface to control LED in networking (was Re: [PATCHv2 09/10] rfkill: Userspace control for airplane mode)

2016-02-24 Thread Pavel Machek
On Wed 2016-02-24 12:01:37, Johannes Berg wrote: > On Wed, 2016-02-24 at 11:46 +0100, Pavel Machek wrote: > > > If you want different trigger, implement different trigger. If you > > want to indicate all but wifi, implement all but wifi, and then > > userspace can select it by writing trigger

[PATCH 11/50] pinctrl: cherryview: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration. Signed-off-by: Laxman Dewangan Cc: Mika Westerberg Cc: Heikki Krogerus --- drivers/pinctrl/intel/pinctrl-cherryview.c | 4 ++-- 1 file changed, 2

[PATCH 13/50] pinctrl: mtk-common: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration and clean the error path. Signed-off-by: Laxman Dewangan Cc: Matthias Brugger Cc: Hongzhou Yang Cc: Yingjoe Chen ---

[PATCH 16/50] pinctrl: nomadic: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration. Signed-off-by: Laxman Dewangan Cc: Alessandro Rubini Cc: linux-arm-ker...@lists.infradead.org --- drivers/pinctrl/nomadik/pinctrl-abx500.c | 3 ++- drivers/pinctrl/nomadik/pinctrl-nomadik.c | 2 +-

[PATCH 31/50] pinctrl: uniphier: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Laxman Dewangan
Use devm_pinctrl_register() for pin control registration and remove need of .remove callback. Signed-off-by: Laxman Dewangan Cc: Masahiro Yamada --- drivers/pinctrl/uniphier/pinctrl-ph1-ld4.c | 1 -

Re: [PATCH 28/50] pinctrl: ssbi-mpp: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Maxime Ripard
On Wed, Feb 24, 2016 at 06:45:53PM +0530, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration and clean > the error path. > > Signed-off-by: Laxman Dewangan > Cc: Maxime Ripard > Cc: Chen-Yu Tsai

Re: [PATCH 21/50] pinctrl: msm: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Bjorn Andersson
On Wed 24 Feb 05:15 PST 2016, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration and clean > the error path. > > Signed-off-by: Laxman Dewangan > Cc: Bjorn Andersson > Cc: Thomas Gleixner

Re: [PATCH 07/50] pinctrl: nsp-gpio: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Ray Jui
On 2/24/2016 5:15 AM, Laxman Dewangan wrote: Use devm_pinctrl_register() for pin control registration. Signed-off-by: Laxman Dewangan Cc: Ray Jui Cc: Scott Branden Cc: Jon Mason ---

[PATCH 3/5] all: s390: move wrapper infrastructure to generic headers

2016-02-24 Thread Yury Norov
__SC_COMPAT_CAST for s390 is too specific due to 31-bit pointer length, so it's moved to arch/s390/include/asm/compat.h. Generic declaration assumes that long, unsigned long and pointer types are all 32-bit length. linux/syscalls_structs.h header is introduced, because from now (see next patch)

Re: custom ioctl-based interface to control LED in networking (was Re: [PATCHv2 09/10] rfkill: Userspace control for airplane mode)

2016-02-24 Thread Johannes Berg
On Wed, 2016-02-24 at 11:46 +0100, Pavel Machek wrote: > If you want different trigger, implement different trigger. If you > want to indicate all but wifi, implement all but wifi, and then > userspace can select it by writing trigger name. This is still mostly a strawman, since userspace

Re: [PATCH 06/50] pinctrl: iproc-gpio: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Ray Jui
On 2/24/2016 5:15 AM, Laxman Dewangan wrote: Use devm_pinctrl_register() for pin control registration and clean the error path. Signed-off-by: Laxman Dewangan Cc: Ray Jui Cc: Scott Branden Cc: Jon Mason

[PATCH 5/5] all: wrap needed syscalls in generic unistd

2016-02-24 Thread Yury Norov
As generic unistd syscall table is written in C, syscall prototypes declaration is needed. It's added to compat header. Signed-off-by: Yury Norov --- include/linux/compat.h| 225 + include/uapi/asm-generic/unistd.h | 227

[PATCH 1/5] all: syscall wrappers: add documentation

2016-02-24 Thread Yury Norov
Signed-off-by: Yury Norov --- Documentation/adding-syscalls.txt | 32 1 file changed, 32 insertions(+) diff --git a/Documentation/adding-syscalls.txt b/Documentation/adding-syscalls.txt index cc2d4ac..1db880c 100644 ---

[PATCH v2 0/5] all: s390: make compat wrappers the generic solution

2016-02-24 Thread Yury Norov
The problem that makes us use wrappers is that some compat architectures allows user code to access top halves of registers. This is not a problem for syscalls that are already handled by compat code, or for that who has types of the same size in kernel and userspace. In case of s390 and

Re: [PATCH 18/50] pinctrl: spmi: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Bjorn Andersson
On Wed 24 Feb 05:15 PST 2016, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration and clean > the error path. > > Signed-off-by: Laxman Dewangan > Cc: Ivan T. Ivanov > Cc: Lee Jones > Cc: Stephen

Re: [PATCH 20/50] pinctrl: ssbi-mpp: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Bjorn Andersson
On Wed 24 Feb 05:15 PST 2016, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration and clean > the error path. > > Signed-off-by: Laxman Dewangan > Cc: Bjorn Andersson > --- Reviewed-by: Bjorn Andersson

[PATCH] usbip: move usbip_protocol.txt to Documentation

2016-02-24 Thread Christian Lamparter
The usbip_protocol.txt, a document which describes usbip's inner workings is currently located in the projects source directory (drivers/usb/usbip/...). This patch moves it to Documentation/usb. This discussion was brought up by Guy Harris [0] during the review of the USBIP dissector I wrote. For

Re: [PATCH 03/50] pinctrl: bcm281xx: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Ray Jui
On 2/24/2016 5:15 AM, Laxman Dewangan wrote: Use devm_pinctrl_register() for pin control registration. Signed-off-by: Laxman Dewangan Cc: Ray Jui --- drivers/pinctrl/bcm/pinctrl-bcm281xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

Re: [PATCH] usbip: move usbip_protocol.txt to Documentation

2016-02-24 Thread Greg KH
On Wed, Feb 24, 2016 at 07:23:08PM +0100, Christian Lamparter wrote: > The usbip_protocol.txt, a document which describes usbip's > inner workings is currently located in the projects source > directory (drivers/usb/usbip/...). This patch moves it to > Documentation/usb. > > This discussion was

[PATCH 2/5] all: introduce COMPAT_WRAPPER option and enable it for s390

2016-02-24 Thread Yury Norov
Signed-off-by: Yury Norov --- arch/Kconfig | 4 arch/s390/Kconfig | 1 + 2 files changed, 5 insertions(+) diff --git a/arch/Kconfig b/arch/Kconfig index f6b649d..6393093 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -583,6 +583,10 @@ config

Re: [PATCH 17/50] pinctrl: spmi-gpio: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Bjorn Andersson
On Wed 24 Feb 05:15 PST 2016, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration and clean > the error path. > > Signed-off-by: Laxman Dewangan > Cc: "Ivan T. Ivanov" > Cc: Lee Jones > Cc:

Re: [PATCH 05/50] pinctrl: cygnus-mux: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Ray Jui
On 2/24/2016 5:15 AM, Laxman Dewangan wrote: Use devm_pinctrl_register() for pin control registration. Signed-off-by: Laxman Dewangan Cc: Ray Jui Cc: Scott Branden Cc: Jon Mason ---

Re: [PATCH 04/50] pinctrl: bcm2835: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Ray Jui
On 2/24/2016 5:15 AM, Laxman Dewangan wrote: Use devm_pinctrl_register() for pin control registration. Signed-off-by: Laxman Dewangan Cc: Ray Jui --- drivers/pinctrl/bcm/pinctrl-bcm2835.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH 4/5] all: s390: move compat_wrappers.c from arch/s390/kernel to kernel/

2016-02-24 Thread Yury Norov
Some syscalls are declared conditionally, so corresponding wrappers are conditional accordingly. Signed-off-by: Yury Norov --- arch/s390/kernel/Makefile | 2 +- arch/s390/kernel/compat_wrapper.c | 129 - kernel/Makefile

Re: [PATCH 29/50] pinctrl: tegra: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Stephen Warren
On 02/24/2016 06:15 AM, Laxman Dewangan wrote: Use devm_pinctrl_register() for pin control registration and remove need of .remove callback. Acked-by: Stephen Warren Any chance you could send a patch to soc-to-kernel-pinctrl-driver.py in

Re: [PATCHv6 1/3] rdmacg: Added rdma cgroup controller

2016-02-24 Thread Haggai Eran
Hi, Overall I the patch looks good to me. I have a few comments below. On 20/02/2016 13:00, Parav Pandit wrote: > Resource pool is created/destroyed dynamically whenever > charging/uncharging occurs respectively and whenever user > configuration is done. Its a tradeoff of memory vs little more

Re: [PATCH 30/50] pinctrl: tegra-xusb: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Stephen Warren
On 02/24/2016 06:15 AM, Laxman Dewangan wrote: Use devm_pinctrl_register() for pin control registration and clean the error path. Acked-by: Stephen Warren -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to

[PATCH v2 6/8] ACPI: serial: implement earlycon on ACPI DBG2 port

2016-02-24 Thread Aleksey Makarov
Add ACPI_DBG2_EARLYCON_DECLARE() macros that declares an earlycon on the serial port specified in the DBG2 ACPI table. Pass the string "earlycon=acpi_dbg2" to the kernel to activate it. Callbacks for EARLYCON_DECLARE() and OF_EARLYCON_DECLARE() can also be used for this macros. Signed-off-by:

Re: [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister}

2016-02-24 Thread Stefan Wahren
Hi Laxman, > Laxman Dewangan hat am 24. Februar 2016 um 14:15 > geschrieben: > > > Add resource manageemnt APIs fro pinctrl_register() and pinctrl_unregister() > and use these new APIs on hw driver to reduce the error path code and > remove callback for driver. > just for

Re: [PATCHv2 09/10] rfkill: Userspace control for airplane mode

2016-02-24 Thread Johannes Berg
On Tue, 2016-02-23 at 22:45 +0100, Pavel Machek wrote: > Well "the airplane mode" is well defined. It means no intentional > transmitting at radio frequencies. > > The fact that you are allowed to use WIFI on certain flights does not > change anything. Nope, not that simple. Pick up any

Re:magnet materials for your oil industry

2016-02-24 Thread Thomas
Dear, How are you?Long time not contact! We have met on the exhibition before,and we talked about the magnet items.I am Thomas from Topmag Co.,ltd,HongKong,China. These day the NdFeB price becomes more and more lower,do you have any new items use the magnets? Maybe we can help you for the

Re: [RFC v5 0/8] Additional kmsg devices

2016-02-24 Thread Andrew Morton
On Wed, 16 Dec 2015 10:27:57 -0500 Tejun Heo wrote: > On Wed, Dec 16, 2015 at 08:47:35AM +0100, Richard Weinberger wrote: > > > Andrew? Are you or anyone else interested in picking up this patchset? > > > > I know I'm repeating myself. But this should be done in userspace. >

Re: [PATCH 13/50] pinctrl: mtk-common: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Hongzhou Yang
On Wed, 2016-02-24 at 18:45 +0530, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration and clean > the error path. > > Signed-off-by: Laxman Dewangan > Cc: Matthias Brugger > Cc: Hongzhou Yang