Re: [Merge tag 'pci-v4.12-changes' of git] 857f864014: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8

2017-06-13 Thread Logan Gunthorpe
On 13/06/17 11:00 PM, Greg Kroah-Hartman wrote: > No, don't modify any drivers, do this in the core chardev code. Ok, well then maybe I misunderstood what you originally asked for because I don't see how you can change a fixed allocation to a dynamic one without touching the driver code which ne

Re: [Merge tag 'pci-v4.12-changes' of git] 857f864014: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8

2017-06-13 Thread Greg Kroah-Hartman
On Tue, Jun 13, 2017 at 09:13:32PM +0200, Sven-Haegar Koch wrote: > On Tue, 13 Jun 2017, Greg Kroah-Hartman wrote: > > > On Tue, Jun 13, 2017 at 10:25:40AM -0600, Logan Gunthorpe wrote: > > > > > > On 12/06/17 10:35 PM, Greg Kroah-Hartman wrote: > > > > Or better yet, just turn all char major all

Re: [Merge tag 'pci-v4.12-changes' of git] 857f864014: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8

2017-06-13 Thread Greg Kroah-Hartman
On Tue, Jun 13, 2017 at 11:47:30AM -0600, Logan Gunthorpe wrote: > > > On 13/06/17 10:35 AM, Greg Kroah-Hartman wrote: > > For char devices, I doubt it, but we can't take the chance, which is why > > you make it an option. Then, it's enabled for 'allmodconfig' builds, > > which helps testers out

[PATCH] of: update ePAPR references to point to Devicetree Specification

2017-06-13 Thread frowand . list
From: Frank Rowand The Devicetree Specification has superseded the ePAPR as the base specification for bindings. Update files in Documentation to reference the new document. Some files are not updated because there is no hypervisor chapter in the Devicetree Specification: Documentation/devic

Re: [PATCH 6/8] usb: gadget: f_acm: add an ioctl to get the current line coding

2017-06-13 Thread Alan Cox
On Mon, 12 Jun 2017 20:26:13 +0300 Tal Shorer wrote: > The user can issue USB_F_GET_LINE_CODING to get the current line coding > as set by the host (or the default if unset yet). No this is not how to do it. We don't want weirdass ioctls for each different tty device type. There are two ways th

Re: [PATCH v2 1/8] tty: add a poll() callback in struct tty_operations

2017-06-13 Thread Alan Cox
On Tue, 13 Jun 2017 09:52:07 +0300 Tal Shorer wrote: > If a tty driver wants to notify the user of some exceptional event, > such as a usb cdc acm device set_line_coding event, it needs a way to > modify the mask returned by poll() and possible also add wait queues. > In order to do that, we allo

Re: [Merge tag 'pci-v4.12-changes' of git] 857f864014: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8

2017-06-13 Thread Sven-Haegar Koch
On Tue, 13 Jun 2017, Greg Kroah-Hartman wrote: > On Tue, Jun 13, 2017 at 10:25:40AM -0600, Logan Gunthorpe wrote: > > > > On 12/06/17 10:35 PM, Greg Kroah-Hartman wrote: > > > Or better yet, just turn all char major allocations into dynamic, which > > > would be really good for test systems. I t

Re: [Merge tag 'pci-v4.12-changes' of git] 857f864014: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8

2017-06-13 Thread Logan Gunthorpe
On 13/06/17 10:35 AM, Greg Kroah-Hartman wrote: > For char devices, I doubt it, but we can't take the chance, which is why > you make it an option. Then, it's enabled for 'allmodconfig' builds, > which helps testers out. Well I took a look at this and it looks like a lot of work to modify all t

Re: [Merge tag 'pci-v4.12-changes' of git] 857f864014: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8

2017-06-13 Thread Greg Kroah-Hartman
On Tue, Jun 13, 2017 at 10:25:40AM -0600, Logan Gunthorpe wrote: > > > On 12/06/17 10:35 PM, Greg Kroah-Hartman wrote: > > Or better yet, just turn all char major allocations into dynamic, which > > would be really good for test systems. I thought someone proposed > > patches for that a long tim

Re: [Merge tag 'pci-v4.12-changes' of git] 857f864014: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8

2017-06-13 Thread Logan Gunthorpe
On 12/06/17 10:35 PM, Greg Kroah-Hartman wrote: > Or better yet, just turn all char major allocations into dynamic, which > would be really good for test systems. I thought someone proposed > patches for that a long time ago, but I can't find them anymore. That > would be the simplest solution

Re: [Merge tag 'pci-v4.12-changes' of git] 857f864014: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8

2017-06-13 Thread Logan Gunthorpe
On 13/06/17 05:48 AM, Alan Cox wrote: > If you dump the list of majors and drivers do they all look valid or is > there any corruption or repetition that looks odd (wondering if we've > got too many devices or a leak) ? They look valid to me. Logan Character devices: 1 mem 4 /dev/vc/0 4

Re: [Merge tag 'pci-v4.12-changes' of git] 857f864014: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8

2017-06-13 Thread Alan Cox
On Mon, 2017-06-12 at 17:34 -0600, Logan Gunthorpe wrote: > Hey, > > Ok, I dug into this bug and I know what's going on. Unfortunately, > it's > a mess of a couple issues and I don't know what correct the > solution(s) > is(are). > > 1) The test we are looking at is overrunning the dynamic char d

Re: [PATCH 02/20] 32-bit ABI: introduce ARCH_32BIT_OFF_T config option

2017-06-13 Thread Yury Norov
On Thu, Jun 08, 2017 at 04:09:50PM +0100, Catalin Marinas wrote: > On Sun, Jun 04, 2017 at 02:59:51PM +0300, Yury Norov wrote: > > All new 32-bit architectures should have 64-bit off_t type, but existing > > architectures has 32-bit ones. > > > > To handle it, new config option is added to arch/Kc

Re: [PATCH v2 6/8] usb: gadget: f_acm: add an ioctl to get the current line coding

2017-06-13 Thread Tal Shorer
On Tue, Jun 13, 2017 at 12:19 PM, Greg KH wrote: > On Tue, Jun 13, 2017 at 09:52:12AM +0300, Tal Shorer wrote: >> The user can issue USB_F_GET_LINE_CODING to get the current line coding >> as set by the host (or the default if unset yet). >> >> Signed-off-by: Tal Shorer >> --- >> Documentation/i

Re: [PATCH v2 6/8] usb: gadget: f_acm: add an ioctl to get the current line coding

2017-06-13 Thread Greg KH
On Tue, Jun 13, 2017 at 09:52:12AM +0300, Tal Shorer wrote: > The user can issue USB_F_GET_LINE_CODING to get the current line coding > as set by the host (or the default if unset yet). > > Signed-off-by: Tal Shorer > --- > Documentation/ioctl/ioctl-number.txt | 1 + > drivers/usb/gadget/functi