Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-17 Thread Greg Kroah-Hartman
On Tue, Oct 17, 2017 at 05:26:20PM +0200, Rafael J. Wysocki wrote: > On Tuesday, October 17, 2017 9:15:43 AM CEST Greg Kroah-Hartman wrote: > > On Tue, Oct 17, 2017 at 12:05:11AM +0200, Rafael J. Wysocki wrote: > > > On Monday, October 16, 2017 8:28:52 AM CEST Greg Kroah-Hartman wrote: > > > > On M

Re: [PATCH v9 00/20] simplify crypto wait for async op

2017-10-17 Thread Gilad Ben-Yossef
On Tue, Oct 17, 2017 at 5:06 PM, Russell King - ARM Linux wrote: > On Sun, Oct 15, 2017 at 10:19:45AM +0100, Gilad Ben-Yossef wrote: >> Many users of kernel async. crypto services have a pattern of >> starting an async. crypto op and than using a completion >> to wait for it to end. >> >> This pat

Re: [PATCH 0/12] PM / sleep: Driver flags for system suspend/resume

2017-10-17 Thread Rafael J. Wysocki
On Tuesday, October 17, 2017 9:41:16 PM CEST Ulf Hansson wrote: [cut] > > > >> deploying this and from a middle layer point of view, all the trivial > >> cases supports this. > > > > These functions are wrong, however, because they attempt to reuse the > > whole callback *path* instead of just re

Re: [PATCH 0/2] mm, thp: introduce dedicated transparent huge page allocation interfaces

2017-10-17 Thread Andrew Morton
On Mon, 16 Oct 2017 17:19:15 +0800 changbin...@intel.com wrote: > The first one introduce new interfaces, the second one kills naming confusion. > The aim is to remove duplicated code and simplify transparent huge page > allocation. These introduce various allnoconfig build errors. -- To unsubscr

Re: [PATCH 0/12] PM / sleep: Driver flags for system suspend/resume

2017-10-17 Thread Rafael J. Wysocki
On Tuesday, October 17, 2017 10:12:19 PM CEST Alan Stern wrote: > On Tue, 17 Oct 2017, Ulf Hansson wrote: > > > > These functions are wrong, however, because they attempt to reuse the > > > whole callback *path* instead of just reusing driver callbacks. The > > > *only* reason why it all "works"

Re: [PATCH v2 3/4] dt-bindings: hwmon: Add ti-max-expected-current-microamp property to ina2xx

2017-10-17 Thread Guenter Roeck
On Tue, Oct 17, 2017 at 03:36:31PM -0500, Rob Herring wrote: > On Thu, Oct 12, 2017 at 02:36:04PM +0200, Maciej Purski wrote: > > Add optional max expected current property which allows calibrating > > the ina sensor in order to achieve requested measure scale. Document > > the changes in Documenta

Re: [PATCH v2 3/4] dt-bindings: hwmon: Add ti-max-expected-current-microamp property to ina2xx

2017-10-17 Thread Rob Herring
On Thu, Oct 12, 2017 at 02:36:04PM +0200, Maciej Purski wrote: > Add optional max expected current property which allows calibrating > the ina sensor in order to achieve requested measure scale. Document > the changes in Documentation/hwmon/ina2xx. > > Signed-off-by: Maciej Purski > --- > Docume

Re: [PATCH 0/12] PM / sleep: Driver flags for system suspend/resume

2017-10-17 Thread Alan Stern
On Tue, 17 Oct 2017, Ulf Hansson wrote: > > These functions are wrong, however, because they attempt to reuse the > > whole callback *path* instead of just reusing driver callbacks. The > > *only* reason why it all "works" is because there are no middle layer > > callbacks involved in that now. >

Re: [PATCH 0/12] PM / sleep: Driver flags for system suspend/resume

2017-10-17 Thread Ulf Hansson
[...] >> >> I am not sure I fully understand the goal you have with this series. >> Can we please try to get that clear before I continue the review. > > Quoting from the above: > > "This patch series focuses on addressing those problems so as to make it > easier to reuse callback routines by poin

[PATCH] Fix a typo in Documentation/sysctl/vm.txt

2017-10-17 Thread Kangmin Park
A trivial patch to fix a typo in Documentation/sysctl/vm.txt Replace agressiveness with aggressiveness. Sorry for two mistake mails. Thanks. Signed-off-by: Kangmin Park Cc: Jiri Kosina Cc: Alan Cox Cc: Andrew Morton diff --git a/Documentation/sysctl/vm.txt b/Documentation/sysctl/vm.txt index

[PATCH] Fix a typo in Documentation/sysctl/vm.txt

2017-10-17 Thread Kangmin Park
A trivial patch to fix a typo in Documentation/sysctl/vm.txt Replace agressiveness with aggresiveness. Signed-off-by: Kangmin Park Cc: Jiri Kosina Cc: Alan Cox Cc: Andrew Morton diff --git a/Documentation/sysctl/vm.txt b/Documentation/sysctl/vm.txt index 9baf66a9ef4e..342a88561722 100644 ---

[PATCH] Fix a typo in Documentation/sysctl/vm.txt

2017-10-17 Thread Kangmin Park
A trivial patch to fix a typo in Documentation/sysctl/vm.txt Signed-off-by: Kangmin Park Cc: Jiri Kosina Cc: Alan Cox Cc: Andrew Morton diff --git a/Documentation/sysctl/vm.txt b/Documentation/sysctl/vm.txt index 342a88561722..9baf66a9ef4e 100644 --- a/Documentation/sysctl/vm.txt +++ b/Docume

Re: [PATCH 12/12] PM / core: Add AVOID_RPM driver flag

2017-10-17 Thread Andy Shevchenko
On Tue, 2017-10-17 at 17:59 +0200, Rafael J. Wysocki wrote: > On Tuesday, October 17, 2017 5:33:17 PM CEST Andy Shevchenko wrote: > > On Mon, 2017-10-16 at 03:32 +0200, Rafael J. Wysocki wrote: > > > If DPM_FLAG_SMART_SUSPEND is not set, DPM_FLAG_AVOID_RPM has no > > > effect. > > > > > > + if (d

Re: [PATCH 12/12] PM / core: Add AVOID_RPM driver flag

2017-10-17 Thread Rafael J. Wysocki
On Tuesday, October 17, 2017 5:33:17 PM CEST Andy Shevchenko wrote: > On Mon, 2017-10-16 at 03:32 +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Define and document a new driver flag, DPM_FLAG_AVOID_RPM, to inform > > the PM core and middle layer code that the driver has some

Re: [PATCH 12/12] PM / core: Add AVOID_RPM driver flag

2017-10-17 Thread Andy Shevchenko
On Mon, 2017-10-16 at 03:32 +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Define and document a new driver flag, DPM_FLAG_AVOID_RPM, to inform > the PM core and middle layer code that the driver has something > significant to do in its ->suspend and/or ->resume callbacks and > run

Re: [PATCH 0/12] PM / sleep: Driver flags for system suspend/resume

2017-10-17 Thread Rafael J. Wysocki
On Tuesday, October 17, 2017 10:36:39 AM CEST Ulf Hansson wrote: > On 16 October 2017 at 03:12, Rafael J. Wysocki wrote: > > Hi All, > > > > Well, this took more time than expected, as I tried to cover everything I > > had > > in mind regarding PM flags for drivers. > > > > This work was triggere

Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-17 Thread Rafael J. Wysocki
On Tuesday, October 17, 2017 9:15:43 AM CEST Greg Kroah-Hartman wrote: > On Tue, Oct 17, 2017 at 12:05:11AM +0200, Rafael J. Wysocki wrote: > > On Monday, October 16, 2017 8:28:52 AM CEST Greg Kroah-Hartman wrote: > > > On Mon, Oct 16, 2017 at 03:29:02AM +0200, Rafael J. Wysocki wrote: > > > > str

Re: [PATCH v5 5/6] perf: hisi: Add support for HiSilicon SoC DDRC PMU driver

2017-10-17 Thread Mark Rutland
On Tue, Aug 22, 2017 at 04:07:56PM +0800, Shaokun Zhang wrote: > This patch adds support for DDRC PMU driver in HiSilicon SoC chip, Each > DDRC has own control, counter and interrupt registers and is an separate > PMU. For each DDRC PMU, it has 8-fixed-purpose counters which have been > mapped to 8

Re: [PATCH v5 4/6] perf: hisi: Add support for HiSilicon SoC HHA PMU driver

2017-10-17 Thread Mark Rutland
On Tue, Aug 22, 2017 at 04:07:55PM +0800, Shaokun Zhang wrote: > L3 cache coherence is maintained by Hydra Home Agent (HHA) in HiSilicon > SoC. This patch adds support for HHA PMU driver, Each HHA has own > control, counter and interrupt registers and is an separate PMU. For > each HHA PMU, it has

Re: [PATCH v5 3/6] perf: hisi: Add support for HiSilicon SoC L3C PMU driver

2017-10-17 Thread Mark Rutland
On Tue, Aug 22, 2017 at 04:07:54PM +0800, Shaokun Zhang wrote: > +static int hisi_l3c_pmu_init_irq(struct hisi_pmu *l3c_pmu, > + struct platform_device *pdev) > +{ > + int irq, ret; > + > + /* Read and init IRQ */ > + irq = platform_get_irq(pdev, 0); > +

[PATCH 1/1] Documentation: update kernel enforcement support list

2017-10-17 Thread Eduardo Valentin
Adding myself to the list as I missed the window to be in the original patch. Cc: Jonathan Corbet Cc: Bart Van Assche Cc: Namhyung Kim Cc: Olof Johansson Cc: Juergen Gross Cc: Javier Martinez Canillas Signed-off-by: Eduardo Valentin --- Documentation/process/kernel-enforcement-statement.rs

Re: [PATCH v5 2/6] perf: hisi: Add support for HiSilicon SoC uncore PMU driver

2017-10-17 Thread Mark Rutland
Hi, Apologies for the delay for this review. Largely this seems to look OK, but there are a couple of things which stick out. On Tue, Aug 22, 2017 at 04:07:53PM +0800, Shaokun Zhang wrote: > +int hisi_uncore_pmu_event_init(struct perf_event *event) > +{ > + struct hw_perf_event *hwc = &event

Re: [PATCH v9 00/20] simplify crypto wait for async op

2017-10-17 Thread Russell King - ARM Linux
On Sun, Oct 15, 2017 at 10:19:45AM +0100, Gilad Ben-Yossef wrote: > Many users of kernel async. crypto services have a pattern of > starting an async. crypto op and than using a completion > to wait for it to end. > > This patch set simplifies this common use case in two ways: > > First, by separ

[PATCH v7 3/4] arm64: kvm: Set Virtual SError Exception Syndrome for guest

2017-10-17 Thread Dongjiu Geng
RAS Extension add a VSESR_EL2 register which can provides the syndrome value reported to software on taking a virtual SError interrupt exception. This patch supports to specify this Syndrome. In the RAS Extensions we can not set all-zero syndrome value for SError, which means 'RAS error: Uncategor

[PATCH v7 4/4] arm64: kvm: handle SEI notification for guest

2017-10-17 Thread Dongjiu Geng
when KVM received SError, it firstly classified the error according to [ESR_ELx.AET]. If the SEI is Uncategorized or IMPLEMENTATION DEFINED directly inject virtual SError with IMPLEMENTATION DEFINED syndrome. If the SError error is not propagated, then let host to handle it. Because usually the ad

[PATCH v7 0/4] Add RAS virtualization support

2017-10-17 Thread Dongjiu Geng
In the firmware-first RAS solution, corrupt data is detected in a memory location when guest OS application software executing at EL0 or guest OS kernel El1 software are reading from the memory. The memory node records errors into an accessible system registers. Because SCR_EL3.EA is 1, then CPU w

[PATCH v7 2/4] arm64: kvm: Introduce KVM_ARM_SET_SERROR_ESR ioctl

2017-10-17 Thread Dongjiu Geng
On ARM64 SError syndrome value is specific to the model being emulated for the guest and user space needs a way to tell the kernel this value. userspace can specify different value to affect guest OS error recovery behaviour. We make this API ARM-specific as we haven't yet reached a consensus for

[PATCH v7 1/4] arm64: kvm: route synchronous external abort exceptions to EL2

2017-10-17 Thread Dongjiu Geng
ARMv8.2 adds a new bit HCR_EL2.TEA which controls to route synchronous external aborts to EL2, and adds a trap control bit HCR_EL2.TERR which controls to trap all Non-secure EL1&0 error record accesses to EL2. This patch enables the two bits for the guest OS. when an synchronous abort is generated

Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-17 Thread Greg Kroah-Hartman
On Tue, Oct 17, 2017 at 12:07:37AM +0200, Rafael J. Wysocki wrote: > On Monday, October 16, 2017 8:31:22 AM CEST Greg Kroah-Hartman wrote: > > On Mon, Oct 16, 2017 at 03:29:02AM +0200, Rafael J. Wysocki wrote: > > > +static inline void dev_pm_set_driver_flags(struct device *dev, unsigned > > > int

Re: [PATCH v9 00/20] simplify crypto wait for async op

2017-10-17 Thread Herbert Xu
On Tue, Oct 17, 2017 at 02:55:21PM +0300, Gilad Ben-Yossef wrote: > > Would you mind if we used ENOSPC instead of E2BIG? > > "No space left on device" seems more appropriate than > "Argument list too long". It's fine by me. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~he

Re: [PATCH 2/2] mm: rename page dtor functions to {compound,huge,transhuge}_page__dtor

2017-10-17 Thread Michal Hocko
On Tue 17-10-17 14:22:14, Kirill A. Shutemov wrote: > On Tue, Oct 17, 2017 at 12:22:03PM +0200, Michal Hocko wrote: > > On Mon 16-10-17 17:19:17, changbin...@intel.com wrote: > > > From: Changbin Du > > > > > > The current name free_{huge,transhuge}_page are paired with > > > alloc_{huge,transhug

Re: [PATCH v9 00/20] simplify crypto wait for async op

2017-10-17 Thread Gilad Ben-Yossef
On Sun, Oct 15, 2017 at 6:38 PM, Herbert Xu wrote: > > On Sun, Oct 15, 2017 at 10:19:45AM +0100, Gilad Ben-Yossef wrote: > > > > Changes from v8: > > - Remove the translation of EAGAIN return code to the > > previous return code of EBUSY for the user space > > interface of algif as no one seem

Re: [PATCH 2/2] mm: rename page dtor functions to {compound,huge,transhuge}_page__dtor

2017-10-17 Thread Kirill A. Shutemov
On Tue, Oct 17, 2017 at 12:22:03PM +0200, Michal Hocko wrote: > On Mon 16-10-17 17:19:17, changbin...@intel.com wrote: > > From: Changbin Du > > > > The current name free_{huge,transhuge}_page are paired with > > alloc_{huge,transhuge}_page functions, but the actual page free > > function is stil

Re: [PATCH v9 17/20] crypto: talitos: move to generic async completion

2017-10-17 Thread Christophe LEROY
Le 15/10/2017 à 11:20, Gilad Ben-Yossef a écrit : The talitos driver starts several async crypto ops and waits for their completions. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef Tested-by: Christophe Leroy --- drivers/crypto/talitos.c | 38 +-

Re: [PATCH 1/2] mm, thp: introduce dedicated transparent huge page allocation interfaces

2017-10-17 Thread Kirill A. Shutemov
On Mon, Oct 16, 2017 at 05:19:16PM +0800, changbin...@intel.com wrote: > @@ -501,6 +501,45 @@ void prep_transhuge_page(struct page *page) > set_compound_page_dtor(page, TRANSHUGE_PAGE_DTOR); > } > > +struct page *alloc_transhuge_page_vma(gfp_t gfp_mask, > + struct vm_area_struc

Re: [PATCH 1/2] mm, thp: introduce dedicated transparent huge page allocation interfaces

2017-10-17 Thread Michal Hocko
On Tue 17-10-17 12:20:52, Michal Hocko wrote: > [CC Kirill] now for real > On Mon 16-10-17 17:19:16, changbin...@intel.com wrote: > > From: Changbin Du > > > > This patch introduced 4 new interfaces to allocate a prepared > > transparent huge page. > > - alloc_transhuge_page_vma > > - alloc

Re: [PATCH 2/2] mm: rename page dtor functions to {compound,huge,transhuge}_page__dtor

2017-10-17 Thread Michal Hocko
On Mon 16-10-17 17:19:17, changbin...@intel.com wrote: > From: Changbin Du > > The current name free_{huge,transhuge}_page are paired with > alloc_{huge,transhuge}_page functions, but the actual page free > function is still free_page() which will indirectly call > free_{huge,transhuge}_page. So

Re: [PATCH 1/2] mm, thp: introduce dedicated transparent huge page allocation interfaces

2017-10-17 Thread Michal Hocko
[CC Kirill] On Mon 16-10-17 17:19:16, changbin...@intel.com wrote: > From: Changbin Du > > This patch introduced 4 new interfaces to allocate a prepared > transparent huge page. > - alloc_transhuge_page_vma > - alloc_transhuge_page_nodemask > - alloc_transhuge_page_node > - alloc_transhu

Re: [PATCH 2/2] mm: rename page dtor functions to {compound,huge,transhuge}_page__dtor

2017-10-17 Thread Du, Changbin
Hi Khandual, > > long freed); > > bool isolate_huge_page(struct page *page, struct list_head *list); > > void putback_active_hugepage(struct page *page); > > -void free_huge_page(struct page *page); > > +void huge_page_dtor(struct page *page); > > void

Re: [PATCH 1/2] mm, thp: introduce dedicated transparent huge page allocation interfaces

2017-10-17 Thread Du, Changbin
Hi Khandual, Thanks for your review. On Tue, Oct 17, 2017 at 01:38:07PM +0530, Anshuman Khandual wrote: > On 10/16/2017 02:49 PM, changbin...@intel.com wrote: > > From: Changbin Du > > > > This patch introduced 4 new interfaces to allocate a prepared > > transparent huge page. > > - alloc_tran

Re: [PATCH 4/4] char/snsc: Delete unnecessary braces in five functions

2017-10-17 Thread SF Markus Elfring
>> /* ...or if we want to block, then do so here */ >> -if (down_interruptible(&sd->sd_wbs)) { >> +if (down_interruptible(&sd->sd_wbs)) >> /* something went wrong with wait */ >> return -ERESTARTSYS; >> -} >>

Re: [PATCH 0/12] PM / sleep: Driver flags for system suspend/resume

2017-10-17 Thread Ulf Hansson
On 16 October 2017 at 03:12, Rafael J. Wysocki wrote: > Hi All, > > Well, this took more time than expected, as I tried to cover everything I had > in mind regarding PM flags for drivers. > > This work was triggered by attempts to fix and optimize PM in the > i2c-designware-platdev driver that end

Re: [PATCH 2/2] mm: rename page dtor functions to {compound,huge,transhuge}_page__dtor

2017-10-17 Thread Anshuman Khandual
On 10/16/2017 02:49 PM, changbin...@intel.com wrote: > From: Changbin Du > > The current name free_{huge,transhuge}_page are paired with > alloc_{huge,transhuge}_page functions, but the actual page free > function is still free_page() which will indirectly call > free_{huge,transhuge}_page. So th

Re: [PATCH 1/2] mm, thp: introduce dedicated transparent huge page allocation interfaces

2017-10-17 Thread Anshuman Khandual
On 10/16/2017 02:49 PM, changbin...@intel.com wrote: > From: Changbin Du > > This patch introduced 4 new interfaces to allocate a prepared > transparent huge page. > - alloc_transhuge_page_vma > - alloc_transhuge_page_nodemask > - alloc_transhuge_page_node > - alloc_transhuge_page > If

Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-17 Thread Greg Kroah-Hartman
On Tue, Oct 17, 2017 at 12:05:11AM +0200, Rafael J. Wysocki wrote: > On Monday, October 16, 2017 8:28:52 AM CEST Greg Kroah-Hartman wrote: > > On Mon, Oct 16, 2017 at 03:29:02AM +0200, Rafael J. Wysocki wrote: > > > struct dev_pm_info { > > > pm_message_tpower_state; > > > unsigned