Re: V4L docs and docbook

Hi Jon, On 02/17/2016 10:52 PM, Jonathan Corbet wrote: > Hey, Mauro, > > There's been a conversation going on that I keep meaning to bring you > into. In short, there's a fair amount of interest in improving our > formatted kernel documentation, and, in particular, making it easier to > write;

Re: [PATCH v2 0/2] moves samples out of Documentation directory

> >> Arnd >> >> [PATCH v2 1/2] samples: connector: from Documentation to samples >> [PATCH v2 2/2] samples: v4l: from Documentation to samples directory > > I can take them through the docs tree. > > Hans [added], are you OK with moving v4l2-pci-skeleton.c ove

Re: [PATCH] [media] Documentation: Fix V4L2_CTRL_FLAG_VOLATILE

On 07/22/2016 04:07 PM, Ricardo Ribalda Delgado wrote: > V4L2_CTRL_FLAG_VOLATILE behaviour when V4L2_CTRL_FLAG_EXECUTE_ON_WRITE > is set was not properly explained. > > Reported-by: Dimitrios Katsaros <patcherw...@gmail.com> > Credit-to: Hans Verkuil <hansv...

Re: [PATCH] doc-rst: Remove the media docbook

.@s-opensource.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> I'd like to take the opportunity to thank all those who worked so hard on this, esp. Markus and Mauro. Great job! Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-doc&quo

Re: [PATCH v4 11/12] [media] Documentation: Add HSV encodings

On 07/18/2016 02:42 PM, Ricardo Ribalda Delgado wrote: > Describe the hsv_enc field and its use. > > Signed-off-by: Ricardo Ribalda Delgado > --- > Documentation/media/uapi/v4l/pixfmt-002.rst| 12 ++- > Documentation/media/uapi/v4l/pixfmt-003.rst|

Re: [PATCH v4 10/12] [media] videodev2.h Add HSV encoding

On 07/18/2016 02:42 PM, Ricardo Ribalda Delgado wrote: > Some hardware maps the Hue between 0 and 255 instead of 0-179. Support > this format with a new field hsv_enc. > > Signed-off-by: Ricardo Ribalda Delgado > --- > include/uapi/linux/videodev2.h | 21

Re: [PATCH v3 8/9] [media] vivid: Fix YUV555 and YUV565 handling

On 07/16/2016 12:41 PM, Ricardo Ribalda Delgado wrote: > precalculate_color() had a optimization that avoided duplicated > conversion for YUV formats. This optimization did not take into > consideration YUV444, YUV555, YUV565 or limited range quantization. > > This patch keeps the optimization,

Re: [PATCH v3 4/9] [media] vivid: code refactor for color encoding

On 07/16/2016 12:41 PM, Ricardo Ribalda Delgado wrote: > Replace is_yuv with color_enc Which can be used by other > color encodings such us HSV. > > This change should ease the review of the following patches. > > Signed-off-by: Ricardo Ribalda Delgado > --- >

Re: [ANN] Media documentation converted to ReST markup language

On 07/08/2016 03:34 PM, Mauro Carvalho Chehab wrote: > As commented on the patch series I just submitted, we finished the conversion > of the Media uAPI book from DocBook to ReST. > > For now, I'm placing the new documentation, after parsed by Sphinx, at this > place: >

Re: [PATCH 00/54] Second series of ReST convert patches for media

On 07/08/2016 03:02 PM, Mauro Carvalho Chehab wrote: > That's the second series of patches related to DocBook to ReST > conversion. With this patch series, we're ready to merge it > upstream. > > There are still one thing to do: there are some new updates at > the DocBook pages on two topic

Re: [PATCH 13/15] [media] cec-core: Convert it to ReST format

On 08/19/2016 03:05 PM, Mauro Carvalho Chehab wrote: There are some things there that aren't ok for ReST format. Fix them. Signed-off-by: Mauro Carvalho Chehab OK, so I posted a similar patch for this: https://patchwork.linuxtv.org/patch/36376/ It's part of one

Re: [PATCH] [media] videodev2.h.rst.exceptions: fix warnings

and > related flags") > > Cc: Charles-Antoine Couret <charles-antoine.cou...@nexvision.fr> > Cc: Hans Verkuil <hans.verk...@cisco.com> > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Hans Verkuil <hans.verk...@cisco

Re: [PATCH v5 3/6] documentation: media: Add documentation for new RGB and YUV bus formats

in this case two pixels are transferred per bus sample), 1, 1.5 (encoded as 1_5) and 2. With that additional change you can add my: Acked-by: Hans Verkuil <hans.verk...@cisco.com> Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in

Re: [PATCH v3 3/6] documentation: media: Add documentation for new RGB and YUV bus formats

On 03/07/2017 05:42 PM, Neil Armstrong wrote: > Add documentation for added Bus Formats to describe RGB and YUS formats used > as input to the Synopsys DesignWare HDMI TX Controller. > > Signed-off-by: Neil Armstrong > --- >

Re: [PATCH v3 3/6] documentation: media: Add documentation for new RGB and YUV bus formats

On 03/17/2017 05:11 PM, Neil Armstrong wrote: > On 03/16/2017 06:01 PM, Archit Taneja wrote: >> >> >> On 3/7/2017 10:12 PM, Neil Armstrong wrote: >>> Add documentation for added Bus Formats to describe RGB and YUS formats used >> >> s/YUS/YUV > > Thanks again > >> >>> as input to the

Re: [PATCH] [media] vidioc-queryctrl.rst: fix menu/int menu references

On 04/09/2017 12:56 PM, Mauro Carvalho Chehab wrote: > The documentation incorrectly mentions MENU and INTEGER_MENU > at struct v4l2_querymenu table as if they were flags. They're > not: they're types. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Revi

Re: [PATCH 1/3] [media] platform: compile VIDEO_CODA with COMPILE_TEST

On 03/09/2017 09:08 PM, Mauro Carvalho Chehab wrote: > Currently, IMX_VDOA and VIDEO_CODA only builds on ARCH_MXC. > > That prevented me to build-test the driver, causing a bad patch > to be applied, and to see other warnings on this driver. Huh, must be the time of year. I just made a similar

Re: [PATCH] [media] coda: fix warnings when compiling with 64 bits

On 09/03/17 21:17, Mauro Carvalho Chehab wrote: > drivers/media/platform/coda/coda-common.c: In function ‘coda_alloc_aux_buf’: > ./include/linux/kern_levels.h:4:18: warning: format ‘%u’ expects argument of > type ‘unsigned int’, but argument 4 has type ‘size_t {aka long unsigned int}’ >

Re: [PATCH v7 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

On 09/28/2017 12:23 AM, Mauro Carvalho Chehab wrote: > Add a glossary of terms for V4L2, as several concepts are complex > enough to cause misunderstandings. > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/media/uapi/v4l/glossary.rst | 136 >

Re: [PATCH v7 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

On 10/10/2017 10:20 AM, Mauro Carvalho Chehab wrote: > Em Tue, 10 Oct 2017 09:47:13 +0200 > Hans Verkuil <hverk...@xs4all.nl> escreveu: > >> On 09/28/2017 12:23 AM, Mauro Carvalho Chehab wrote: >>> Add a glossary of terms for V4L2, as several concepts a

Re: [PATCH v7 7/7] media: open.rst: add a notice about subdev-API on vdev-centric

ific > controls. Just to note that there is a pull request pending from me that removes this from the cobalt driver. So once that's merged there are only two drivers that do this. Anyway: Acked-by: Hans Verkuil <hans.verk...@cisco.com> Regards, Hans > > Signed-off-by: Ma

Re: [PATCH v7 6/7] media: videodev2: add a flag for MC-centric devices

. For such devices, the > sub-devices' configuration > can be controlled via the :ref:`sub-device API `, which creates one > device node per sub-device. > > +.. attention:: > + > + Devices that require **MC-centric** media hardware control should should -> shall After t

Re: [PATCH v8 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

More (mostly) small stuff: On 10/10/2017 01:45 PM, Mauro Carvalho Chehab wrote: > Add a glossary of terms for V4L2, as several concepts are complex > enough to cause misunderstandings. > > Signed-off-by: Mauro Carvalho Chehab > --- >

Re: [PATCH v8 4/7] media: open.rst: document vdevnode-centric and mc-centric types

More word-smithing... On 10/10/2017 01:45 PM, Mauro Carvalho Chehab wrote: > When we added support for omap3, back in 2010, we added a new > type of V4L2 devices that aren't fully controlled via the V4L2 > device node. > > Yet, we have never clearly documented in the V4L2 specification > the

Re: [PATCH v2 02/17] media: v4l2-common: get rid of v4l2_routing dead struct

On 09/27/17 23:46, Mauro Carvalho Chehab wrote: > This struct is not used anymore. Get rid of it and update > the documentation about what should still be converted. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Hans Verkuil <h

Re: [PATCH v2 04/17] media: v4l2-common.h: document ancillary functions

On 09/27/17 23:46, Mauro Carvalho Chehab wrote: > There are several ancillary functions that aren't documented. s/ancillary/helper/g > > Document them. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/v4l2-core/v4l2-common.c | 14 - >

Re: [PATCH v2 07/17] media: v4l2-event.rst: improve events description

Nice! I have some small fixes and one little rewrite for the replace/merge documentation: On 09/27/17 23:46, Mauro Carvalho Chehab wrote: > Both v4l2-event.rst and v4l2-event.h have an overview of > events, but there are some inconsistencies there: > > - at v4l2-event, the event's ringbuffer is

Re: [PATCH v2 09/17] media: cec-pin.h: convert comments for cec_pin_state into kernel-doc

On 09/27/17 23:46, Mauro Carvalho Chehab wrote: > This enum is already documented, but it is not using a kernel-doc > format. Convert its format, in order to produce documentation. > > Signed-off-by: Mauro Carvalho Chehab No, this does not belong in the kernel API doc.

Re: [PATCH v2 03/17] media: v4l2-common: get rid of struct v4l2_discrete_probe

num_sizes; > -}; > - > -const struct v4l2_frmsize_discrete *v4l2_find_nearest_format( > - const struct v4l2_discrete_probe *probe, > - s32 width, s32 height); > +const struct v4l2_frmsize_discrete > +*v4l2_fi

Re: [PATCH v2 06/17] media: v4l2-dv-timings.h: convert comment into kernel-doc markup

On 09/27/17 23:46, Mauro Carvalho Chehab wrote: > The can_reduce_fps() is already documented, but it is not > using the kernel-doc markup. Convert it, in order to generate > documentation from it. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> A

Re: [PATCH v2 08/17] media: v4l2-ioctl.h: convert debug macros into enum and document

On 09/27/17 23:46, Mauro Carvalho Chehab wrote: > Currently, there's no way to document #define foo > with kernel-doc. So, convert it to an enum, and document. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Hans Verkuil <hans.verk.

Re: [PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

On 08/25/2017 12:06 PM, Mauro Carvalho Chehab wrote: > Em Fri, 25 Aug 2017 11:44:27 +0200 > Hans Verkuil <hansv...@cisco.com> escreveu: > >> On 08/25/2017 11:40 AM, Mauro Carvalho Chehab wrote: >>> From: Mauro Carvalho Chehab <mche...@osg.samsung.com> >>

Re: [PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

On 08/25/2017 11:40 AM, Mauro Carvalho Chehab wrote: > From: Mauro Carvalho Chehab > > As both vdev-centric and mc-centric devices may implement the > same APIs, we need a flag to allow userspace to distinguish > between them. > > Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

On 08/25/2017 12:35 PM, Mauro Carvalho Chehab wrote: > Em Fri, 25 Aug 2017 12:13:53 +0200 > Hans Verkuil <hansv...@cisco.com> escreveu: > >> On 08/25/2017 12:06 PM, Mauro Carvalho Chehab wrote: >>> Em Fri, 25 Aug 2017 11:44:27 +0200 >>> Han

Re: [PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

On 25/08/17 12:50, Mauro Carvalho Chehab wrote: > Em Fri, 25 Aug 2017 12:42:51 +0200 > Hans Verkuil <hansv...@cisco.com> escreveu: > >> On 08/25/2017 12:35 PM, Mauro Carvalho Chehab wrote: >>> Em Fri, 25 Aug 2017 12:13:53 +0200 >>> Hans Verkuil <hansv...

Re: [PATCH RFC v2] media: open.rst: document devnode-centric and mc-centric types

On 24/08/17 14:07, Mauro Carvalho Chehab wrote: > From: "mche...@s-opensource.com" > > When we added support for omap3, back in 2010, we added a new > type of V4L2 devices that aren't fully controlled via the V4L2 > device node. Yet, we never made it clear, at the V4L2

Re: [PATCH 1/3] media: open.rst: document devnode-centric and mc-centric types

On 25/08/17 11:40, Mauro Carvalho Chehab wrote: > From: "mche...@s-opensource.com" > > When we added support for omap3, back in 2010, we added a new > type of V4L2 devices that aren't fully controlled via the V4L2 > device node. Yet, we never made it clear, at the V4L2

Re: [PATCH v4 5/7] media: open.rst: Adjust some terms to match the glossary

On 26/08/17 13:53, Mauro Carvalho Chehab wrote: > As we now have a glossary, some terms used on open.rst > require adjustments. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> Regards, Hans

Re: [PATCH v4 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

This is a partial review. I think I need to review the other patches first before continuing this review. But it doesn't hurt to post this now. On 26/08/17 13:53, Mauro Carvalho Chehab wrote: > Add a glossary of terms for V4L2, as several concepts are complex > enough to cause misunderstandings.

Re: [PATCH v4 4/7] media: open.rst: document devnode-centric and mc-centric types

On 26/08/17 13:53, Mauro Carvalho Chehab wrote: > When we added support for omap3, back in 2010, we added a new > type of V4L2 devices that aren't fully controlled via the V4L2 > device node. > > Yet, we have never clearly documented in the V4L2 specification > the differences between the two

Re: [PATCH v4 3/7] media: open.rst: remove the minor number range

In any case, > this is not relevant, as udev will take care of it. > > So, remove this useless misinformation. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> > --- > Documentation/media/uapi/v4l/open.rst

Re: [PATCH v4 6/7] media: videodev2: add a flag for MC-centric devices

On 26/08/17 13:53, Mauro Carvalho Chehab wrote: > As both vdev-centric and MC-centric devices may implement the > same APIs, we need a flag to allow userspace to distinguish > between them. > > Signed-off-by: Mauro Carvalho Chehab > --- >

Re: [PATCH v4 7/7] media: open.rst: add a notice about subdev-API on vdev-centric

On 26/08/17 13:53, Mauro Carvalho Chehab wrote: > The documentation doesn't mention if vdev-centric hardware > control would have subdev API or not. > > Add a notice about that, reflecting the current status, where > three drivers use it, in order to support some subdev-specific > controls. I

Re: [PATCH v4 7/7] media: open.rst: add a notice about subdev-API on vdev-centric

On 28/08/17 12:30, Mauro Carvalho Chehab wrote: > Em Mon, 28 Aug 2017 12:05:06 +0200 > Hans Verkuil <hverk...@xs4all.nl> escreveu: > >> On 26/08/17 13:53, Mauro Carvalho Chehab wrote: >>> The documentation doesn't mention if vdev-centric hardware >

Re: [PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

> Em Fri, 25 Aug 2017 12:56:30 +0200 >>> Hans Verkuil <hverk...@xs4all.nl> escreveu: >>> >>>> On 25/08/17 12:50, Mauro Carvalho Chehab wrote: >>>>> Em Fri, 25 Aug 2017 12:42:51 +0200 >>>>> Hans Verkuil <hansv...@cisco.com>

Re: [PATCH v2 1/3] media: open.rst: better document device node naming

by-id > + │ └── usb-OmniVision._USB_Camera-B4.04.27.1-video-index0 -> > ../../video0 > + └── by-path > + └── pci-:00:14.0-usb-0:2:1.0-video-index0 -> ../../video0 > + > > Many drivers support "video_nr", "radio_nr" or "vbi

Re: [PATCH 1/3] media: open.rst: document devnode-centric and mc-centric types

On 25/08/17 15:11, Laurent Pinchart wrote: > Hi Mauro, > > Thank you for the patch. > > On Friday, 25 August 2017 12:40:05 EEST Mauro Carvalho Chehab wrote: >> From: "mche...@s-opensource.com" >> >> When we added support for omap3, back in 2010, we added a new >> type

Re: [PATCH v4 7/7] media: open.rst: add a notice about subdev-API on vdev-centric

On 29/08/17 10:31, Ramesh Shanmugasundaram wrote: > Hi Hans, > >> On 28/08/17 12:30, Mauro Carvalho Chehab wrote: >>> Em Mon, 28 Aug 2017 12:05:06 +0200 >>> Hans Verkuil <hverk...@xs4all.nl> escreveu: >>> >>>> On 26/08/17 13:53, Mauro Carva

Re: [PATCH 23/24] media: v4l2-tpg*.h: move headers to include/media/tpg and merge them

, merge them. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> Thanks! Hans > --- > drivers/media/common/v4l2-tpg/v4l2-tpg-colors.c | 2 +- > drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 2

Re: [PATCH 07/24] media: get rid of i2c-addr.h

bttv driver or at tvtuner. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> Huh, I thought this header was nuked a long time ago... Regards, Hans > --- > drivers/media/i2c/tda7432.c |

Re: [PATCH 04/24] media: v4l2-mediabus: convert flags to enums and document them

s > are obsolete and in the process of cleanings, I opted to just > keep the behavior, using an unsigned int inside those two > drivers. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> Nice cleanup. Regard

Re: [PATCH 09/24] media: v4l2-dev: document video_device flags

On 09/10/17 12:19, Mauro Carvalho Chehab wrote: > Convert #defines to enums and add kernel-doc markups for V4L2 > video_device flags. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> Regards,

Re: [PATCH 06/24] media: i2c-addr.h: get rid of now unused defines

On 09/10/17 12:19, Mauro Carvalho Chehab wrote: > Some of the previously used I2C addresses there aren't used > anymore. So, get rid of them. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com>

Re: [PATCH] media: v4l2-tpg: use __u16 instead of int for struct tpg_rbg_color16

On 09/10/17 12:23, Mauro Carvalho Chehab wrote: > Despite the struct says "color16", it was actually using 32 bits > for each color. Fix it. > > Suggested-by: Hans Verkuil <hverk...@xs4all.nl> > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com&g

Re: [PATCH 24/24] media: v4l2-tpg.h: rename color structs

at public header! > > So rename them to: > color -> tpg_rbg_color8 > color16 -> tpg_rbg_color16 > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> Thanks! Hans > --- &

Re: [PATCH 02/11] media: videobuf2: Add new uAPI for DVB streaming I/O

Hi Mauro, Thanks for this patch series, nice to see this moving forward. Some comments below (note the wrong queue_setup code in particular since that relates to my comment about the '[PATCH v3] media: videobuf2-core: don't go out of the buffer range' patch). On 12/21/2017 05:18 PM, Mauro

Re: [PATCH 02/11] media: videobuf2: Add new uAPI for DVB streaming I/O

A quick follow-up: On 01/08/2018 02:54 PM, Hans Verkuil wrote: >> +/* >> + * Videobuf operations >> + */ >> +int dvb_vb2_init(struct dvb_vb2_ctx *ctx, const char *name, int nonblocking) >> +{ >> +struct vb2_queue *q = >vb_q; >> +int r