[PATCH v4 00/10] PECI device driver introduction

xed OF table for hwmon to make it indicate as a PECI client of Intel CPU target. * Added a maintainer of PECI subsystem into MAINTAINERS document. Jae Hyun Yoo (11): dt-bindings: Add a document of PECI subsystem Documentation: ioctl: Add ioctl numbers for PECI subsystem drivers/peci: Add supp

[v4 02/11] Documentation: ioctl: Add ioctl numbers for PECI subsystem

This commit updates ioctl-number.txt to reflect ioctl numbers used by the PECI subsystem. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> Cc: James Feist <james.fe...@linux.intel.com> Cc: Jason M Biils <jason.m.bi...@linux.intel.com> Cc: Vernon Mauery <vernon.m

[v4 08/11] Documentation: hwmon: Add documents for PECI hwmon client drivers

This commit adds hwmon documents for PECI cputemp and dimmtemp drivers. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> Reviewed-by: Haiyue Wang <haiyue.w...@linux.intel.com> Reviewed-by: James Feist <james.fe...@linux.intel.com> Reviewed-by: Vernon

[PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

From: Jae Hyun Yoo <jae.hyun@intel.com> Hello, This patch set provides support for PECI of AST2400/2500 which can give us PECI functionalities such as temperature monitoring, platform manageability, processor diagnostics and failure analysis. Also provides generic peci.h and peci_i

[PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers

This commit adds driver implementation for Aspeed PECI. Also adds generic peci.h and peci_ioctl.h files to provide compatibility to peci drivers that can be implemented later e.g. Nuvoton's BMC SoC family. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> --- drivers/misc/K

[PATCH linux dev-4.10 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon

This commit adds driver implementation for a generic PECI hwmon. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> --- drivers/hwmon/Kconfig | 6 + drivers/hwmon/Makefile | 1 + drivers/hwmon/peci-hwmon.c | 953 + 3 files c

[PATCH linux dev-4.10 1/6] Documentation: dt-bindings: Add Aspeed PECI

This commit adds a dt-bindings document for Aspeed PECI. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> --- .../devicetree/bindings/misc/aspeed-peci.txt | 55 ++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/binding

[PATCH linux dev-4.10 5/6] Documentation: hwmon: Add a generic PECI hwmon

From: Jae Hyun Yoo <jae.hyun@intel.com> This commit add a document for a generic PECI hwmon driver. Signed-off-by: Jae Hyun Yoo <jae.hyun@intel.com> --- Documentation/hwmon/peci-hwmon | 74 ++ 1 file changed, 74 insertions(+) create

[PATCH linux dev-4.10 4/6] Documentation: dt-bindings: Add a generic PECI hwmon

This commit add a dt-bindings document for a generic PECI hwmon driver. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> --- .../devicetree/bindings/hwmon/peci-hwmon.txt | 33 ++ 1 file changed, 33 insertions(+) create mode 100644 Documentation/devi

[PATCH linux dev-4.10 2/6] ARM: dts: aspeed: peci: Add Aspeed PECI

This commit adds Aspeed PECI node into aspeed-g4 and aspeed-g5. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> --- arch/arm/boot/dts/aspeed-g4.dtsi | 14 ++ arch/arm/boot/dts/aspeed-g5.dtsi | 14 ++ 2 files changed, 28 insertions(+) diff --git a/arch/ar

Re: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers

On 1/10/2018 2:18 AM, Greg KH wrote: On Tue, Jan 09, 2018 at 02:31:23PM -0800, Jae Hyun Yoo wrote: This commit adds driver implementation for Aspeed PECI. Also adds generic peci.h and peci_ioctl.h files to provide compatibility to peci drivers that can be implemented later e.g. Nuvoton's BMC

Re: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers

On 1/10/2018 2:20 AM, Greg KH wrote: On Tue, Jan 09, 2018 at 02:31:23PM -0800, Jae Hyun Yoo wrote: +#pragma pack(push, 1) +struct peci_xfer_msg { + unsigned char client_addr; + unsigned char tx_len; + unsigned char rx_len; + unsigned char tx_buf[MAX_BUFFER_SIZE

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

On 1/10/2018 2:17 AM, Greg KH wrote: On Tue, Jan 09, 2018 at 02:31:20PM -0800, Jae Hyun Yoo wrote: From: Jae Hyun Yoo <jae.hyun@intel.com> Hello, This patch set provides support for PECI of AST2400/2500 which can give us PECI functionalities such as temperature monitoring, pl

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

On 1/10/2018 11:17 AM, Greg KH wrote: On Wed, Jan 10, 2018 at 11:14:34AM -0800, Jae Hyun Yoo wrote: On 1/10/2018 2:17 AM, Greg KH wrote: On Tue, Jan 09, 2018 at 02:31:20PM -0800, Jae Hyun Yoo wrote: From: Jae Hyun Yoo <jae.hyun@intel.com> Hello, This patch set provides support fo

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

On 1/10/2018 12:27 PM, Greg KH wrote: On Wed, Jan 10, 2018 at 11:30:05AM -0800, Jae Hyun Yoo wrote: On 1/10/2018 11:17 AM, Greg KH wrote: On Wed, Jan 10, 2018 at 11:14:34AM -0800, Jae Hyun Yoo wrote: On 1/10/2018 2:17 AM, Greg KH wrote: On Tue, Jan 09, 2018 at 02:31:20PM -0800, Jae Hyun Yoo

Re: [PATCH linux dev-4.10 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon

On 1/10/2018 4:29 AM, Arnd Bergmann wrote: On Tue, Jan 9, 2018 at 11:31 PM, Jae Hyun Yoo <jae.hyun@linux.intel.com> wrote: This commit adds driver implementation for a generic PECI hwmon. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> +static int xfer_peci_msg(i

Re: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers

On 1/10/2018 3:55 AM, Arnd Bergmann wrote: On Tue, Jan 9, 2018 at 11:31 PM, Jae Hyun Yoo <jae.hyun@linux.intel.com> wrote: This commit adds driver implementation for Aspeed PECI. Also adds generic peci.h and peci_ioctl.h files to provide compatibility to peci drivers that can be imple

Re: [PATCH linux dev-4.10 4/6] Documentation: dt-bindings: Add a generic PECI hwmon

On 1/10/2018 4:20 AM, Arnd Bergmann wrote: On Tue, Jan 9, 2018 at 11:31 PM, Jae Hyun Yoo <jae.hyun@linux.intel.com> wrote: This commit add a dt-bindings document for a generic PECI hwmon driver. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> --- .../devicetree/bi

Re: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers

On 1/11/2018 1:06 AM, Benjamin Herrenschmidt wrote: On Tue, 2018-01-09 at 14:31 -0800, Jae Hyun Yoo wrote: +struct peci_rd_ia_msr_msg { + unsigned char target; + unsigned char thread_id; + unsigned short address; + unsigned long value; +}; Those types are representing

Re: [linux, dev-4.10, 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon

On 1/11/2018 1:40 PM, Guenter Roeck wrote: On Thu, Jan 11, 2018 at 11:47:01AM -0800, Jae Hyun Yoo wrote: On 1/10/2018 1:47 PM, Guenter Roeck wrote: On Tue, Jan 09, 2018 at 02:31:26PM -0800, Jae Hyun Yoo wrote: This commit adds driver implementation for a generic PECI hwmon. Signed-off

Re: [linux, dev-4.10, 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon

On 1/11/2018 2:18 PM, Andrew Lunn wrote: +static const struct of_device_id peci_of_table[] = { + { .compatible = "peci-hwmon", }, This does not look like a reference to some piece of hardware. This driver provides generic PECI hwmon function to which controller has PECI HW such as

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

On 1/11/2018 12:56 AM, Benjamin Herrenschmidt wrote: On Thu, 2018-01-11 at 08:30 +0100, Greg KH wrote: 4.13? Why that kernel? It too is obsolete and insecure and unsupported. Haha, it's n-1. come on :-) What keeps you all from just always tracking the latest tree from Linus? What is in

Re: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers

On 1/11/2018 1:02 AM, Benjamin Herrenschmidt wrote: On Wed, 2018-01-10 at 11:18 +0100, Greg KH wrote: On Tue, Jan 09, 2018 at 02:31:23PM -0800, Jae Hyun Yoo wrote: This commit adds driver implementation for Aspeed PECI. Also adds generic peci.h and peci_ioctl.h files to provide compatibility

Re: [linux, dev-4.10, 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon

On 1/10/2018 1:47 PM, Guenter Roeck wrote: On Tue, Jan 09, 2018 at 02:31:26PM -0800, Jae Hyun Yoo wrote: This commit adds driver implementation for a generic PECI hwmon. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> --- drivers/hwmon/Kconfig | 6 + drivers/hwmon/Ma

Re: [linux, dev-4.10, 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon

On 1/11/2018 3:53 PM, Andrew Lunn wrote: On Thu, Jan 11, 2018 at 03:14:37PM -0800, Jae Hyun Yoo wrote: On 1/11/2018 2:18 PM, Andrew Lunn wrote: +static const struct of_device_id peci_of_table[] = { + { .compatible = "peci-hwmon", }, This does not look like a reference to

Re: [PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic PECI hwmon client driver

On 2/21/2018 1:48 PM, Guenter Roeck wrote: On Wed, Feb 21, 2018 at 01:24:48PM -0800, Jae Hyun Yoo wrote: Hi Guenter, Thanks for sharing your time to review this code. Please check my answers inline. On 2/21/2018 10:26 AM, Guenter Roeck wrote: On Wed, Feb 21, 2018 at 08:16:05AM -0800, Jae

Re: [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core

On 2/21/2018 1:51 PM, Andrew Lunn wrote: Is there a real need to do transfers in atomic context, or with interrupts disabled? Actually, no. Generally, this function will be called in sleep-able context so this code is for an exceptional case handling. I'll rewrite this code like below:

Re: [PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic PECI hwmon client driver

On 2/21/2018 4:37 PM, Andrew Lunn wrote: But even with this change, it still needs to use delayed creation because BMC side kernel doesn't know how many DIMMs are populated on a remote server before the remote server completes its memory training and testing in BIOS, but it needs to check the

Re: [RFC PATCH] drivers/peci: peci_match_id() can be static

On 2/21/2018 11:01 PM, kbuild test robot wrote: Fixes: 99f5d2b99ecd ("drivers/peci: Add support for PECI bus driver core") Signed-off-by: Fengguang Wu --- peci-core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/peci/peci-core.c

Re: [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core

On 2/21/2018 10:54 PM, Greg KH wrote: On Wed, Feb 21, 2018 at 12:42:30PM -0800, Jae Hyun Yoo wrote: On 2/21/2018 9:58 AM, Greg KH wrote: On Wed, Feb 21, 2018 at 08:15:59AM -0800, Jae Hyun Yoo wrote: This commit adds driver implementation for PECI bus into linux driver framework. Signed-off

Re: [PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic PECI hwmon client driver

On 2/23/2018 4:00 PM, Miguel Ojeda wrote: On Thu, Feb 22, 2018 at 2:29 AM, Jae Hyun Yoo <jae.hyun@linux.intel.com> wrote: On 2/21/2018 4:37 PM, Andrew Lunn wrote: But even with this change, it still needs to use delayed creation because BMC side kernel doesn't know how many

[PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core

This commit adds driver implementation for PECI bus into linux driver framework. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> --- drivers/Kconfig |2 + drivers/Makefile|1 + drivers/peci/Kconfig| 20 + drivers/peci/Ma

[PATCH v2 4/8] [PATCH 4/8] drivers/peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

This commit adds PECI adapter driver implementation for Aspeed AST24xx/AST25xx. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> --- drivers/peci/Kconfig | 19 ++ drivers/peci/Makefile | 3 + drivers/peci/peci-aspeed.c

[PATCH v2 5/8] [PATCH [5/8] Documentation: dt-bindings: Add a document for PECI hwmon client driver

This commit adds a dt-bindings document for a generic PECI hwmon client driver. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> --- .../devicetree/bindings/hwmon/peci-hwmon.txt | 27 ++ 1 file changed, 27 insertions(+) create mode 100644 Documen

[PATCH v2 0/8] PECI device driver introduction

ded a function into hwmon driver to convert 10.6 to millidegree. - Dropped non-standard attributes in hwmon driver. - Fixed OF table for hwmon to make it indicate as a PECI client of Intel CPU target. - Added a maintainer of PECI subsystem into MAINTAINERS document. Thanks, -Jae Jae Hyun Yoo

[PATCH v2 8/8] [PATCH 8/8] Add a maintainer for the PECI subsystem

This commit adds a maintainer information for the PECI subsystem. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 93a12af4f180..f9c302cbb76b 100644 --- a/MAINTAINERS

[PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic PECI hwmon client driver

This commit adds a generic PECI hwmon client driver implementation. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> --- drivers/hwmon/Kconfig | 10 + drivers/hwmon/Makefile | 1 + drivers/hwmon/peci-hwmon.c | 928 + 3

[PATCH v2 3/8] [PATCH 3/8] ARM: dts: aspeed: peci: Add PECI node

This commit adds PECI bus/adapter node of AST24xx/AST25xx into aspeed-g4 and aspeed-g5. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> --- arch/arm/boot/dts/aspeed-g4.dtsi | 25 + arch/arm/boot/dts/aspeed-g5.dtsi | 25 + 2 files c

[PATCH v2 2/8] [PATCH 2/8] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

This commit adds a dt-bindings document of PECI adapter driver for Aspeed AST24xx/25xx SoCs. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> --- .../devicetree/bindings/peci/peci-aspeed.txt | 73 ++ 1 file changed, 73 insertions(+) create mode

[PATCH v2 6/8] [PATCH 6/8] Documentation: hwmon: Add a document for PECI hwmon client driver

This commit adds a hwmon document for a generic PECI hwmon client driver. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> --- Documentation/hwmon/peci-hwmon | 73 ++ 1 file changed, 73 insertions(+) create mode 100644 Documentation/hwmo

Re: [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core

Hi Andrew, Thanks for sharing your time to review it. Please check my answers inline. On 2/21/2018 9:04 AM, Andrew Lunn wrote: +static int peci_locked_xfer(struct peci_adapter *adapter, + struct peci_xfer_msg *msg, + bool do_retry, +

Re: [PATCH v2 2/8] [PATCH 2/8] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

On 2/21/2018 9:13 AM, Andrew Lunn wrote: On Wed, Feb 21, 2018 at 08:16:00AM -0800, Jae Hyun Yoo wrote: This commit adds a dt-bindings document of PECI adapter driver for Aspeed AST24xx/25xx SoCs. Hi Jae It would be good to separate this into two. One binding document for a generic adaptor

Re: [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core

On 2/21/2018 9:58 AM, Greg KH wrote: On Wed, Feb 21, 2018 at 08:15:59AM -0800, Jae Hyun Yoo wrote: This commit adds driver implementation for PECI bus into linux driver framework. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> --- Why is there no other Intel developers w

Re: [PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic PECI hwmon client driver

Hi Guenter, Thanks for sharing your time to review this code. Please check my answers inline. On 2/21/2018 10:26 AM, Guenter Roeck wrote: On Wed, Feb 21, 2018 at 08:16:05AM -0800, Jae Hyun Yoo wrote: This commit adds a generic PECI hwmon client driver implementation. Signed-off-by: Jae

Re: [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core

Hi Julia, Thanks for sharing your time on reviewing it. Please see my inline answers. Jae On 3/6/2018 7:19 PM, Julia Cartwright wrote: On Wed, Feb 21, 2018 at 08:15:59AM -0800, Jae Hyun Yoo wrote: This commit adds driver implementation for PECI bus into linux driver framework. Signed-off

Re: [PATCH v2 2/8] [PATCH 2/8] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

Hi Pavel, Thanks for sharing your time on reviewing it. Please see my answers inline. -Jae On 3/6/2018 4:40 AM, Pavel Machek wrote: Hi! Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> --- .../devicetree/bindings/peci/peci-aspeed.txt | 73 ++

Re: [PATCH v2 0/8] PECI device driver introduction

Hi Pavel, Please see my answer inline. On 3/6/2018 4:40 AM, Pavel Machek wrote: Hi! Introduction of the Platform Environment Control Interface (PECI) bus device driver. PECI is a one-wire bus interface that provides a communication channel between Intel processor and chipset components to

Re: [PATCH v2 6/8] [PATCH 6/8] Documentation: hwmon: Add a document for PECI hwmon client driver

Hi Randy, On 3/6/2018 12:28 PM, Randy Dunlap wrote: Hi, On 02/21/2018 08:16 AM, Jae Hyun Yoo wrote: +temp_labelProvides DDR DIMM temperature if this label indicates + 'DIMM #'. +temp_inputProvides current temperature of the DDR DIMM. + +Note

Re: [PATCH v2 2/8] [PATCH 2/8] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

Hi Milton, Thanks for sharing your time to review this patch. Please see my answer inline. Jae On 3/9/2018 3:41 PM, Milton Miller II wrote: About 03/07/2018 04:12PM in some time zone, Pavel Machek wrote: Subject: Re: [PATCH v2 2/8] [PATCH 2/8] Documentations: dt-bindings: Add a document

[PATCH v3 01/10] Documentations: dt-bindings: Add documents of generic PECI bus, adapter and client drivers

This commit adds documents of generic PECI bus, adapter and client drivers. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> Reviewed-by: Haiyue Wang <haiyue.w...@linux.intel.com> Reviewed-by: James Feist <james.fe...@linux.intel.com> Reviewed-by: Vernon

[PATCH v3 00/10] PECI device driver introduction

xed OF table for hwmon to make it indicate as a PECI client of Intel CPU target. * Added a maintainer of PECI subsystem into MAINTAINERS document. Fengguang Wu (1): drivers/peci: Add support for PECI bus driver core Jae Hyun Yoo (10): Documentations: dt-bindings: Add documents of generic PECI

[PATCH v3 09/10] drivers/hwmon: Add PECI hwmon client drivers

This commit adds PECI cputemp and dimmtemp hwmon drivers. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> Reviewed-by: Haiyue Wang <haiyue.w...@linux.intel.com> Reviewed-by: James Feist <james.fe...@linux.intel.com> Reviewed-by: Vernon Mauery <vernon.mau...@linu

[PATCH v3 10/10] Add a maintainer for the PECI subsystem

This commit adds a maintainer information for the PECI subsystem. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> Reviewed-by: Haiyue Wang <haiyue.w...@linux.intel.com> Reviewed-by: James Feist <james.fe...@linux.intel.com> Reviewed-by: Vernon Mauery <vernon.mau..

[PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers

This commit adds dt-bindings documents for PECI cputemp and dimmtemp client drivers. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> Reviewed-by: Haiyue Wang <haiyue.w...@linux.intel.com> Reviewed-by: James Feist <james.fe...@linux.intel.com> Reviewed-by: Vernon

[PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core

This commit adds driver implementation for PECI bus core into linux driver framework. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Reviewed-by: Haiyue Wang <haiyue.w...@linux.intel.com> Reviewed-by: Jam

[PATCH v3 02/10] Documentations: ioctl: Add ioctl numbers for PECI subsystem

This commit Updates ioctl-number.txt to reflect ioctl numbers being used by the PECI subsystem. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> Cc: Alan Cox <a...@linux.intel.com> Cc: Andrew Jeffery <and...@aj.id.au> Cc: Andrew Lunn <and...@lunn.ch> Cc: Andy Sh

[PATCH v3 05/10] ARM: dts: aspeed: peci: Add PECI node

This commit adds PECI bus/adapter node of AST24xx/AST25xx into aspeed-g4 and aspeed-g5. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> Reviewed-by: Haiyue Wang <haiyue.w...@linux.intel.com> Reviewed-by: James Feist <james.fe...@linux.intel.com> Reviewed-by: Vernon

[PATCH v3 06/10] drivers/peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

This commit adds PECI adapter driver implementation for Aspeed AST24xx/AST25xx. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> Reviewed-by: Haiyue Wang <haiyue.w...@linux.intel.com> Reviewed-by: James Feist <james.fe...@linux.intel.com> Reviewed-by: Vernon

[PATCH v3 08/10] Documentation: hwmon: Add documents for PECI hwmon client drivers

This commit adds hwmon documents for PECI cputemp and dimmtemp drivers. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> Reviewed-by: Haiyue Wang <haiyue.w...@linux.intel.com> Reviewed-by: James Feist <james.fe...@linux.intel.com> Reviewed-by: Vernon

[PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

This commit adds a dt-bindings document of PECI adapter driver for Aspeed AST24xx/25xx SoCs. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> Reviewed-by: Haiyue Wang <haiyue.w...@linux.intel.com> Reviewed-by: James Feist <james.fe...@linux.intel.com> Reviewed

Re: [PATCH v3 09/10] drivers/hwmon: Add PECI hwmon client drivers

Hi Guenter, Thanks a lot for sharing your time. Please see my inline answers. On 4/10/2018 3:28 PM, Guenter Roeck wrote: On Tue, Apr 10, 2018 at 11:32:11AM -0700, Jae Hyun Yoo wrote: This commit adds PECI cputemp and dimmtemp hwmon drivers. Signed-off-by: Jae Hyun Yoo <jae.h

Re: [PATCH v3 09/10] drivers/hwmon: Add PECI hwmon client drivers

On 4/11/2018 8:40 PM, Guenter Roeck wrote: On 04/11/2018 07:51 PM, Jae Hyun Yoo wrote: On 4/11/2018 5:34 PM, Guenter Roeck wrote: On 04/11/2018 02:59 PM, Jae Hyun Yoo wrote: Hi Guenter, Thanks a lot for sharing your time. Please see my inline answers. On 4/10/2018 3:28 PM, Guenter Roeck

Re: [PATCH v3 09/10] drivers/hwmon: Add PECI hwmon client drivers

On 4/12/2018 10:37 AM, Guenter Roeck wrote: On Thu, Apr 12, 2018 at 10:09:51AM -0700, Jae Hyun Yoo wrote: [ ... ] +static int find_core_index(struct peci_cputemp *priv, int channel) +{ +    int core_channel = channel - DEFAULT_CHANNEL_NUMS; +    int idx, found = 0; + +    for (idx = 0; idx

Re: [PATCH v3 06/10] drivers/peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

Hello Joel, Thanks for sharing your time. Please see my answers inline. On 4/11/2018 4:51 AM, Joel Stanley wrote: Hello Jae, On 11 April 2018 at 04:02, Jae Hyun Yoo <jae.hyun@linux.intel.com> wrote: This commit adds PECI adapter driver implementation for Aspeed AST24xx/A

Re: [PATCH v3 01/10] Documentations: dt-bindings: Add documents of generic PECI bus, adapter and client drivers

Hi Joel, On 4/11/2018 4:52 AM, Joel Stanley wrote: Hi Jae, On 11 April 2018 at 04:02, Jae Hyun Yoo <jae.hyun@linux.intel.com> wrote: This commit adds documents of generic PECI bus, adapter and client drivers. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> Reviewe

Re: [PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

Hi Joel, On 4/11/2018 4:52 AM, Joel Stanley wrote: On 11 April 2018 at 04:02, Jae Hyun Yoo <jae.hyun@linux.intel.com> wrote: This commit adds a dt-bindings document of PECI adapter driver for Aspeed We try to capitalise ASPEED. Got it. Will capitalize all Aspeed words. AST24x

Re: [PATCH v3 05/10] ARM: dts: aspeed: peci: Add PECI node

On 4/11/2018 4:52 AM, Joel Stanley wrote: On 11 April 2018 at 04:02, Jae Hyun Yoo <jae.hyun@linux.intel.com> wrote: This commit adds PECI bus/adapter node of AST24xx/AST25xx into aspeed-g4 and aspeed-g5. The patches to the device trees get merged by the ASPEED maintainer (me). On

Re: [PATCH v3 09/10] drivers/hwmon: Add PECI hwmon client drivers

On 4/11/2018 5:34 PM, Guenter Roeck wrote: On 04/11/2018 02:59 PM, Jae Hyun Yoo wrote: Hi Guenter, Thanks a lot for sharing your time. Please see my inline answers. On 4/10/2018 3:28 PM, Guenter Roeck wrote: On Tue, Apr 10, 2018 at 11:32:11AM -0700, Jae Hyun Yoo wrote: This commit adds PECI

Re: [PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

On 4/18/2018 6:59 AM, Rob Herring wrote: On Tue, Apr 17, 2018 at 5:06 PM, Jae Hyun Yoo <jae.hyun@linux.intel.com> wrote: On 4/17/2018 11:16 AM, Jae Hyun Yoo wrote: On 4/17/2018 6:16 AM, Rob Herring wrote: On Mon, Apr 16, 2018 at 6:12 PM, Jae Hyun Yoo <jae.hyun@linux.intel.c

Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers

On 4/18/2018 7:32 AM, Rob Herring wrote: On Tue, Apr 17, 2018 at 3:40 PM, Jae Hyun Yoo <jae.hyun@linux.intel.com> wrote: On 4/16/2018 4:51 PM, Jae Hyun Yoo wrote: On 4/16/2018 4:22 PM, Jae Hyun Yoo wrote: On 4/16/2018 11:14 AM, Rob Herring wrote: On Tue, Apr 10, 2018 at 11:3

Re: [PATCH v3 01/10] Documentations: dt-bindings: Add documents of generic PECI bus, adapter and client drivers

Hi Rob, Thanks for sharing your time. Please see my answers inline. On 4/16/2018 10:59 AM, Rob Herring wrote: On Tue, Apr 10, 2018 at 11:32:03AM -0700, Jae Hyun Yoo wrote: This commit adds documents of generic PECI bus, adapter and client drivers. "dt-bindings: ..." for the subj

Re: [PATCH v3 09/10] drivers/hwmon: Add PECI hwmon client drivers

Hi Andy, Thanks a lot for your review. Please check my inline answers. On 4/24/2018 8:56 AM, Andy Shevchenko wrote: On Tue, 2018-04-10 at 11:32 -0700, Jae Hyun Yoo wrote: drivers/hwmon/peci-cputemp.c | 783 ++ drivers/hwmon/peci-dimmtemp.c | 432

Re: [PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core

On 4/24/2018 9:01 AM, Andy Shevchenko wrote: On Tue, 2018-04-10 at 11:32 -0700, Jae Hyun Yoo wrote: This commit adds driver implementation for PECI bus core into linux driver framework. All comments you got for patch 6 are applicable here. And perhaps in the rest of the series. The rule

Re: [PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core

On 4/23/2018 3:52 AM, Greg KH wrote: On Tue, Apr 10, 2018 at 11:32:05AM -0700, Jae Hyun Yoo wrote: +static void peci_adapter_dev_release(struct device *dev) +{ + /* do nothing */ +} As per the in-kernel documentation, I am now allowed to make fun of you. You are trying to "out

Re: [PATCH v3 06/10] drivers/peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

Hi Robin, On 4/17/2018 6:37 AM, Robin Murphy wrote: Just a drive-by nit: On 10/04/18 19:32, Jae Hyun Yoo wrote: [...] +#define PECI_CTRL_SAMPLING_MASK GENMASK(19, 16) +#define PECI_CTRL_SAMPLING(x)   (((x) << 16) & PECI_CTRL_SAMPLING_MASK) +#define PECI_CTRL_SAMPLING_GET

Re: [PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

On 4/17/2018 6:16 AM, Rob Herring wrote: On Mon, Apr 16, 2018 at 6:12 PM, Jae Hyun Yoo <jae.hyun@linux.intel.com> wrote: On 4/16/2018 11:10 AM, Rob Herring wrote: On Tue, Apr 10, 2018 at 11:32:06AM -0700, Jae Hyun Yoo wrote: This commit adds a dt-bindings document of PECI adapter

Re: [PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

On 4/17/2018 11:16 AM, Jae Hyun Yoo wrote: On 4/17/2018 6:16 AM, Rob Herring wrote: On Mon, Apr 16, 2018 at 6:12 PM, Jae Hyun Yoo <jae.hyun@linux.intel.com> wrote: On 4/16/2018 11:10 AM, Rob Herring wrote: On Tue, Apr 10, 2018 at 11:32:06AM -0700, Jae Hyun Yoo wrote: This commi

Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers

On 4/16/2018 11:14 AM, Rob Herring wrote: On Tue, Apr 10, 2018 at 11:32:09AM -0700, Jae Hyun Yoo wrote: This commit adds dt-bindings documents for PECI cputemp and dimmtemp client drivers. "dt-bindings: hwmon: ..." for the subject. I'll change the subject. Signed-off-by: Ja

Re: [PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

On 4/16/2018 11:10 AM, Rob Herring wrote: On Tue, Apr 10, 2018 at 11:32:06AM -0700, Jae Hyun Yoo wrote: This commit adds a dt-bindings document of PECI adapter driver for Aspeed AST24xx/25xx SoCs. Signed-off-by: Jae Hyun Yoo <jae.hyun@linux.intel.com> Reviewed-by: Haiyue Wang <

Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers

On 4/16/2018 4:22 PM, Jae Hyun Yoo wrote: On 4/16/2018 11:14 AM, Rob Herring wrote: On Tue, Apr 10, 2018 at 11:32:09AM -0700, Jae Hyun Yoo wrote: This commit adds dt-bindings documents for PECI cputemp and dimmtemp client drivers. "dt-bindings: hwmon: ..." for the subject. I

Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers

On 4/18/2018 2:57 PM, Jae Hyun Yoo wrote: On 4/18/2018 2:28 PM, Rob Herring wrote: On Wed, Apr 18, 2018 at 3:28 PM, Jae Hyun Yoo <jae.hyun@linux.intel.com> wrote: On 4/18/2018 7:32 AM, Rob Herring wrote: On Tue, Apr 17, 2018 at 3:40 PM, Jae Hyun Yoo <jae.hyun@linux.intel.c