Re: [PATCH 02/10] docs: sphinxify coccinelle.txt and add it to dev-tools

Acked-by: Julia Lawall <julia.law...@lip6.fr> On Mon, 8 Aug 2016, Jonathan Corbet wrote: > No textual changes have been made, but the formatting has obviously been > tweaked. > > Cc: Michal Marek <mma...@suse.com> > Cc: Gilles Muller <gilles.mul...@lip6.fr>

Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn

hwmon to convert in applesmc.c > > > > Perhaps a coccinelle script? > > > > Two questions for Julia Lawall: > > > > o is there a better way to do this than repeat the blocks > > one for each replacement > > o can struct device * dev be made an arbitrary id

Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn

On Sun, 22 Jan 2017, Joe Perches wrote: > On Sun, 2017-01-22 at 22:43 -0800, Joe Perches wrote: > > Two questions for Julia Lawall: > > > > o is there a better way to do this than repeat the blocks > > one for each replacement > > o can struct device * de

Re: [PATCH v4 1/1] DM: inplace compressed DM target (fwd)

On line 1759, since ret is unsigned it will not be less than 0. julia -- Forwarded message -- Date: Tue, 14 Feb 2017 09:00:39 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH v4 1/1]

Re: [PATCH] scripts/coccicheck: Update reference for the corresponding documentation

mat "reStructuredText" > in August 2016. > > Fixes: 4b9033a33494ec9154d63e706e9e47f7eb3fd59e ("docs: sphinxify > coccinelle.txt and add it to dev-tools") > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Julia Lawall <julia.law...@

Re: kernel-doc-rst-lint (was: Re: [PATCH 00/15] improve function-level documentation)

On Wed, 5 Oct 2016, Jani Nikula wrote: > On Wed, 05 Oct 2016, Daniel Vetter wrote: > > Jani Nikula has a patch with a scrip to make the one kernel-doc parser > > into a lint/checker pass over the entire kernel. I think that'd would > > be more robust instead of trying to

Re: "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk())

On Mon, 19 Sep 2016, Joe Perches wrote: > On Tue, 2016-09-20 at 01:11 +0100, Al Viro wrote: > > IMO what we need is to go through all rules in CodingStyle and if for > > some rule there is no overwhelming majority in the core kernel, well, > > the list has grown way too large and could use

Re: "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk())

On Mon, 19 Sep 2016, Joe Perches wrote: > On Tue, 2016-09-20 at 07:53 +0200, Julia Lawall wrote: > > On Mon, 19 Sep 2016, Joe Perches wrote: > > > On Tue, 2016-09-20 at 01:11 +0100, Al Viro wrote: > > > > IMO what we need is to go through all rules in CodingStyl

Re: "CodingStyle: Clarify and complete chapter 7" in docs-next

> > The main intent of checkpatch these days appears to be providing an easy > > way of thoughtless inflation of commit counts, everything else be damned. > > Make-work, in other words. > > Yes, I've noticed the trend too :-( But that's a problem with the > people using the tool, mostly, not with

kernel-doc

Hello, I have the inpression that not all comments on specific functions are using the following notation: function_name() - Brief description of function. They are good about using the -, but some don't have the () after the function name and others (perhaps only one subsystem) have the

Re: [PATCH] doc: add note on usleep_range range

On Tue, 13 Dec 2016, Nicholas Mc Guire wrote: > On Tue, Dec 13, 2016 at 11:10:50AM +0200, Jani Nikula wrote: > > On Tue, 13 Dec 2016, Nicholas Mc Guire wrote: > > > useleep_range() with a delta of 0 makes no sense and only prevents the > > > timer subsystem from optimizing

[PATCH] drivers: hwmon: fix device_node_continue.cocci warnings

Device node iterators put the previous value of the index variable, so an explicit put causes a double put. Generated by: scripts/coccinelle/iterators/device_node_continue.cocci CC: Jaghathiswari Rankappagounder Natarajan <ja...@google.com> Signed-off-by: Julia Lawall <julia.law..

[PATCH] drivers: hwmon: fix ptr_ret.cocci warnings

Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci CC: Jaghathiswari Rankappagounder Natarajan <ja...@google.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com>

[PATCH] drivers: hwmon: fix semicolon.cocci warnings

Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Jaghathiswari Rankappagounder Natarajan <ja...@google.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> --- url: https://github

Re: [Outreachy kernel] [PATCH] Documentation: Fix typos

On Wed, 15 Mar 2017, Alison Schofield wrote: > On Wed, Mar 15, 2017 at 09:07:56PM +0100, Julia Lawall wrote: > > > > > > On Wed, 15 Mar 2017, Tamara Diaconita wrote: > > > > > Fix typos in sync_file.txt to make documentation grammatically correc

Re: [Outreachy kernel] [PATCH] Documentation: Fix typos

On Wed, 15 Mar 2017, Tamara Diaconita wrote: > Fix typos in sync_file.txt to make documentation grammatically correct. It's a bit picky, but you are not making the text grammatically correct, You are fixing spelling mistakes, but not changing any aspect of the grammar. julia > >

Re: [Outreachy kernel] [PATCH v2] Documentation: admin-guide: Fix typos

On Tue, 14 Mar 2017, Tamara Diaconita wrote: > Fix typos in admin-guide directory. > Make documentation clear and grammatically correct. You may want to collect the words in which you find problems, and see if other files have the same problems. julia > > Signed-off-by: Tamara Diaconita

Re: [Outreachy kernel] [PATCH v2] Documentation: admin-guide: Fix typos

roblem in other files, and thus find more opportunities for patches. julia > > marți, 14 martie 2017, 11:05:55 UTC+2, Julia Lawall a scris: > > > On Tue, 14 Mar 2017, Tamara Diaconita wrote: > > > Fix typos in admin-guide directory. > > Make documenta

Re: [Outreachy kernel] [PATCH] Documentation: x86: Fix typos

On Tue, 14 Mar 2017, Tamara Diaconita wrote: > Fix typos in x86 directory. > Make documentation clear and grammatically correct. > > Signed-off-by: Tamara Diaconita > --- > Documentation/x86/boot.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

[PATCH] ipmi: bt-i2c: fix call_kern.cocci warnings

endan Higgins <brendanhigg...@google.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> --- url: https://github.com/0day-ci/linux/commits/Brendan-Higgins/ipmi-bt-i2c-added-IPMI-Block-Transfer-over-I2C/20170806-034713 ipmi

[PATCH] docs: dev-tools: correct Coccinelle version number

There is no Coccinelle version 1.2. 1.0.2 must be what was intended. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- Documentation/dev-tools/coccinelle.rst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/dev-tools/coccinelle.rst b/Documentati

Re: [PATCH v2 2/5] Documentation: Add doc for runchecks, a checker runner

> diff --git a/Documentation/dev-tools/runchecks.rst > b/Documentation/dev-tools/runchecks.rst > new file mode 100644 > index 000..b25b3de > --- /dev/null > +++ b/Documentation/dev-tools/runchecks.rst > @@ -0,0 +1,215 @@ > +.. Copyright 2017 Knut Omang > + > +Makefile

Re: device attribute documentation

On Thu, 14 Dec 2017, Jonathan Corbet wrote: > On Thu, 14 Dec 2017 15:30:13 +0100 (CET) > Julia Lawall <julia.law...@lip6.fr> wrote: > > [CC += Greg in case he disagrees] > > > My intern, Aishwarya Pant, is looking into how to improve the > > documentation of

Re: [PATCH] docs: dev-tools: coccinelle: delete out of date wiki reference

On Tue, 14 Nov 2017, Masahiro Yamada wrote: > Hi Julia, Jon, > > 2017-11-14 1:50 GMT+09:00 Julia Lawall <julia.law...@lip6.fr>: > > The wiki is no longer available. > > > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> > > > > > Jo

[PATCH] docs: dev-tools: coccinelle: delete out of date wiki reference

The wiki is no longer available. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- diff --git a/Documentation/dev-tools/coccinelle.rst b/Documentation/dev-tools/coccinelle.rst index 37e474f..94f41c2 100644 --- a/Documentation/dev-tools/coccinelle.rst +++ b/Documentation/dev

Re: [PATCH] hwmon: (sht3x) move sysfs documentation to Documentation/ABI (fwd)

In the end, the change was not very popular... julia -- Forwarded message -- Date: Fri, 22 Dec 2017 10:10:28 -0800 From: Guenter Roeck To: Aishwarya Pant Cc: Jean Delvare , linux-hw...@vger.kernel.org,

Re: [PATCH] rtc: sysfs: move sysfs & ioctl interface to Documentation/ABI

On Mon, 1 Jan 2018, Aishwarya Pant wrote: > Right now, the decription of the rtc and sysfs interfaces is in > Documentation/rtc.txt. Since these are a part of the ABI, they should be > in Documentation/ABI along with the rest. > > Signed-off-by: Aishwarya Pant > --- > Let