Re: [ANN] Media documentation converted to ReST markup language

2016-07-13 Thread Laurent Pinchart
Hi Mauro, On Wednesday 13 Jul 2016 11:11:43 Mauro Carvalho Chehab wrote: > Em Sat, 09 Jul 2016 20:10:21 +0300 Laurent Pinchart escreveu: > > The other one is related, the table of contents in the main page of each > > section > > (https://mchehab.fedorapeople.org/media_API_bo

Re: [ANN] Media documentation converted to ReST markup language

2016-07-09 Thread Laurent Pinchart
requiring many clicks (or actually any click at all). How can we keep that feature ? By the way, the "Video for Linux API" section (and the other sibling sections) are child nodes of the "Introduction" section. That feels quite odd. -- Regards, Laurent Pinchart --

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Laurent Pinchart
kfigure.py | 442 ++++++ > 6 files changed, 548 insertions(+), 6 deletions(-) > create mode 100644 Documentation/doc-guide/hello.dot > create mode 100644 Documentation/doc-guide/svg_image.svg > create mode 100644 Documentation/sphinx/kfigure.py -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Laurent Pinchart
Hi Daniel, On Thursday 02 Mar 2017 14:54:32 Daniel Vetter wrote: > On Thu, Mar 2, 2017 at 1:26 PM, Laurent Pinchart wrote: > > Hi Daniel, > > > > Thank you for the patch. > > > > With this applied, I get > > > > make[1]: Entering dir

Re: [PATCH] drm/doc: atomic overview, with graph

2017-03-02 Thread Laurent Pinchart
nd not get stalled due to output routing changing > on > + different CRTCs. > + > +Taken all together there's two consequences for the atomic design: > + > +- The overall state is split up into per-object state structures: > + :c:type:`struct drm_plane_state ` for planes, > :c:type:`struc

Re: [PATCH 22/47] [media] v4l2-dev.rst: fix a broken c domain reference

2016-09-08 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Thursday 08 Sep 2016 09:03:44 Mauro Carvalho Chehab wrote: > The "struct" were inside the reference, causing it to break. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Laurent Pinchart <laure

Re: [PATCH 22/22] usb: document that URB transfer_buffer should be aligned

2017-03-30 Thread Laurent Pinchart
Hi Mauro, On Wednesday 29 Mar 2017 22:06:33 Mauro Carvalho Chehab wrote: > Em Thu, 30 Mar 2017 01:15:27 +0300 Laurent Pinchart escreveu: > > On Wednesday 29 Mar 2017 15:54:21 Mauro Carvalho Chehab wrote: > > > Several host controllers, commonly found on ARM, like dwc2, >

Re: [PATCH 22/22] usb: document that URB transfer_buffer should be aligned

2017-03-30 Thread Laurent Pinchart
Hi Mauro, On Thursday 30 Mar 2017 07:28:00 Mauro Carvalho Chehab wrote: > Em Thu, 30 Mar 2017 12:34:32 +0300 Laurent Pinchart escreveu: > > On Thursday 30 Mar 2017 10:11:31 Oliver Neukum wrote: > >> Am Donnerstag, den 30.03.2017, 01:15 +0300 schrieb Laurent Pinchart: > >&

Re: [PATCH 22/22] usb: document that URB transfer_buffer should be aligned

2017-03-30 Thread Laurent Pinchart
Hi Oliver, On Thursday 30 Mar 2017 10:11:31 Oliver Neukum wrote: > Am Donnerstag, den 30.03.2017, 01:15 +0300 schrieb Laurent Pinchart: > > > + may also override PAD bytes at the end of the ``transfer_buffer``, > > > up to the > > > + size of the CPU word. >

Re: [PATCH 22/22] usb: document that URB transfer_buffer should be aligned

2017-03-30 Thread Laurent Pinchart
(0x5678), > > it will actually read 32 bits, with 16-bits with some random value, > > > > causing a buffer overflow. E. g. buffer content will now be: > > buf = { 0x12, x34, 0xde, 0xad } > > > > In other words, the second transfer corrupted the data fr

Re: [PATCH 22/22] usb: document that URB transfer_buffer should be aligned

2017-03-29 Thread Laurent Pinchart
on is normally ensured if the buffer is > + * allocated with kmalloc(), but this may not be the case if the driver > + * allocates a bigger buffer and point to a random place inside it. > + * Couldn't we avoid three copies of the same text ? The chance they will get out-of-sync is

Re: [PATCH v6 3/6] documentation: media: Add documentation for new RGB and YUV bus formats

2017-04-04 Thread Laurent Pinchart
- b\ :sub:`8` > + - b\ :sub:`7` > + - b\ :sub:`6` > + - b\ :sub:`5` > + - b\ :sub:`4` > + - b\ :sub:`3` > + - b\ :sub:`2` > + - b\ :sub:`1` > + - b\ :sub:`0` > + > +.. raw:: latex > + > +\endgroup > + >

Re: [PATCH v6 5/6] drm: bridge: dw-hdmi: Add Documentation on supported input formats

2017-04-04 Thread Laurent Pinchart
ff-by: Neil Armstrong <narmstr...@baylibre.com> Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > --- > Documentation/gpu/bridge/dw-hdmi.rst | 15 +++ > Documentation/gpu/index.rst | 1 + > 2 files changed, 16 insertions(+) > create

Re: [PATCH v6 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings

2017-04-04 Thread Laurent Pinchart
ats and encodings on it's internal > + * 48bit bus. > + * s/it's/its/ [snip] Apart from that, Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] drm/doc: diagram for mode objects and properties

2017-03-02 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Wednesday 01 Mar 2017 09:27:14 Daniel Vetter wrote: > Resulted in confusion a few times in the past. > > v2: Spelling fix (Eric). > > Cc: Eric Anholt <e...@anholt.net> > Acked-by: Eric Anholt <e...@anholt.net> > Cc

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Laurent Pinchart
Hi Daniel and Markus, On Thursday 02 Mar 2017 16:11:08 Daniel Vetter wrote: > On Thu, Mar 02, 2017 at 03:58:36PM +0100, Markus Heiser wrote: > > Am 02.03.2017 um 15:14 schrieb Laurent Pinchart: > > > On Thursday 02 Mar 2017 14:54:32 Daniel Vetter wrote: > > >>

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Laurent Pinchart
and convert, otherwise debugging issues with > the diagrams is impossible. > > v3: Only sphinx 1.4 (released in Mar 2016) has patches.Figure. > Implement Markus suggestion for backwards compatability with earlier > releases. Laurent reported this, running sphinx 1.3. Solution entirely &g

Re: [PATCH v2 08/17] media: v4l2-ioctl.h: convert debug macros into enum and document

2017-10-13 Thread Laurent Pinchart
og poll syscalls. > + */ > +enum v4l2_debug_flags { > + V4L2_DEV_DEBUG_IOCTL= 0x01, > + V4L2_DEV_DEBUG_IOCTL_ARG= 0x02, > + V4L2_DEV_DEBUG_FOP = 0x04, > + V4L2_DEV_DEBUG_STREAMING= 0x08, > + V4L2_DEV_DEBUG_POLL = 0x

Re: [PATCH v2 02/17] media: v4l2-common: get rid of v4l2_routing dead struct

2017-10-13 Thread Laurent Pinchart
-opensource.com> Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > --- > include/media/v4l2-common.h | 14 +- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h &g

Re: [PATCH v2 14/17] media: v4l2-async: better describe match union at async match struct

2017-10-13 Thread Laurent Pinchart
;waiting list > + * probed, to a notifier->waiting list. > + * Not to be used by drivers. > */ > struct v4l2_async_subdev { > enum v4l2_async_match_type match_type; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 06/17] media: v4l2-dv-timings.h: convert comment into kernel-doc markup

2017-10-13 Thread Laurent Pinchart
gt; + * - For CVT timings: if reduced blanking v2 (vsync == 8) is true. > + * - For CEA861 timings: if %V4L2_DV_FL_CAN_REDUCE_FPS flag is true. > */ > static inline bool can_reduce_fps(struct v4l2_bt_timings *bt) > { -- Regards, Laurent Pinchart -- To unsubscribe from this list: send t

Re: [PATCH v2 15/17] media: v4l2-ctrls: document nested members of structs

2017-10-13 Thread Laurent Pinchart
alue/ > + * @cur.val: The control's current value, if the @type is represented via > + * a u32 integer (see v4l2_ctrl_type). > * @val: The control's new s32 value. > * @priv:The control's private pointer. For use by the driver. It is > * untouched by the contr

Re: [PATCH v2 03/17] media: v4l2-common: get rid of struct v4l2_discrete_probe

2017-10-13 Thread Laurent Pinchart
at( > - const struct v4l2_discrete_probe *probe, > - s32 width, s32 height); > +const struct v4l2_frmsize_discrete > +*v4l2_find_nearest_format(const struct v4l2_frmsize_discrete *sizes, > + const size_t num_sizes, No need for a const keyword. > + s32 width, s32 height); > > void v4l2_get_timestamp(struct timeval *tv); -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 12/17] media: v4l2-fwnode.h: better describe bus union at fwnode endpoint struct

2017-10-13 Thread Laurent Pinchart
ile Industry Processor > + * Interface's Camera Serial Interface version 2 > + * (MIPI CSI2). These are not pointers. > * @link_frequencies: array of supported link frequencies > * @nr_of_link_frequencies: number of elements in link_frequenccies array &

Re: [PATCH v2 05/17] media: v4l2-device.h: document ancillary macros

2017-10-13 Thread Laurent Pinchart
oups, according to > + * each element at v4l2_subdev_ops. > */ > #define v4l2_device_has_op(v4l2_dev, grpid, o, f) \ > ({ \ > @@ -331,9 +492,18 @@ static inline void v4l2_subdev_notify(struct > v4l2_subdev *sd, __result; > \ > }) > > -/* > - * Does any subdev with matching grpmsk (or all if grpmsk == 0) has the > given > - * op? > +/** > + * v4l2_device_mask_has_op - checks if any subdev with matching group > + * mask has a given ops. > + * > + * @v4l2_dev: pointer to v4l2_device > + * @grpmsk: bitmask to be checked against v4l2_subdev->grp_id > + * group ID to be matched. Use 0 to match them all. > + * @o: name of the element at v4l2_subdev_ops that contains @f. > + * Each element there groups a set of callbacks functions. > + * @f: callback function that will be called if @cond matches. > + * The callback functions are defined in groups, according to > + * each element at v4l2_subdev_ops. > */ > #define v4l2_device_mask_has_op(v4l2_dev, grpmsk, o, f) > \ > ({ \ -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 04/17] media: v4l2-common.h: document ancillary functions

2017-10-13 Thread Laurent Pinchart
ouldn't mention userspace here. > + */ > const struct v4l2_frmsize_discrete > *v4l2_find_nearest_format(const struct v4l2_frmsize_discrete *sizes, > const size_t num_sizes, > s32 width, s32 height); > > +/** > + * v4l2_get_timestamp - ancillary routine to get a timestamp to be used > when > + * filling streaming metadata. Internally, it uses ktime_get_ts(), + > * with is the recommended way to get it. s/with/which/ > + * > + * @tv: pointer to timeval to be filled. > + */ > void v4l2_get_timestamp(struct timeval *tv); > > #endif /* V4L2_COMMON_H_ */ -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC v2] media: open.rst: document devnode-centric and mc-centric types

2017-08-25 Thread Laurent Pinchart
struct device (SoC IP core, I2C chip, ...) - group of hardware devices that together make a larger user-facing functional device (for instance the SoC ISP IP cores and external camera sensors together make a camera device) We need different terms for those different concepts, and we need to

Re: [PATCH 1/3] media: open.rst: document devnode-centric and mc-centric types

2017-08-25 Thread Laurent Pinchart
en light to such implementations until we have to, and I also prefer discussing this topic separately. It will require a fair amount of work to document (and thus first agree on), and there's no need to block the rest of this patch until we complete that work. For those reasons I would lik

Re: [PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

2017-08-25 Thread Laurent Pinchart
ntrolled via V4L2 device nodes (radio, video, vbi, > >> +sdr > >> * - ``V4L2_CAP_DEVICE_CAPS`` > >>- 0x8000 > >>- The driver fills the ``device_caps`` field. This capability can > >> > >> diff --git a/include/uapi/linux/v

Re: [PATCH 1/3] media: open.rst: document devnode-centric and mc-centric types

2017-08-25 Thread Laurent Pinchart
Hi Mauro, On Friday, 25 August 2017 16:38:23 EEST Mauro Carvalho Chehab wrote: > Em Fri, 25 Aug 2017 16:11:15 +0300 Laurent Pinchart escreveu: > > On Friday, 25 August 2017 12:40:05 EEST Mauro Carvalho Chehab wrote: > >> From: "mche...@s-opensource.com" <mche...@s-

Re: [PATCH v2 08/17] media: v4l2-ioctl.h: convert debug macros into enum and document

2017-12-18 Thread Laurent Pinchart
Hi Mauro, On Monday, 18 December 2017 17:13:26 EET Mauro Carvalho Chehab wrote: > Em Fri, 13 Oct 2017 15:38:11 +0300 Laurent Pinchart escreveu: > > On Thursday, 28 September 2017 00:46:51 EEST Mauro Carvalho Chehab wrote: > >> Currently, there's no way to document #define foo