Re: [PATCH v3 04/30] staging: unisys: visorbus: remove unused module parameters

2016-06-08 Thread Neil Horman
On Wed, Jun 08, 2016 at 02:42:08PM +, Binder, David Anthony wrote: > > -Original Message- > > From: Neil Horman [mailto:nhor...@redhat.com] > > Sent: Wednesday, June 08, 2016 9:08 AM > > To: Binder, David Anthony <david.bin...@unisys.com> > >

Re: [PATCH v3 04/30] staging: unisys: visorbus: remove unused module parameters

2016-06-07 Thread Neil Horman
On Sat, Jun 04, 2016 at 01:27:04PM -0400, David Kershner wrote: > From: David Binder > > Removes unused module parameters from visorbus_main.c, in response to > findings by SonarQube. > > Signed-off-by: David Binder > Signed-off-by: David

Re: [PATCH v3 11/30] staging: unisys: visorbus: use kernel timer instead of workqueue

2016-06-07 Thread Neil Horman
On Sat, Jun 04, 2016 at 01:27:11PM -0400, David Kershner wrote: > From: Tim Sell > > A kernel timer is now used as the vehicle to periodically call the > channel_interrupt function of registered visor drivers, instead of a > workqueue. > > This simplifies a lot of

Re: [PATCH v3 11/30] staging: unisys: visorbus: use kernel timer instead of workqueue

2016-06-07 Thread Neil Horman
On Tue, Jun 07, 2016 at 01:47:13PM +, Sell, Timothy C wrote: > > -Original Message- > > From: Neil Horman [mailto:nhor...@redhat.com] > > Sent: Tuesday, June 07, 2016 9:40 AM > > To: Kershner, David A > > Cc: cor...@lwn.net; t...@linutronix.de; mi...@redha

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

2016-06-14 Thread Neil Horman
> include/linux/visorbus}/channel_guid.h (100%) > rename {drivers/staging/unisys/include => > include/linux/visorbus}/diagchannel.h (100%) > rename {drivers/staging/unisys/include => > include/linux/visorbus}/guestlinuxdebug.h (100%) > rename {drivers/staging/unisys/

Re: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking

2016-06-02 Thread Neil Horman
On Thu, Jun 02, 2016 at 05:02:11AM +, Sell, Timothy C wrote: > > -Original Message- > > From: Neil Horman [mailto:nhor...@redhat.com] > > Sent: Wednesday, June 01, 2016 2:43 PM > > To: Sell, Timothy C > > Cc: Kershner, David A; cor...@lwn.net; t...@linut

Re: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking

2016-06-01 Thread Neil Horman
On Wed, Jun 01, 2016 at 03:09:13PM +, Sell, Timothy C wrote: > > -Original Message- > > From: Neil Horman [mailto:nhor...@redhat.com] > > Sent: Wednesday, June 01, 2016 10:18 AM > > To: Kershner, David A > > Cc: cor...@lwn.net; t...@linutronix.de; mi...@

Re: [PATCH v2 01/27] staging: unisys: visorbus change -1 return values

2016-06-01 Thread Neil Horman
On Tue, May 31, 2016 at 10:26:27PM -0400, David Kershner wrote: > From: Erik Arfvidson > > This patch changes the vague -1 return values to -EFAULT since > it would be the most appropriate, given that this error > would only occur in an unexpected bad offset field. >

Re: [PATCH v2 03/27] staging: unisys: iovmcall_gnuc.h change -1 return values

2016-06-01 Thread Neil Horman
On Tue, May 31, 2016 at 10:26:29PM -0400, David Kershner wrote: > From: Erik Arfvidson > > This patch changes the vague -1 return values to -EPERM. > This operation is not supported is a good alternative > to -1 because the return is basically telling the caller > that

Re: [PATCH v2 02/27] staging: unisys: visorchipset change -1 return value

2016-06-01 Thread Neil Horman
On Tue, May 31, 2016 at 10:26:28PM -0400, David Kershner wrote: > From: Erik Arfvidson > > This patch changes the vague -1 return value to -EINVAL > > Signed-off-by: Erik Arfvidson > Signed-off-by: David Kershner