Re: [PATCH 00/19] mtd: rawnand: API cleanup (2nd batch)

On Sat, 15 Sep 2018 19:54:40 +0200 Miquel Raynal wrote: > Hi Boris, > > Boris Brezillon wrote on Fri, 7 Sep 2018 > 00:38:32 +0200: > > > Hello, > > > > This is the 2nd batch of API cleanup patches. This time we move > > deprecated hooks/fields to the

Re: [PATCH 19/19] mtd: rawnand: Move JEDEC code to nand_jedec.c

On Fri, 7 Sep 2018 10:40:44 +0200 Ladislav Michl wrote: > Hi Boris, > > this patchseries is really amazing clean up. Thank you! I'm glad I'm not the only one to find it useful :-). > > On Fri, Sep 07, 2018 at 12:38:51AM +0200, Boris Brezillon wrote: > > This mo

[PATCH 08/19] mtd: rawnand: Deprecate ->{set,get}_features() hooks

Those hooks should be replaced by a proper ->exec_op() implementation. Move them to the nand_legacy struct to make it clear. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c | 4 +- drivers/mtd/nand/raw/cafe_nand.c | 4 +- drivers/mtd/n

[PATCH 19/19] mtd: rawnand: Move JEDEC code to nand_jedec.c

This moves ONFI related code to nand_onfi.c and ONFI related struct/macros to include/linux/mtd/onfi.h. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/Makefile | 1 + drivers/mtd/nand/raw/internals.h | 3 + drivers/mtd/nand/raw/nand_base.c | 98

[PATCH 12/19] mtd: rawnand: Get rid of the duplicate nand_chip forward declaration

There's already a forward declaration of nand_chip at the beginning of the file. Get rid of this one. Signed-off-by: Boris Brezillon --- include/linux/mtd/rawnand.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h index 768415ed1159

[PATCH 03/19] mtd: rawnand: Deprecate ->{read,write}_{byte,buf}() hooks

All those hooks have been replaced by ->exec_op(). Move them to the nand_legacy struct. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/ams-delta.c | 6 +-- drivers/mtd/nand/raw/atmel/nand-controller.c | 8 ++-- drivers/mtd/nand/raw/au1550nd.c |

[PATCH 18/19] mtd: rawnand: Move ONFI code to nand_onfi.c

This moves ONFI related code to nand_onfi.c and ONFI related struct/macros to include/linux/mtd/onfi.h. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/Makefile| 1 + drivers/mtd/nand/raw/internals.h | 7 + drivers/mtd/nand/raw/nand_base.c | 296

[PATCH 17/19] mtd: rawnand: Move legacy code to nand_legacy.c

Allows us to move a few hundred lines of deprecated code out of the core file which is quite big. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/Makefile | 2 +- drivers/mtd/nand/raw/internals.h | 6 + drivers/mtd/nand/raw/nand_base.c | 618

[PATCH 05/19] mtd: rawnand: Deprecate ->dev_ready() and ->waitfunc()

Those hooks have been replaced by ->exec_op(). Move them to the nand_legacy struct. Signed-off-by: Boris Brezillon --- Documentation/driver-api/mtdnand.rst | 4 +-- drivers/mtd/nand/raw/ams-delta.c | 4 +-- drivers/mtd/nand/raw/atmel/nand-controller.c |

[PATCH 07/19] mtd: rawnand: Deprecate ->erase()

we should discourage people from overloading this method and encourage them to implement ->exec_op() instead. Move the ->erase() hook to the nand_legacy struct to make it clear. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/denali.c| 2 +- drivers/mtd/nand/raw/nand_b

[PATCH 09/19] mtd: rawnand: Deprecate ->chip_delay

The wait timeouts and delays are directly extracted from the NAND timings and ->chip_delay is only used in legacy path, so let's move it to the nand_legacy struct to make it clear. Signed-off-by: Boris Brezillon --- Documentation/driver-api/mtdnand.rst | 2 +- drivers/mtd/nand/

[PATCH 10/19] mtd: rawnand: Move function prototypes after struct declarations

Move nand_scan[_with_ids]() and nand_wait_ready() at the end of the file where all function prototype lies. This will also allow us to get rid of the nand_flash_dev forward declaration. Signed-off-by: Boris Brezillon --- include/linux/mtd/rawnand.h | 24 1 file changed

[PATCH 15/19] mtd: rawnand: Inline onfi_get_async_timing_mode()

onfi_get_async_timing_mode() is only used in one place inside nand_base.c. Let's inline the code and kill the helper. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/nand_base.c | 5 +++-- include/linux/mtd/rawnand.h | 9 - 2 files changed, 3 insertions(+), 11 deletions

[PATCH 13/19] mtd: rawnand: Get rid of a few unused definitions

Those definitions are not used, let's remove them. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/nand_timings.c | 14 -- include/linux/mtd/rawnand.h | 8 2 files changed, 22 deletions(-) diff --git a/drivers/mtd/nand/raw/nand_timings.c b/drivers/mtd

[PATCH 06/19] mtd: rawnand: Deprecate ->block_{bad,markbad}() hooks

discourage people from overloading those methods and encourage them to fix their driver instead. Move the ->block_{bad,markbad}() hooks to the nand_legacy struct to make it clear. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/cafe_nand.c | 2 +- drivers/mtd/nand/

[PATCH 16/19] mtd: rawnand: Keep all internal stuff private

that are not supposed to be exposed. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/internals.h | 98 drivers/mtd/nand/raw/nand_amd.c | 2 +- drivers/mtd/nand/raw/nand_base.c | 21 drivers/mtd/nand/raw/nand_bbt.c | 3 +- drivers

[PATCH 14/19] mtd: rawnand: Move platform_nand_xxx definitions out of rawnand.h

platform_nand_xxx definitions are just used by the plat_nand driver. Let's move those definitions out of the core/driver-agnostic rawnand.h header. Signed-off-by: Boris Brezillon --- arch/arm/mach-ep93xx/snappercl15.c | 3 +- arch/arm/mach-ep93xx/ts72xx.c | 3 +- arch/arm/mach

[PATCH 11/19] mtd: rawnand: Get rid of nand_flash_dev forward declation

nand_scan[with_ids]() have been moved at the end of the file. We can now get rid of of the nand_flash_dev forward declaration. Signed-off-by: Boris Brezillon --- include/linux/mtd/rawnand.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd

[PATCH 04/19] mtd: rawnand: Deprecate ->cmd_ctrl() and ->cmdfunc()

Those hooks have been replaced by ->exec_op(). Move them to the nand_legacy struct. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/ams-delta.c | 2 +- drivers/mtd/nand/raw/atmel/nand-controller.c | 4 +- drivers/mtd/nand/raw/au1550nd.c |

[PATCH 02/19] mtd: rawnand: Create a legacy struct and move ->IO_ADDR_{R,W} there

as deprecated. We start with the ->IO_ADDR_{R,W] fields. Signed-off-by: Boris Brezillon --- Documentation/driver-api/mtdnand.rst | 24 arch/arm/mach-ep93xx/snappercl15.c | 5 +++-- arch/arm/mach-ep93xx/ts72xx.c| 6 +++--- arch/arm/mach-imx/mach-qong.c|

[PATCH 01/19] mtd: rawnand: Leave chip->IO_ADDR_{R,W} to NULL when unused

There's no point in poisoning the ->IO_ADDR_{R,W}, a NULL pointer is just as good to detect unexpected ->IO_ADDR_{R,W} usage. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 3 --- drivers/mtd/nand/raw/socrates_nand.c | 4 2 files changed, 7 del

[PATCH 00/19] mtd: rawnand: API cleanup (2nd batch)

on the API/core cleanup. Regards, Boris Boris Brezillon (19): mtd: rawnand: Leave chip->IO_ADDR_{R,W} to NULL when unused mtd: rawnand: Create a legacy struct and move ->IO_ADDR_{R,W} there mtd: rawnand: Deprecate ->{read,write}_{byte,buf}() hooks mtd: rawnand: Deprecate ->cmd_ctrl() a

Re: [PATCH 16/18] mtd: rawnand.h: use nested union kernel-doc markups

On Mon, 7 May 2018 06:35:52 -0300 Mauro Carvalho Chehab wrote: > Gets rid of those warnings and better document the parameters. > > ./include/linux/mtd/rawnand.h:752: warning: Function parameter or member > 'timings.sdr' not described in 'nand_data_interface' >

Re: [PATCH 16/18] mtd: rawnand.h: use nested union kernel-doc markups

On Wed, 9 May 2018 09:10:34 -0300 Mauro Carvalho Chehab <mchehab+sams...@kernel.org> wrote: > Hi Boris, > > Em Mon, 7 May 2018 08:32:32 -0300 > Mauro Carvalho Chehab <mchehab+sams...@kernel.org> escreveu: > > > Hi Boris, > > > > Em Mon,

Re: [PATCH 16/18] mtd: rawnand.h: use nested union kernel-doc markups

On Mon, 7 May 2018 08:32:32 -0300 Mauro Carvalho Chehab <mchehab+sams...@kernel.org> wrote: > Hi Boris, > > Em Mon, 7 May 2018 11:46:50 +0200 > Boris Brezillon <boris.brezil...@bootlin.com> escreveu: > > > Hi Mauro, > > > > diff --git a/in

Re: [PATCH 16/18] mtd: rawnand.h: use nested union kernel-doc markups

Hi Mauro, On Mon, 7 May 2018 06:35:52 -0300 Mauro Carvalho Chehab wrote: > Gets rid of those warnings and better document the parameters. > > ./include/linux/mtd/rawnand.h:752: warning: Function parameter or member > 'timings.sdr' not described in

Re: [PATCH v4 00/10] Add the I3C subsystem

Hi Greg, On Sun, 29 Apr 2018 15:36:42 +0200 Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Mon, Apr 23, 2018 at 07:56:46PM +0200, Greg Kroah-Hartman wrote: > > On Mon, Apr 23, 2018 at 07:38:14PM +0200, Boris Brezillon wrote: > > > Hi, > > > &

Re: [PATCH v4 03/10] i3c: Add sysfs ABI spec

Hi Greg, On Sun, 29 Apr 2018 15:37:00 +0200 Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Fri, Mar 30, 2018 at 09:47:44AM +0200, Boris Brezillon wrote: > > Document sysfs files/directories/symlinks exposed by the I3C subsystem. > > > > Signed-off-by: Bo

Re: [PATCH v4 00/10] Add the I3C subsystem

Hi, On Fri, 30 Mar 2018 09:47:41 +0200 Boris Brezillon <boris.brezil...@bootlin.com> wrote: > This patch series is a proposal for a new I3C subsystem. This v4 has been sent almost a month ago and I didn't get any feedback so far apart from Rob's R-b. Greg, is there any chance w

[PATCH v4 03/10] i3c: Add sysfs ABI spec

Document sysfs files/directories/symlinks exposed by the I3C subsystem. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- Changes in v2: - new patch --- Documentation/ABI/testing/sysfs-bus-i3c | 95 + 1 file changed, 95 insertions(+) creat

[PATCH v4 00/10] Add the I3C subsystem

Boris Brezillon (10): i3c: Add core I3C infrastructure docs: driver-api: Add I3C documentation i3c: Add sysfs ABI spec dt-bindings: i3c: Document core bindings dt-bindings: i3c: Add macros to help fill I3C/I2C device's reg property MAINTAINERS: Add myself as the I3C subsystem

[PATCH v4 04/10] dt-bindings: i3c: Document core bindings

A new I3C subsystem has been added and a generic description has been created to represent the I3C bus and the devices connected on it. Document this generic representation. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- Changes in v4: - Clarify the fact that static a

[PATCH v4 06/10] MAINTAINERS: Add myself as the I3C subsystem maintainer

Create an entry for the I3C subsystem and mark it as maintained by me. There's no official git repository, patchwork instance, mailing list or website yet, but this will be added after the subsystem has been accepted. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- MAINT

[PATCH v4 05/10] dt-bindings: i3c: Add macros to help fill I3C/I2C device's reg property

The reg property of devices connected to an I3C bus have 3 cells, and filling them manually is not trivial. Provides macros to help doing that. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> Reviewed-by: Rob Herring <r...@kernel.org> --- include/dt-bindings/i3

[PATCH v4 08/10] dt-bindings: i3c: Document Cadence I3C master bindings

Document Cadence I3C master DT bindings. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- Changes in v4: - Fix example to match the new representation --- .../devicetree/bindings/i3c/cdns,i3c-master.txt| 44 ++ 1 file changed, 44 insertions(+) creat

[PATCH v4 10/10] dt-bindings: gpio: Add bindings for Cadence I3C gpio expander

Document the Cadence I3C gpio expander bindings. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- Changes in v4: - Use GPIO_ and IRQ_TYPE_ macros instead of raw numbers - Fix the unit-address in the example --- .../devicetree/bindings/gpio/gpio-cdns-i3c.txt

[PATCH v4 07/10] i3c: master: Add driver for Cadence IP

Add a driver for Cadence I3C master IP. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- Changes in v4: - Fix potential unsigned integer underflow - Add missing static specific on IBI related functions Changes in v3: - Adjust to match I3C framework changes - Implement s

[PATCH v4 09/10] gpio: Add a driver for Cadence I3C GPIO expander

Add a driver for Cadence I3C GPIO expander. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- drivers/gpio/Kconfig | 11 ++ drivers/gpio/Makefile| 1 + drivers/gpio/gpio-cdns-i3c.c | 380 +++ 3 files change

[PATCH v4 02/10] docs: driver-api: Add I3C documentation

Add the I3C documentation describing the protocol, the master driver API and the device driver API. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- Changes in v2: - Moved out of patch "i3c: Add core I3C infrastructure" - Add link to the I3C spec - Move rst files

Re: [PATCH v3 05/11] dt-bindings: i3c: Document core bindings

TIC_ADDR() and I2C_DEV() macros in the bindings doc? > > And if I do, should I use them my example? > > Well, I don't want to see "device@I3C_DEV(...)" for unit-addresses. That wouldn't work anyway. > You can use them for reg property, but it's somewhat pointless to use

Re: [PATCH v3 05/11] dt-bindings: i3c: Document core bindings

gt; + thermal_sensor: sensor@68,39200144004 { > > + reg = <0x68 0x392 0x144004>; > > + assigned-address = <0xa>; > > + }; > > + > > + /* > > +* I3C device without a static

Re: [PATCH v3 11/11] dt-bindings: gpio: Add bindings for Cadence I3C gpio expander

On Mon, 26 Mar 2018 12:12:54 +0200 Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > Hi Boris, > > On Fri, Mar 23, 2018 at 12:00 PM, Boris Brezillon > <boris.brezil...@bootlin.com> wrote: > > Document the Cadence I3C gpio expander bindings. > > > > Si

Re: [PATCH v3 11/11] dt-bindings: gpio: Add bindings for Cadence I3C gpio expander

Hi Geert, On Mon, 26 Mar 2018 12:17:26 +0200 Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > Hi Boris, > > On Fri, Mar 23, 2018 at 12:00 PM, Boris Brezillon > <boris.brezil...@bootlin.com> wrote: > > Document the Cadence I3C gpio expander bindings. > >

Re: [PATCH v3 05/11] dt-bindings: i3c: Document core bindings

Hi Geert, On Mon, 26 Mar 2018 12:22:24 +0200 Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > Hi Boris, > > On Fri, Mar 23, 2018 at 12:00 PM, Boris Brezillon > <boris.brezil...@bootlin.com> wrote: > > From: Boris Brezillon <boris.brezil...@free-electrons.com

Re: [PATCH v3 01/11] i2c: Export of_i2c_get_board_info()

ly, I had a closer look and it seems the only user of info->archdata is i2c-core-of.c, so we can even remove the info->archdata field. -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -- To unsubscribe from this list: send th

Re: [PATCH v3 01/11] i2c: Export of_i2c_get_board_info()

itialized without any further modification, and leaving info->archdata to NULL has the exact same effect (see [1]). Regards, Boris [1]https://elixir.bootlin.com/linux/v4.16-rc6/source/drivers/i2c/i2c-core-base.c#L711 -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engi

Re: [PATCH v3 09/11] dt-bindings: i3c: Document Cadence I3C master bindings

On Fri, 23 Mar 2018 12:10:35 +0100 Thomas Petazzoni <thomas.petazz...@bootlin.com> wrote: > Hello, > > On Fri, 23 Mar 2018 12:00:18 +0100, Boris Brezillon wrote: > > > +Optional properties defined by the generic binding (see > > +Documentation/devicetree/binding

Re: [PATCH v3 05/11] dt-bindings: i3c: Document core bindings

;; > > + i2c-scl-frequency = <10>; > > Another s/frequency/hz/ instance, similar to those reported by Thomas. Will fix it in v4. Thanks, Boris -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -- To unsu

[PATCH v3 04/11] i3c: Add sysfs ABI spec

From: Boris Brezillon <boris.brezil...@free-electrons.com> Document sysfs files/directories/symlinks exposed by the I3C subsystem. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Changes in v2: - new patch --- Documentation/ABI/testing/sysfs-

Re: [PATCH v3 00/11] Add the I3C subsystem

On Fri, 23 Mar 2018 12:00:09 +0100 Boris Brezillon <boris.brezil...@bootlin.com> wrote: > This patch series is a proposal for a new I3C [1] subsystem. > > This infrastructure is not complete yet and will be extended over > time. > > There are a few design choices t

[PATCH v3 05/11] dt-bindings: i3c: Document core bindings

From: Boris Brezillon <boris.brezil...@free-electrons.com> A new I3C subsystem has been added and a generic description has been created to represent the I3C bus and the devices connected on it. Document this generic representation. Signed-off-by: Boris Brezillon <boris.brezi

[PATCH v3 06/11] dt-bindings: i3c: Add macros to help fill I3C/I2C device's reg property

The reg property of devices connected to an I3C bus have 3 cells, and filling them manually is not trivial. Provides macros to help doing that. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- include/dt-bindings/i3c/i3c.h | 28 1 file chang

[PATCH v3 01/11] i2c: Export of_i2c_get_board_info()

From: Boris Brezillon <boris.brezil...@free-electrons.com> I3C busses have to know about all I2C devices connected on the I3C bus to properly initialize the I3C master, and I2C frames can't be sent on the bus until this initialization is done. We can't let the I2C core parse

[PATCH v3 07/11] MAINTAINERS: Add myself as the I3C subsystem maintainer

Create an entry for the I3C subsystem and mark it as maintained by me. There's no official git repository, patchwork instance, mailing list or website yet, but this will be added after the subsystem has been accepted. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- MAINT

[PATCH v3 00/11] Add the I3C subsystem

, Boris Boris Brezillon (11): i2c: Export of_i2c_get_board_info() i3c: Add core I3C infrastructure docs: driver-api: Add I3C documentation i3c: Add sysfs ABI spec dt-bindings: i3c: Document core bindings dt-bindings: i3c: Add macros to help fill I3C/I2C device's reg property

[PATCH v3 09/11] dt-bindings: i3c: Document Cadence I3C master bindings

From: Boris Brezillon <boris.brezil...@free-electrons.com> Document Cadence I3C master DT bindings. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- .../devicetree/bindings/i3c/cdns,i3c-master.txt| 45 ++ 1 file changed, 45 insertion

[PATCH v3 08/11] i3c: master: Add driver for Cadence IP

From: Boris Brezillon <boris.brezil...@free-electrons.com> Add a driver for Cadence I3C master IP. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Changes in v3: - Adjust to match I3C framework changes - Implement support the CMD RESPONSE QUEUE and IBI

[PATCH v3 10/11] gpio: Add a driver for Cadence I3C GPIO expander

Add a driver for Cadence I3C GPIO expander. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- drivers/gpio/Kconfig | 11 ++ drivers/gpio/Makefile| 1 + drivers/gpio/gpio-cdns-i3c.c | 380 +++ 3 files change

[PATCH v3 03/11] docs: driver-api: Add I3C documentation

From: Boris Brezillon <boris.brezil...@free-electrons.com> Add the I3C documentation describing the protocol, the master driver API and the device driver API. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Changes in v2: - Moved out of patch "

[PATCH v3 11/11] dt-bindings: gpio: Add bindings for Cadence I3C gpio expander

Document the Cadence I3C gpio expander bindings. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- .../devicetree/bindings/gpio/gpio-cdns-i3c.txt | 38 ++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/gpi

Re: [PATCH 00/47] arch-removal: device drivers

the mtd patches through the MTD tree. As you've probably noticed, nand code has been moved around and it's easier for me to carry those 2 simple changes in my tree than creating an immutable branch. Let me know if this is a problem. Regards, Boris -- Boris Brezillon, Bootlin (formerly Fr

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

it cannot be considered as utility to > define priorities for all devices before ENTDAA. We have SETNEWDA for other use cases: say you want one of your device to have an higher priority, you can just manually set a new dynamic address that is lower than any other devices on the bus (I plan to e

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

h is more generic and do not see any reason to add > special handling for SETDASA unless there is any reasonable reason to do > otherwise. I agree on one thing: as long as you don't have to reserve a specific dynamic address, SETDASA is not required. At least, that's my understanding. Re

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

T IBIs). But honestly, that's the only use case I can think of, and to me, it sounds like an advanced feature we may want to support at some point, but don't need in the initial implementation. -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://boot

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

ou to > > declare manually assigned addresses is likely to be > > controller-dependent. > > Please refer to figure 90 of public specification. As you can see the DAA > process should start with SETDASA command. Only if devices with a static address needs to be assigned a specific

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

On Mon, 26 Feb 2018 21:40:32 +0100 Boris Brezillon <boris.brezil...@bootlin.com> wrote: > On Mon, 26 Feb 2018 21:36:07 +0100 > Boris Brezillon <boris.brezil...@bootlin.com> wrote: > > > > >>> + > > > >>> +/** > >

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

On Mon, 26 Feb 2018 21:36:07 +0100 Boris Brezillon <boris.brezil...@bootlin.com> wrote: > > >>> + > > >>> +/** > > >>> + * struct i3c_master_controller_ops - I3C master methods > > >>> + * @bus_init: hook responsible for the I3C bu

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

to those transfers. Would that be okay if we pass an i3c_device object to ->priv_xfers()? > > > >> This could be also applied to i2c transfers. > > Not really. The max SCL frequency is something that applies to the > > whole bus, because all I2C

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

sa? if so, what is the addr? It's the payload passed to SETDASA and SETNEWDA, hence the generic _setda suffix. addr is the new dynamic address assigned to the device. -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -- To unsubscribe from

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

Hi Vitor, On Fri, 23 Feb 2018 16:56:14 + Vitor Soares <vitor.soa...@synopsys.com> wrote: > Hi Boris, > > Às 3:16 PM de 12/14/2017, Boris Brezillon escreveu: > > + > > +enum i3c_addr_slot_status i3c_bus_get_addr_slot

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

Hi Greg, On Tue, 19 Dec 2017 10:36:43 +0100 Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Tue, Dec 19, 2017 at 10:28:58AM +0100, Boris Brezillon wrote: > > On Tue, 19 Dec 2017 10:21:19 +0100 > > Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote:

Re: [PATCH v2 5/7] dt-bindings: i3c: Document core bindings

Hi Rob, On Tue, 26 Dec 2017 12:29:34 -0600 Rob Herring wrote: > >> > > > +Optional properties > >> > > > +--- > >> > > > +- reg: static address. Only valid is the device has a static > >> > > > address. > >> > > > +- i3c-dynamic-address: dynamic address to be

Re: [PATCH v2 5/7] dt-bindings: i3c: Document core bindings

On Wed, 20 Dec 2017 12:06:45 -0600 Rob Herring <r...@kernel.org> wrote: > On Sat, Dec 16, 2017 at 07:35:37PM +0100, Boris Brezillon wrote: > > On Sat, 16 Dec 2017 11:20:40 -0600 > > Rob Herring <r...@kernel.org> wrote: > > > > > On Thu, Dec 14, 2017

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

On Tue, 19 Dec 2017 10:21:19 +0100 Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Tue, Dec 19, 2017 at 10:13:36AM +0100, Boris Brezillon wrote: > > On Tue, 19 Dec 2017 10:09:00 +0100 > > Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > >

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

On Tue, 19 Dec 2017 10:09:00 +0100 Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > On Tue, 19 Dec 2017 09:52:50 +0100 > Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > > > On Thu, Dec 14, 2017 at 04:16:05PM +

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

On Tue, 19 Dec 2017 09:52:50 +0100 Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Thu, Dec 14, 2017 at 04:16:05PM +0100, Boris Brezillon wrote: > > +/** > > + * i3c_device_match_id() - Find the I3C device ID entry matching an I3C dev > > + * @i3cdev: the

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

On Sun, 17 Dec 2017 14:32:04 -0800 Randy Dunlap <rdun...@infradead.org> wrote: > On 12/14/17 07:16, Boris Brezillon wrote: > > Add core infrastructure to support I3C in Linux and document it. > > > > Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com

Re: [PATCH v2 5/7] dt-bindings: i3c: Document core bindings

On Sat, 16 Dec 2017 11:20:40 -0600 Rob Herring <r...@kernel.org> wrote: > On Thu, Dec 14, 2017 at 04:16:08PM +0100, Boris Brezillon wrote: > > A new I3C subsystem has been added and a generic description has been > > created to represent the I3C bus and

Re: [PATCH v2 6/7] i3c: master: Add driver for Cadence IP

On Thu, 14 Dec 2017 12:25:14 -0800 Randy Dunlap <rdun...@infradead.org> wrote: > On 12/14/2017 12:17 PM, Boris Brezillon wrote: > >>> + events.events = I3C_CCC_EVENT_HJ | I3C_CCC_EVENT_MR; > >>> + ret = i3c_master_enec_locked(m, I3C_BROADCAST_ADDR, ); > &g

Re: [PATCH v2 6/7] i3c: master: Add driver for Cadence IP

Hi Randy, On Thu, 14 Dec 2017 11:54:16 -0800 Randy Dunlap <rdun...@infradead.org> wrote: > On 12/14/2017 07:16 AM, Boris Brezillon wrote: > > Add a driver for Cadence I3C master IP. > > > > Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> >

[PATCH v2 4/7] i3c: Add sysfs ABI spec

Document sysfs files/directories/symlinks exposed by the I3C subsystem. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Changes in v2: - new patch --- Documentation/ABI/testing/sysfs-bus-i3c | 95 + 1 file changed, 95 insertions(+)

[PATCH v2 3/7] docs: driver-api: Add I3C documentation

Add the I3C documentation describing the protocol, the master driver API and the device driver API. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Changes in v2: - Moved out of patch "i3c: Add core I3C infrastructure" - Add link to the I3C spec

[PATCH v2 0/7] Add the I3C subsystem

reviews on the doc itself :-). Thanks, Boris Boris Brezillon (7): i2c: Export of_i2c_get_board_info() i3c: Add core I3C infrastructure docs: driver-api: Add I3C documentation i3c: Add sysfs ABI spec dt-bindings: i3c: Document core bindings i3c: master: Add driver for Cadence IP dt

[PATCH v2 7/7] dt-bindings: i3c: Document Cadence I3C master bindings

Document Cadence I3C master DT bindings. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- .../devicetree/bindings/i3c/cdns,i3c-master.txt| 45 ++ 1 file changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/i3c/cd

[PATCH v2 1/7] i2c: Export of_i2c_get_board_info()

core parse the I2C device nodes by itself and initialize the bus. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Changes in v2: - fix memset() call - rebase on v4.15-rc1 --- drivers/i2c/i2c-core-base.c | 2 +- drivers/i2c/i2c-core-of.c

[PATCH v2 5/7] dt-bindings: i3c: Document core bindings

A new I3C subsystem has been added and a generic description has been created to represent the I3C bus and the devices connected on it. Document this generic representation. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Changes in v2: - Define how to descri

[PATCH v2 6/7] i3c: master: Add driver for Cadence IP

Add a driver for Cadence I3C master IP. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Changes in v2: - Add basic IBI support. Note that the IP is not really reliable with regards to IBI because you can't extract IBI payloads as soon as you have more than o

Re: [RFC 2/5] i3c: Add core I3C infrastructure

Hi Greg, On Tue, 1 Aug 2017 19:13:27 -0700 Greg Kroah-Hartman wrote: > > > > Unless you see a good reason to not use a R/W lock, I'd like to keep it > > > > this way because master IPs are likely to implement advanced queuing > > > > mechanism (allows one to queue

Re: [RFC 0/5] Add I3C subsystem

On Mon, 31 Jul 2017 21:17:45 +0200 Wolfram Sang wrote: > Hi Boris, > > > This patch series is a proposal for a new I3C [1] subsystem. > > Nice. Good luck with that! > > Some hi-level comments from me related to I2C. I can't say a lot more > because the specs are not

Re: [RFC 2/5] i3c: Add core I3C infrastructure

Le Thu, 17 Aug 2017 11:03:10 +0200, Linus Walleij <linus.wall...@linaro.org> a écrit : > On Mon, Jul 31, 2017 at 6:24 PM, Boris Brezillon > <boris.brezil...@free-electrons.com> wrote: > > > This infrastructure is not complete yet and will be extended over > >

Re: [RFC 2/5] i3c: Add core I3C infrastructure

Le Wed, 16 Aug 2017 23:03:55 +0200, Geert Uytterhoeven a écrit : > On Tue, Aug 1, 2017 at 5:01 PM, Wolfram Sang wrote: > >> I'm perfectly fine with the I3C / I2C framework separation. The only > >> minor problem I had with that was the inaccuracy of the

Re: [PATCH v5 04/19] crypto: marvell/cesa: remove redundant backlog checks on EBUSY

-by: Gilad Ben-Yossef <gi...@benyossef.com> Acked-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > drivers/crypto/marvell/cesa.c | 3 +-- > drivers/crypto/marvell/cesa.h | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/dri

Re: [RFC 3/5] dt-bindings: i3c: Document core bindings

Hi Rob, Le Wed, 9 Aug 2017 18:43:02 -0500, Rob Herring <r...@kernel.org> a écrit : > On Mon, Jul 31, 2017 at 06:24:48PM +0200, Boris Brezillon wrote: > > A new I3C subsystem has been added and a generic description has been > > created to represent the I3C bus and

Re: [RFC 2/5] i3c: Add core I3C infrastructure

On Tue, 1 Aug 2017 17:20:41 +0200 Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > On Tue, 1 Aug 2017 17:01:08 +0200 > Wolfram Sang <w...@the-dreams.de> wrote: > > > > I do not know of any real devices as of today (all my tests have been > >

Re: [RFC 2/5] i3c: Add core I3C infrastructure

Le Tue, 1 Aug 2017 19:27:03 +0200, Wolfram Sang a écrit : > > I'm surprised they didn't allow for slave clock stretching when > > communicating with a legacy i2c device, it will prohibit use of a rather > > large class of devices. :( > > Yes, but I3C is push/pull IIRC. It

Re: [RFC 2/5] i3c: Add core I3C infrastructure

Hi Greg, Le Tue, 1 Aug 2017 10:51:33 -0700, Greg Kroah-Hartman <gre...@linuxfoundation.org> a écrit : > On Tue, Aug 01, 2017 at 12:48:01PM +0200, Boris Brezillon wrote: > > > > +static DEFINE_MUTEX(i3c_core_lock); > > > > + > > > > +void i3c

Re: [RFC 2/5] i3c: Add core I3C infrastructure

On Tue, 1 Aug 2017 16:22:21 +0200 Arnd Bergmann <a...@arndb.de> wrote: > On Tue, Aug 1, 2017 at 3:58 PM, Boris Brezillon > <boris.brezil...@free-electrons.com> wrote: > > On Tue, 1 Aug 2017 15:34:14 +0200 > > Boris Brezillon <boris.brezil...@free-electrons.com>

Re: [RFC 2/5] i3c: Add core I3C infrastructure

On Tue, 1 Aug 2017 16:12:18 +0200 Wolfram Sang wrote: > > > The second way is to have a number of #ifdef and complex > > > Kconfig dependencies for the driver to only register the > > > device_driver objects for the buses that are enabled. This > > > is also doable, but

Re: [RFC 2/5] i3c: Add core I3C infrastructure

On Tue, 1 Aug 2017 15:34:14 +0200 Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > On Tue, 1 Aug 2017 15:11:44 +0200 > Arnd Bergmann <a...@arndb.de> wrote: > > > On Tue, Aug 1, 2017 at 2:29 PM, Boris Brezillon > > <boris.brezil...@free-electro

Re: [RFC 2/5] i3c: Add core I3C infrastructure

On Tue, 1 Aug 2017 15:11:44 +0200 Arnd Bergmann <a...@arndb.de> wrote: > On Tue, Aug 1, 2017 at 2:29 PM, Boris Brezillon > <boris.brezil...@free-electrons.com> wrote: > > On Tue, 1 Aug 2017 14:00:05 +0200 > > Arnd Bergmann <a...@arndb.de> wrote: > > &g

  1   2   >