[PATCH] switchdev: documentation: minor typo fixes

2017-08-20 Thread Chris Packham
Two typos in switchdev.txt Signed-off-by: Chris Packham <chris.pack...@alliedtelesis.co.nz> --- Documentation/networking/switchdev.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt

[PATCH] switchdev: documentation: minor typo fixes

2017-08-17 Thread Chris Packham
Two typos in switchdev.txt Signed-off-by: Chris Packham <chris.pack...@alliedtelesis.co.nz> --- Documentation/networking/switchdev.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt

Re: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

2017-05-16 Thread Chris Packham
On 17/05/17 15:09, Ye Xiaolong wrote: > On 05/16, Chris Packham wrote: >> On 16/05/17 20:23, kbuild test robot wrote: >>> Hi Chris, >>> >>> [auto build test ERROR on hwmon/hwmon-next] >>> [also build test ERROR on v4.12-rc1 next-20170516] >>> [

Re: [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

2017-05-16 Thread Chris Packham
> https://github.com/0day-ci/linux/commits/Chris-Packham/hwmon-adt7475-fan-stall-prevention/20170515-093530 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git > hwmon-next > config: x86_64-rhel (attached as .config) > compiler: gcc-6 (

[PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

2017-05-14 Thread Chris Packham
When enabled temperature smoothing allows ramping the fan speed over a configurable period of time instead of jumping to the new speed instantaneously. Signed-off-by: Chris Packham <chris.pack...@alliedtelesis.co.nz> --- Changes in v2: - use a single tempN_smoothing attribute Changes

Re: [PATCH v3 3/4] hwmon: (adt7475) temperature smoothing

2017-05-14 Thread Chris Packham
On 15/05/17 03:40, Guenter Roeck wrote: > On 05/10/2017 08:45 PM, Chris Packham wrote: >> When enabled temperature smoothing allows ramping the fan speed over a >> configurable period of time instead of jumping to the new speed >> instantaneously. >> >> Signed-

Re: [PATCH v3 2/4] hwmon: (adt7475) fan stall prevention

2017-05-14 Thread Chris Packham
On 15/05/17 02:54, Guenter Roeck wrote: > On 05/10/2017 08:45 PM, Chris Packham wrote: >> By default adt7475 will stop the fans (pwm duty cycle 0%) when the >> temperature drops past Tmin - hysteresis. Some systems want to keep the >> fans moving even when the temperature d

[PATCH v3 2/4] hwmon: (adt7475) fan stall prevention

2017-05-10 Thread Chris Packham
at the minimum configure pwm duty cycle. Signed-off-by: Chris Packham <chris.pack...@alliedtelesis.co.nz> --- Changes in v2: - use pwmN_stall_dis as the attribute name. I think this describes the purpose pretty well. I went with a new attribute instead of overloading pwmN_auto_point1_pwm so this d

[PATCH v3 3/4] hwmon: (adt7475) temperature smoothing

2017-05-10 Thread Chris Packham
When enabled temperature smoothing allows ramping the fan speed over a configurable period of time instead of jumping to the new speed instantaneously. Signed-off-by: Chris Packham <chris.pack...@alliedtelesis.co.nz> --- Changes in v2: - use a single tempN_smoothing attribute Changes

Re: [RFC PATCH v2 3/3] hwmon: (adt7475) temperature smoothing

2017-05-03 Thread Chris Packham
On 04/05/17 04:30, Guenter Roeck wrote: > On Wed, May 03, 2017 at 12:40:09PM +1200, Chris Packham wrote: >> When enabled temperature smoothing allows ramping the fan speed over a >> configurable period of time instead of jumping to the new speed >> instantaneously. >&

Re: [RFC PATCH v2 2/3] hwmon: (adt7475) fan stall prevention

2017-05-03 Thread Chris Packham
On 04/05/17 04:10, Guenter Roeck wrote: > On Wed, May 03, 2017 at 12:40:08PM +1200, Chris Packham wrote: >> By default adt7475 will stop the fans (pwm duty cycle 0%) when the >> temperature drops past Tmin - hysteresis. Some systems want to keep the >> fans moving even when

Re: [RFC PATCH v2 3/3] hwmon: (adt7475) temperature smoothing

2017-05-03 Thread Chris Packham
On 03/05/17 12:40, Chris Packham wrote: > When enabled temperature smoothing allows ramping the fan speed over a > configurable period of time instead of jumping to the new speed > instantaneously. > > Signed-off-by: Chris Packham <chris.pack...@alliedtelesis.co.nz> > ---

[RFC PATCH v2 3/3] hwmon: (adt7475) temperature smoothing

2017-05-02 Thread Chris Packham
When enabled temperature smoothing allows ramping the fan speed over a configurable period of time instead of jumping to the new speed instantaneously. Signed-off-by: Chris Packham <chris.pack...@alliedtelesis.co.nz> --- Changes in v2: - use a single tempN_smoothing attribute Documen

[RFC PATCH v2 2/3] hwmon: (adt7475) fan stall prevention

2017-05-02 Thread Chris Packham
at the minimum configure pwm duty cycle. Signed-off-by: Chris Packham <chris.pack...@alliedtelesis.co.nz> --- Changes in v2: - use pwmN_stall_dis as the attribute name. I think this describes the purpose pretty well. I went with a new attribute instead of overloading pwmN_auto_point1_pwm so this d

Re: [PATCH 2/3] hwmon: (adt7475) fan stall prevention

2017-05-02 Thread Chris Packham
On 03/05/17 06:07, Guenter Roeck wrote: > On Tue, May 02, 2017 at 05:45:35PM +1200, Chris Packham wrote: >> By default adt7475 will stop the fans (pwm duty cycle 0%) when the >> temperature drops past Tmin - hysteresis. Some systems want to keep the >> fans moving even when

Re: [RFC PATCH 3/3] hwmon: (adt7475) temperature smoothing

2017-05-02 Thread Chris Packham
On 03/05/17 07:14, Guenter Roeck wrote: > On Tue, May 02, 2017 at 05:45:36PM +1200, Chris Packham wrote: >> When enabled temperature smoothing allows ramping the fan speed over a >> configurable period of time instead of jumping to the new speed >> instantaneously. >&

[PATCH 2/3] hwmon: (adt7475) fan stall prevention

2017-05-01 Thread Chris Packham
at the minimum configure pwm duty cycle. Signed-off-by: Chris Packham <chris.pack...@alliedtelesis.co.nz> --- pwmN_min is a horrible name but I really can't think of anything better. I'm biased a little because that is essentially the name of the bits in the datasheet. I'm open to suggestions. Documen

[RFC PATCH 3/3] hwmon: (adt7475) temperature smoothing

2017-05-01 Thread Chris Packham
When enabled temperature smoothing allows ramping the fan speed over a configurable period of time instead of jumping to the new speed instantaneously. Signed-off-by: Chris Packham <chris.pack...@alliedtelesis.co.nz> --- Documentation/hwmon/adt7475 | 5 ++ drivers/hwmon/adt7475.c

[PATCH] docs: hwmon: Fix typo "Microship" should be "Microchip"

2017-02-21 Thread Chris Packham
Signed-off-by: Chris Packham <chris.pack...@alliedtelesis.co.nz> --- Documentation/hwmon/tc654 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/hwmon/tc654 b/Documentation/hwmon/tc654 index 91a2843f5f98..47636a8077b4 100644 --- a/Documentation/hwmon/tc654

Re: [PATCHv4] hwmon: Add tc654 driver

2016-10-12 Thread Chris Packham
On 10/13/2016 02:03 AM, Guenter Roeck wrote: > On Tue, Oct 11, 2016 at 10:26:31AM +1300, Chris Packham wrote: >> > Add support for the tc654 and tc655 fan controllers from Microchip. >> > >> > http://ww1.microchip.com/downloads/en/DeviceDoc/20001734C.pdf >>

[PATCHv4] hwmon: Add tc654 driver

2016-10-10 Thread Chris Packham
Add support for the tc654 and tc655 fan controllers from Microchip. http://ww1.microchip.com/downloads/en/DeviceDoc/20001734C.pdf Signed-off-by: Chris Packham <chris.pack...@alliedtelesis.co.nz> --- Changes in v4: - tab-align values in #defines - ensure locking in set_pwm covers updating

Re: [PATCHv3] hwmon: Add tc654 driver

2016-10-10 Thread Chris Packham
On 10/11/2016 02:22 AM, Guenter Roeck wrote: >> +if (val) >> > + data->config |= TC654_REG_CONFIG_DUTYC; >> > + else >> > + data->config &= ~TC654_REG_CONFIG_DUTYC; > I just realized that this won't work as intended. Problem is that you > only fill data->config when reading

[PATCHv3] hwmon: Add tc654 driver

2016-10-09 Thread Chris Packham
Add support for the tc654 and tc655 fan controllers from Microchip. http://ww1.microchip.com/downloads/en/DeviceDoc/20001734C.pdf Signed-off-by: Chris Packham <chris.pack...@alliedtelesis.co.nz> --- Changes in v3: - typofix in documentation - add missing value to tc654_pwm_map, re-generate

Re: [PATCHv2] hwmon: Add tc654 driver

2016-10-09 Thread Chris Packham
Hi Gunter, Thanks for the review. v3 on it's way some responses below. On 10/08/2016 07:29 AM, Guenter Roeck wrote: > On Fri, Oct 07, 2016 at 02:38:44PM +1300, Chris Packham wrote: >> Add support for the tc654 and tc655 fan controllers from Microchip. >> >> http://ww1.micro

[PATCHv2] hwmon: Add tc654 driver

2016-10-06 Thread Chris Packham
Add support for the tc654 and tc655 fan controllers from Microchip. http://ww1.microchip.com/downloads/en/DeviceDoc/20001734C.pdf Signed-off-by: Chris Packham <chris.pack...@alliedtelesis.co.nz> --- Changes in v2: - Add Documentation/hwmon/tc654 - Incorporate most of the review comment