Re: kernel-doc unbuildable with sphinx 1.7

2018-03-02 Thread Jiri Slaby
On 03/02/2018, 03:34 PM, Jonathan Corbet wrote:
> I got a patch from Takashi this very morning for that problem; I guess
> I'll have to fast-track it Linusward.

Oh, thanks!

P.S.: Takashi, could you push it to our master & stable branches?

-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


kernel-doc unbuildable with sphinx 1.7

2018-03-02 Thread Jiri Slaby
Hi,

in openSUSE, sphinx was updated to 1.7.1 and kernel-doc cannot be built
since that time:
Running Sphinx v1.7.1

Extension error:
Could not import extension kerneldoc (exception: cannot import name
'Directive')

It is because sphinx.util.compat.* was removed from sphinx in 1.7 since
it was deprecated for a long time:
"sphinx.util.compat.%s is deprecated and will be removed "
   "in Sphinx 1.7, please use docutils' instead."


Could you fix that up? python is not my favourite interpreter so fixing
it myself is not feasible on my side.

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 7/7] vgacon: remove prehistoric macros

2016-10-03 Thread Jiri Slaby
These macros:
* CAN_LOAD_EGA_FONTS
* CAN_LOAD_PALETTE
* TRIDENT_GLITCH
* VGA_CAN_DO_64KB
* SLOW_VGA
are either always set or always unset. They come from the linux 2.1
times. And given nobody switched them to some configurable options, I
assume nobody actually uses them.

So remove the macros and leave in place appropriate branches of the
conditional code.

Signed-off-by: Jiri Slaby <jsl...@suse.cz>
Cc: Tomi Valkeinen <tomi.valkei...@ti.com>
Cc: <linux-fb...@vger.kernel.org>
Cc: <linux-doc@vger.kernel.org>
---
 Documentation/VGA-softcursor.txt | 12 --
 drivers/video/console/vgacon.c   | 49 
 2 files changed, 5 insertions(+), 56 deletions(-)

diff --git a/Documentation/VGA-softcursor.txt b/Documentation/VGA-softcursor.txt
index 70acfbf399eb..2ea8968b64a6 100644
--- a/Documentation/VGA-softcursor.txt
+++ b/Documentation/VGA-softcursor.txt
@@ -2,13 +2,11 @@ Software cursor for VGAby Pavel Machek 
<pa...@atrey.karlin.mff.cuni.cz>
 ===and Martin Mares <m...@atrey.karlin.mff.cuni.cz>
 
Linux now has some ability to manipulate cursor appearance. Normally, you
-can set the size of hardware cursor (and also work around some ugly bugs in
-those miserable Trident cards--see #define TRIDENT_GLITCH in drivers/video/
-vgacon.c). You can now play a few new tricks:  you can make your cursor look
-like a non-blinking red block, make it inverse background of the character it's
-over or to highlight that character and still choose whether the original
-hardware cursor should remain visible or not.  There may be other things I have
-never thought of.
+can set the size of hardware cursor. You can now play a few new tricks:  you
+can make your cursor look like a non-blinking red block, make it inverse
+background of the character it's over or to highlight that character and still
+choose whether the original hardware cursor should remain visible or not.
+There may be other things I have never thought of.
 
The cursor appearance is controlled by a "[?1;2;3c" escape sequence
 where 1, 2 and 3 are parameters described below. If you omit any of them,
diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
index d13d5d372604..c22a56232b7c 100644
--- a/drivers/video/console/vgacon.c
+++ b/drivers/video/console/vgacon.c
@@ -60,15 +60,6 @@ static struct vgastate vgastate;
 
 #define BLANK 0x0020
 
-#define CAN_LOAD_EGA_FONTS /* undefine if the user must not do this */
-#define CAN_LOAD_PALETTE   /* undefine if the user must not do this */
-
-/* You really do _NOT_ want to define this, unless you have buggy
- * Trident VGA which will resize cursor when moving it between column
- * 15 & 16. If you define this and your VGA is OK, inverse bug will
- * appear.
- */
-#undef TRIDENT_GLITCH
 #define VGA_FONTWIDTH   8   /* VGA does not support fontwidths != 8 */
 /*
  *  Interface used by the world
@@ -157,18 +148,10 @@ static inline void write_vga(unsigned char reg, unsigned 
int val)
 * handlers, thus the write has to be IRQ-atomic.
 */
raw_spin_lock_irqsave(_lock, flags);
-
-#ifndef SLOW_VGA
v1 = reg + (val & 0xff00);
v2 = reg + 1 + ((val << 8) & 0xff00);
outw(v1, vga_video_port_reg);
outw(v2, vga_video_port_reg);
-#else
-   outb_p(reg, vga_video_port_reg);
-   outb_p(val >> 8, vga_video_port_val);
-   outb_p(reg + 1, vga_video_port_reg);
-   outb_p(val & 0xff, vga_video_port_val);
-#endif
raw_spin_unlock_irqrestore(_lock, flags);
 }
 
@@ -426,18 +409,6 @@ static const char *vgacon_startup(void)
request_resource(_resource,
 _console_resource);
 
-#ifdef VGA_CAN_DO_64KB
-   /*
-* get 64K rather than 32K of video RAM.
-* This doesn't actually work on all "VGA"
-* controllers (it seems like setting MM=01
-* and COE=1 isn't necessarily a good idea)
-*/
-   vga_vram_base = 0xa;
-   vga_vram_size = 0x1;
-   outb_p(6, VGA_GFX_I);
-   outb_p(6, VGA_GFX_D);
-#endif
/*
 * Normalise the palette registers, to point
 * the 16 screen colours to the first 16
@@ -627,11 +598,6 @@ static void vgacon_set_cursor_size(int xpos, int from, int 
to)
unsigned long flags;
int curs, cure;
 
-#ifdef TRIDENT_GLITCH
-   if (xpos < 16)
-   from--, to--;
-#endif
-
if ((from == cursor_size_lastfrom) && (to == cursor_size_lastto))
return;
cursor_si