Re: [PATCH v5 32/32] x86/mm: Add support to make use of Secure Memory Encryption

2017-05-19 Thread Josh Poimboeuf
On Fri, May 19, 2017 at 01:30:05PM +0200, Borislav Petkov wrote: > > it is called so early. I can get past it by adding: > > > > CFLAGS_mem_encrypt.o := $(nostackp) > > > > in the arch/x86/mm/Makefile, but that obviously eliminates the support > > for the whole file. Would it be better to split

Re: [PATCH] Documentation/livepatch: remove the limitation for schedule() patching

2017-01-09 Thread Josh Poimboeuf
On Mon, Jan 09, 2017 at 01:50:19PM +0100, Miroslav Benes wrote: > There is still one thing which I don't understand. Why __schedule() > (patched or the original) is not on the stack. The actual "sleep" > should happen in __switch_to_asm() which is C function now. And there is a > call to

Re: [PATCH] Documentation/livepatch: remove the limitation for schedule() patching

2017-01-06 Thread Josh Poimboeuf
> > Of course __switch_to_asm() is not patchable for the reason described in > the section. But there is no __fentry__ call and I cannot imagine a > reason to do it anyway. > > Therefore, remove the paragraphs from the section. > > Signed-off-by: Miroslav Benes <mbe.

Re: livepatch: reuse module loader code to write relocations

2016-03-21 Thread Josh Poimboeuf
On Mon, Mar 21, 2016 at 10:16:17PM +0100, Jiri Kosina wrote: > On Mon, 21 Mar 2016, Jessica Yu wrote: > > > Yes, this is a concern and I'm not sure what the best way to fix it > > is. If both MODULE_NAME_LEN and KSYM_NAME_LEN were straight up > > constants, then I think Josh's stringify approach

Re: [PATCH v5 4/6] livepatch: reuse module loader code to write relocations

2016-03-21 Thread Josh Poimboeuf
On Mon, Mar 21, 2016 at 11:46:51AM -0500, Josh Poimboeuf wrote: > On Mon, Mar 21, 2016 at 05:31:57PM +0100, Petr Mladek wrote: > > > diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c > > > index 780f00c..2aa20fa 100644 > > > --- a/kernel/livepatch/core.

Re: [PATCH v5 2/6] module: preserve Elf information for livepatch modules

2016-03-21 Thread Josh Poimboeuf
On Wed, Mar 16, 2016 at 03:47:04PM -0400, Jessica Yu wrote: > For livepatch modules, copy Elf section, symbol, and string information > from the load_info struct in the module loader. Persist copies of the > original symbol table and string table. > > Livepatch manages its own relocation sections

Re: [RFC PATCH v4 2/6] module: preserve Elf information for livepatch modules

2016-02-08 Thread Josh Poimboeuf
On Wed, Feb 03, 2016 at 08:11:07PM -0500, Jessica Yu wrote: > For livepatch modules, copy Elf section, symbol, and string information > from the load_info struct in the module loader. Persist copies of the > original symbol table and string table. > > Livepatch manages its own relocation sections

Re: module: s390: keep mod_arch_specific for livepatch modules

2016-02-04 Thread Josh Poimboeuf
On Wed, Feb 03, 2016 at 08:37:52PM -0500, Jessica Yu wrote: > +++ Jessica Yu [03/02/16 20:11 -0500]: > >Livepatch needs to utilize the symbol information contained in the > >mod_arch_specific struct in order to be able to call the s390 > >apply_relocate_add() function to apply relocations. Keep a