RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-11-19 Thread Levy, Amir (Jer)
On Fri, Nov 18 2016, 12:07 PM, gre...@linuxfoundation.org wrote: > On Fri, Nov 18, 2016 at 08:48:36AM +0000, Levy, Amir (Jer) wrote: > > > BTW, it is quite a shame that the Thunderbolt firmware version can't > > > be read from Linux. > > > > > > > This is

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-11-18 Thread Levy, Amir (Jer)
On Tue, Nov 15 2016, 12:59 PM, Simon Guinot wrote: > On Wed, Nov 09, 2016 at 03:42:53PM +0000, Levy, Amir (Jer) wrote: > > On Wed, Nov 9 2016, 04:36 PM, Simon Guinot wrote: > > > Hi Amir, > > > > > > I have an ASUS "All Series/Z87-DELUXE/QUAD" motherb

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-11-10 Thread Levy, Amir (Jer)
On Thu, Nov 10 2016, 01:44 PM, Greg KH wrote: > On Thu, Nov 10, 2016 at 11:39:19AM +0000, Levy, Amir (Jer) wrote: > > > And how about getting some internal-Intel kernel developers to > > > review and sign-off on this code? Don't make the community do the > > &g

RE: [PATCH v9 7/8] thunderbolt: Networking doc

2016-11-10 Thread Levy, Amir (Jer)
On Wed, Nov 9 2016, 06:00 PM, Greg KH wrote: > On Wed, Nov 09, 2016 at 04:20:07PM +0200, Amir Levy wrote: > > Adding Thunderbolt(TM) networking documentation. > > > > Signed-off-by: Amir Levy > > --- > > Documentation/00-INDEX | 2 + > >

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-11-10 Thread Levy, Amir (Jer)
On Wed, Nov 9 2016, 06:02 PM, Greg KH wrote: > On Wed, Nov 09, 2016 at 04:20:00PM +0200, Amir Levy wrote: > > This driver enables Thunderbolt Networking on non-Apple platforms > > running Linux. > > > > Thunderbolt Networking provides peer-to-peer connections to transfer > > files between

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-11-09 Thread Levy, Amir (Jer)
On Wed, Nov 9 2016, 04:36 PM, Simon Guinot wrote: > On Wed, Nov 09, 2016 at 04:20:00PM +0200, Amir Levy wrote: > > This driver enables Thunderbolt Networking on non-Apple platforms > > running Linux. > > > > Thunderbolt Networking provides peer-to-peer connections to transfer > > files between

RE: [PATCH v8 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-09-30 Thread Levy, Amir (Jer)
On Fri, Sep 30 2016, 09:40 AM, David Miller wrote: > From: Greg KH > Date: Fri, 30 Sep 2016 08:30:05 +0200 > > > On Fri, Sep 30, 2016 at 01:55:55AM -0400, David Miller wrote: > >> From: Amir Levy > >> Date: Wed, 28 Sep 2016 17:44:22 +0300 >

RE: [PATCH v6 2/8] thunderbolt: Updating the register definitions

2016-09-11 Thread Levy, Amir (Jer)
On Sun, Sep 11 2016, 03:02 AM, Andreas Noever wrote: > On Mon, Aug 1, 2016 at 2:23 PM, Amir Levy wrote: > > Adding more Thunderbolt(TM) register definitions and some helper > > macros. > > Thinking about this again I would prefer it if you would put your definitions >

RE: [PATCH v5 6/8] thunderbolt: Networking transmit and receive

2016-07-31 Thread Levy, Amir (Jer)
On Sun, Jul 31 2016, 09:45 PM, David Miller wrote: > From: "Levy, Amir (Jer)" <amir.jer.l...@intel.com> > Date: Sun, 31 Jul 2016 10:15:52 + > > > The network stack thinks it is Ethernet, it might not accept Runt > > frames, so the driver pads the fra

RE: [PATCH v5 4/8] thunderbolt: Communication with the ICM (firmware)

2016-07-31 Thread Levy, Amir (Jer)
On Sat, Jul 30 2016, 12:03 AM, Stephen Hemminger wrote: > On Thu, 28 Jul 2016 11:15:17 +0300 > Amir Levy wrote: > > > +int nhi_send_message(struct tbt_nhi_ctxt *nhi_ctxt, enum pdf_value > pdf, > > +u32 msg_len, const u8 *msg, bool ignore_icm_resp) { > >

RE: [PATCH v5 5/8] thunderbolt: Networking state machine

2016-07-31 Thread Levy, Amir (Jer)
On Thu, Jul 28 2016, 02:35 PM, Lukas Wunner wrote: > On Thu, Jul 28, 2016 at 11:15:18AM +0300, Amir Levy wrote: > > + nhi_ctxt->net_devices[ > > + port_num].medium_sts = > > Looks like a carriage return slipped in here. Will be fixed.

RE: [PATCH v5 4/8] thunderbolt: Communication with the ICM (firmware)

2016-07-31 Thread Levy, Amir (Jer)
On Sat, Jul 30 2016, 12:48 AM, Greg KH wrote: > On Fri, Jul 29, 2016 at 02:02:24PM -0700, Stephen Hemminger wrote: > > On Thu, 28 Jul 2016 11:15:17 +0300 > > Amir Levy wrote: > > > > > +static LIST_HEAD(controllers_list); static > > >

RE: [PATCH v5 6/8] thunderbolt: Networking transmit and receive

2016-07-31 Thread Levy, Amir (Jer)
On Sat, Jul 30 2016, 12:07 AM, Stephen Hemminger wrote: > On Thu, 28 Jul 2016 11:15:19 +0300 > Amir Levy wrote: > > > + /* pad short packets */ > > + if (unlikely(skb->len < ETH_ZLEN)) { > > + int pad_len = ETH_ZLEN - skb->len; > > +