Re: [PATCH v2] gpiolib: add hogs support for machine code

2018-05-02 Thread Linus Walleij
On Thu, Apr 26, 2018 at 6:42 PM, Bartosz Golaszewski <b...@bgdev.pl> wrote: > 2018-04-26 14:07 GMT+02:00 Linus Walleij <linus.wall...@linaro.org>: >> On Tue, Apr 10, 2018 at 10:30 PM, Bartosz Golaszewski <b...@bgdev.pl> wrote: >> >>> Board files

Re: [PATCH v2] gpiolib: add hogs support for machine code

2018-04-26 Thread Linus Walleij
g: unable to hog GPIO line $LABEL $GPIONR -517" error > for every single gpio-hog and wonder why :(. Hm maybe we can simply improbe the error messages so people realize they have to go and fix their pin control driver(s)? OK maybe a bit whimsical comment from me here... :/ Yours, Linus Walle

Re: [PATCH v2] gpiolib: add hogs support for machine code

2018-04-26 Thread Linus Walleij
t I bet you intend to follow up with some machine patches and then it is immediately worth it. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 09/10] gpio: Add a driver for Cadence I3C GPIO expander

2018-04-26 Thread Linus Walleij
you to get this code into the kernel, so: Acked-by: Linus Walleij <linus.wall...@linaro.org> The following is an observation for future improvement: > +static int cdns_i3c_gpio_read_reg(struct cdns_i3c_gpio *gpioc, u8 reg, > + u8 *val) > +{

Re: [PATCH v1 1/1] misc: IBM Virtual Management Channel Driver

2018-04-25 Thread Linus Walleij
If some specific domain knowledge is needed to read and understand the document, you need to state these prerequisites at the beginning of the document. Something like: "if you don't know a lot about virtualization already, then don't even bother trying to read this document". Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/8] Move most GPIO documentation to driver-api/gpio/ and ReST

2018-03-22 Thread Linus Walleij
> Documentation: gpio: Move drivers-on-gpio.txt to driver-api I applied all 8 patches to devel for v4.17. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/8] Move most GPIO documentation to driver-api/gpio/ and ReST

2018-03-10 Thread Linus Walleij
to take these through the docs tree or see them go via > GPIO; Linus, what's your preference? I might have some doc patches that could collide so I can take them. I take it there will be a v2? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc

Re: [RFC PATCH 3/5] gpio: gpiolib: Add chardev support for maintaining GPIO values on reset

2017-10-31 Thread Linus Walleij
the user likely has an idea about the whole system that is comprehensive. They use the random raspberry Pi (etc) development board for this. OK. When we are talking about adding GPIO in mass-market goods such as phones and tablets and laptops userspace GPIO access become more and more dubious. Yours, Lin

Re: [RFC PATCH 1/5] gpio: gpiolib: Add core support for maintaining GPIO values on reset

2017-10-20 Thread Linus Walleij
On Fri, Oct 20, 2017 at 9:17 AM, Linus Walleij <linus.wall...@linaro.org> wrote: > On Fri, Oct 20, 2017 at 5:37 AM, Andrew Jeffery <and...@aj.id.au> wrote: > >> GPIO state reset tolerance is implemented in gpiolib through the >> addition of a new pinconf param

Re: [RFC PATCH 4/5] gpio: gpiolib: Add sysfs support for maintaining GPIO values on reset

2017-10-20 Thread Linus Walleij
cumentation/ABI/obsolete/sysfs-gpio that's why. This is being phased out and should not be extended. Everyone should use the character device, especially for new functionality. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message

Re: [RFC PATCH 3/5] gpio: gpiolib: Add chardev support for maintaining GPIO values on reset

2017-10-20 Thread Linus Walleij
o assume persistance for userspace use cases, don't you think? Whether the system goes to sleep or the gpiochip resets should not make a door suddenly close or the lights in the christmas tree go out, right? I think if the gpiochip supports persistance of any kind, we should try to use it and not

Re: [RFC PATCH 2/5] gpio: gpiolib: Add OF support for maintaining GPIO values on reset

2017-10-20 Thread Linus Walleij
Now you're mixing up decimal and hex. Anyways, I do not think this is necessary. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 1/5] gpio: gpiolib: Add core support for maintaining GPIO values on reset

2017-10-20 Thread Linus Walleij
ster bits (or similar) where you can select to preserve across sleep, reset, one or the other, AND there is also a usecase such that a user wants to preserve the value across reset but not suspend or vice versa. I suspect that will not happen. Yours, Linus Walleij -- To unsubscribe from thi

Re: [PATCH 8/8] Documentation: fix ref to gpio.txt

2017-10-16 Thread Linus Walleij
On Thu, Oct 12, 2017 at 10:24 PM, Tom Saeger <tom.sae...@oracle.com> wrote: > Signed-off-by: Tom Saeger <tom.sae...@oracle.com> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to major

Re: [PATCH v3 3/3] gpio: mockup: use irq_sim

2017-08-20 Thread Linus Walleij
than Cameron <jonathan.came...@huawei.com> > Reviewed-by: Linus Walleij <linus.wall...@linaro.org> I applied this to the GPIO tree after pulling the infrastructure from Thomas branch. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH v4 0/3] simulated interrupts

2017-08-20 Thread Linus Walleij
it/tip/tip.git irq/for-gpio Awesome, thanks Thomas. I pulled this into the GPIO devel branch. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC 2/5] i3c: Add core I3C infrastructure

2017-08-17 Thread Linus Walleij
do otherwise is complain "it is broken" and then they start to hack around it instead of helping out with the core. (I think you're well aware of that phenomenon.) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message t

Re: [PATCH v2 3/3] gpio: mockup: use irq_sim

2017-08-13 Thread Linus Walleij
On Tue, Aug 1, 2017 at 4:50 PM, Bartosz Golaszewski <b...@bgdev.pl> wrote: > Shrink the driver by removing the code dealing with dummy interrupts > and replacing it with calls to the irq_sim API. > > Signed-off-by: Bartosz Golaszewski <b...@bgdev.pl> Reviewed-by: L

Re: [PATCH] pinctrl: generic: update references to Documentation/pinctrl.txt

2017-08-07 Thread Linus Walleij
.@o2linux.fr> > Fixes: 5a9b73832e9e ("pinctrl.txt: move it to the driver-api book") Patch applied for fixes. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] gpio: mockup: use irq_sim

2017-08-02 Thread Linus Walleij
On Wed, Jul 19, 2017 at 2:20 PM, Bartosz Golaszewski <b...@bgdev.pl> wrote: > Shrink the driver by removing the code dealing with dummy interrupts > and replacing it with calls to the irq_sim API. > > Signed-off-by: Bartosz Golaszewski <b...@bgdev.pl> Reviewed-by: L

Re: [PATCH 0/3] simulated interrupts

2017-08-02 Thread Linus Walleij
ally GPIO(-ish) lines are armed and the system put to sleep, and when it comes up, the information of what line woke it up is there in a special register, but the actual (synchronous) interrupt line is no longer asserted or edge triggered, so an interrupt need to be inserted. Yours, Linus Walleij -

Re: [PATCH 01/29] pinctrl.txt: standardize document format

2017-06-20 Thread Linus Walleij
On Sat, Jun 17, 2017 at 5:03 PM, Mauro Carvalho Chehab <mche...@s-opensource.com> wrote: > Linus Walleij <linus.wall...@linaro.org> escreveu: >> Should the file be renamed pinctrl.rst now? > > If you just rename it, Sphinx will complain because it doesn't >

Re: [PATCH v3 06/10] pinctrl: sunxi: add support of R40 to A10 pinctrl driver

2017-05-29 Thread Linus Walleij
at I need to apply and what I can ignore. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 05/10] dt-bindings: add compatible string for Allwinner R40 pinctrl

2017-05-29 Thread Linus Walleij
> Signed-off-by: Icenowy Zheng <icen...@aosc.io> > Acked-by: Rob Herring <r...@kernel.org> > --- > Changes in v3: > - Added Rob's ACK. Patch applied with Chen-Yu's review tag. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc&quo

Re: [PATCH v3 04/10] pinctrl: sunxi: drop dedicated A20 driver

2017-05-29 Thread Linus Walleij
Changes in v3: > - Only remove the A20 driver(A10 driver for A20 is enabled in > the previous commit now). Patch applied with Chen-Yu's review tag, and I also fixed up the Makefile by removing the rule for this file. Yours, Linus Walleij -- To unsubscribe from this list: send the line

Re: [PATCH v3 03/10] pinctrl: sunxi: add A20 support to A10 driver

2017-05-29 Thread Linus Walleij
y Zheng <icen...@aosc.io> > --- > Changes in v3: > - Enable A10 driver for A20 and disable A20 driver in this commit, in > order to prevent A10 driver from conflicting with A20 driver. Patch applied with Chen-Yu's review tag. Yours, Linus Walleij -- To unsubscribe from this list: send th

Re: [PATCH v3 02/10] pinctrl: sunxi: Add SoC ID definitions for A10, A20 and R40 SoCs

2017-05-29 Thread Linus Walleij
-by: Icenowy Zheng <icen...@aosc.io> > --- > Changes in v3: > - Commit message change. Patch applied with Chen-Yu's review tag. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.o

Re: [PATCH 01/29] pinctrl.txt: standardize document format

2017-05-23 Thread Linus Walleij
@s-opensource.com> I applied the patch fixing some of the indentation mistakes pointed out by Geert. Should the file be renamed pinctrl.rst now? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.ker

Re: [PATCH v2 00/10] Initial Allwinner R40 support

2017-05-22 Thread Linus Walleij
fore > R40 support is added into the A10 driver. I'd be happy to merge the pinctrl parts as soon as you fixed the things pointed out during review. Include Rob's ACKs on the DT binding patches please. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc

Re: [PATCH v2 10/10] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Ultra

2017-05-11 Thread Linus Walleij
es on this board like in the other rpi boards, should be something like: { gpio-line-names = "...", "..."; }; This is very helpful for users. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 04/10] pinctrl: sunxi: switch A20's pinctrl driver to use the A10 version

2017-05-11 Thread Linus Walleij
ht to me but I'm waiting for Maxime's review on these patches. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/5] pinctrl: sunxi: add driver for V3s SoC

2017-01-11 Thread Linus Walleij
On Tue, Jan 3, 2017 at 4:16 PM, Icenowy Zheng <icen...@aosc.xyz> wrote: > V3s SoC features only a pin controller (for the lack of CPUs part). > > Add a driver for this controller. > > Signed-off-by: Icenowy Zheng <icen...@aosc.xyz> Patch applied with Maxime's

Re: [PATCH 1/2] ABI: rtc-ab8500: fix rtc_calibration documentation

2016-10-29 Thread Linus Walleij
On Sat, Oct 29, 2016 at 12:10 PM, Mauro Carvalho Chehab <mche...@s-opensource.com> wrote: > The "What:" field at the ABI should describe the location of > the ABI, e. g. the position under a mounted sysfs. > > Fix it. > > Cc: Mark Godfrey <mark.godf..

Re: [PATCH] regulator/overview.txt: Use ".." for ranges, instead of "->"

2016-10-10 Thread Linus Walleij
On Mon, Oct 3, 2016 at 10:45 AM, Pavel Machek <pa...@ucw.cz> wrote: > Using "->" to indicate range is not too common, switch to ".." > > Signed-off-by: Pavel Machek <pa...@ucw.cz> You sent this patch to me... resend it to the regulator maintainer.

Re: [PATCH] gpio/board.txt: point to gpiod_set_value

2016-10-10 Thread Linus Walleij
On Mon, Oct 3, 2016 at 10:43 AM, Pavel Machek <pa...@ucw.cz> wrote: > gpiod_set_value() is preffered interface these days, so add a > pointer. Also fix a missing ). > > Signed-off-by: Pavel Machek <pa...@ucw.cz> Patch applied with some tweaking. Yours, Linus Wallei

Re: [PATCH 4/4] pinctrl.txt: Reflow/wrap paragraph describing GPIO interaction

2016-06-13 Thread Linus Walleij
On Fri, Jun 10, 2016 at 9:16 AM, Andrew Jeffery <and...@aj.id.au> wrote: > Signed-off-by: Andrew Jeffery <and...@aj.id.au> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to major

Re: [PATCH 2/4] pinctrl.txt: Fix grammar in pinmux request list

2016-06-13 Thread Linus Walleij
On Fri, Jun 10, 2016 at 9:16 AM, Andrew Jeffery <and...@aj.id.au> wrote: > Signed-off-by: Andrew Jeffery <and...@aj.id.au> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to major

Re: [PATCH 16/20] mfd: stw481x: Use devm_mfd_add_devices() for mfd_device registration

2016-04-05 Thread Linus Walleij
<ldewan...@nvidia.com> > CC: Linus Walleij <linus.wall...@linaro.org> Acked-by: Linus Walleij <linus.wall...@linaro.org> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kerne

Re: [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister}

2016-03-15 Thread Linus Walleij
Ks on your branch and ask me to pull it after v4.6-rc1. No need to resend the patches. Unfortunately it arrived too late for the merge window, but hey: we got the devm gpiochip in for v4.6. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in th

Re: [PATCH] Documentation: gpio: board: fix GPIO_LOOKUP{,_IDX} documentation

2016-02-25 Thread Linus Walleij
t; > Signed-off-by: Gabor Juhos <juh...@openwrt.org> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister}

2016-02-25 Thread Linus Walleij
ly guess I like this too, so wait a while, collect ACKs and send me a branch to pull for this too. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/61] gpio: Add and use devm_gpiochip_add_data()

2016-02-25 Thread Linus Walleij
ochip I've pulled this branch into my tree on a separate branch for testing. I pushed the tree to kernel.org so that the zeroday autobuilders can have a go at it. If everything goes well I plan to merge this for v4.6, then we can merge the changes in pin control and other subsystems for v4.7. Yo

Re: [PATCH 00/61] gpio: Add and use devm_gpiochip_add_data()

2016-02-22 Thread Linus Walleij
gpio: Add devm_ apis for gpio_chip_add and remove Awesome! Do you have a git I can just pull these off so I don't have to apply then all one-by-one? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger

[PATCH] Documentation: update the devices.txt documentation

2016-02-19 Thread Linus Walleij
Jens Axboe <ax...@kernel.dk> Signed-off-by: Linus Walleij <linus.wall...@linaro.org> --- Greg I guess this can go through the drivercore tree? --- CREDITS | 1 + Documentation/devices.txt | 80 +++ 2 files changed, 26 insertions