Re: [PATCH 2/6] module: use list_for_each_entry_rcu() on find_module_all()

On Thu, 18 May 2017, Luis R. Rodriguez wrote: > The module list has been using RCU in a lot of other calls > for a while now, we just overlooked changing this one over to > use RCU. > > Signed-off-by: Luis R. Rodriguez > --- > kernel/module.c | 2 +- > 1 file changed, 1

Re: [PATCH] Documentation/livepatch: remove the limitation for schedule() patching

On Fri, 6 Jan 2017, Josh Poimboeuf wrote: > On Fri, Jan 06, 2017 at 03:00:45PM +0100, Miroslav Benes wrote: > > > > 2. reversion of the process does not work as expected. The kernel > > crashes after the removal of the module. A task very likely slept in > > sc

Re: [PATCH] Documentation/livepatch: remove the limitation for schedule() patching

On Fri, 6 Jan 2017, Petr Mladek wrote: > On Fri 2017-01-06 15:00:45, Miroslav Benes wrote: > > The Limitations section of the documentation describes the impossibility > > to livepatch anything that is inlined to __schedule() function. This had > > been true till 4.9 kernel c

[PATCH] Documentation/livepatch: remove the limitation for schedule() patching

try__ call and I cannot imagine a reason to do it anyway. Therefore, remove the paragraphs from the section. Signed-off-by: Miroslav Benes <mbe...@suse.cz> --- FWIW, I also tested this to be sure on top of the consistency model patch set. I patched schedule() function which

Re: [PATCH v6 0/5] (mostly) Arch-independent livepatch

On Tue, 22 Mar 2016, Jessica Yu wrote: > v6: > - Since we hard-code the field widths for the objname and symbol name >for the sscanf() calls, which are supposed to correspond to the values >of MODULE_NAME_LEN and KSYM_NAME_LEN, use BUILD_BUG_ON() to detect when >the values of these

Re: [PATCH v5 6/6] Documentation: livepatch: outline Elf format and requirements for patch modules

On Wed, 16 Mar 2016, Jessica Yu wrote: > Document livepatch module requirements and the special Elf constants patch > modules use. > > Signed-off-by: Jessica Yu <j...@redhat.com> Fantastic to have it Acked-by: Miroslav Benes <mbe...@suse.cz> -- To unsubscribe from

Re: [PATCH v5 5/6] samples: livepatch: mark as livepatch module

On Wed, 16 Mar 2016, Jessica Yu wrote: > Mark the module as a livepatch module so that the module loader can > appropriately identify and initialize it. > > Signed-off-by: Jessica Yu <j...@redhat.com> Reviewed-by: Miroslav Benes <mbe...@suse.cz> -- To unsubscribe from

Re: [RFC PATCH v4 4/6] livepatch: reuse module loader code to write relocations

> > +/* .klp.sym.[objname].symbol_name,sympos */ > > +static int klp_get_sym_objname(char *s, char **result) > > +{ > > Do we need result to be a double-pointer? If I am not mistaken just 'char > *result' could be sufficient. You check the return value, so result could > be NULL or objname as

Re: [RFC PATCH v4 4/6] livepatch: reuse module loader code to write relocations

On Tue, 9 Feb 2016, Petr Mladek wrote: > On Wed 2016-02-03 20:11:09, Jessica Yu wrote: > > Reuse module loader code to write relocations, thereby eliminating the need > > for architecture specific relocation code in livepatch. Specifically, reuse > > the apply_relocate_add() function in the

Re: [RFC PATCH v4 0/6] (mostly) Arch-independent livepatch

On Wed, 3 Feb 2016, Jessica Yu wrote: > Jessica Yu (6): > Elf: add livepatch-specific Elf constants > module: preserve Elf information for livepatch modules > module: s390: keep mod_arch_specific for livepatch modules > livepatch: reuse module loader code to write relocations > samples: