,
- attributes (such as aligned) containing numbers were not removed,
- attributes are only cleared from struct fields, not structs themselves.
This patch addresses these issues by removing the attributes.
Signed-off-by: Sakari Ailus
---
scripts/kernel-doc | 7 ---
1 file changed, 4 insertions(+), 3
s simple enough to just declare them, de-obfuscating
> the code.
>
> While here, replace BUG_ON() by WARN_ON() as there's no reason
> why to panic the Kernel if this fails.
>
> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com>
Thanks!
Acked-by: Sakari Ailus <
On Mon, Dec 18, 2017 at 05:27:04PM -0200, Mauro Carvalho Chehab wrote:
> Em Mon, 9 Oct 2017 23:23:56 +0300
> Sakari Ailus <sakari.ai...@iki.fi> escreveu:
>
> > Hi Mauro,
> >
> > On Mon, Oct 09, 2017 at 07:19:21AM -0300, Mauro Carvalho Chehab wrote:
> >
Hi Mauro,
On Tue, Oct 10, 2017 at 08:37:43AM -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 6 Oct 2017 15:48:22 +0300
> Sakari Ailus <sakari.ai...@iki.fi> escreveu:
>
> > Hi Mauro,
> >
> > On Wed, Sep 27, 2017 at 07:23:47PM -0300, Mauro Carvalho Chehab wrote
Hi Mauro,
On Tue, Oct 10, 2017 at 09:49:38AM -0300, Mauro Carvalho Chehab wrote:
> Em Tue, 10 Oct 2017 14:54:35 +0300
> Sakari Ailus <sakari.ai...@iki.fi> escreveu:
>
> > On Tue, Oct 10, 2017 at 06:15:03AM -0300, Mauro Carvalho Chehab wrote:
> > > Em Fri, 6 Oct 20
On Mon, Oct 09, 2017 at 07:19:24AM -0300, Mauro Carvalho Chehab wrote:
> Use the existing macros to identify vb2_io_modes bits.
>
> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com>
Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com>
--
Sakari Ailus
e-mail
.@s-opensource.com>
Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com>
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
gt; + *
> + * .. note::
> + *
> + *The following fields at @q should be set before calling this function:
should -> shall
I bet there's a lot of that in the documentation elsewhere, including this
patch.
--
Kind regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe fr
On Tue, Oct 10, 2017 at 06:15:03AM -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 6 Oct 2017 14:51:06 +0300
> Sakari Ailus <sakari.ai...@iki.fi> escreveu:
>
> > Hi Mauro,
> >
> > On Fri, Oct 06, 2017 at 01:22:29PM +0300, Sakari Ailus wrote:
> > > > +
On Tue, Oct 10, 2017 at 05:30:04AM -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 6 Oct 2017 13:22:29 +0300
> Sakari Ailus <sakari.ai...@iki.fi> escreveu:
>
> > > +Bridge driver
> > > + The same as V4L2 main driver.
> >
> > Not all V4L2 main driv
efines a certain ops.
s/ops/operation/ (or "op").
> + *
> + * @sd: pointer to the v4l2_subdev
> + * @o: name of the element at v4l2_subdev_ops that contains @f.
> + * Each element there groups a set of callbacks functions.
How about:
@o: The group of callback functions in v4l2_subd
flags, as defined by v4l2_subdev_flags.
> *
> * @v4l2_dev: pointer to struct _device
Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com>
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a
its right place.
>
> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com>
For patches 10--14:
Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com>
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-d
mpose(struct v4l2_subdev *sd,
> + struct v4l2_subdev_pad_config *cfg,
> + unsigned int pad)
> +{
> + WARN_ON(pad >= sd->entity.num_pads);
> + return [pad].try_compose;
> +}
> #endif
>
> extern const struct v4l2_fil
On Mon, Oct 09, 2017 at 07:19:09AM -0300, Mauro Carvalho Chehab wrote:
> Instead of using (1 << n) for bits, use the BIT() macro,
> as it makes them better documented.
I wouldn't say this makes a difference from documentation point of view.
Anyway,
Acked-by: Sakari Ailu
ash-led-class.h
> +++ b/include/media/v4l2-flash-led-class.h
> @@ -91,12 +91,24 @@ struct v4l2_flash {
> struct v4l2_ctrl **ctrls;
> };
>
> +/**
> + * v4l2_subdev_to_v4l2_flash - Returns a _flash from the
v4l2_flash -> struct v4l2_flash ?
Same below. With these,
A
m
> + * the media_entity embedded on it.
> + *
> + * @entity: pointer to media_entity
> + */
> +#define media_entity_to_video_device(entity) \
> + container_of(entity, struct video_device, entity)
> +
> +/**
> + * media_entity_to_video_device - Returns a vide
media controller API ` before
> +the periferal can be used. For such devices, the sub-devices' configuration
> +can be controlled via the :ref:`sub-device API `, which creates one
> +device node per sub-device.
> +
> .. _v4l2_device_naming:
>
> V4L2 Device Node Naming
--
Hi Mauro,
On Fri, Oct 06, 2017 at 01:22:29PM +0300, Sakari Ailus wrote:
> > +V4L2 device node
> > + A device node that is associated to a V4L2 main driver,
> > + as specified in :ref:`v4l2_device_naming`.
I think we need to name the interface, not so much their ins
y: Hans Verkuil <hans.verk...@cisco.com>
> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com>
Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com>
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linu
We have drivers for things implemented via ISP. However, right now,
> there's no distinction at the driver if the functionality is implemented
> on software (ISP) or in hardware.
>
> >
> > > confusing, as an ISP hardware may actually implement different
> > > fun
On Thu, Oct 05, 2017 at 03:39:29PM -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 5 Oct 2017 11:21:07 +0300
> Sakari Ailus <sakari.ai...@iki.fi> escreveu:
>
> > Hi Mauro,
> >
> > My apologies for the late reply.
> >
> > On Tue, Aug 29, 2017 at
Hi Mauro,
My apologies for the late reply.
On Tue, Aug 29, 2017 at 10:07:50AM -0300, Mauro Carvalho Chehab wrote:
> Em Tue, 29 Aug 2017 10:47:48 +0300
> Sakari Ailus <sakari.ai...@iki.fi> escreveu:
>
> > Hi Mauro,
> >
> > Thanks for the update. A few commen
Hi Mauro,
(Removing the non-list recipients.)
On Fri, Sep 29, 2017 at 06:27:13AM -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 28 Sep 2017 15:09:21 +0300
> Sakari Ailus <sakari.ai...@iki.fi> escreveu:
>
> > Hi Mauro,
> >
> > On Wed, Sep 27, 2017 at 06:46:56PM -
source.com>
Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com>
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ort some subdev-specific
> controls.
>
> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com>
Thanks!
Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com>
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubs
roperty API is just an API.
--
Kind regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
union at async match struct
> media: v4l2-ctrls: document nested members of structs
> media: videobuf2-core: improve kernel-doc markups
> media: media-entity.h: add kernel-doc markups for nested structs
For patches apart form 7 and 13 (see my comments to them):
Acked-by: Sakari Ai
ing buffer/g
With that,
Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com>
> name is, instead, v4l2_kevent;
>
> - Some things are mentioned on both places (with different words),
> others are either on one of the files.
>
> In order to cleanup this mess, put everyt
nterface/MIPI Alliance/
Same below.
Please see:
<URL:https://mipi.org/content/what-does-mipi-stand>
With that,
Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com>
> + * Interface's Camera Serial Interface version 1
> + * (MIPI CSI1) or
There appears to be an issue in using \small in certain cases on Sphinx
1.4 and 1.5. Other format documents don't use \small either, remove it
from here as well.
Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
---
Hi Mauro,
What would you think of this as an alternative ap
not be true. In any case,
> this is not relevant, as udev will take care of it.
>
> So, remove this useless misinformation.
>
> Acked-by: Hans Verkuil <hans.verk...@cisco.com>
> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com>
Acked-by: Sakari Ailus <saka
> + ├── by-id
> + │ └── usb-OmniVision._USB_Camera-B4.04.27.1-video-index0 ->
> ../../video0
> + └── by-path
> + └── pci-:00:14.0-usb-0:2:1.0-video-index0 -> ../../video0
> +
> +
> Many drivers support "video_nr", "radio_nr" o
vice
> + specific settings.
> +
> +.. note::
> +
> + A **vdev-centric** may optionally expose V4L2 sub-devices via
> + :ref:`sub-device API `. In that case, it has to implement
> + the :ref:`media controller API ` as well.
Looks good!
> +
> +
> +
> +.. _v4l2_device_namin
argue. :-D
Could you drop ", although this might change in the future" part? We've
established that there is no use case currently and we could well allow
things in the API that were not allowed before without a specific not in
the spec.
> +
> +
> +.. _v4l2_device_naming:
>
> Device Naming
> =
--
Kind regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mauro,
On Wed, Aug 23, 2017 at 10:42:28AM -0300, Mauro Carvalho Chehab wrote:
> Em Wed, 23 Aug 2017 12:37:30 +0300
> Sakari Ailus <sakari.ai...@iki.fi> escreveu:
>
> > Hi Mauro,
> >
> > Thanks for the patch! Something like this was long due.
> &
availability is better for the user
space, and unlike between video node centric vs. MC-centric, there are
hardly technical reasons (or at least I can't remember one) for doing this.
I remember we had a few of these drivers and the agreement was to add MC
interface to those.
> +
> +
37 matches
Mail list logo
