Re: [PATCH v3 3/4] seccomp: Audit attempts to modify the actions_logged sysctl

2018-05-04 Thread Steve Grubb
On Thursday, May 3, 2018 9:08:14 PM EDT Tyler Hicks wrote: > The decision to log a seccomp action will always be subject to the > value of the kernel.seccomp.actions_logged sysctl, even for processes > that are being inspected via the audit subsystem, in an upcoming patch. > Therefore, we need to

Re: [PATCH v4 2/2] ThunderX2: Add Cavium ThunderX2 SoC UNCORE PMU driver

2018-05-04 Thread Ganapatrao Kulkarni
Hi Mark, On Thu, Apr 26, 2018 at 4:29 PM, Mark Rutland wrote: > Hi, > > On Wed, Apr 25, 2018 at 02:30:47PM +0530, Ganapatrao Kulkarni wrote: >> + >> +/* L3c and DMC has 16 and 8 channels per socket respectively. >> + * Each Channel supports UNCORE PMU device and consists of

Re: [PATCH v4 2/2] ThunderX2: Add Cavium ThunderX2 SoC UNCORE PMU driver

2018-05-04 Thread Robin Murphy
Hi Kim, On 04/05/18 01:30, Kim Phillips wrote: On Tue, 1 May 2018 12:54:05 +0100 Will Deacon wrote: Hi Kim, Hi Will, thanks for responding. On Fri, Apr 27, 2018 at 11:56:25AM -0500, Kim Phillips wrote: On Fri, 27 Apr 2018 17:09:14 +0100 Will Deacon

[PATCH] libata: remove ata_sff_data_xfer_noirq()

2018-05-04 Thread Sebastian Andrzej Siewior
ata_sff_data_xfer_noirq() is invoked via the ->sff_data_xfer hook. The latter is invoked by ata_pio_sector(), atapi_send_cdb() and __atapi_pio_bytes() which in turn is invoked by ata_sff_hsm_move(). The latter function requires that the "ap->lock" lock is held which needs to be taken with disabled

Re: [PATCH v3 0/9] trace_uprobe: Support SDT markers having reference count (semaphore)

2018-05-04 Thread Oleg Nesterov
Sorry Ravi, I saved the new version for review and forgot about it... I'll try to do this on weekend. On 05/03, Ravi Bangoria wrote: > > On 04/17/2018 10:02 AM, Ravi Bangoria wrote: > > Userspace Statically Defined Tracepoints[1] are dtrace style markers > > inside userspace applications.

Re: [PATCH v3 6/9] trace_uprobe: Support SDT markers having reference count (semaphore)

2018-05-04 Thread Ravi Bangoria
Hi Masami, On 05/04/2018 10:18 AM, Masami Hiramatsu wrote: >> +void uprobe_down_write_dup_mmap(void) >> +{ >> +percpu_down_write(_mmap_sem); >> +} >> + >> +void uprobe_up_write_dup_mmap(void) >> +{ >> +percpu_up_write(_mmap_sem); >> +} >> + > I'm not sure why these hunks are not done in

Re: [PATCH] MAINTAINERS & files: Canonize the e-mails I use at files

2018-05-04 Thread Mauro Carvalho Chehab
Em Fri, 04 May 2018 13:58:39 +0300 Jani Nikula escreveu: > On Fri, 04 May 2018, Mauro Carvalho Chehab wrote: > > From now on, I'll start using my @kernel.org as my development e-mail. > > > > As such, let's remove the entries that point

Re: [PATCH] MAINTAINERS & files: Canonize the e-mails I use at files

2018-05-04 Thread Jani Nikula
On Fri, 04 May 2018, Mauro Carvalho Chehab wrote: > From now on, I'll start using my @kernel.org as my development e-mail. > > As such, let's remove the entries that point to the old > mche...@s-opensource.com at MAINTAINERS file. > > For the files written with a

[PATCH] MAINTAINERS & files: Canonize the e-mails I use at files

2018-05-04 Thread Mauro Carvalho Chehab
>From now on, I'll start using my @kernel.org as my development e-mail. As such, let's remove the entries that point to the old mche...@s-opensource.com at MAINTAINERS file. For the files written with a copyright with mchehab@s-opensource, let's keep Samsung on their names, using

Re: [PATCH v3 6/9] trace_uprobe: Support SDT markers having reference count (semaphore)

2018-05-03 Thread Masami Hiramatsu
Hi Ravi, I have some comments, please see below. On Tue, 17 Apr 2018 10:02:41 +0530 Ravi Bangoria wrote:\ > diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h > index 7bd2760..2db3ed1 100644 > --- a/include/linux/uprobes.h > +++

[PATCH v3 1/4] seccomp: Separate read and write code for actions_logged sysctl

2018-05-03 Thread Tyler Hicks
Break the read and write paths of the kernel.seccomp.actions_logged sysctl into separate functions to maintain readability. An upcoming change will need to audit writes, but not reads, of this sysctl which would introduce too many conditional code paths on whether or not the 'write' parameter

[PATCH v3 0/4] Better integrate seccomp logging and auditing

2018-05-03 Thread Tyler Hicks
Seccomp received improved logging controls in v4.14. Applications can opt into logging of "handled" actions (SECCOMP_RET_TRAP, SECCOMP_RET_TRACE, SECCOMP_RET_ERRNO) using the SECCOMP_FILTER_FLAG_LOG bit when loading filters. They can also debug filter matching with the new SECCOMP_RET_LOG action.

[PATCH v3 4/4] seccomp: Don't special case audited processes when logging

2018-05-03 Thread Tyler Hicks
Seccomp logging for "handled" actions such as RET_TRAP, RET_TRACE, or RET_ERRNO can be very noisy for processes that are being audited. This patch modifies the seccomp logging behavior to treat processes that are being inspected via the audit subsystem the same as processes that aren't under

[PATCH v3 2/4] seccomp: Configurable separator for the actions_logged string

2018-05-03 Thread Tyler Hicks
The function that converts a bitmask of seccomp actions that are allowed to be logged is currently only used for constructing the display string for the kernel.seccomp.actions_logged sysctl. That string wants a space character to be used for the separator between actions. A future patch will make

[PATCH v3 3/4] seccomp: Audit attempts to modify the actions_logged sysctl

2018-05-03 Thread Tyler Hicks
The decision to log a seccomp action will always be subject to the value of the kernel.seccomp.actions_logged sysctl, even for processes that are being inspected via the audit subsystem, in an upcoming patch. Therefore, we need to emit an audit record on attempts at writing to the actions_logged

Re: [PATCH v4 2/2] ThunderX2: Add Cavium ThunderX2 SoC UNCORE PMU driver

2018-05-03 Thread Kim Phillips
On Tue, 1 May 2018 12:54:05 +0100 Will Deacon wrote: > Hi Kim, Hi Will, thanks for responding. > On Fri, Apr 27, 2018 at 11:56:25AM -0500, Kim Phillips wrote: > > On Fri, 27 Apr 2018 17:09:14 +0100 > > Will Deacon wrote: > > > On Fri, Apr 27, 2018 at

Re: [PATCH v2 3/4] seccomp: Audit attempts to modify the actions_logged sysctl

2018-05-03 Thread Steve Grubb
On Thursday, May 3, 2018 6:36:18 PM EDT Tyler Hicks wrote: > On 05/03/2018 04:12 PM, Steve Grubb wrote: > > On Thursday, May 3, 2018 4:51:36 PM EDT Tyler Hicks wrote: > >> On 05/03/2018 03:48 PM, Paul Moore wrote: > >>> On Thu, May 3, 2018 at 4:42 PM, Steve Grubb wrote: >

Re: [PATCH v2 3/4] seccomp: Audit attempts to modify the actions_logged sysctl

2018-05-03 Thread Tyler Hicks
On 05/03/2018 04:12 PM, Steve Grubb wrote: > On Thursday, May 3, 2018 4:51:36 PM EDT Tyler Hicks wrote: >> On 05/03/2018 03:48 PM, Paul Moore wrote: >>> On Thu, May 3, 2018 at 4:42 PM, Steve Grubb wrote: On Thursday, May 3, 2018 4:18:26 PM EDT Paul Moore wrote: > On

Re: [PATCH v2 3/4] seccomp: Audit attempts to modify the actions_logged sysctl

2018-05-03 Thread Steve Grubb
On Thursday, May 3, 2018 4:51:36 PM EDT Tyler Hicks wrote: > On 05/03/2018 03:48 PM, Paul Moore wrote: > > On Thu, May 3, 2018 at 4:42 PM, Steve Grubb wrote: > >> On Thursday, May 3, 2018 4:18:26 PM EDT Paul Moore wrote: > >>> On Wed, May 2, 2018 at 2:18 PM, Steve Grubb

Re: [PATCH v2 3/4] seccomp: Audit attempts to modify the actions_logged sysctl

2018-05-03 Thread Tyler Hicks
On 05/03/2018 03:48 PM, Paul Moore wrote: > On Thu, May 3, 2018 at 4:42 PM, Steve Grubb wrote: >> On Thursday, May 3, 2018 4:18:26 PM EDT Paul Moore wrote: >>> On Wed, May 2, 2018 at 2:18 PM, Steve Grubb wrote: On Wednesday, May 2, 2018 11:53:19 AM EDT

Re: [PATCH v2 3/4] seccomp: Audit attempts to modify the actions_logged sysctl

2018-05-03 Thread Paul Moore
On Thu, May 3, 2018 at 4:42 PM, Steve Grubb wrote: > On Thursday, May 3, 2018 4:18:26 PM EDT Paul Moore wrote: >> On Wed, May 2, 2018 at 2:18 PM, Steve Grubb wrote: >> > On Wednesday, May 2, 2018 11:53:19 AM EDT Tyler Hicks wrote: >> >> The decision to log a

Re: [PATCH v2 3/4] seccomp: Audit attempts to modify the actions_logged sysctl

2018-05-03 Thread Steve Grubb
On Thursday, May 3, 2018 4:18:26 PM EDT Paul Moore wrote: > On Wed, May 2, 2018 at 2:18 PM, Steve Grubb wrote: > > On Wednesday, May 2, 2018 11:53:19 AM EDT Tyler Hicks wrote: > >> The decision to log a seccomp action will always be subject to the > >> value of the

Re: [PATCH v2 3/4] seccomp: Audit attempts to modify the actions_logged sysctl

2018-05-03 Thread Paul Moore
On Wed, May 2, 2018 at 2:18 PM, Steve Grubb wrote: > On Wednesday, May 2, 2018 11:53:19 AM EDT Tyler Hicks wrote: >> The decision to log a seccomp action will always be subject to the >> value of the kernel.seccomp.actions_logged sysctl, even for processes >> that are being

Re: [PATCH 4/6] mm, arm64: untag user addresses in mm/gup.c

2018-05-03 Thread Andrey Konovalov
On Thu, May 3, 2018 at 5:24 PM, Kirill A. Shutemov wrote: > On Thu, May 03, 2018 at 04:09:56PM +0200, Andrey Konovalov wrote: >> On Wed, May 2, 2018 at 7:25 PM, Andrey Konovalov >> wrote: >> I wasn't able to find anything that calls follow_page with

Re: [PATCH 4/6] mm, arm64: untag user addresses in mm/gup.c

2018-05-03 Thread Kirill A. Shutemov
On Thu, May 03, 2018 at 04:09:56PM +0200, Andrey Konovalov wrote: > On Wed, May 2, 2018 at 7:25 PM, Andrey Konovalov > wrote: > > On Wed, May 2, 2018 at 5:36 PM, Kirill A. Shutemov > > wrote: > >> On Wed, May 02, 2018 at 02:38:42PM +,

Re: [PATCH v3 2/9] mm: Prefix vma_ to vaddr_to_offset() and offset_to_vaddr()

2018-05-03 Thread Steven Rostedt
On Tue, 17 Apr 2018 10:02:37 +0530 Ravi Bangoria wrote: > From: Ravi Bangoria > > Make function names more meaningful by adding vma_ prefix > to them. Actually, I would have done this patch before the first one, since the first

Re: [PATCH v3 8/9] trace_uprobe/sdt: Document about reference counter

2018-05-03 Thread Masami Hiramatsu
On Tue, 17 Apr 2018 10:02:43 +0530 Ravi Bangoria wrote: > From: Ravi Bangoria > > Reference counter gate the invocation of probe. If present, > by default reference count is 0. Kernel needs to increment > it before tracing the

Re: [PATCH v3 9/9] perf probe: Support SDT markers having reference counter (semaphore)

2018-05-03 Thread Masami Hiramatsu
On Tue, 17 Apr 2018 10:02:44 +0530 Ravi Bangoria wrote: > From: Ravi Bangoria > > With this, perf buildid-cache will save SDT markers with reference > counter in probe cache. Perf probe will be able to probe markers > having

[PATCH v2 1/6] arm64: add type casts to untagged_addr macro

2018-05-03 Thread Andrey Konovalov
This patch makes the untagged_addr macro accept all kinds of address types (void *, unsigned long, etc.) and allows not to specify type casts in each place where it is used. This is done by using __typeof__. Signed-off-by: Andrey Konovalov ---

[PATCH v2 4/6] mm, arm64: untag user addresses in mm/gup.c

2018-05-03 Thread Andrey Konovalov
mm/gup.c provides a kernel interface that accepts user addresses and manipulates user pages directly (for example get_user_pages, that is used by the futex syscall). Here we also need to handle the case of tagged user pointers. Add untagging to gup.c functions that use user pointers for vma

[PATCH v2 6/6] arm64: update Documentation/arm64/tagged-pointers.txt

2018-05-03 Thread Andrey Konovalov
Add a note that work on passing tagged user pointers to the kernel via syscalls has started, but might not be complete yet. Signed-off-by: Andrey Konovalov --- Documentation/arm64/tagged-pointers.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH v2 3/6] arm64: untag user addresses in access_ok and __uaccess_mask_ptr

2018-05-03 Thread Andrey Konovalov
copy_from_user (and a few other similar functions) are used to copy data from user memory into the kernel memory or vice versa. Since a user can provided a tagged pointer to one of the syscalls that use copy_from_user, we need to correctly handle such pointers. Do this by untagging user pointers

[PATCH v2 5/6] lib, arm64: untag addrs passed to strncpy_from_user and strnlen_user

2018-05-03 Thread Andrey Konovalov
strncpy_from_user and strnlen_user accept user addresses as arguments, and do not go through the same path as copy_from_user and others, so here we need to handle the case of tagged user addresses separately. Untag user pointers passed to these functions. Signed-off-by: Andrey Konovalov

[PATCH v2 0/6] arm64: untag user pointers passed to the kernel

2018-05-03 Thread Andrey Konovalov
Hi! arm64 has a feature called Top Byte Ignore, which allows to embed pointer tags into the top byte of each pointer. Userspace programs (such as HWASan, a memory debugging tool [1]) might use this feature and pass tagged user pointers to the kernel through syscalls or other interfaces. This

[PATCH v2 2/6] uaccess: add untagged_addr definition for other arches

2018-05-03 Thread Andrey Konovalov
To allow arm64 syscalls accept tagged pointers from userspace, we must untag them when they are passed to the kernel. Since untagging is done in generic parts of the kernel (like the mm subsystem), the untagged_addr macro should be defined for all architectures. Define it as a noop for other

Re: [PATCH 4/6] mm, arm64: untag user addresses in mm/gup.c

2018-05-03 Thread Andrey Konovalov
On Wed, May 2, 2018 at 7:25 PM, Andrey Konovalov wrote: > On Wed, May 2, 2018 at 5:36 PM, Kirill A. Shutemov > wrote: >> On Wed, May 02, 2018 at 02:38:42PM +, Andrey Konovalov wrote: >>> > Does having a tagged address here makes any

Spende für Sie

2018-05-03 Thread Domenico Curro'
Mein Name ist RICHARD WAHL. Ich habe eine Spende von 3,5 Millionen Euro für Sie gewonnen. Ich habe $ 533 Millionen Mega Millions Jackpot 2018 gewonnen. Ich habe derzeit keine Krebserkrankungen und mein Gesundheitszustand ist schlecht. Bitte mailen Sie mich an on- (richardwah...@gmail.com) --

Re: [PATCH v3 0/9] trace_uprobe: Support SDT markers having reference count (semaphore)

2018-05-03 Thread Ravi Bangoria
On 04/17/2018 10:02 AM, Ravi Bangoria wrote: > Userspace Statically Defined Tracepoints[1] are dtrace style markers > inside userspace applications. Applications like PostgreSQL, MySQL, > Pthread, Perl, Python, Java, Ruby, Node.js, libvirt, QEMU, glib etc > have these markers embedded in them.

Re: [PATCH v2 4/4] seccomp: Don't special case audited processes when logging

2018-05-02 Thread Paul Moore
On Wed, May 2, 2018 at 12:57 PM, Kees Cook wrote: > On Wed, May 2, 2018 at 8:53 AM, Tyler Hicks wrote: >> diff --git a/kernel/seccomp.c b/kernel/seccomp.c >> index da78835..9029d9d 100644 >> --- a/kernel/seccomp.c >> +++ b/kernel/seccomp.c >> @@

Re: [PATCH v2 3/4] seccomp: Audit attempts to modify the actions_logged sysctl

2018-05-02 Thread James Morris
On Wed, 2 May 2018, Tyler Hicks wrote: > type=CONFIG_CHANGE msg=audit(1525275325.613:142): op=seccomp-logging > actions=kill_process,kill_thread,errno,trace,log > old-actions=kill_process,kill_thread,errno,trace,log res=1 > > No audit records are generated when reading the actions_logged

Re: [PATCH v2 2/4] seccomp: Configurable separator for the actions_logged string

2018-05-02 Thread James Morris
On Wed, 2 May 2018, Tyler Hicks wrote: > The function that converts a bitmask of seccomp actions that are > allowed to be logged is currently only used for constructing the display > string for the kernel.seccomp.actions_logged sysctl. That string wants a > space character to be used for the

Re: [PATCH v2 1/4] seccomp: Separate read and write code for actions_logged sysctl

2018-05-02 Thread James Morris
On Wed, 2 May 2018, Tyler Hicks wrote: > Break the read and write paths of the kernel.seccomp.actions_logged > sysctl into separate functions to maintain readability. An upcoming > change will need to audit writes, but not reads, of this sysctl which > would introduce too many conditional code

Re: [PATCH v2 3/4] seccomp: Audit attempts to modify the actions_logged sysctl

2018-05-02 Thread Steve Grubb
On Wednesday, May 2, 2018 11:53:19 AM EDT Tyler Hicks wrote: > The decision to log a seccomp action will always be subject to the > value of the kernel.seccomp.actions_logged sysctl, even for processes > that are being inspected via the audit subsystem, in an upcoming patch. > Therefore, we need

Re: [PATCH 4/6] mm, arm64: untag user addresses in mm/gup.c

2018-05-02 Thread Andrey Konovalov
On Wed, May 2, 2018 at 5:36 PM, Kirill A. Shutemov wrote: > On Wed, May 02, 2018 at 02:38:42PM +, Andrey Konovalov wrote: >> > Does having a tagged address here makes any difference? I couldn't hit a >> > failure with my simple tests (LD_PRELOAD a library that

Re: [PATCH] doc: botching-up-ioctls: Make it clearer why structs must be padded

2018-05-02 Thread Eric Anholt
Daniel Vetter writes: > This came up in discussions when reviewing drm patches. > > Cc: Eric Anholt > Cc: linux-doc@vger.kernel.org > Cc: Jonathan Corbet > Signed-off-by: Daniel Vetter > > -- > > Aside: I wonder

Re: [PATCH v2 4/4] seccomp: Don't special case audited processes when logging

2018-05-02 Thread Kees Cook
On Wed, May 2, 2018 at 8:53 AM, Tyler Hicks wrote: > diff --git a/kernel/seccomp.c b/kernel/seccomp.c > index da78835..9029d9d 100644 > --- a/kernel/seccomp.c > +++ b/kernel/seccomp.c > @@ -584,18 +584,13 @@ static inline void seccomp_log(unsigned long syscall, > long

Re: [PATCH] coresight: Remove %px for printing pcsr value

2018-05-02 Thread Mathieu Poirier
On 1 May 2018 at 23:00, Leo Yan wrote: > The driver prints pcsr twice: the first time it uses specifier %px to > print hexadecimal pcsr value and the second time uses specifier %pS for > output kernel symbols. > > As suggested by Kees, using %pS should be sufficient and %px

Re: [PATCH 2/3] seccomp: Audit attempts to modify the actions_logged sysctl

2018-05-02 Thread Tyler Hicks
On 05/01/2018 12:25 PM, Paul Moore wrote: > On Tue, May 1, 2018 at 12:41 PM, Steve Grubb wrote: >> On Tuesday, May 1, 2018 11:18:55 AM EDT Paul Moore wrote: >>> On Fri, Apr 27, 2018 at 3:16 PM, Tyler Hicks wrote: The decision to log a seccomp action

[PATCH v2 3/4] seccomp: Audit attempts to modify the actions_logged sysctl

2018-05-02 Thread Tyler Hicks
The decision to log a seccomp action will always be subject to the value of the kernel.seccomp.actions_logged sysctl, even for processes that are being inspected via the audit subsystem, in an upcoming patch. Therefore, we need to emit an audit record on attempts at writing to the actions_logged

[PATCH v2 4/4] seccomp: Don't special case audited processes when logging

2018-05-02 Thread Tyler Hicks
Seccomp logging for "handled" actions such as RET_TRAP, RET_TRACE, or RET_ERRNO can be very noisy for processes that are being audited. This patch modifies the seccomp logging behavior to treat processes that are being inspected via the audit subsystem the same as processes that aren't under

[PATCH v2 2/4] seccomp: Configurable separator for the actions_logged string

2018-05-02 Thread Tyler Hicks
The function that converts a bitmask of seccomp actions that are allowed to be logged is currently only used for constructing the display string for the kernel.seccomp.actions_logged sysctl. That string wants a space character to be used for the separator between actions. A future patch will make

[PATCH v2 1/4] seccomp: Separate read and write code for actions_logged sysctl

2018-05-02 Thread Tyler Hicks
Break the read and write paths of the kernel.seccomp.actions_logged sysctl into separate functions to maintain readability. An upcoming change will need to audit writes, but not reads, of this sysctl which would introduce too many conditional code paths on whether or not the 'write' parameter

[PATCH v2 0/4] Better integrate seccomp logging and auditing

2018-05-02 Thread Tyler Hicks
Seccomp received improved logging controls in v4.14. Applications can opt into logging of "handled" actions (SECCOMP_RET_TRAP, SECCOMP_RET_TRACE, SECCOMP_RET_ERRNO) using the SECCOMP_FILTER_FLAG_LOG bit when loading filters. They can also debug filter matching with the new SECCOMP_RET_LOG action.

Re: [PATCH 4/6] mm, arm64: untag user addresses in mm/gup.c

2018-05-02 Thread Kirill A. Shutemov
On Wed, May 02, 2018 at 02:38:42PM +, Andrey Konovalov wrote: > > Does having a tagged address here makes any difference? I couldn't hit a > > failure with my simple tests (LD_PRELOAD a library that randomly adds > > tags to pointers returned by malloc). > > I think you're right,

Re: [PATCH 3/6] arm64: untag user addresses in copy_from_user and others

2018-05-02 Thread Andrey Konovalov
On Thu, Apr 26, 2018 at 5:47 PM, Catalin Marinas wrote: > On Wed, Apr 18, 2018 at 08:53:12PM +0200, Andrey Konovalov wrote: >> @@ -238,12 +239,15 @@ static inline void uaccess_enable_not_uao(void) >> /* >> * Sanitise a uaccess pointer such that it becomes NULL if above

Re: [PATCH v6 0/8] ipc: Clamp *mni to the real IPCMNI limit & increase that limit

2018-05-02 Thread Eric W. Biederman
Waiman Long writes: > On 05/01/2018 10:18 PM, Eric W. Biederman wrote: >> >>> The sysctl parameters msgmni, shmmni and semmni have an inherent limit >>> of IPC_MNI (32k). However, users may not be aware of that because they >>> can write a value much higher than that without

Re: [PATCH 4/6] mm, arm64: untag user addresses in mm/gup.c

2018-05-02 Thread Andrey Konovalov
On Thu, Apr 26, 2018 at 7:47 PM, Catalin Marinas wrote: My approach with this was to add untagging to every gup.c function that is exposed for external use, but perhaps adding untagging only where it is actually required is a better approach. > On Wed, Apr 18, 2018 at

Re: [PATCH v7 2/5] cpuset: Add cpuset.sched_load_balance to v2

2018-05-02 Thread Mike Galbraith
On Wed, 2018-05-02 at 16:02 +0200, Peter Zijlstra wrote: > On Wed, May 02, 2018 at 09:47:00AM -0400, Waiman Long wrote: > > > > I've read half of the next patch that adds the isolation thing. And > > > while that kludges around the whole root cgorup is magic thing, it > > > doesn't help if you

Re: [PATCH v7 3/5] cpuset: Add a root-only cpus.isolated v2 control file

2018-05-02 Thread Peter Zijlstra
On Thu, Apr 19, 2018 at 09:47:02AM -0400, Waiman Long wrote: > diff --git a/Documentation/cgroup-v2.txt b/Documentation/cgroup-v2.txt > index c970bd7..8d89dc2 100644 > --- a/Documentation/cgroup-v2.txt > +++ b/Documentation/cgroup-v2.txt > @@ -1484,6 +1484,31 @@ Cpuset Interface Files > a

Re: [PATCH v7 2/5] cpuset: Add cpuset.sched_load_balance to v2

2018-05-02 Thread Peter Zijlstra
On Wed, May 02, 2018 at 09:47:00AM -0400, Waiman Long wrote: > > I've read half of the next patch that adds the isolation thing. And > > while that kludges around the whole root cgorup is magic thing, it > > doesn't help if you move the above scenario on level down: > > > > > > R > > /

Re: [PATCH v7 2/5] cpuset: Add cpuset.sched_load_balance to v2

2018-05-02 Thread Waiman Long
On 05/02/2018 09:42 AM, Peter Zijlstra wrote: > On Wed, May 02, 2018 at 09:29:54AM -0400, Waiman Long wrote: >> On 05/02/2018 06:24 AM, Peter Zijlstra wrote: >>> On Thu, Apr 19, 2018 at 09:47:01AM -0400, Waiman Long wrote: + cpuset.sched_load_balance + A read-write single value file

Re: [PATCH v7 2/5] cpuset: Add cpuset.sched_load_balance to v2

2018-05-02 Thread Peter Zijlstra
On Wed, May 02, 2018 at 09:29:54AM -0400, Waiman Long wrote: > On 05/02/2018 06:24 AM, Peter Zijlstra wrote: > > On Thu, Apr 19, 2018 at 09:47:01AM -0400, Waiman Long wrote: > >> + cpuset.sched_load_balance > >> + A read-write single value file which exists on non-root cgroups. > > Uhhm.. it

Re: [PATCH v7 2/5] cpuset: Add cpuset.sched_load_balance to v2

2018-05-02 Thread Waiman Long
On 05/02/2018 06:24 AM, Peter Zijlstra wrote: > On Thu, Apr 19, 2018 at 09:47:01AM -0400, Waiman Long wrote: >> + cpuset.sched_load_balance >> +A read-write single value file which exists on non-root cgroups. > Uhhm.. it should very much exist in the root group too. Otherwise you > cannot

Re: [PATCH v6 0/8] ipc: Clamp *mni to the real IPCMNI limit & increase that limit

2018-05-02 Thread Waiman Long
On 05/01/2018 10:18 PM, Eric W. Biederman wrote: > >> The sysctl parameters msgmni, shmmni and semmni have an inherent limit >> of IPC_MNI (32k). However, users may not be aware of that because they >> can write a value much higher than that without getting any error or >> notification. Reading

Re: [PATCH v2] gpiolib: add hogs support for machine code

2018-05-02 Thread Linus Walleij
On Thu, Apr 26, 2018 at 6:42 PM, Bartosz Golaszewski wrote: > 2018-04-26 14:07 GMT+02:00 Linus Walleij : >> On Tue, Apr 10, 2018 at 10:30 PM, Bartosz Golaszewski wrote: >> >>> Board files constitute a significant part of the users of the

Re: [PATCH v4 03/10] i3c: Add sysfs ABI spec

2018-05-02 Thread Geert Uytterhoeven
Hi Greg, On Wed, May 2, 2018 at 1:10 PM, Greg Kroah-Hartman wrote: > On Wed, May 02, 2018 at 11:47:49AM +0200, Geert Uytterhoeven wrote: >> On Sun, Apr 29, 2018 at 3:37 PM, Greg Kroah-Hartman >> wrote: >> > On Fri, Mar 30, 2018 at

Re: [PATCH v4 03/10] i3c: Add sysfs ABI spec

2018-05-02 Thread Greg Kroah-Hartman
On Wed, May 02, 2018 at 11:47:49AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Sun, Apr 29, 2018 at 3:37 PM, Greg Kroah-Hartman > wrote: > > On Fri, Mar 30, 2018 at 09:47:44AM +0200, Boris Brezillon wrote: > >> Document sysfs files/directories/symlinks exposed

Re: [PATCH v7 2/5] cpuset: Add cpuset.sched_load_balance to v2

2018-05-02 Thread Peter Zijlstra
On Thu, Apr 19, 2018 at 09:47:01AM -0400, Waiman Long wrote: > + cpuset.sched_load_balance > + A read-write single value file which exists on non-root cgroups. Uhhm.. it should very much exist in the root group too. Otherwise you cannot disable it there, which is required to allow smaller

Re: [PATCH v4 03/10] i3c: Add sysfs ABI spec

2018-05-02 Thread Geert Uytterhoeven
Hi Greg, On Sun, Apr 29, 2018 at 3:37 PM, Greg Kroah-Hartman wrote: > On Fri, Mar 30, 2018 at 09:47:44AM +0200, Boris Brezillon wrote: >> Document sysfs files/directories/symlinks exposed by the I3C subsystem. >> >> Signed-off-by: Boris Brezillon

[PATCH] doc: botching-up-ioctls: Make it clearer why structs must be padded

2018-05-02 Thread Daniel Vetter
This came up in discussions when reviewing drm patches. Cc: Eric Anholt Cc: linux-doc@vger.kernel.org Cc: Jonathan Corbet Signed-off-by: Daniel Vetter -- Aside: I wonder whether we shouldn't move this to some other place and rst-ify

Re: [PATCH] coresight: Remove %px for printing pcsr value

2018-05-02 Thread Leo Yan
On Tue, May 01, 2018 at 10:29:46PM -0700, Kees Cook wrote: > On Tue, May 1, 2018 at 10:00 PM, Leo Yan wrote: > > The driver prints pcsr twice: the first time it uses specifier %px to > > print hexadecimal pcsr value and the second time uses specifier %pS for > > output kernel

Re: [PATCH] coresight: Remove %px for printing pcsr value

2018-05-01 Thread Kees Cook
On Tue, May 1, 2018 at 10:00 PM, Leo Yan wrote: > The driver prints pcsr twice: the first time it uses specifier %px to > print hexadecimal pcsr value and the second time uses specifier %pS for > output kernel symbols. > > As suggested by Kees, using %pS should be sufficient

[PATCH] coresight: Remove %px for printing pcsr value

2018-05-01 Thread Leo Yan
The driver prints pcsr twice: the first time it uses specifier %px to print hexadecimal pcsr value and the second time uses specifier %pS for output kernel symbols. As suggested by Kees, using %pS should be sufficient and %px isn't necessary; the reason is if the pcsr is a kernel space address,

Re: [PATCH v6 0/8] ipc: Clamp *mni to the real IPCMNI limit & increase that limit

2018-05-01 Thread Eric W. Biederman
> The sysctl parameters msgmni, shmmni and semmni have an inherent limit > of IPC_MNI (32k). However, users may not be aware of that because they > can write a value much higher than that without getting any error or > notification. Reading the parameters back will show the newly written >

Re: [PATCH v7 4/5] cpuset: Restrict load balancing off cpus to subset of cpus.isolated

2018-05-01 Thread Waiman Long
On 05/01/2018 04:58 PM, Tejun Heo wrote: > Hello, > > On Tue, May 01, 2018 at 04:33:45PM -0400, Waiman Long wrote: >> I think that will work too. We currently don't have a flag to make a >> file visible on first-level children only, but it shouldn't be hard to >> make one. > I think it'd be fine

Re: [PATCH v7 4/5] cpuset: Restrict load balancing off cpus to subset of cpus.isolated

2018-05-01 Thread Tejun Heo
Hello, On Tue, May 01, 2018 at 04:33:45PM -0400, Waiman Long wrote: > I think that will work too. We currently don't have a flag to make a > file visible on first-level children only, but it shouldn't be hard to > make one. I think it'd be fine to make the flag file exist on all !root cgroups

Re: [PATCH v7 4/5] cpuset: Restrict load balancing off cpus to subset of cpus.isolated

2018-05-01 Thread Waiman Long
On 05/01/2018 03:51 PM, Tejun Heo wrote: > Hello, Waiman. > > Sorry about the delay. > > On Thu, Apr 19, 2018 at 09:47:03AM -0400, Waiman Long wrote: >> With the addition of "cpuset.cpus.isolated", it makes sense to add the >> restriction that load balancing can only be turned off if the CPUs in

Re: [PATCH v7 4/5] cpuset: Restrict load balancing off cpus to subset of cpus.isolated

2018-05-01 Thread Tejun Heo
Hello, Waiman. Sorry about the delay. On Thu, Apr 19, 2018 at 09:47:03AM -0400, Waiman Long wrote: > With the addition of "cpuset.cpus.isolated", it makes sense to add the > restriction that load balancing can only be turned off if the CPUs in > the isolated cpuset are subset of

Re: [PATCH 2/3] seccomp: Audit attempts to modify the actions_logged sysctl

2018-05-01 Thread Paul Moore
On Tue, May 1, 2018 at 12:41 PM, Steve Grubb wrote: > On Tuesday, May 1, 2018 11:18:55 AM EDT Paul Moore wrote: >> On Fri, Apr 27, 2018 at 3:16 PM, Tyler Hicks wrote: >> > The decision to log a seccomp action will always be subject to the >> > value of

Re: [PATCH 2/3] seccomp: Audit attempts to modify the actions_logged sysctl

2018-05-01 Thread Steve Grubb
On Tuesday, May 1, 2018 11:18:55 AM EDT Paul Moore wrote: > On Fri, Apr 27, 2018 at 3:16 PM, Tyler Hicks wrote: > > The decision to log a seccomp action will always be subject to the > > value of the kernel.seccomp.actions_logged sysctl, even for processes > > that are

Re: [PATCH 3/3] seccomp: Don't special case audited processes when logging

2018-05-01 Thread Paul Moore
On Fri, Apr 27, 2018 at 3:16 PM, Tyler Hicks wrote: > Seccomp logging for "handled" actions such as RET_TRAP, RET_TRACE, or > RET_ERRNO can be very noisy for processes that are being audited. This > patch modifies the seccomp logging behavior to treat processes that are >

Re: [PATCH 2/3] seccomp: Audit attempts to modify the actions_logged sysctl

2018-05-01 Thread Paul Moore
On Fri, Apr 27, 2018 at 3:16 PM, Tyler Hicks wrote: > The decision to log a seccomp action will always be subject to the > value of the kernel.seccomp.actions_logged sysctl, even for processes > that are being inspected via the audit subsystem, in an upcoming patch. >

Re: [PATCH v6 3/8] sysctl: Warn when a clamped sysctl parameter is set out of range

2018-05-01 Thread Waiman Long
On 04/30/2018 06:40 PM, Kees Cook wrote: > I like this series overall, thanks! No objections from me. One thing I > noted, though: > > On Fri, Apr 27, 2018 at 2:00 PM, Waiman Long wrote: >> if (param->min && *param->min > val) { >> if

Re: [PATCH v4 2/2] ThunderX2: Add Cavium ThunderX2 SoC UNCORE PMU driver

2018-05-01 Thread Will Deacon
Hi Kim, On Fri, Apr 27, 2018 at 11:56:25AM -0500, Kim Phillips wrote: > On Fri, 27 Apr 2018 17:09:14 +0100 > Will Deacon wrote: > > On Fri, Apr 27, 2018 at 10:46:29AM -0500, Kim Phillips wrote: > > > On Fri, 27 Apr 2018 15:37:20 +0100 > > > Will Deacon

Re: [PATCH v6 3/8] sysctl: Warn when a clamped sysctl parameter is set out of range

2018-04-30 Thread Kees Cook
I like this series overall, thanks! No objections from me. One thing I noted, though: On Fri, Apr 27, 2018 at 2:00 PM, Waiman Long wrote: > if (param->min && *param->min > val) { > if (clamp) { > val =

Re: [PATCH] VFIO: Fix Documentation

2018-04-30 Thread Alex Williamson
On Fri, 20 Apr 2018 18:07:27 +0800 "dongbo (E)" wrote: > From: Dong Bo > > Signed-off-by: Dong Bo > --- Hi Dong Bo, The patch is corrupted, please resend and also include a commit log, something as simple as "Update

Re: [PATCH resend] VFS: simplify seq_file iteration code and interface

2018-04-30 Thread Jonathan Corbet
On Mon, 30 Apr 2018 11:50:04 +1000 NeilBrown wrote: > This patch simplifies the interface for first/next iteration and > simplifies the code, while maintaining complete backward > compatability. Now: > > - if ->start() is given a pos of zero, it should return an iterator >

Re: [PATCH 06/10] misc: pci_endpoint_test: Add MSI-X support

2018-04-30 Thread Gustavo Pimentel
Hi Alan, On 30/04/2018 16:35, Alan Douglas wrote: > Hi Gustavo, > > On April 27, 2018, 4:57 p.m. Gustavo Pimentel wrote: >> Add MSI-X support and update driver documentation accordingly. >> >> Add new driver parameter to allow interruption type selection. >> >> Modify the Legacy/MSI/MSI-X test

RE: [PATCH 06/10] misc: pci_endpoint_test: Add MSI-X support

2018-04-30 Thread Alan Douglas
Hi Gustavo, On April 27, 2018, 4:57 p.m. Gustavo Pimentel wrote: > Add MSI-X support and update driver documentation accordingly. > > Add new driver parameter to allow interruption type selection. > > Modify the Legacy/MSI/MSI-X test process, by: > - Add and use a specific register located in

Re: [PATCH V2 1/9] pwm: core: Add support for PWM HW driver with pwm capture only

2018-04-30 Thread Thierry Reding
On Wed, Mar 21, 2018 at 10:10:36AM +0530, Rajkumar Rampelli wrote: > Add support for pwm HW driver which has only capture functionality. > This helps to implement the PWM based Tachometer driver which reads > the PWM output signals from electronic fans. > > PWM Tachometer captures the period and

Re: [PATCH v4 00/10] Add the I3C subsystem

2018-04-30 Thread Boris Brezillon
Hi Greg, On Sun, 29 Apr 2018 15:36:42 +0200 Greg Kroah-Hartman wrote: > On Mon, Apr 23, 2018 at 07:56:46PM +0200, Greg Kroah-Hartman wrote: > > On Mon, Apr 23, 2018 at 07:38:14PM +0200, Boris Brezillon wrote: > > > Hi, > > > > > > On Fri, 30 Mar 2018 09:47:41

Re: [PATCH v4 03/10] i3c: Add sysfs ABI spec

2018-04-30 Thread Boris Brezillon
Hi Greg, On Sun, 29 Apr 2018 15:37:00 +0200 Greg Kroah-Hartman wrote: > On Fri, Mar 30, 2018 at 09:47:44AM +0200, Boris Brezillon wrote: > > Document sysfs files/directories/symlinks exposed by the I3C subsystem. > > > > Signed-off-by: Boris Brezillon

[PATCH resend] VFS: simplify seq_file iteration code and interface

2018-04-29 Thread NeilBrown
Just resending after 2 weeks silence, in case it fell through a crack. Thanks, NeilBrown ("git am -c" understands this line) --8<- The documentation for seq_file suggests that it is necessary to be able to move the iterator to a given offset, however that is not the

Re: LICENSES: Missing ISC text & possibly a category ("Not recommended" vs. "Preferred licenses")

2018-04-29 Thread Greg Kroah-Hartman
On Sun, Apr 29, 2018 at 12:15:11PM +0200, Rafał Miłecki wrote: > On 29 April 2018 at 07:26, Greg Kroah-Hartman > wrote: > > On Sat, Apr 28, 2018 at 11:25:17PM +0200, Rafał Miłecki wrote: > >> Due to some maintainers *preferring* BSD-compatible license for DTS > >>

Re: [PATCH v4 00/10] Add the I3C subsystem

2018-04-29 Thread Greg Kroah-Hartman
On Mon, Apr 23, 2018 at 07:56:46PM +0200, Greg Kroah-Hartman wrote: > On Mon, Apr 23, 2018 at 07:38:14PM +0200, Boris Brezillon wrote: > > Hi, > > > > On Fri, 30 Mar 2018 09:47:41 +0200 > > Boris Brezillon wrote: > > > > > This patch series is a proposal for a new

Re: [PATCH v4 03/10] i3c: Add sysfs ABI spec

2018-04-29 Thread Greg Kroah-Hartman
On Fri, Mar 30, 2018 at 09:47:44AM +0200, Boris Brezillon wrote: > Document sysfs files/directories/symlinks exposed by the I3C subsystem. > > Signed-off-by: Boris Brezillon > --- > Changes in v2: > - new patch > --- > Documentation/ABI/testing/sysfs-bus-i3c | 95 >

Re: [PATCH v6 8/8] ipc: Conserve sequence numbers in extended IPCMNI mode

2018-04-29 Thread kbuild test robot
Hi Waiman, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17-rc2 next-20180426] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v6 7/8] ipc: Allow boot time extension of IPCMNI from 32k to 2M

2018-04-29 Thread kbuild test robot
Hi Waiman, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17-rc2 next-20180426] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: LICENSES: Missing ISC text & possibly a category ("Not recommended" vs. "Preferred licenses")

2018-04-29 Thread Rafał Miłecki
On 29 April 2018 at 07:26, Greg Kroah-Hartman wrote: > On Sat, Apr 28, 2018 at 11:25:17PM +0200, Rafał Miłecki wrote: >> Due to some maintainers *preferring* BSD-compatible license for DTS >> files [0], I was writing mine using ISC. I had no very special reason >> for

Re: LICENSES: Missing ISC text & possibly a category ("Not recommended" vs. "Preferred licenses")

2018-04-29 Thread Luis R. Rodriguez
On Sun, Apr 29, 2018 at 07:03:15AM +, Luis R. Rodriguez wrote: > On Sun, Apr 29, 2018 at 07:26:17AM +0200, Greg Kroah-Hartman wrote: > > I see it is only used in a very small number of dts files. Why not just > > use BSD-2-Clause instead? What do you find in ISC that is not available > > to

<    4   5   6   7   8   9   10   11   12   13   >