Re: [PATCH 1/1] mm, compaction: correct the bounds of __fragmentation_index()

2018-02-23 Thread Michal Hocko
On Fri 23-02-18 13:40:09, Robert Harris wrote: > If you are asking me to prove whether modifying the tuneable in the > manner above, thereby preferring compaction for more fragmented systems, > is successful then I can't answer now. I assume that the onus would > have been on Mel to show this at

Re: [PATCH 1/1] mm, compaction: correct the bounds of __fragmentation_index()

2018-02-23 Thread Robert Harris
> On 23 Feb 2018, at 09:10, Michal Hocko wrote: > > On Mon 19-02-18 14:30:36, Robert Harris wrote: >> >> >>> On 19 Feb 2018, at 12:39, Michal Hocko wrote: >>> >>> On Mon 19-02-18 12:14:26, Robert Harris wrote: > On 19 Feb 2018, at

Re: [PATCH 1/1] mm, compaction: correct the bounds of __fragmentation_index()

2018-02-23 Thread Michal Hocko
On Mon 19-02-18 14:30:36, Robert Harris wrote: > > > > On 19 Feb 2018, at 12:39, Michal Hocko wrote: > > > > On Mon 19-02-18 12:14:26, Robert Harris wrote: > >> > >> > >>> On 19 Feb 2018, at 08:26, Michal Hocko wrote: > >>> > >>> On Sun 18-02-18

Re: [PATCH 1/1] mm, compaction: correct the bounds of __fragmentation_index()

2018-02-22 Thread Robert Harris
> On 19 Feb 2018, at 12:39, Michal Hocko wrote: > > On Mon 19-02-18 12:14:26, Robert Harris wrote: >> >> >>> On 19 Feb 2018, at 08:26, Michal Hocko wrote: >>> >>> On Sun 18-02-18 16:47:55, robert.m.har...@oracle.com wrote: From: "Robert M. Harris"

Re: [PATCH 1/1] mm, compaction: correct the bounds of __fragmentation_index()

2018-02-19 Thread Robert Harris
> On 19 Feb 2018, at 13:10, Mel Gorman wrote: > > On Mon, Feb 19, 2018 at 12:26:39PM +, Robert Harris wrote: >> >> >>> On 19 Feb 2018, at 09:47, Mel Gorman wrote: >>> >>> On Sun, Feb 18, 2018 at 04:47:55PM +, robert.m.har...@oracle.com wrote:

Re: [PATCH 1/1] mm, compaction: correct the bounds of __fragmentation_index()

2018-02-19 Thread Mel Gorman
On Mon, Feb 19, 2018 at 12:26:39PM +, Robert Harris wrote: > > > > On 19 Feb 2018, at 09:47, Mel Gorman wrote: > > > > On Sun, Feb 18, 2018 at 04:47:55PM +, robert.m.har...@oracle.com wrote: > >> From: "Robert M. Harris" > >> > >>

Re: [PATCH 1/1] mm, compaction: correct the bounds of __fragmentation_index()

2018-02-19 Thread Michal Hocko
On Mon 19-02-18 12:14:26, Robert Harris wrote: > > > > On 19 Feb 2018, at 08:26, Michal Hocko wrote: > > > > On Sun 18-02-18 16:47:55, robert.m.har...@oracle.com wrote: > >> From: "Robert M. Harris" > >> > >> __fragmentation_index() calculates a

Re: [PATCH 1/1] mm, compaction: correct the bounds of __fragmentation_index()

2018-02-19 Thread Robert Harris
> On 19 Feb 2018, at 09:47, Mel Gorman wrote: > > On Sun, Feb 18, 2018 at 04:47:55PM +, robert.m.har...@oracle.com wrote: >> From: "Robert M. Harris" >> >> __fragmentation_index() calculates a value used to determine whether >> compaction

Re: [PATCH 1/1] mm, compaction: correct the bounds of __fragmentation_index()

2018-02-19 Thread Robert Harris
> On 19 Feb 2018, at 08:26, Michal Hocko wrote: > > On Sun 18-02-18 16:47:55, robert.m.har...@oracle.com wrote: >> From: "Robert M. Harris" >> >> __fragmentation_index() calculates a value used to determine whether >> compaction should be

Re: [PATCH 1/1] mm, compaction: correct the bounds of __fragmentation_index()

2018-02-19 Thread Mel Gorman
On Sun, Feb 18, 2018 at 04:47:55PM +, robert.m.har...@oracle.com wrote: > From: "Robert M. Harris" > > __fragmentation_index() calculates a value used to determine whether > compaction should be favoured over page reclaim in the event of allocation > failure. The

Re: [PATCH 1/1] mm, compaction: correct the bounds of __fragmentation_index()

2018-02-19 Thread Michal Hocko
On Sun 18-02-18 16:47:55, robert.m.har...@oracle.com wrote: > From: "Robert M. Harris" > > __fragmentation_index() calculates a value used to determine whether > compaction should be favoured over page reclaim in the event of allocation > failure. The calculation

[PATCH 1/1] mm, compaction: correct the bounds of __fragmentation_index()

2018-02-18 Thread robert . m . harris
From: "Robert M. Harris" __fragmentation_index() calculates a value used to determine whether compaction should be favoured over page reclaim in the event of allocation failure. The calculation itself is opaque and, on inspection, does not match its existing