Re: [PATCH 15/24] media: v4l2-subdev: get rid of __V4L2_SUBDEV_MK_GET_TRY() macro

2017-12-19 Thread Sakari Ailus
On Tue, Dec 19, 2017 at 09:03:55AM -0200, Mauro Carvalho Chehab wrote: > [PATCH] media: v4l2-subdev: get rid of __V4L2_SUBDEV_MK_GET_TRY() macro > > The __V4L2_SUBDEV_MK_GET_TRY() macro is used to define > 3 functions that have the same arguments. The code of those > functions is simple enough to

Re: [PATCH 15/24] media: v4l2-subdev: get rid of __V4L2_SUBDEV_MK_GET_TRY() macro

2017-12-19 Thread Mauro Carvalho Chehab
Em Tue, 19 Dec 2017 10:24:51 +0200 Sakari Ailus escreveu: > On Mon, Dec 18, 2017 at 05:27:04PM -0200, Mauro Carvalho Chehab wrote: > > Em Mon, 9 Oct 2017 23:23:56 +0300 > > Sakari Ailus escreveu: > > > > > Hi Mauro, > > > > > > On Mon, Oct 09, 2017

Re: [PATCH 15/24] media: v4l2-subdev: get rid of __V4L2_SUBDEV_MK_GET_TRY() macro

2017-12-19 Thread Sakari Ailus
On Mon, Dec 18, 2017 at 05:27:04PM -0200, Mauro Carvalho Chehab wrote: > Em Mon, 9 Oct 2017 23:23:56 +0300 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > On Mon, Oct 09, 2017 at 07:19:21AM -0300, Mauro Carvalho Chehab wrote: > > > The __V4L2_SUBDEV_MK_GET_TRY() macro is

Re: [PATCH 15/24] media: v4l2-subdev: get rid of __V4L2_SUBDEV_MK_GET_TRY() macro

2017-12-18 Thread Mauro Carvalho Chehab
Em Mon, 9 Oct 2017 23:23:56 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Mon, Oct 09, 2017 at 07:19:21AM -0300, Mauro Carvalho Chehab wrote: > > The __V4L2_SUBDEV_MK_GET_TRY() macro is used to define > > 3 functions that have the same arguments. The code of those > >

Re: [PATCH 15/24] media: v4l2-subdev: get rid of __V4L2_SUBDEV_MK_GET_TRY() macro

2017-10-09 Thread Sakari Ailus
Hi Mauro, On Mon, Oct 09, 2017 at 07:19:21AM -0300, Mauro Carvalho Chehab wrote: > The __V4L2_SUBDEV_MK_GET_TRY() macro is used to define > 3 functions that have the same arguments. The code of those > functions is simple enough to just declare them, de-obfuscating > the code. > > While here,

[PATCH 15/24] media: v4l2-subdev: get rid of __V4L2_SUBDEV_MK_GET_TRY() macro

2017-10-09 Thread Mauro Carvalho Chehab
The __V4L2_SUBDEV_MK_GET_TRY() macro is used to define 3 functions that have the same arguments. The code of those functions is simple enough to just declare them, de-obfuscating the code. While here, replace BUG_ON() by WARN_ON() as there's no reason why to panic the Kernel if this fails.