Re: [PATCH 2/3] doc-rst: Delete output of failed dot-SVG conversion

2017-02-06 Thread Jonathan Corbet
On Sat, 04 Feb 2017 17:18:43 +0100 Ben Hutchings wrote: > I've now tested this, and found that dot still touches the output file > even if it fails. So changing to -o doesn't fix anything. > > Please apply the original patch. That has now been done. Thanks, jon -- To

Re: [PATCH 2/3] doc-rst: Delete output of failed dot-SVG conversion

2017-02-06 Thread Jani Nikula
On Sat, 04 Feb 2017, Ben Hutchings wrote: > On Wed, 2017-02-01 at 13:20 -0700, Jonathan Corbet wrote: >> On Tue, 31 Jan 2017 15:37:50 + >> Ben Hutchings wrote: >> >> > > I'd just use dot -o.   >> > >> > That does make more sense.  I looked for

Re: [PATCH 2/3] doc-rst: Delete output of failed dot-SVG conversion

2017-02-01 Thread Jonathan Corbet
On Tue, 31 Jan 2017 15:37:50 + Ben Hutchings wrote: > > I'd just use dot -o. > > That does make more sense. I looked for such an option before writing > this, but the manual page doesn't mention it! Can I get an updated patch from you? Then I'll apply the whole

Re: [PATCH 2/3] doc-rst: Delete output of failed dot-SVG conversion

2017-01-31 Thread Ben Hutchings
On Tue, 2017-01-31 at 09:36 +0200, Jani Nikula wrote: > On Tue, 31 Jan 2017, Ben Hutchings wrote: > > As we use redirection to create the SVG file, even a failed > > conversion > > will create the file and 'make' will consider it up-to-date if the > > build is retried.  We

Re: [PATCH 2/3] doc-rst: Delete output of failed dot-SVG conversion

2017-01-31 Thread Mauro Carvalho Chehab
Em Tue, 31 Jan 2017 14:00:59 +0100 Markus Heiser escreveu: > Am 31.01.2017 um 11:41 schrieb Mauro Carvalho Chehab : > > > Em Tue, 31 Jan 2017 09:44:10 +0100 > > Markus Heiser escreveu: > > > >> BTW, my 'convert'

Re: [PATCH 2/3] doc-rst: Delete output of failed dot-SVG conversion

2017-01-31 Thread Markus Heiser
Am 31.01.2017 um 11:41 schrieb Mauro Carvalho Chehab : > Em Tue, 31 Jan 2017 09:44:10 +0100 > Markus Heiser escreveu: > >> BTW, my 'convert' (ImageMagick) is very slow and CPU consuming: >> >> GENPDF

Re: [PATCH 2/3] doc-rst: Delete output of failed dot-SVG conversion

2017-01-31 Thread Mauro Carvalho Chehab
Em Tue, 31 Jan 2017 09:44:10 +0100 Markus Heiser escreveu: > BTW, my 'convert' (ImageMagick) is very slow and CPU consuming: > >GENPDF Documentation/media/uapi/v4l/selection.svg > > takes approximately 20% - 30% of the **complete** build time > of the 'pdfdocs'

Re: [PATCH 2/3] doc-rst: Delete output of failed dot-SVG conversion

2017-01-30 Thread Jani Nikula
On Tue, 31 Jan 2017, Ben Hutchings wrote: > As we use redirection to create the SVG file, even a failed conversion > will create the file and 'make' will consider it up-to-date if the > build is retried. We should delete it in case of failure. > > Fixes: ec868e4ee2bc