Re: [PATCH 6/9] serial: doc: .break_ctl() is called with port->mutex() held

[Peter Hurley]

On 03/14/2016 08:16 AM, Geert Uytterhoeven wrote:
> Note that mutex_lock() should not be called with interrupts disabled.
> 
> Signed-off-by: Geert Uytterhoeven 
> ---
>  Documentation/serial/driver | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Documentation/serial/driver b/Documentation/serial/driver
> index 3b08df5bcc17e944..09e73e061fcf795c 100644
> --- a/Documentation/serial/driver
> +++ b/Documentation/serial/driver
> @@ -177,8 +177,7 @@ hardware.
>   should be terminated when another call is made with a zero
>   ctl.
>  
> - Locking: none.
> - Interrupts: caller dependent.
> + Locking: caller holds port->mutex


>   This call must not sleep
   ^^^
And remove this line as well.

>  
>startup(port)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 6/9] serial: doc: .break_ctl() is called with port->mutex() held

[Geert Uytterhoeven]

Note that mutex_lock() should not be called with interrupts disabled.

Signed-off-by: Geert Uytterhoeven 
---
 Documentation/serial/driver | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/serial/driver b/Documentation/serial/driver
index 3b08df5bcc17e944..09e73e061fcf795c 100644
--- a/Documentation/serial/driver
+++ b/Documentation/serial/driver
@@ -177,8 +177,7 @@ hardware.
should be terminated when another call is made with a zero
ctl.
 
-   Locking: none.
-   Interrupts: caller dependent.
+   Locking: caller holds port->mutex
This call must not sleep
 
   startup(port)
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html