Re: [PATCH v2] hwmon: xgene: access mailbox as RAM

2016-09-09 Thread Guenter Roeck
On Fri, Sep 09, 2016 at 10:10:45PM +0200, Arnd Bergmann wrote: > The newly added hwmon driver fails to build in an allmodconfig > kernel: > > ERROR: "memblock_is_memory" [drivers/hwmon/xgene-hwmon.ko] undefined! > > According to comments in the code, the mailbox is a shared memory region,

Re: [PATCH v2] hwmon: xgene: access mailbox as RAM

2016-09-09 Thread Hoan Tran
Hi Arnd, On Fri, Sep 9, 2016 at 1:10 PM, Arnd Bergmann wrote: > The newly added hwmon driver fails to build in an allmodconfig > kernel: > > ERROR: "memblock_is_memory" [drivers/hwmon/xgene-hwmon.ko] undefined! > > According to comments in the code, the mailbox is a shared

[PATCH v2] hwmon: xgene: access mailbox as RAM

2016-09-09 Thread Arnd Bergmann
The newly added hwmon driver fails to build in an allmodconfig kernel: ERROR: "memblock_is_memory" [drivers/hwmon/xgene-hwmon.ko] undefined! According to comments in the code, the mailbox is a shared memory region, not a set of MMIO registers, so we should use memremap() for mapping it