Re: [PATCH v2] printk: Add boottime and real timestamps

2017-08-01 Thread Mark Salyzyn
On 08/01/2017 10:35 AM, Prarit Bhargava wrote: On 08/01/2017 01:00 PM, John Stultz wrote: On Tue, Aug 1, 2017 at 5:55 AM, Prarit Bhargava wrote: printk.time=1/CONFIG_PRINTK_TIME=1 adds a unmodified local hardware clock timestamp to printk messages. The local hardware

Re: [PATCH v2] printk: Add boottime and real timestamps

2017-08-01 Thread Thomas Gleixner
On Tue, 1 Aug 2017, Prarit Bhargava wrote: > On 08/01/2017 01:00 PM, John Stultz wrote: > > Its been asked already, but I've not yet seen an answer. > > Sorry for missing this. > > > Is there a reason your not also adding PRINTK_TIME_BOOT here (which to > > me would be more generally useful then

Re: [PATCH v2] printk: Add boottime and real timestamps

2017-08-01 Thread John Stultz
On Tue, Aug 1, 2017 at 10:35 AM, Prarit Bhargava wrote: > > > On 08/01/2017 01:00 PM, John Stultz wrote: >> Is there a reason your not also adding PRINTK_TIME_BOOT here (which to >> me would be more generally useful then REAL or MONO)? > > REAL has been useful to me in debug

Re: [PATCH v2] printk: Add boottime and real timestamps

2017-08-01 Thread Prarit Bhargava
On 08/01/2017 01:00 PM, John Stultz wrote: > On Tue, Aug 1, 2017 at 5:55 AM, Prarit Bhargava wrote: >> printk.time=1/CONFIG_PRINTK_TIME=1 adds a unmodified local hardware clock >> timestamp to printk messages. The local hardware clock loses time each >> day making it

Re: [PATCH v2] printk: Add boottime and real timestamps

2017-08-01 Thread John Stultz
On Tue, Aug 1, 2017 at 5:55 AM, Prarit Bhargava wrote: > printk.time=1/CONFIG_PRINTK_TIME=1 adds a unmodified local hardware clock > timestamp to printk messages. The local hardware clock loses time each > day making it difficult to determine exactly when an issue has occurred

Re: [PATCH v2] printk: Add boottime and real timestamps

2017-08-01 Thread Luis R. Rodriguez
On Tue, Aug 01, 2017 at 08:55:28AM -0400, Prarit Bhargava wrote: > diff --git a/arch/x86/configs/x86_64_defconfig > b/arch/x86/configs/x86_64_defconfig > index 4a4b16e56d35..23da8e5297a1 100644 > --- a/arch/x86/configs/x86_64_defconfig > +++ b/arch/x86/configs/x86_64_defconfig > @@ -283,7 +283,13

[PATCH v2] printk: Add boottime and real timestamps

2017-08-01 Thread Prarit Bhargava
printk.time=1/CONFIG_PRINTK_TIME=1 adds a unmodified local hardware clock timestamp to printk messages. The local hardware clock loses time each day making it difficult to determine exactly when an issue has occurred in the kernel log, and making it difficult to determine how kernel and hardware