Re: [PATCH 1/2] debugfs: prevent access to possibly dead file_operations at file open

2016-02-07 Thread Greg Kroah-Hartman
On Tue, Dec 01, 2015 at 12:21:31AM +0100, Nicolai Stange wrote: > Nothing prevents a dentry found by path lookup before a return of > __debugfs_remove() to actually get opened after that return. Now, after > the return of __debugfs_remove(), there are no guarantees whatsoever > regarding the

Re: [PATCH 2/2] debugfs: prevent access to removed files' private data

2016-02-07 Thread Greg Kroah-Hartman
On Tue, Dec 01, 2015 at 12:26:41AM +0100, Nicolai Stange wrote: > Upon return of debugfs_remove()/debugfs_remove_recursive(), it might > still be attempted to access associated private file data through > previously opened struct file objects. If that data has been freed by > the caller of

Re: [PATCH] add POWER Virtual Management Channel driver

2016-02-16 Thread Greg Kroah-Hartman
On Tue, Feb 16, 2016 at 02:43:13PM -0600, Steven Royer wrote: > From: Steven Royer > > The ibmvmc driver is a device driver for the POWER Virtual Management > Channel virtual adapter on the PowerVM platform. It is used to > communicate with the hypervisor for virtualization

Re: [PATCH] add POWER Virtual Management Channel driver

2016-02-17 Thread Greg Kroah-Hartman
On Wed, Feb 17, 2016 at 03:18:26PM -0600, Steven Royer wrote: > On 2016-02-16 16:18, Greg Kroah-Hartman wrote: > >On Tue, Feb 16, 2016 at 02:43:13PM -0600, Steven Royer wrote: > >>From: Steven Royer <sero...@us.ibm.com> > >> > >>The ibmvmc driver is a devi

Re: [PATCH v4] tty: serial: meson: Implement earlycon support

2016-03-23 Thread Greg Kroah-Hartman
On Wed, Mar 23, 2016 at 11:39:36AM +0100, Andreas Färber wrote: > Am 06.03.2016 um 12:21 schrieb Andreas Färber: > > Split off the bulk of the existing meson_serial_console_write() > > implementation into meson_serial_port_write() for implementing > > meson_serial_early_console_write(). > > > >

Re: [PATCH] Documentation: update the devices.txt documentation

2016-03-05 Thread Greg Kroah-Hartman
. > > Also move paragraphs around so as to emphasize dynamic major number > allocation. > > Remove paragraph on 2.6 deprecation, that tag no longer appears > anywhere in the file. > > Cc: Jonathan Corbet <cor...@lwn.net> > Cc: Linus Torvalds <torva...@linux-foundation.

Re: [PATCH 5/8] uio: fix dmem_region_start computation

2016-07-15 Thread Greg Kroah-Hartman
On Fri, Jul 15, 2016 at 02:34:00PM +0530, Anup Patel wrote: > From: Jan Viktorin > > The variable i contains a total number of resources (including > IORESOURCE_IRQ). However, we want the dmem_region_start to point > after the last resource of type IORESOURCE_MEM. The

Re: [PATCH 1/1] MicroSemi Switchtec management interface driver

2017-01-31 Thread Greg Kroah-Hartman
On Tue, Jan 31, 2017 at 10:03:24AM -0700, Logan Gunthorpe wrote: > Microsemi's "Switchtec" line of PCI switch devices is already well > supported by the kernel with standard PCI switch drivers. However, the > Switchtec device advertises a special management endpoint with a separate > PCI function

Re: [PATCH 1/1] MicroSemi Switchtec management interface driver

2017-01-31 Thread Greg Kroah-Hartman
On Tue, Jan 31, 2017 at 10:35:44AM -0700, Logan Gunthorpe wrote: > > > On 31/01/17 10:26 AM, Greg Kroah-Hartman wrote: > > That's one big patch to review, would you want to do that? > > Sorry, will do. > > > Can you break it up into smaller parts? At least put th

Re: [PATCH v2 0/4] New Microsemi PCI Switch Management Driver

2017-02-23 Thread Greg Kroah-Hartman
On Thu, Feb 23, 2017 at 01:36:51PM -0700, Logan Gunthorpe wrote: > Hello, > > We're still waiting on any kind of response from Bjorn. (If you're > listening please say something!) > > Does anyone have any suggestions for dealing with an unresponsive > maintainer? Or a way for us to move forward

Re: [PATCH v2 1/4] MicroSemi Switchtec management interface driver

2017-02-10 Thread Greg Kroah-Hartman
On Fri, Feb 10, 2017 at 10:03:10AM -0700, Logan Gunthorpe wrote: > > > On 10/02/17 09:55 AM, Greg Kroah-Hartman wrote: > > Yes, but try it yourself to verify it really is correct :) > > Yes, of course... turns out it wasn't. I accidentally refereed to dev > before I a

Re: [PATCH v2 1/4] MicroSemi Switchtec management interface driver

2017-02-10 Thread Greg Kroah-Hartman
On Fri, Feb 10, 2017 at 09:48:37AM -0700, Logan Gunthorpe wrote: > Hey Greg, > > Thanks so much for the review. > > On 10/02/17 07:51 AM, Greg Kroah-Hartman wrote: > > On Thu, Feb 02, 2017 at 11:06:00AM -0700, Logan Gunthorpe wrote: > >> + cdev = >cd

Re: [PATCH v2 0/4] New Microsemi PCI Switch Management Driver

2017-02-10 Thread Greg Kroah-Hartman
On Thu, Feb 02, 2017 at 11:05:59AM -0700, Logan Gunthorpe wrote: > Changes since v1: > > * Rebased onto 4.10-rc6 (cleanly) > * Split the patch into a few more easily digestible patches (as > suggested by Greg Kroah-Hartman) > * Folded switchtec.c into switchtec.h (per Greg)

Re: [PATCH v2 1/4] MicroSemi Switchtec management interface driver

2017-02-10 Thread Greg Kroah-Hartman
On Thu, Feb 02, 2017 at 11:06:00AM -0700, Logan Gunthorpe wrote: > + cdev = >cdev; > + cdev_init(cdev, _fops); > + cdev->owner = THIS_MODULE; > + cdev->kobj.parent = >kobj; Minor nit, the kobject in a cdev is unlike any other kobject you have ever seen, don't mess with it, it's

Re: [PATCH v2 1/4] MicroSemi Switchtec management interface driver

2017-02-10 Thread Greg Kroah-Hartman
me/nvme-cli > > Signed-off-by: Logan Gunthorpe <log...@deltatee.com> > Signed-off-by: Stephen Bates <stephen.ba...@microsemi.com> Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-d

Re: [PATCH v2 3/4] switchtec: Add sysfs attributes to the Switchtec driver

2017-02-10 Thread Greg Kroah-Hartman
/ABI/testing/sysfs-class-switchtec. > > Signed-off-by: Logan Gunthorpe <log...@deltatee.com> > Signed-off-by: Stephen Bates <stephen.ba...@microsemi.com> Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> -- To unsubscribe from this list: send the line "uns

Re: [PATCH v3] tty: pl011: Work around QDF2400 E44 stuck BUSY bit

2017-02-15 Thread Greg Kroah-Hartman
On Wed, Feb 15, 2017 at 07:50:27PM +, Mark Rutland wrote: > On Wed, Feb 15, 2017 at 01:01:59PM -0500, Christopher Covington wrote: > > The Qualcomm Datacenter Technologies QDF2400 family of SoCs contains a > > custom (non-PrimeCell) implementation of the SBSA UART. Occasionally the > > BUSY

Re: [PATCH v9 00/10] mux controller abstraction and iio/i2c muxes

2017-02-28 Thread Greg Kroah-Hartman
On Tue, Feb 28, 2017 at 04:17:52PM +0100, Peter Rosin wrote: > Hi! > > The status of this series [1] is that Rob Herring has acked/reviewed all > devicetree changes, so I suppose that's ok. Jonathan Cameron has acked > the additions to the iio subsystem and reviewed the new iio driver. > Wolfram

Re: [PATCH v5 0/4] New Microsemi PCI Switch Management Driver

2017-02-28 Thread Greg Kroah-Hartman
On Tue, Feb 28, 2017 at 10:11:56AM -0700, Logan Gunthorpe wrote: > In any case, I also wish we could have had this discussion 3 months ago > when we posted the RFC and not when I have people pushing to get this > merged. Relax, there is no rush here, no deadlines, etc. Moving the files to a

Re: [PATCH] docs-rst: add inter-document cross references

2016-09-21 Thread Greg Kroah-Hartman
this change to just add the cross-references without the rename, as > it makes easier if we decide to use symlinks instead of renames. > > As I rebased the rename patch as well, on the top of this one, we can > also use the rename, if people find it better. For the stable_ker

Re: [PATCH 3/3] doc-rst: add an ABI book

2016-10-28 Thread Greg Kroah-Hartman
On Fri, Oct 28, 2016 at 11:33:51AM -0200, Mauro Carvalho Chehab wrote: > Em Fri, 28 Oct 2016 08:49:12 -0400 > Greg Kroah-Hartman <gre...@linuxfoundation.org> escreveu: > > > On Fri, Oct 28, 2016 at 08:31:57AM -0400, Greg Kroah-Hartman wrote: > > > On Fri, Oct 28, 2

Re: ABI conversion to ReST - Was: Re: [PATCH 0/4] reST-directive kernel-cmd / include contentent from scripts

2016-10-28 Thread Greg Kroah-Hartman
On Thu, Oct 27, 2016 at 10:34:05PM -0200, Mauro Carvalho Chehab wrote: > As defined at Documentation/ABI/README, this is actually a database > with those fields: > > What, Date, KernelVersion, Contact, Description and Users. > > An user-face documentation would probably require only a few of

Re: ABI conversion to ReST - Was: Re: [PATCH 0/4] reST-directive kernel-cmd / include contentent from scripts

2016-10-28 Thread Greg Kroah-Hartman
On Fri, Oct 28, 2016 at 08:14:21AM -0200, Mauro Carvalho Chehab wrote: > Em Fri, 28 Oct 2016 02:54:33 -0400 > Greg Kroah-Hartman <gre...@linuxfoundation.org> escreveu: > > > On Thu, Oct 27, 2016 at 10:34:05PM -0200, Mauro Carvalho Chehab wrote: > > > As defin

Re: [PATCH 3/3] doc-rst: add an ABI book

2016-10-28 Thread Greg Kroah-Hartman
bi_book.pl Any hint as to what the output of this actually looks like? No matter, I like this, thanks for doing this, it should be really helpful. Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-doc"

Re: [PATCH 3/3] doc-rst: add an ABI book

2016-10-28 Thread Greg Kroah-Hartman
On Fri, Oct 28, 2016 at 08:31:57AM -0400, Greg Kroah-Hartman wrote: > On Fri, Oct 28, 2016 at 10:19:47AM -0200, Mauro Carvalho Chehab wrote: > > Use a script to parse the Documenation/ABI directory and output > > it at the admin-guide. > > > > Signed-off-by: Mauro

Re: [PATCH 2/3] ABI: sysfs-driver-hid: the "What" field doesn't parse fine

2016-10-28 Thread Greg Kroah-Hartman
s-opensource.com> Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] ABI: fix some syntax issues at the ABI database

2016-10-28 Thread Greg Kroah-Hartman
t; > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: ABI conversion to ReST - Was: Re: [PATCH 0/4] reST-directive kernel-cmd / include contentent from scripts

2016-10-28 Thread Greg Kroah-Hartman
On Fri, Oct 28, 2016 at 10:20:57AM -0200, Mauro Carvalho Chehab wrote: > Em Fri, 28 Oct 2016 06:28:23 -0400 > Greg Kroah-Hartman <gre...@linuxfoundation.org> escreveu: > > > On Fri, Oct 28, 2016 at 08:14:21AM -0200, Mauro Carvalho Chehab wrote: > > > Em Fri, 28 Oct

Re: [PATCH v3 4/4] firmware: remove warning at documentation generation time

2016-12-01 Thread Greg Kroah-Hartman
On Thu, Dec 01, 2016 at 05:11:54PM +0100, Luis R. Rodriguez wrote: > On Fri, Nov 25, 2016 at 06:50:32PM -0200, Mauro Carvalho Chehab wrote: > > Em Fri, 25 Nov 2016 15:59:47 +0100 > > Silvio Fricke escreveu: > > > > > This patch removes following error at for `make

Re: [PATCH 2/2] isdn: i4l: move active-isdn drivers to staging

2017-01-05 Thread Greg Kroah-Hartman
On Tue, Jan 03, 2017 at 10:19:29PM +0100, Arnd Bergmann wrote: > On Tuesday, January 3, 2017 4:24:36 PM CET Greg Kroah-Hartman wrote: > > On Wed, Mar 02, 2016 at 08:06:46PM +0100, Arnd Bergmann wrote: > > > The icn, act2000 and pcbit drivers are all for very old hardware, >

Re: [PATCH 2/2] isdn: i4l: move active-isdn drivers to staging

2017-01-03 Thread Greg Kroah-Hartman
On Wed, Mar 02, 2016 at 08:06:46PM +0100, Arnd Bergmann wrote: > The icn, act2000 and pcbit drivers are all for very old hardware, > and it is highly unlikely that anyone is actually still using them > on modern kernels, if at all. > > All three drivers apparently are for hardware that predates

Re: [RFC 1/1] MicroSemi Switchtec management interface driver

2016-12-18 Thread Greg Kroah-Hartman
On Sat, Dec 17, 2016 at 10:09:22AM -0700, Logan Gunthorpe wrote: > +struct switchtec_dev { > + struct pci_dev *pdev; > + struct msix_entry *msix; > + struct device *dev; > + struct kref kref; Why do you have a pointer to a device, yet a kref as well? Just have this structure

Re: [PATCH v12 00/10] mux controller abstraction and iio/i2c muxes

2017-03-30 Thread Greg Kroah-Hartman
On Thu, Mar 30, 2017 at 09:34:52AM +0200, Peter Rosin wrote: > On 2017-03-27 16:21, Peter Rosin wrote: > > Hi Greg! > > > > Please apply. > > > > *snip snip* > > > v10 -> v11 changes > > - added a new patch (12) with a fix for messed up error path reported > > by Paul Gortmaker. > > Oops,

Re: [PATCH v11 11/12] iio: multiplexer: fix unsigned check with less than zero

2017-03-27 Thread Greg Kroah-Hartman
On Mon, Mar 27, 2017 at 03:46:47PM +0200, Peter Rosin wrote: > On 2017-03-27 15:06, Johan Hovold wrote: > > On Mon, Mar 27, 2017 at 02:17:48PM +0200, Peter Rosin wrote: > >> Comparing a size_t with less than zero is always false as size_t > >> is unsigned. So, change the type of the variable to

Re: [PATCH v2 00/21] Convert USB documentation to ReST format

2017-04-11 Thread Greg Kroah-Hartman
On Tue, Apr 11, 2017 at 03:36:39PM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 11 Apr 2017 16:58:40 +0200 > Greg Kroah-Hartman <gre...@linuxfoundation.org> escreveu: > > > On Sat, Apr 08, 2017 at 10:04:33PM +0200, Greg Kroah-Hartman wrote: > > > On Sat, Ap

Re: [PATCH v13 03/10] mux: minimal mux subsystem and gpio-based mux controller

2017-04-18 Thread Greg Kroah-Hartman
On Thu, Apr 13, 2017 at 06:43:07PM +0200, Peter Rosin wrote: > +config MUX_GPIO > + tristate "GPIO-controlled Multiplexer" > + depends on OF && GPIOLIB Why have the gpio and mux core in the same patch? And why does this depend on OF? > + help > + GPIO-controlled Multiplexer

Re: [PATCH v4 2/6] usb: fix some references for /proc/bus/usb

2017-04-18 Thread Greg Kroah-Hartman
On Sun, Apr 16, 2017 at 09:51:07PM -0300, Mauro Carvalho Chehab wrote: > Since when we got rid of usbfs, the /proc/bus/usb is now > elsewhere. Fix references for it. > > Signed-off-by: Mauro Carvalho Chehab Oops, will take this one instead... -- To unsubscribe from

Re: [PATCH v4 4/6] usb.rst: move documentation from proc_usb_info.txt to USB ReST book

2017-04-18 Thread Greg Kroah-Hartman
.rst, adjusting it to point to > the right places. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to

Re: [PATCH v3 2/3] usb: fix some references for /proc/bus/usb

2017-04-18 Thread Greg Kroah-Hartman
On Sun, Apr 16, 2017 at 01:40:04PM -0300, Mauro Carvalho Chehab wrote: > Since when we got rid of usbfs, the /proc/bus/usb is now > elsewhere. Fix references for it. > > Signed-off-by: Mauro Carvalho Chehab As this touches USB code, I'll take this in my tree. thanks,

Re: [RFC 2/5] i3c: Add core I3C infrastructure

2017-08-01 Thread Greg Kroah-Hartman
On Tue, Aug 01, 2017 at 11:30:01PM +0200, Boris Brezillon wrote: > Hi Greg, > > Le Tue, 1 Aug 2017 10:51:33 -0700, > Greg Kroah-Hartman <gre...@linuxfoundation.org> a écrit : > > > On Tue, Aug 01, 2017 at 12:48:01PM +0200, Boris Brezillon wrote: > > > &g

Re: [RFC 2/5] i3c: Add core I3C infrastructure

2017-08-01 Thread Greg Kroah-Hartman
On Tue, Aug 01, 2017 at 11:30:01PM +0200, Boris Brezillon wrote: > > > > No release type? Oh that's bad bad bad and implies you have never > > > > removed a device from your system as the kernel would have complained > > > > loudly at you. > > > > > > You got me, never tried to remove a device

Re: [RFC 2/5] i3c: Add core I3C infrastructure

2017-07-31 Thread Greg Kroah-Hartman
On Mon, Jul 31, 2017 at 06:24:47PM +0200, Boris Brezillon wrote: > Add core infrastructure to support I3C in Linux and document it. > > This infrastructure is not complete yet and will be extended over > time. > > There are a few design choices that are worth mentioning because they > impact the

Re: [RFC 2/5] i3c: Add core I3C infrastructure

2017-08-01 Thread Greg Kroah-Hartman
On Tue, Aug 01, 2017 at 12:48:01PM +0200, Boris Brezillon wrote: > > > +static DEFINE_MUTEX(i3c_core_lock); > > > + > > > +void i3c_bus_lock(struct i3c_bus *bus, bool exclusive) > > > +{ > > > + if (exclusive) > > > + down_write(>lock); > > > + else > > > + down_read(>lock); > > >

Re: [PATCH] misc: Implement devm_misc_register

2017-05-08 Thread Greg Kroah-Hartman
On Tue, May 09, 2017 at 02:27:48AM +, Gregory Fong wrote: > Add device managed devm_misc_register() to allow simplifying some > miscdevice code. > > Signed-off-by: Gregory Fong > --- > This seemed like it would be handy for removing a large chunk of the cleanup

Re: [Merge tag 'pci-v4.12-changes' of git] 857f864014: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8

2017-06-12 Thread Greg Kroah-Hartman
On Mon, Jun 12, 2017 at 05:34:59PM -0600, Logan Gunthorpe wrote: > 1) The test we are looking at is overrunning the dynamic char dev major > numbers by a lot. On a successful run, it gets down to 216 where the > limit is 234. Thus, there are 18 too many major numbers assigned and the > fact that

Re: [PATCH 10/30] kobject.txt: standardize document format

2017-05-18 Thread Greg Kroah-Hartman
inx: > > - Add markups for titles; > - mark literal blocks as such; > - add needed whitespace/blank lines; > - use :Author: and :Last updated: for authorship. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Greg Kroah-Hartman <gre..

Re: [PATCH v15 00/13] mux controller abstraction and iio/i2c muxes

2017-06-03 Thread Greg Kroah-Hartman
On Sun, May 14, 2017 at 09:51:03PM +0200, Peter Rosin wrote: > From: Peter Rosin > > Hi Greg, > > Philipp found problems in v14 with using a mutex for locking that was > the outcome of the review for v13, so I'm now using a semaphore instead > of the rwsem that was in v13. That

Re: [PATCH v15 00/13] mux controller abstraction and iio/i2c muxes

2017-06-03 Thread Greg Kroah-Hartman
On Sat, Jun 03, 2017 at 07:26:27PM +0900, Greg Kroah-Hartman wrote: > On Sun, May 14, 2017 at 09:51:03PM +0200, Peter Rosin wrote: > > From: Peter Rosin <p...@axentia.se> > > > > Hi Greg, > > > > Philipp found problems in v14 with using a mutex for locking

Re: [PATCH v15 00/13] mux controller abstraction and iio/i2c muxes

2017-06-03 Thread Greg Kroah-Hartman
On Sat, Jun 03, 2017 at 08:37:21PM +0200, Luc Van Oostenryck wrote: > On Sat, Jun 3, 2017 at 12:26 PM, Greg Kroah-Hartman > <gre...@linuxfoundation.org> wrote: > > On Sun, May 14, 2017 at 09:51:03PM +0200, Peter Rosin wrote: > >> From: Peter Rosin <p...

Re: [Merge tag 'pci-v4.12-changes' of git] 857f864014: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8

2017-06-13 Thread Greg Kroah-Hartman
On Tue, Jun 13, 2017 at 09:13:32PM +0200, Sven-Haegar Koch wrote: > On Tue, 13 Jun 2017, Greg Kroah-Hartman wrote: > > > On Tue, Jun 13, 2017 at 10:25:40AM -0600, Logan Gunthorpe wrote: > > > > > > On 12/06/17 10:35 PM, Greg Kroah-Hartman wrote: > > > &g

Re: [Merge tag 'pci-v4.12-changes' of git] 857f864014: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8

2017-06-12 Thread Greg Kroah-Hartman
On Mon, Jun 12, 2017 at 10:29:20PM -0600, Logan Gunthorpe wrote: > > > On 12/06/17 10:18 PM, Greg Kroah-Hartman wrote: > > What test causes so many major numbers to be allocated? Is this > > in-kernel test code? Do you really have a system that requires so many > >

Re: [Merge tag 'pci-v4.12-changes' of git] 857f864014: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8

2017-06-12 Thread Greg Kroah-Hartman
On Tue, Jun 13, 2017 at 06:34:16AM +0200, Greg Kroah-Hartman wrote: > On Mon, Jun 12, 2017 at 10:29:20PM -0600, Logan Gunthorpe wrote: > > > > > > On 12/06/17 10:18 PM, Greg Kroah-Hartman wrote: > > > What test causes so many major numbers to be allocated? Is this

Re: [Merge tag 'pci-v4.12-changes' of git] 857f864014: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8

2017-06-13 Thread Greg Kroah-Hartman
On Tue, Jun 13, 2017 at 10:25:40AM -0600, Logan Gunthorpe wrote: > > > On 12/06/17 10:35 PM, Greg Kroah-Hartman wrote: > > Or better yet, just turn all char major allocations into dynamic, which > > would be really good for test systems. I thought someone proposed > &

Re: [PATCH 0/12] PM / sleep: Driver flags for system suspend/resume

2017-10-16 Thread Greg Kroah-Hartman
On Mon, Oct 16, 2017 at 03:12:35AM +0200, Rafael J. Wysocki wrote: > Hi All, > > Well, this took more time than expected, as I tried to cover everything I had > in mind regarding PM flags for drivers. > > This work was triggered by attempts to fix and optimize PM in the > i2c-designware-platdev

Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-16 Thread Greg Kroah-Hartman
On Mon, Oct 16, 2017 at 03:29:02AM +0200, Rafael J. Wysocki wrote: > struct dev_pm_info { > pm_message_tpower_state; > unsigned intcan_wakeup:1; > @@ -561,6 +580,7 @@ struct dev_pm_info { > boolis_late_suspended:1; > bool

Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-16 Thread Greg Kroah-Hartman
On Mon, Oct 16, 2017 at 03:29:02AM +0200, Rafael J. Wysocki wrote: > +static inline void dev_pm_set_driver_flags(struct device *dev, unsigned int > flags) > +{ > + dev->power.driver_flags = flags; > +} Should this function just set the specific bit? Or is it going to be ok to set the whole

[PATCH] Documentation: add Kernel Driver Statement to the kernel

2017-10-06 Thread Greg Kroah-Hartman
reference it in one canonical place (as the LF wiki keeps moving things around.) This also will allow people to add their names to it, as I seem to have lost the ability to do that by not knowing how to edit things on the original document. Signed-off-by: Greg Kroah-Hartman <gre...@linuxf

Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-17 Thread Greg Kroah-Hartman
On Tue, Oct 17, 2017 at 12:05:11AM +0200, Rafael J. Wysocki wrote: > On Monday, October 16, 2017 8:28:52 AM CEST Greg Kroah-Hartman wrote: > > On Mon, Oct 16, 2017 at 03:29:02AM +0200, Rafael J. Wysocki wrote: > > > struct dev_pm_info { > > > pm_messa

Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-17 Thread Greg Kroah-Hartman
On Tue, Oct 17, 2017 at 12:07:37AM +0200, Rafael J. Wysocki wrote: > On Monday, October 16, 2017 8:31:22 AM CEST Greg Kroah-Hartman wrote: > > On Mon, Oct 16, 2017 at 03:29:02AM +0200, Rafael J. Wysocki wrote: > > > +static inline void dev_pm_set_driver_flags(struct dev

Re: [PATCH V3 2/8] drivers: boot_constraint: Add boot_constraints_disable kernel parameter

2017-08-29 Thread Greg Kroah-Hartman
On Tue, Aug 01, 2017 at 02:53:43PM +0530, Viresh Kumar wrote: > Users must be given an option to discard any constraints set by > bootloaders. For example, consider that a constraint is set for the LCD > controller's supply and the LCD driver isn't loaded by the kernel. If > the user doesn't need

Re: [PATCH V3 2/8] drivers: boot_constraint: Add boot_constraints_disable kernel parameter

2017-08-29 Thread Greg Kroah-Hartman
On Tue, Aug 29, 2017 at 12:02:41PM +0200, Viresh Kumar wrote: > On 29-08-17, 08:37, Greg Kroah-Hartman wrote: > > On Tue, Aug 01, 2017 at 02:53:43PM +0530, Viresh Kumar wrote: > > > + boot_constraints_disable > > > + Do not set any boot constraints for

Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-18 Thread Greg Kroah-Hartman
On Tue, Oct 17, 2017 at 05:26:20PM +0200, Rafael J. Wysocki wrote: > On Tuesday, October 17, 2017 9:15:43 AM CEST Greg Kroah-Hartman wrote: > > On Tue, Oct 17, 2017 at 12:05:11AM +0200, Rafael J. Wysocki wrote: > > > On Monday, October 16, 2017 8:28:52 AM CEST Greg K

Re: [Update][PATCH v2 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-19 Thread Greg Kroah-Hartman
t need to be > checked by ->prepare callbacks. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com> Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] Documentation: update kernel enforcement support list

2017-10-18 Thread Greg Kroah-Hartman
On Tue, Oct 17, 2017 at 08:06:53AM -0700, Eduardo Valentin wrote: > Adding myself to the list as I missed the window to be in the original patch. > > Cc: Jonathan Corbet > Cc: Bart Van Assche > Cc: Namhyung Kim > Cc: Olof Johansson

Re: [RFC] doc: add maintainer book

2017-11-22 Thread Greg Kroah-Hartman
On Wed, Nov 22, 2017 at 09:39:39AM +1100, Tobin C. Harding wrote: > There is currently very little documentation in the kernel on maintainer > level tasks. In particular there are no documents on creating pull > requests to submit to Linus. > > Quoting Greg Kroah-Hartman on LKML:

Re: [PATCH v2] doc: add maintainer book

2017-11-24 Thread Greg Kroah-Hartman
On Sat, Nov 25, 2017 at 08:44:19AM +1100, Tobin C. Harding wrote: > There is currently very little documentation in the kernel on maintainer > level tasks. In particular there are no documents on creating pull > requests to submit to Linus. > > Quoting Greg Kroah-Hartman on LKML:

Re: [PATCH v2] doc: add maintainer book

2017-11-25 Thread Greg Kroah-Hartman
On Sat, Nov 25, 2017 at 07:22:36PM +1100, Tobin C. Harding wrote: > On Sat, Nov 25, 2017 at 08:56:23AM +0100, Greg Kroah-Hartman wrote: > > On Sat, Nov 25, 2017 at 08:44:19AM +1100, Tobin C. Harding wrote: > > > There is currently very little documentation in the kernel on main

Re: [PATCH v10 08/13] regmap: add SLIMbus support

2017-12-13 Thread Greg Kroah-Hartman
On Mon, Dec 11, 2017 at 11:43:02PM +, srinivas.kandaga...@linaro.org wrote: > From: Srinivas Kandagatla > > This patch adds support to read/write SLIMbus value elements. > Currently it only supports byte read/write. Adding this support in > regmap would give

Re: [PATCH v10 00/13] Introduce framework for SLIMbus device driver

2017-12-13 Thread Greg Kroah-Hartman
On Mon, Dec 11, 2017 at 11:42:54PM +, srinivas.kandaga...@linaro.org wrote: > From: Srinivas Kandagatla > > SLIMbus (Serial Low Power Interchip Media Bus) is a specification > developed by MIPI (Mobile Industry Processor Interface) alliance. > SLIMbus is a

[PATCH 2/3] Documentation: Add Luis R. Rodriguez to list of enforcement statement endorsers

2017-12-13 Thread Greg Kroah-Hartman
From: "Luis R. Rodriguez" <mcg...@kernel.org> Add my name to the list. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- Documentation/process/kernel-enforcement-statement.rst | 1 + 1 file changed

[PATCH 1/3] Documentation: Add Kees Cook to list of enforcement statement endorsers

2017-12-13 Thread Greg Kroah-Hartman
From: Kees Cook <keesc...@chromium.org> Add my name to the list. Signed-off-by: Kees Cook <keesc...@chromium.org> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- Documentation/process/kernel-enforcement-statement.rst | 1 + 1 file changed, 1 insert

[PATCH 0/3] Documentation: more names to the enforcement statement

2017-12-13 Thread Greg Kroah-Hartman
Hi Jon, Here are 3 patches for the kernel-enforcement-statement file that came in after the file was originally added to the kernel tree. thanks, greg k-h David Sterba (1): Documentation: Add myself to the enforcement statement list Kees Cook (1): Documentation: Add Kees Cook to list of

[PATCH 3/3] Documentation: Add myself to the enforcement statement list

2017-12-13 Thread Greg Kroah-Hartman
From: David Sterba <dste...@suse.com> Signed-off-by: David Sterba <dste...@suse.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- Documentation/process/kernel-enforcement-statement.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentat

Re: [RFC 2/5] i3c: Add core I3C infrastructure

2017-12-13 Thread Greg Kroah-Hartman
On Wed, Dec 13, 2017 at 05:20:43PM +0100, Boris Brezillon wrote: > Hi Greg, > > On Tue, 1 Aug 2017 19:13:27 -0700 > Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > > > > > > Unless you see a good reason to not use a R/W lock, I'd like to keep >

Re: Maintainer docs for patch merging

2017-12-19 Thread Greg Kroah-Hartman
On Wed, Dec 20, 2017 at 11:25:41AM +1100, Tobin C. Harding wrote: > Hi, > > Recently we started a maintainer book (merged into Jonathan's docs-next > branch). > > Would any current maintainers please be willing to explain how they go > about generating the automated emails one often receives

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

2017-12-19 Thread Greg Kroah-Hartman
On Tue, Dec 19, 2017 at 10:13:36AM +0100, Boris Brezillon wrote: > On Tue, 19 Dec 2017 10:09:00 +0100 > Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > > > On Tue, 19 Dec 2017 09:52:50 +0100 > > Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

2017-12-19 Thread Greg Kroah-Hartman
On Thu, Dec 14, 2017 at 04:16:05PM +0100, Boris Brezillon wrote: > +/** > + * i3c_device_match_id() - Find the I3C device ID entry matching an I3C dev > + * @i3cdev: the I3C device we're searching a match for > + * @id_table: the I3C device ID table > + * > + * Return: a pointer to the first entry

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

2017-12-19 Thread Greg Kroah-Hartman
On Tue, Dec 19, 2017 at 10:28:58AM +0100, Boris Brezillon wrote: > On Tue, 19 Dec 2017 10:21:19 +0100 > Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > > > On Tue, Dec 19, 2017 at 10:13:36AM +0100, Boris Brezillon wrote: > > > On Tue, 19 Dec 2017 10:09:

[PATCH] Documentation/process: add Co-Developed-by: tag for patches with multiple authors

2017-11-16 Thread Greg Kroah-Hartman
of the patch. Note, these other authors must also provide a Signed-off-by: tag as it is their work that is being submitted here. Reported-by: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> diff --git a/Documentation/process/5.Post

Re: git pull

2017-11-14 Thread Greg Kroah-Hartman
On Tue, Nov 14, 2017 at 01:00:14PM +0100, Ulf Hansson wrote: > [...] > > > > > An example pull request of mine might look like: > > Char/Misc patches for 4.15-rc1 > > > > Here is the big char/misc patch set for the 4.15-rc1 merge > > window. Contained in here is the

Re: git pull

2017-11-14 Thread Greg Kroah-Hartman
Adding lkml and linux-doc mailing lists... On Tue, Nov 14, 2017 at 10:11:55AM +1100, Tobin C. Harding wrote: > Hi Greg, > > This is totally asking a favour, feel free to ignore. How do you format > your [GIT PULL] emails to Linus? Do you create a tag and then run a git > command to get the

[PATCH 4.9 102/109] dma-buf: Update kerneldoc for sync_file_create

2017-12-07 Thread Greg Kroah-Hartman
rg> Link: http://patchwork.freedesktop.org/patch/msgid/20161209185309.1682-3-daniel.vet...@ffwll.ch Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers/dma-buf/sync_file.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) --- a/drivers/dma-b

Re: [PATCH 17/18] docs: uio-howto.rst: use a code block to solve a warning

2018-05-07 Thread Greg Kroah-Hartman
On Mon, May 07, 2018 at 06:35:53AM -0300, Mauro Carvalho Chehab wrote: > /devel/v4l/docs/Documentation/driver-api/uio-howto.rst:715: WARNING: > Unexpected indentation. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org> Reviewed-by: Greg

Re: [PATCH 08/18] docs: driver-api: add clk documentation

2018-05-07 Thread Greg Kroah-Hartman
On Mon, May 07, 2018 at 06:35:44AM -0300, Mauro Carvalho Chehab wrote: > The clk.rst is already in ReST format. So, move it to the > driver-api guide, where it belongs. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org> Reviewed-by: Greg

Re: [PATCH 02/18] docs: fix location of request_firmware & friends

2018-05-07 Thread Greg Kroah-Hartman
into its own directory") > Cc: Kees Cook <keesc...@chromium.org> > Cc: Luis R. Rodriguez <mcg...@kernel.org> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Signed-off-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org> Reviewed-by: Greg Kroah-Hartman <gr

Re: [PATCH 03/18] docs: */index.rst: Add newer documents to their respective index.rst

2018-05-07 Thread Greg Kroah-Hartman
Chehab <mchehab+sams...@kernel.org> Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] PCI/AER: Define and allocate aer_stats structure for AER capable devices

2018-05-23 Thread Greg Kroah-Hartman
On Tue, May 22, 2018 at 03:28:01PM -0700, Rajat Jain wrote: > --- /dev/null > +++ b/drivers/pci/pcie/aer/aerdrv_stats.c > @@ -0,0 +1,64 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2018 Google Inc, All Rights Reserved. > + * Rajat Jain (raja...@google.com) Google has the

Re: [PATCH 2/5] PCI/AER: Add sysfs stats for AER capable devices

2018-05-23 Thread Greg Kroah-Hartman
On Tue, May 22, 2018 at 03:28:02PM -0700, Rajat Jain wrote: > Add the following AER sysfs stats to represent the counters for each > kind of error as seen by the device: > > dev_total_cor_errs > dev_total_fatal_errs > dev_total_nonfatal_errs You need Documentation/ABI/ updates for new sysfs

Re: [PATCH 3/5] PCP/AER: Add sysfs attributes to provide breakdown of AERs

2018-05-23 Thread Greg Kroah-Hartman
On Tue, May 22, 2018 at 03:28:03PM -0700, Rajat Jain wrote: > Add sysfs attributes to provide breakdown of the AERs seen, > into different type of correctable or uncorrectable errors: > > dev_breakdown_correctable > dev_breakdown_uncorrectable > > Signed-off-by: Rajat Jain >

Re: [PATCH 5/5] Documentation/PCI: Add details of PCI AER statistics

2018-05-23 Thread Greg Kroah-Hartman
On Tue, May 22, 2018 at 03:28:05PM -0700, Rajat Jain wrote: > Add the PCI AER statistics details to > Documentation/PCI/pcieaer-howto.txt > > Signed-off-by: Rajat Jain > --- > Documentation/PCI/pcieaer-howto.txt | 35 + > 1 file changed, 35

Re: [PATCH 2/5] PCI/AER: Add sysfs stats for AER capable devices

2018-05-23 Thread Greg Kroah-Hartman
On Tue, May 22, 2018 at 03:28:02PM -0700, Rajat Jain wrote: > +#define aer_stats_aggregate_attr(field) > \ > + static ssize_t \ > + field##_show(struct device *dev, struct device_attribute

Re: [PATCH v2 1/5] PCI/AER: Define and allocate aer_stats structure for AER capable devices

2018-05-24 Thread Greg Kroah-Hartman
On Wed, May 23, 2018 at 10:58:04AM -0700, Rajat Jain wrote: > --- > v2: Fix the license header as per Greg's suggestions > (Since there is disagreement with using "//" vs "/* */" for license > I decided to keep the one preferred by Linus, also used by others > in this directory) The

Re: [PATCH 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device

2018-05-26 Thread Greg Kroah-Hartman
On Sat, May 26, 2018 at 10:33:59PM +0200, Marcus Folkesson wrote: > Signed-off-by: Marcus Folkesson I can't take patches without any changelog text. And why would you submit a patch over 1000 lines without any? Please fix. thanks, greg k-h -- To unsubscribe from

Re: [PATCH 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device

2018-05-27 Thread Greg Kroah-Hartman
On Sun, May 27, 2018 at 07:48:47AM +0200, Marcus Folkesson wrote: > On Sat, May 26, 2018 at 10:56:52PM +0200, Greg Kroah-Hartman wrote: > > On Sat, May 26, 2018 at 10:33:59PM +0200, Marcus Folkesson wrote: > > > Signed-off-by: Marcus Folkesson <marcus.folkes...@gmail.com&g

Re: [PATCH v4 03/10] i3c: Add sysfs ABI spec

2018-05-02 Thread Greg Kroah-Hartman
On Wed, May 02, 2018 at 11:47:49AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Sun, Apr 29, 2018 at 3:37 PM, Greg Kroah-Hartman > <gre...@linuxfoundation.org> wrote: > > On Fri, Mar 30, 2018 at 09:47:44AM +0200, Boris Brezillon wrote: > >> Document sysfs f

Re: LICENSES: Missing ISC text & possibly a category ("Not recommended" vs. "Preferred licenses")

2018-04-29 Thread Greg Kroah-Hartman
On Sun, Apr 29, 2018 at 12:15:11PM +0200, Rafał Miłecki wrote: > On 29 April 2018 at 07:26, Greg Kroah-Hartman > <gre...@linuxfoundation.org> wrote: > > On Sat, Apr 28, 2018 at 11:25:17PM +0200, Rafał Miłecki wrote: > >> Due to some maintainers *preferring* BSD

Re: [PATCH v4 03/10] i3c: Add sysfs ABI spec

2018-04-29 Thread Greg Kroah-Hartman
On Fri, Mar 30, 2018 at 09:47:44AM +0200, Boris Brezillon wrote: > Document sysfs files/directories/symlinks exposed by the I3C subsystem. > > Signed-off-by: Boris Brezillon > --- > Changes in v2: > - new patch > --- > Documentation/ABI/testing/sysfs-bus-i3c | 95 >

Re: [PATCH v4 00/10] Add the I3C subsystem

2018-04-29 Thread Greg Kroah-Hartman
On Mon, Apr 23, 2018 at 07:56:46PM +0200, Greg Kroah-Hartman wrote: > On Mon, Apr 23, 2018 at 07:38:14PM +0200, Boris Brezillon wrote: > > Hi, > > > > On Fri, 30 Mar 2018 09:47:41 +0200 > > Boris Brezillon <boris.brezil...@bootlin.com> wrote: > > > >

Re: LICENSES: Missing ISC text & possibly a category ("Not recommended" vs. "Preferred licenses")

2018-04-28 Thread Greg Kroah-Hartman
On Sat, Apr 28, 2018 at 11:25:17PM +0200, Rafał Miłecki wrote: > Hi, > > Due to some maintainers *preferring* BSD-compatible license for DTS > files [0], I was writing mine using ISC. I had no very special reason > for it: I was choosing between BSD-2-Clause, MIT and ISC. I've chosen > ISC as I

Re: [Update][PATCH v2 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags

2017-10-20 Thread Greg Kroah-Hartman
On Fri, Oct 20, 2017 at 01:11:22PM +0200, Rafael J. Wysocki wrote: > On Thursday, October 19, 2017 9:33:15 AM CEST Greg Kroah-Hartman wrote: > > On Thu, Oct 19, 2017 at 01:17:31AM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki <rafael.j.wyso...@intel.com> >

  1   2   >