[PATCH 01/10] PCI: endpoint: Add MSI-X interfaces

2018-04-27 Thread Gustavo Pimentel
Add PCI_EPC_IRQ_MSIX type. Add MSI-X callbacks signatures to ops structure. Add sysfs interface for set/get MSI-X capability maximum number. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- drivers/pci/endpoint/pci-ep-cfs.c | 24 drivers/pci/endpoi

[PATCH 09/10] tools: PCI: Add MSI-X support

2018-04-27 Thread Gustavo Pimentel
Add MSI-X support to pcitest tool. Modify pcitest.sh script to accomodate MSI-X interrupt tests. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- include/uapi/linux/pcitest.h | 1 + tools/pci/pcitest.c | 18 +- tools/pci/pcitest.sh

[PATCH 02/10] PCI: dwc: Add MSI-X callbacks handler

2018-04-27 Thread Gustavo Pimentel
for triggering interruptions. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- drivers/pci/dwc/pci-dra7xx.c | 2 +- drivers/pci/dwc/pcie-artpec6.c | 2 +- drivers/pci/dwc/pcie-designware-ep.c | 143 - drivers/pci/dwc/pcie-desi

[PATCH 03/10] PCI: cadence: Update cdns_pcie_ep_raise_irq function signature

2018-04-27 Thread Gustavo Pimentel
Change cdns_pcie_ep_raise_irq() signature, namely the interrupt_num variable type from u8 to u16 to accommodate the 2048 maximum MSI-X interrupts. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> Acked-by: Alan Douglas <adoug...@cadence.com> --- drivers/pci/cadence/

[PATCH 06/10] misc: pci_endpoint_test: Add MSI-X support

2018-04-27 Thread Gustavo Pimentel
the interrupt ID number from the command section to a register located in a BAR. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- Documentation/misc-devices/pci-endpoint-test.txt | 3 + drivers/misc/pci_endpoint_test.c | 121 +++ drivers/pci/en

[PATCH 04/10] PCI: dwc: Rework MSI callbacks handler

2018-04-27 Thread Gustavo Pimentel
Remove duplicate defines located on pcie-designware.h file already available on /include/uapi/linux/pci-regs.h file. Add pci_epc_set_msi() maximum 32 interrupts validation. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- drivers/pci/dwc/pcie-designware-ep.

[PATCH 10/10] misc: pci_endpoint_test: Use pci_irq_vector function

2018-04-27 Thread Gustavo Pimentel
Replace "pdev->irq + index" operation by the pci_irq_vector() call, that converts from device vector to Linux IRQ. (suggestion made by Alan Douglas). Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- drivers/misc/pci_endpoint_test.c | 10 +- 1 file ch

[PATCH 07/10] misc: pci_endpoint_test: Replace lower into upper case characters

2018-04-27 Thread Gustavo Pimentel
Replace all initial lower case character into upper case in comments and debug printks. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- drivers/misc/pci_endpoint_test.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/driver

[PATCH 08/10] PCI: endpoint: functions/pci-epf-test: Replace lower into upper case characters

2018-04-27 Thread Gustavo Pimentel
Replace all initial lower case character into upper case in comments and debug printks. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- drivers/pci/endpoint/functions/pci-epf-test.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff

[PATCH 05/10] PCI: dwc: Add legacy interrupt callback handler

2018-04-27 Thread Gustavo Pimentel
Add a legacy interrupt callback handler. Currently DesignWare IP don't allow triggering the legacy interrupt. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- drivers/pci/dwc/pcie-designware-ep.c | 10 ++ drivers/pci/dwc/pcie-designware-plat.c | 3 +-- drive

[PATCH 00/10] Add MSI-X support on pcitest tool

2018-04-27 Thread Gustavo Pimentel
driver. Add a new input parameter (msix) to pcitest tool to test MSI-X feature. Update the pcitest.sh script to support MSI-X feature tests. [1] -> https://lkml.org/lkml/2018/4/27/342 Gustavo Pimentel (10): PCI: endpoint: Add MSI-X interfaces PCI: dwc: Add MSI-X callbacks handler

Re: [RFC 01/10] PCI: dwc: Add MSI-X callbacks handler

2018-05-10 Thread Gustavo Pimentel
Hi Alan, Sorry for the delay on the response, I only have time to proper analyze this now. On 24/04/2018 10:15, Alan Douglas wrote: > Hi, > > On 10 April 2018 18:15 Gustavo Pimentel wrote: >> Changes the pcie_raise_irq function signature, namely the interrupt_num >>

[PATCH v2 4/7] PCI: dwc: Rework MSI callbacks handler

2018-05-17 Thread Gustavo Pimentel
Remove duplicate defines located on pcie-designware.h file already available on /include/uapi/linux/pci-regs.h file. Add pci_epc_set_msi() maximum 32 interrupts validation. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- Change v1->v2: - Nothing changed, just

[PATCH v2 1/7] PCI: endpoint: Add MSI-X interfaces

2018-05-17 Thread Gustavo Pimentel
-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- Change v1->v2: - Nothing changed, just to follow the patch set version. drivers/pci/endpoint/pci-ep-cfs.c | 24 +++ drivers/pci/endpoint/pci-epc-core.c | 59 - include/linux/

[PATCH v2 0/7] Add MSI-X support on pcitest tool

2018-05-17 Thread Gustavo Pimentel
on set/get and triggering MSI methods on EP DesignWare IP driver. Add a new input parameter (msix) to pcitest tool to test MSI-X feature. Update the pcitest.sh script to support MSI-X feature tests. Gustavo Pimentel (7): PCI: endpoint: Add MSI-X interfaces PCI: dwc: Add MSI-X callbacks handler

[PATCH v2 3/7] PCI: cadence: Update cdns_pcie_ep_raise_irq function signature

2018-05-17 Thread Gustavo Pimentel
Change cdns_pcie_ep_raise_irq() signature, namely the interrupt_num variable type from u8 to u16 to accommodate 2048 maximum MSI-X interrupts. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> Acked-by: Alan Douglas <adoug...@cadence.com> --- Change v1->v2: - Nothin

[PATCH v2 5/7] PCI: dwc: Add legacy interrupt callback handler

2018-05-17 Thread Gustavo Pimentel
Add a legacy interrupt callback handler. Currently DesignWare IP don't allow trigger legacy interrupts. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- Change v1->v2: - Nothing changed, just to follow the patch set version. drivers/pci/dwc/pcie-designware-ep

[PATCH v2 7/7] tools: PCI: Add MSI-X support

2018-05-17 Thread Gustavo Pimentel
Add MSI-X support to pcitest tool. Add 2 new IOCTL commands: - Allow to reconfigure driver IRQ type in runtime. - Allow to retrieve current driver IRQ type configured. Modify pcitest.sh script to accommodate MSI-X interrupt tests. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.

[PATCH v2 6/7] misc: pci_endpoint_test: Add MSI-X support

2018-05-17 Thread Gustavo Pimentel
process, by having in a BAR: - Interrupt type triggered (added). - Interrupt ID number (moved from the command section). Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- Change v1->v2: - Allow IRQ type driver reconfiguring in runtime, follwing Kishon's suggestion. Docu

[PATCH v2 2/7] PCI: dwc: Add MSI-X callbacks handler

2018-05-17 Thread Gustavo Pimentel
for triggering interruptions. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- Change v1->v2: - Nothing changed, just to follow the patch set version. drivers/pci/dwc/pci-dra7xx.c | 2 +- drivers/pci/dwc/pcie-artpec6.c | 2 +- drivers/pci/dwc/pcie-design

Re: [RFC 01/10] PCI: dwc: Add MSI-X callbacks handler

2018-04-26 Thread Gustavo Pimentel
Hi Kishon, On 24/04/2018 12:24, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 24 April 2018 03:06 PM, Gustavo Pimentel wrote: >> Hi Kishon, >> >> On 24/04/2018 08:07, Kishon Vijay Abraham I wrote: >>> Hi, >>> >>> On Monday 23 April

Re: [RFC 06/10] misc: pci_endpoint_test: Add MSI-X support

2018-04-26 Thread Gustavo Pimentel
Hi Kishon, On 24/04/2018 12:43, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 24 April 2018 04:27 PM, Gustavo Pimentel wrote: >> Hi Kishon, >> >> On 24/04/2018 08:19, Kishon Vijay Abraham I wrote: >>> Hi, >>> >>> On Tuesday 17 April

Re: [PATCH 06/10] misc: pci_endpoint_test: Add MSI-X support

2018-04-30 Thread Gustavo Pimentel
Hi Alan, On 30/04/2018 16:35, Alan Douglas wrote: > Hi Gustavo, > > On April 27, 2018, 4:57 p.m. Gustavo Pimentel wrote: >> Add MSI-X support and update driver documentation accordingly. >> >> Add new driver parameter to allow interruption type selection. >> &g

[RFC 01/10] PCI: dwc: Add MSI-X callbacks handler

2018-04-10 Thread Gustavo Pimentel
more generic and flexible. Implements MSI-X set/get functions for sysfs interface in order to change the EP entries number. Implements EP MSI-X interface for triggering interruptions. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- drivers/pci/dwc/pci-dra7xx.c

[RFC 07/10] misc: pci_endpoint_test: Replace lower into upper case characters

2018-04-10 Thread Gustavo Pimentel
Replaces lower into upper case characters in comments and debug printks. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- drivers/misc/pci_endpoint_test.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/misc/pci_endpoint_te

[RFC 05/10] PCI: dwc: Add legacy interrupt callback handler

2018-04-10 Thread Gustavo Pimentel
Adds a legacy interrupt callback handler. Currently Designware IP doesn't allow triggering the legacy interrupt. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- drivers/pci/dwc/pcie-designware-ep.c | 10 ++ drivers/pci/dwc/pcie-designware-plat.c | 3 +-- d

[RFC 04/10] PCI: dwc: MSI callbacks handler rework

2018-04-10 Thread Gustavo Pimentel
Adds in pci_epc_set_msi function a maximum number of 32 interrupts validation. Removes duplicate defines located on pcie-designware.h file. Uses now the defines available on /include/uapi/linux/pci-regs.h file. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- drivers/p

[RFC 02/10] PCI: cadence: Update cdns_pcie_ep_raise_irq function signature

2018-04-10 Thread Gustavo Pimentel
Changes the cdns_pcie_ep_raise_irq function signature, namely the interrupt_num variable type from u8 to u16 to accommodate the MSI-X maximum interrupts of 2048. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- drivers/pci/cadence/pcie-cadence-ep.c | 2 +- 1 file chan

[RFC 06/10] misc: pci_endpoint_test: Add MSI-X support

2018-04-10 Thread Gustavo Pimentel
Adds the MSI-X support and updates driver documentation accordingly. Changes the driver parameter in order to allow the interruption type selection. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- Documentation/misc-devices/pci-endpoint-test.txt | 3 + driver

[RFC 10/10] tools: PCI: Add MSI-X support

2018-04-10 Thread Gustavo Pimentel
Adds MSI-X support to the pcitest tool and modified the pcitest.sh script to accomodate this new type of interruption test. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- include/uapi/linux/pcitest.h | 1 + tools/pci/pcitest.c | 18 +- too

[RFC 08/10] PCI: endpoint: functions/pci-epf-test: Add MSI-X support

2018-04-10 Thread Gustavo Pimentel
Adds driver's MSI-X support. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- drivers/pci/endpoint/functions/pci-epf-test.c | 87 +-- 1 file changed, 69 insertions(+), 18 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-tes

[RFC 09/10] PCI: endpoint: functions/pci-epf-test: Replace lower into upper case characters

2018-04-10 Thread Gustavo Pimentel
Replaces lower into upper case characters in comments and debug printks. Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> --- drivers/pci/endpoint/functions/pci-epf-test.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drive

Re: [RFC 03/10] PCI: endpoint: Add MSI-X interfaces

2018-04-17 Thread Gustavo Pimentel
Hi Kishon, On 17/04/2018 11:24, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 10 April 2018 10:44 PM, Gustavo Pimentel wrote: >> Implements the generic method for calling the get/set callbacks. >> >> Adds the PCI_EPC_IRQ_MSIX type. >> >> Adds th

Re: [RFC 10/10] tools: PCI: Add MSI-X support

2018-04-24 Thread Gustavo Pimentel
Hi Alan, On 24/04/2018 10:57, Alan Douglas wrote: > Hi Gustavo, > > On 10 April 2018 18:15, Gustavo Pimentel wrote: >> Adds MSI-X support to the pcitest tool and modified the pcitest.sh script to >> accomodate this new type of interruption test. >> >>

Re: [RFC 01/10] PCI: dwc: Add MSI-X callbacks handler

2018-04-23 Thread Gustavo Pimentel
Hi Kishon, On 16/04/2018 10:29, Kishon Vijay Abraham I wrote: > Hi Gustavo, > > On Tuesday 10 April 2018 10:44 PM, Gustavo Pimentel wrote: >> Changes the pcie_raise_irq function signature, namely the interrupt_num >> variable type from u8 to u16 to accommodate the MSI

Re: [RFC 06/10] misc: pci_endpoint_test: Add MSI-X support

2018-04-24 Thread Gustavo Pimentel
Hi Kishon, On 24/04/2018 08:19, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 17 April 2018 11:08 PM, Gustavo Pimentel wrote: >> Hi Kishon, >> >> On 17/04/2018 11:33, Kishon Vijay Abraham I wrote: >>> Hi, >>> >>> On Tuesday 10 April 2018

Re: [RFC 01/10] PCI: dwc: Add MSI-X callbacks handler

2018-04-24 Thread Gustavo Pimentel
Hi Kishon, On 24/04/2018 08:07, Kishon Vijay Abraham I wrote: > Hi, > > On Monday 23 April 2018 03:06 PM, Gustavo Pimentel wrote: >> Hi Kishon, >> >> On 16/04/2018 10:29, Kishon Vijay Abraham I wrote: >>> Hi Gustavo, >>> >>> On Tuesday 10 Apr

Re: [RFC 00/10] Adds pcitest tool support for MSI-X

2018-04-24 Thread Gustavo Pimentel
Hi Alan, On 24/04/2018 07:48, Alan Douglas wrote: > Hi Gustavo, > > On 10 April 2018 18:15 Gustavo Pimentel wrote: >> This patch set depends the following series: >> https://urldefense.proofpoint.com/v2/url?u=https-3A__lkml.org_lkml_2018_4_10_421=DwIFAg=DPL6_X_6JkXF

Re: [RFC 06/10] misc: pci_endpoint_test: Add MSI-X support

2018-04-24 Thread Gustavo Pimentel
Hi Alan, On 24/04/2018 07:59, Alan Douglas wrote: > Hi Gustavo, > > On 10 April 2018 18:15 Gustavo Pimentel wrote: >> >> Adds the MSI-X support and updates driver documentation accordingly. >> >> Changes the driver parameter in order to allow the interruption ty

Re: [RFC 01/10] PCI: dwc: Add MSI-X callbacks handler

2018-04-24 Thread Gustavo Pimentel
On 24/04/2018 10:15, Alan Douglas wrote: > Hi, > > On 10 April 2018 18:15 Gustavo Pimentel wrote: >> Changes the pcie_raise_irq function signature, namely the interrupt_num >> variable type from u8 to u16 to accommodate the MSI-X maximum interrupts >> of 2048. >>

Re: [RFC 06/10] misc: pci_endpoint_test: Add MSI-X support

2018-04-17 Thread Gustavo Pimentel
Hi Kishon, On 17/04/2018 11:33, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 10 April 2018 10:44 PM, Gustavo Pimentel wrote: >> Adds the MSI-X support and updates driver documentation accordingly. >> >> Changes the driver parameter in order to allow the int