Re: [PATCH v2 2/5] Documentation: Add doc for runchecks, a checker runner

2017-12-16 Thread Knut Omang
/runchecks.rst > > @@ -0,0 +1,215 @@ > > +.. Copyright 2017 Knut Omang <knut.om...@oracle.com> > > + > > +Makefile support for running checkers > > += > > + > > +Tools like sparse, coccinelle and scripts/checkpatch.p

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-16 Thread Knut Omang
On Sat, 2017-12-16 at 09:00 -0800, Joe Perches wrote: > On Sat, 2017-12-16 at 17:27 +0100, Knut Omang wrote: > > On Sat, 2017-12-16 at 07:21 -0800, Joe Perches wrote: > > > On Sat, 2017-12-16 at 15:42 +0100, Knut Omang wrote: > > > > This patch series implements fea

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-16 Thread Knut Omang
On Sat, 2017-12-16 at 07:21 -0800, Joe Perches wrote: > On Sat, 2017-12-16 at 15:42 +0100, Knut Omang wrote: > > This patch series implements features to make it easier to run checkers on > > the > > entire kernel as part of automatic and developer testing. > &g

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-18 Thread Knut Omang
On Mon, 2017-12-18 at 07:30 -0800, Joe Perches wrote: > On Mon, 2017-12-18 at 14:05 +0100, Knut Omang wrote: > > > Here is a list of the checkpatch messages for drivers/infiniband > > > sorted by type. > > > > > > Many of these might be corrected by using &g

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-18 Thread Knut Omang
On Sun, 2017-12-17 at 22:00 -0700, Jason Gunthorpe wrote: > On Sun, Dec 17, 2017 at 03:14:10AM +0100, Knut Omang wrote: > > > > I like the ability to add more checkers and keep then in the main > > > upstream tree. But adding overrides for specific subsystems goes

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-18 Thread Knut Omang
On Sun, 2017-12-17 at 22:00 -0800, Joe Perches wrote: > On Sun, 2017-12-17 at 22:00 -0700, Jason Gunthorpe wrote: > > On Sun, Dec 17, 2017 at 03:14:10AM +0100, Knut Omang wrote: > > > > > > I like the ability to add more checkers and keep then in the main > &

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-18 Thread Knut Omang
On Mon, 2017-12-18 at 17:56 +, Bart Van Assche wrote: > On Mon, 2017-12-18 at 10:46 -0700, Jason Gunthorpe wrote: > > On Sun, Dec 17, 2017 at 10:00:17PM -0800, Joe Perches wrote: > > > > > > Today when we run checkers we get so many warnings it is too hard to > > > > make any sense of it. > >

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-16 Thread Knut Omang
On Sat, 2017-12-16 at 09:47 -0800, Stephen Hemminger wrote: > On Sat, 16 Dec 2017 15:42:25 +0100 > Knut Omang <knut.om...@oracle.com> wrote: > > > This patch series implements features to make it easier to run checkers on > > the > > entire kernel as part o

[PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-16 Thread Knut Omang
checker in cases where types either are not available at all (checkdoc) or where only a few can be filtered out (sparse) With this in place it also became trivial to make the look and feel similar for sparse and checkdoc as for checkpatch, with some optional color support too, to make fixing issues in the

[PATCH v2 2/5] Documentation: Add doc for runchecks, a checker runner

2017-12-16 Thread Knut Omang
ess sparse specific and more generic. The coccinelle documentation also had the behaviour of C=1 and C=2 swapped. Signed-off-by: Knut Omang <knut.om...@oracle.com> Reviewed-by: Håkon Bugge <haakon.bu...@oracle.com> Reviewed-by: Åsmund Østvold <asmund.ostv...@oracle.com> Revi

Re: [PATCH 0/7] Support for automatic checkpatch running in the kernel

2017-11-17 Thread Knut Omang
-checkpatch.html Thanks, Knut On Thu, 2017-11-16 at 18:01 +0100, Knut Omang wrote: > This patch series implements features to facilitate running checkpatch on the > entire kernel as part of automatic testing. > > This is done by by adding a few small features to checkpatch and put these >

[PATCH 7/7] Documentation: Update checkpatch --ignore-cfg description

2017-11-16 Thread Knut Omang
When running checkpatch with --ignore-cfg it will now traverse the directories above the source file until a match is found. Reflect this enhanced behaviour in the documentation. Signed-off-by: Knut Omang <knut.om...@oracle.com> --- Documentation/dev-tools/run-checkpatch.rs

[PATCH 4/7] Documentation: Add documentation for the new P= Makefile option

2017-11-16 Thread Knut Omang
Signed-off-by: Knut Omang <knut.om...@oracle.com> Reviewed-by: Håkon Bugge <haakon.bu...@oracle.com> Reviewed-by: Åsmund Østvold <asmund.ostv...@oracle.com> Reviewed-by: John Haxby <john.ha...@oracle.com> Signed-off-by: Knut Omang <knut.om...@oracle.com> --- Doc

[PATCH 0/7] Support for automatic checkpatch running in the kernel

2017-11-16 Thread Knut Omang
patch.cfg file(s) to have 0 errors or warnings at any commit boundary. The combined set is available here: git://github.com/knuto/linux.git branch checkpatch Comments and suggestions appreciated! Thanks, Knut Knut Omang (7): checkpatch: Implement new --ignore-cfg parameter kbuild: Add P=

Re: [PATCH 0/7] Support for automatic checkpatch running in the kernel

2017-11-16 Thread Knut Omang
On Thu, 2017-11-16 at 14:57 -0800, Kees Cook wrote: > On Thu, Nov 16, 2017 at 9:01 AM, Knut Omang <knut.om...@oracle.com> wrote: > > The most important checkpatch feature added is the --ignore-cfg feature, > > which > > takes a file argument and parses that fil

Re: [PATCH v3 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

2018-01-04 Thread Knut Omang
On Thu, 2018-01-04 at 17:50 +0200, Jani Nikula wrote: > On Thu, 04 Jan 2018, Knut Omang <knut.om...@oracle.com> wrote: > > Add scripts/runchecks which has generic support for running > > checker tools in a convenient and user friendly way that > > the author hopes can c

Re: [PATCH v3 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

2018-01-05 Thread Knut Omang
On Fri, 2018-01-05 at 16:08 -0200, Mauro Carvalho Chehab wrote: > Em Thu, 04 Jan 2018 21:15:31 +0100 > Knut Omang <knut.om...@oracle.com> escreveu: > > > > I'm surprised the commit message and the provided documentation say > > > nothing about using CHECK=foo

Re: [PATCH v3 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

2018-01-07 Thread Knut Omang
On Sun, 2018-01-07 at 13:03 +0100, Philippe Ombredanne wrote: > Knut, > > On Fri, Jan 5, 2018 at 3:30 PM, Jani Nikula <jani.nik...@linux.intel.com> > wrote: > > On Thu, 04 Jan 2018, Knut Omang <knut.om...@oracle.com> wrote: > >> On Thu, 2018-01-04 at 17:50

Re: [PATCH v3 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

2018-01-07 Thread Knut Omang
On Sun, 2018-01-07 at 08:12 -0200, Mauro Carvalho Chehab wrote: > Em Fri, 05 Jan 2018 20:41:41 +0100 > Knut Omang <knut.om...@oracle.com> escreveu: > > > On Fri, 2018-01-05 at 16:08 -0200, Mauro Carvalho Chehab wrote: > > > Em Thu, 04 Jan 2018 21:15:31 +

[PATCH v4 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

2018-01-19 Thread Knut Omang
inelle documentation also had the behaviour of C=1 and C=2 swapped. Signed-off-by: Knut Omang <knut.om...@oracle.com> Reviewed-by: Håkon Bugge <haakon.bu...@oracle.com> Reviewed-by: Åsmund Østvold <asmund.ostv...@oracle.com> Reviewed-by: John Haxby <john.ha...@oracle.com> Re

[PATCH v4 0/1] Support for generalized use of make C={1,2} via a wrapper program

2018-01-19 Thread Knut Omang
ailable at all (checkdoc) or where only a few can be filtered out (sparse) With this in place it also became almost trivial to make the look and feel similar for sparse, smatch and checkdoc as for checkpatch, with some optional color support too, to make fixing issues in the code, the goal of thi

Re: [PATCH v4 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

2018-02-04 Thread Knut Omang
On Mon, 2018-02-05 at 16:03 +0900, Masahiro Yamada wrote: > 2018-02-05 15:41 GMT+09:00 Knut Omang <knut.om...@oracle.com>: > > On Fri, 2018-01-19 at 11:14 +0100, Knut Omang wrote: > >> Add scripts/runchecks which has generic support for running > >> checker tools

Re: [PATCH v4 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

2018-02-04 Thread Knut Omang
On Fri, 2018-01-19 at 11:14 +0100, Knut Omang wrote: > Add scripts/runchecks which has generic support for running > checker tools in a convenient and user friendly way that > the author hopes can contribute to rein in issues detected > by these tools in a manageable and co

[PATCH v3 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

2018-01-04 Thread Knut Omang
the behaviour of C=1 and C=2 swapped. Signed-off-by: Knut Omang <knut.om...@oracle.com> Reviewed-by: Håkon Bugge <haakon.bu...@oracle.com> Reviewed-by: Åsmund Østvold <asmund.ostv...@oracle.com> Reviewed-by: John Haxby <john.ha...@oracle.com> --- Documentation/dev-t

[PATCH v3 0/1] Support for generalized use of make C={1,2} via a wrapper program

2018-01-04 Thread Knut Omang
ome optional color support too, to make fixing issues in the code, the goal of this whole exercise, much more pleasant IMHO :-) Thanks, Knut Knut Omang (1): runchecks: Generalize make C={1,2} to support multiple checkers Documentation/dev-tools/coccinelle.rst | 12 +- Documentation/dev-

Re: [PATCH v4 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

2018-03-19 Thread Knut Omang
On Mon, 2018-02-05 at 08:20 +0100, Knut Omang wrote: > On Mon, 2018-02-05 at 16:03 +0900, Masahiro Yamada wrote: Hi Masahiro, I know these are busy times but any hope of getting forward on this? Anything more I can do to ease the process? Thanks for your time, Knut > > 2018-02-05 15: