pfn_mkwrite to take only vmf).
Signed-off-by: Liviu Dudau
---
Documentation/gpu/drm-mm.rst | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst
index 91d82f39fbf4..a1c0ae3b2c38 100644
--- a/Documentation
On Fri, May 19, 2017 at 12:25:49PM +0800, Leo Yan wrote:
> Add detailed documentation for Coresight CPU debug driver, which
> contains the info for driver implementation, Mike Leach excellent
> summary for "clock and power domain". At the end some examples on how
> to enable the debugging functiona
Hi Rob,
On Fri, Feb 23, 2018 at 08:17:51AM -0500, Rob Clark wrote:
> From: Brian Starkey
>
> Writeback connectors represent writeback engines which can write the
> CRTC output to a memory framebuffer. Add a writeback connector type and
> related support functions.
>
> Drivers should initialize
On Fri, Feb 23, 2018 at 09:24:10AM -0500, Rob Clark wrote:
> On Fri, Feb 23, 2018 at 9:00 AM, Liviu Dudau wrote:
> > Hi Rob,
> >
> > On Fri, Feb 23, 2018 at 08:17:51AM -0500, Rob Clark wrote:
> >> From: Brian Starkey
> >>
> >> Writeback connectors
since v4:
> > - Added atomic_commit() vfunc to connector helper funcs, so that
> >writeback jobs are committed from atomic helpers
> >
> > Signed-off-by: Brian Starkey
> > [rebased and fixed conflicts]
> > Signed-off-by: Mihail Atanass
On Fri, Feb 23, 2018 at 11:43:29AM -0500, Sean Paul wrote:
> On Fri, Feb 23, 2018 at 11:25:11AM -0500, Rob Clark wrote:
> > On Fri, Feb 23, 2018 at 10:59 AM, Sean Paul wrote:
> > >
> > > Have we considered hiding writeback behind a client cap instead?
> >
> > It is kinda *almost* unneeded, since
On Fri, Feb 23, 2018 at 11:39:06AM -0500, Sean Paul wrote:
> On Fri, Feb 23, 2018 at 04:21:05PM +0000, Liviu Dudau wrote:
> > On Fri, Feb 23, 2018 at 10:59:35AM -0500, Sean Paul wrote:
> > > On Fri, Feb 23, 2018 at 08:17:51AM -0500, Rob Clark wrote:
> >
On Mon, Dec 03, 2018 at 11:31:56AM +, Ayan Halder wrote:
> We have added a new format ie DRM_FORMAT_XVYU2101010 which is supported
> by mali display driver.
>
> Signed-off-by: Ayan Kumar halder
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm
On Mon, Dec 03, 2018 at 11:31:58AM +, Ayan Halder wrote:
> Added the AFBC decoder registers for DP500 , DP550 and DP650.
> These registers control the processing of AFBC buffers. It controls various
> features like AFBC decoder enable, lossless transformation and block split
> as well as settin
On Mon, Dec 03, 2018 at 11:31:59AM +, Ayan Halder wrote:
> We need to define a common list of format modifiers supported by each of the
> Mali
> display processors. The difference between DP500 from DP550/650 is that DP500
> does not support block split mode (ie AFBC_FORMAT_MOD_SPLIT) and DP55
/patch/10460063/
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/malidp_hw.c | 22 +-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c
> index 55d379b
On Mon, Dec 03, 2018 at 11:32:01AM +, Ayan Halder wrote:
> The constraints are as follows (for Mali-DP 500, 550, 650) :-
>
> 1. AFBC is not supported for the formats defined in
> malidp_hw_format_is_linear_only()
>
> 2. Some of the formats are supported only with AFBC modifiers. Thus we have
al lines.
> 2. DRM_FORMAT_YUV420_10BIT :- It can rotate upto 8 horizontal lines in
> dp550 and 16 horizontal lines in DP650.
>
> Signed-off-by: Ayan Kumar halder
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/malidp_hw.c | 101
>
ck in memory writeback encoder helper function
> to validate if the framebuffer has any modifier and if so, return EINVAL.
>
> Signed-off-by: Ayan Kumar halder
Acked-by: Liviu Dudau
> ---
> drivers/gpu/drm/arm/malidp_mw.c | 5 +
> 1 file changed, 5 insertions(+)
>
&
,
> the calculation of AFBC framebuffer size needs to use malidp_format_get_bpp().
>
> Signed-off-by: Ayan Kumar halder
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/malidp_drv.c | 13 -
> 1 file changed, 8 insertions(+), 5 deletions(-)
e 8 or 16 bytes).
> For example, DRM_FORMAT_VUY101010 is 30 bits per pixel. For a framebuffer of
> width 32 pixels, the pitch will be 120 bytes which is not aligned to burst
> size
> (ie 16 bytes) for DP650.
>
> Signed-off-by: Ayan Kumar halder
Acked-by: Liviu Duda
generate the list of modifiers (to be supported for each
> plane) from
> 'malidp_format_modifiers' and features.
>
> Signed-off-by: Ayan Kumar halder
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/malidp_drv.c| 1 +
> drivers/gpu/drm/arm/malidp_pl
On Fri, Dec 14, 2018 at 01:45:13PM +, Ayan Halder wrote:
> On Tue, Dec 04, 2018 at 04:50:51PM +0000, Liviu Dudau wrote:
>
> Hi Liviu,
>
> Please let me know if you agree with my comments. Then I will send a
> v4 patch for this.
> > On Mon, Dec 03, 2018 at 11:31:58AM
On Fri, Dec 14, 2018 at 02:12:23PM +, Ayan Halder wrote:
> On Tue, Dec 04, 2018 at 04:57:46PM +0000, Liviu Dudau wrote:
>
> Hi Liviu,
> > On Mon, Dec 03, 2018 at 11:32:00AM +, Ayan Halder wrote:
> > > We have added some new formats to be supported on DP500/DP550/DP
struct seq_file *sf);
> +};
> +
> +/**
> + * struct komeda_pipeline
> + *
> + * Represent a complete display pipeline and hold all functional components.
> + */
> +struct komeda_pipeline {
> + /** @obj: link pipeline as private obj of drm_atomic_state */
> + struct drm_p
; + };
> +
> + dp0_pipe1: pipeline@1 {
> + clocks = <&fpgaosc2>, <&dpu_aclk>;
> + clock-names = "pxclk", "aclk";
> + reg = <1>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
same here.
> +
> + port@0 {
> + dp0_pipe1_out: endpoint {
> + remote-endpoint = <&db_dvi1_in>;
> + };
> + };
> + };
> + };
> + ...
> +};
> --
> 2.17.1
>
With these changes:
Reviewed-by: Liviu Dudau
Best regards,
Liviu
--
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---
¯\_(ツ)_/¯
gt; product->identify();
> ...
> }
>
> Changes in v3:
> - Fixed style problem found by checkpatch.pl --strict.
>
> Signed-off-by: James (Qian) Wang
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> .../gpu/drm/arm/display/include/malidp_io.h | 42 +++
f "pipeline" to "pipe".
>
> Signed-off-by: James (Qian) Wang
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> .../gpu/drm/arm/display/komeda/komeda_dev.c | 76 +++
> .../gpu/drm/arm/display/komeda/komeda_dev.h | 3 +
> .../drm/
-strict.
>
> Signed-off-by: James (Qian) Wang
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/display/komeda/Makefile | 1 +
> .../gpu/drm/arm/display/komeda/d71/d71_dev.c | 78
> .../gpu/drm/arm/display/komeda/komeda_dev.c |
create_handle,
> +};
> +
> +static int
> +komeda_fb_none_afbc_size_check(struct komeda_dev *mdev, struct komeda_fb
> *kfb,
> +struct drm_file *file,
> +const struct drm_mode_fb_cmd2 *mode_cmd)
Not sure what
v/null
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_private_obj.c
> @@ -0,0 +1,88 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * (C) COPYRIGHT 2018 ARM Limited. All rights reserved.
> + * Author: James.Qian.Wang
> + *
> + */
> +#include "komeda_dev.h"
> +#include "komeda_kms.h"
> +
> +static struct drm_private_state *
> +komeda_pipeline_atomic_duplicate_state(struct drm_private_obj *obj)
> +{
> + struct komeda_pipeline_state *st;
> +
> + st = kmemdup(obj->state, sizeof(*st), GFP_KERNEL);
> + if (!st)
> + return NULL;
> +
> + st->active_comps = 0;
> +
> + __drm_atomic_helper_private_obj_duplicate_state(obj, &st->obj);
> +
> + return &st->obj;
> +}
> +
> +static void
> +komeda_pipeline_atomic_destroy_state(struct drm_private_obj *obj,
> + struct drm_private_state *state)
> +{
> + kfree(priv_to_pipe_st(state));
> +}
> +
> +static const struct drm_private_state_funcs komeda_pipeline_obj_funcs = {
> + .atomic_duplicate_state = komeda_pipeline_atomic_duplicate_state,
> + .atomic_destroy_state = komeda_pipeline_atomic_destroy_state,
> +};
> +
> +static int komeda_pipeline_obj_add(struct komeda_kms_dev *kms,
> +struct komeda_pipeline *pipe)
> +{
> + struct komeda_pipeline_state *st;
> +
> + st = kzalloc(sizeof(*st), GFP_KERNEL);
> + if (!st)
> + return -ENOMEM;
> +
> + st->pipe = pipe;
> + drm_atomic_private_obj_init(&pipe->obj, &st->obj,
> + &komeda_pipeline_obj_funcs);
> +
> + return 0;
> +}
> +
> +int komeda_kms_add_private_objs(struct komeda_kms_dev *kms,
> + struct komeda_dev *mdev)
> +{
> + struct komeda_pipeline *pipe;
> + int i, err;
> +
> + for (i = 0; i < mdev->n_pipelines; i++) {
> + pipe = mdev->pipelines[i];
> +
> + err = komeda_pipeline_obj_add(kms, pipe);
> + if (err)
> + return err;
> +
> + /* Add component */
> + }
> +
> + return 0;
> +}
> +
> +void komeda_kms_cleanup_private_objs(struct komeda_dev *mdev)
> +{
> + struct komeda_pipeline *pipe;
> + struct komeda_component *c;
> + int i, id;
> +
> + for (i = 0; i < mdev->n_pipelines; i++) {
> + pipe = mdev->pipelines[i];
> + dp_for_each_set_bit(id, pipe->avail_comps) {
> + c = komeda_pipeline_get_component(pipe, id);
> +
> + drm_atomic_private_obj_fini(&c->obj);
> + }
> + drm_atomic_private_obj_fini(&pipe->obj);
> + }
> +}
> --
> 2.17.1
>
Reviewed-by: Liviu Dudau
Best regards,
Liviu
--
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---
¯\_(ツ)_/¯
On Fri, Dec 21, 2018 at 10:00:49AM +, james qian wang (Arm Technology
China) wrote:
> v2: Some editing changes according to Randy Dunlap's comments
>
> Signed-off-by: James (Qian) Wang
Reviewed-by: Liviu Dudau
> ---
> Documentation/gpu/drivers.rst| 1 +
> D
On Fri, Dec 21, 2018 at 10:01:06AM +, james qian wang (Arm Technology
China) wrote:
> v2: Adjusted the position of KOMEDA by alphabetical order
>
> Signed-off-by: James (Qian) Wang
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> MAINTAINERS | 9 +
>
On Thu, Dec 27, 2018 at 07:09:07AM +, james qian wang (Arm Technology
China) wrote:
> On Mon, Dec 24, 2018 at 08:32:14PM +0800, Liviu Dudau wrote:
> > On Fri, Dec 21, 2018 at 10:00:33AM +, james qian wang (Arm Technology
> > China) wrote:
> > > Add komeda_
On Thu, Dec 27, 2018 at 07:09:07AM +, james qian wang (Arm Technology
China) wrote:
> On Mon, Dec 24, 2018 at 08:32:14PM +0800, Liviu Dudau wrote:
> > On Fri, Dec 21, 2018 at 10:00:33AM +, james qian wang (Arm Technology
> > China) wrote:
> > > Add komeda_
On Fri, Dec 28, 2018 at 12:56:27PM +0100, Daniel Vetter wrote:
> On Fri, Dec 28, 2018 at 12:15 PM james qian wang (Arm Technology
> China) wrote:
> >
> > On Mon, Dec 24, 2018 at 02:05:43PM +0100, Daniel Vetter wrote:
> > > On Mon, Dec 24, 2018 at 1:33 PM Liviu Dudau wr
Hi Jonathan,
I have a patch adding documentation for the AFBC modifiers supported
by the DRM framework with an upcoming patch series. Patch has been
out for review for a while, please pull.
The include/uapi/drm/drm_fourcc.h change is only a comment pointing
towards the file's location, I hope thi
defined DRM format modifiers. To facilitate
> > consistency and compatibility between different AFBC producers and
> > consumers, document the expectations for usage of the AFBC DRM format
> > modifiers in a new .rst chapter.
> >
> > Signed-off-by: Brian Starkey
>
Hi Matthew,
On Fri, Jan 11, 2019 at 10:13:44AM -0800, Matthew Wilcox wrote:
> On Fri, Jan 11, 2019 at 06:07:49PM +0000, Liviu Dudau wrote:
> > Hi Jonathan,
> >
> > I have a patch adding documentation for the AFBC modifiers supported
> > by the DRM framework with an u
On Fri, Jan 11, 2019 at 11:12:34AM -0700, Jonathan Corbet wrote:
> On Fri, 11 Jan 2019 18:07:49 +
> Liviu Dudau wrote:
>
> > I have a patch adding documentation for the AFBC modifiers supported
> > by the DRM framework with an upcoming patch series. Patch has been
>
gned-off-by: Brian Starkey
[rebased and fixed conflicts]
Signed-off-by: Mihail Atanassov
[rebased and added atomic_commit() vfunc for writeback jobs]
Signed-off-by: Rob Clark
Signed-off-by: Liviu Dudau
---
Documentation/gpu/drm-kms.rst| 9 +
drivers/gpu/drm/Makefile
36 matches
Mail list logo