Re: [PATCH v5 4/8] thunderbolt: Communication with the ICM (firmware)

2016-07-29 Thread Stephen Hemminger
On Thu, 28 Jul 2016 11:15:17 +0300 Amir Levy wrote: > +static LIST_HEAD(controllers_list); > +static DECLARE_RWSEM(controllers_list_rwsem); Why use a semaphore when simple spinlock or mutex would be better? -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v5 6/8] thunderbolt: Networking transmit and receive

2016-07-29 Thread Stephen Hemminger
On Thu, 28 Jul 2016 11:15:19 +0300 Amir Levy wrote: > + /* pad short packets */ > + if (unlikely(skb->len < ETH_ZLEN)) { > + int pad_len = ETH_ZLEN - skb->len; > + > + /* The skb is freed on error */ > +

[PATCH] doc: add missing docbook parameter for fence-array

2016-10-23 Thread Stephen Hemminger
From: Stephen Hemminger <sthem...@microsoft.com> Fixes 'make htmldocs' warning. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- include/linux/fence-array.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/fence-array.h b/include/linux/fence-array.h i

Re: [PATCH v2 3/3] doc: add documentation for uio-hv-generic

2016-10-18 Thread Stephen Hemminger
On Tue, 18 Oct 2016 13:01:20 +0200 Markus Heiser <markus.hei...@darmarit.de> wrote: > Am 18.10.2016 um 12:54 schrieb Jani Nikula <jani.nik...@linux.intel.com>: > > > On Mon, 17 Oct 2016, Stephen Hemminger <step...@networkplumber.org> wrote: > >> From: St

[PATCH v2 3/3] doc: add documentation for uio-hv-generic

2016-10-17 Thread Stephen Hemminger
From: Stephen Hemminger <sthem...@microsoft.com> Update UIO documentation to include basic information about uio_hv_generic. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- Documentation/DocBook/uio-howto.tmpl | 62 1 file

[PATCH net-next v3 3/3] netvsc: remove bonding setup script

2017-08-01 Thread Stephen Hemminger
No longer needed, now all managed by transparent VF logic. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- tools/hv/bondvf.sh | 255 - 1 file changed, 255 deletions(-) delete mode 100755 tools/hv/bondvf.sh diff --git a/to

[PATCH net-next v3 2/3] netvsc: add documentation

2017-08-01 Thread Stephen Hemminger
Add some background documentation on netvsc device options and limitations. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- Documentation/networking/netvsc.txt | 63 + MAINTAINERS | 1 + 2 files changed, 64 inse

[PATCH net-next v3 0/3] netvsc: transparent VF support

2017-08-01 Thread Stephen Hemminger
ial use case where they want it. Stephen Hemminger (3): netvsc: transparent VF management netvsc: add documentation netvsc: remove bonding setup script Documentation/networking/netvsc.txt | 63 ++ MAINTAINERS | 1 + drivers/net/hyperv/hyperv_net.h | 12

[PATCH net 0/2] minor net kernel-doc fixes

2017-07-12 Thread Stephen Hemminger
Fix a couple of small errors in kernel-doc for networking Stephen Hemminger (2): socket: add documentation for missing elements datagram: fix kernel-doc comments include/net/sock.h | 3 +++ net/core/datagram.c | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-) -- 2.11.0

[PATCH net 2/2] datagram: fix kernel-doc comments

2017-07-12 Thread Stephen Hemminger
me: "t". Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- net/core/datagram.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/core/datagram.c b/net/core/datagram.c index 6877c43cc92d..ee5647bd91b3 100644 --- a/net/core/datagram.c +++ b/

[PATCH net 1/2] socket: add documentation for missing elements

2017-07-12 Thread Stephen Hemminger
Fill in missing kernel-doc for missing elements in struct sock. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- include/net/sock.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/net/sock.h b/include/net/sock.h index 8c85791fc196..f69c8c2782df 100644 --- a/i

[PATCH net-next v2 07/10] netvsc: allow smaller send/recv buffer size

2017-07-26 Thread Stephen Hemminger
The default value of send and receive buffer area for host DMA is much larger than it needs to be. Experimentation shows that 4M receive and 1M send is sufficient. Make the size a module parameter so that it can be adjusted as needed for testing or special needs. Signed-off-by: Stephen Hemminger

[PATCH net-next v2 09/10] netvsc: add documentation

2017-07-26 Thread Stephen Hemminger
Add some background documentation on netvsc device options and limitations. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- Documentation/networking/netvsc.txt | 50 + MAINTAINERS | 1 + 2 files changed, 51 inse

[PATCH net-next v2 05/10] netvsc: optimize receive completions

2017-07-26 Thread Stephen Hemminger
receive flushing is needed * Replace division with conditional test * Replace atomic per-device variable with per-channel check. * Handle corner case where receive completion send fails if ring buffer to host is full. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- d

[PATCH net-next v2 00/10] netvsc fixes and new features

2017-07-26 Thread Stephen Hemminger
ork, packets will come in and out but the Linux kernel gets confused and things like ARP don’t work right. There is no way to block manipulation of the slave device, and I am sure someone will find some special use case where they want it. Stephen Hemminger (10): netvsc: fix return value for set_chann

[PATCH net-next v2 08/10] netvsc: transparent VF management

2017-07-26 Thread Stephen Hemminger
of issues because it depends on the script being run early enough in the boot process and with sufficient information to make the association. This patch moves all that functionality into the kernel. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/hyperv_net.h

[PATCH net-next v2 04/10] netvsc: remove unnecessary indirection of page_buffer

2017-07-26 Thread Stephen Hemminger
The internal API was passing struct hv_page_buffer ** when only simple struct hv_page_buffer * was necessary for passing an array. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/hyperv_net.h | 2 +- drivers/net/hyperv/netvsc.c

[PATCH net-next v2 02/10] netvsc: fix warnings reported by lockdep

2017-07-26 Thread Stephen Hemminger
This includes a bunch of fixups for issues reported by lockdep. * ethtool routines can assume RTNL * send is done with RCU lock (and BH disable) * avoid refetching internal device struct (netvsc) instead pass it as a parameter. Signed-off-by: Stephen Hemminger <st

[PATCH net-next 0/4] netvsc: transparent SR-IOV VF support

2017-07-31 Thread Stephen Hemminger
special use case where they want it. Stephen Hemminger (4): netvsc: transparent VF management netvsc: add documentation netvsc: remove bonding setup script pci-hyperv: do not sleep in compose_msi_msg Documentation/networking/netvsc.txt | 63 ++ MAINTAINERS

[PATCH net-next 1/4] netvsc: transparent VF management

2017-07-31 Thread Stephen Hemminger
of issues because it depends on the script being run early enough in the boot process and with sufficient information to make the association. This patch moves all that functionality into the kernel. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/hyperv_net.h

[PATCH net-next 2/4] netvsc: add documentation

2017-07-31 Thread Stephen Hemminger
Add some background documentation on netvsc device options and limitations. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- Documentation/networking/netvsc.txt | 63 + MAINTAINERS | 1 + 2 files changed, 64 inse

[PATCH net-next 4/4] pci-hyperv: do not sleep in compose_msi_msg

2017-07-31 Thread Stephen Hemminger
nse instead of blocking on completion. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/pci/host/pci-hyperv.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c index 415dcc69a502..334

[PATCH net-next v2 1/3] netvsc: transparent VF management

2017-07-31 Thread Stephen Hemminger
of issues because it depends on the script being run early enough in the boot process and with sufficient information to make the association. This patch moves all that functionality into the kernel. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/hyperv_net.h

[PATCH net-next v2 0/3] netvsc: transparent SR-IOV VF support

2017-07-31 Thread Stephen Hemminger
special use case where they want it. Stephen Hemminger (3): netvsc: transparent VF management netvsc: add documentation netvsc: remove bonding setup script Documentation/networking/netvsc.txt | 63 ++ MAINTAINERS | 1 + drivers/net/hyperv/hyperv_net

[PATCH net-next v2 2/3] netvsc: add documentation

2017-07-31 Thread Stephen Hemminger
Add some background documentation on netvsc device options and limitations. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- Documentation/networking/netvsc.txt | 63 + MAINTAINERS | 1 + 2 files changed, 64 inse

[PATCH net-next v2 3/3] netvsc: remove bonding setup script

2017-07-31 Thread Stephen Hemminger
No longer needed, now all managed by transparent VF logic. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- tools/hv/bondvf.sh | 255 - 1 file changed, 255 deletions(-) delete mode 100755 tools/hv/bondvf.sh diff --git a/to

[PATCH net-next 3/4] netvsc: remove bonding setup script

2017-07-31 Thread Stephen Hemminger
No longer needed, now all managed by transparent VF logic. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- tools/hv/bondvf.sh | 255 - 1 file changed, 255 deletions(-) delete mode 100755 tools/hv/bondvf.sh diff --git a/to

Re: [PATCH net-next 4/4] pci-hyperv: do not sleep in compose_msi_msg

2017-07-31 Thread Stephen Hemminger
On Mon, 31 Jul 2017 16:37:12 -0700 Stephen Hemminger <step...@networkplumber.org> wrote: > The setup of MSI with Hyper-V host was sleeping with locks held. > This error is reported when doing SR-IOV hotplug with kernel built with > lockdep. > > BUG: sleeping functio

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-16 Thread Stephen Hemminger
On Sat, 16 Dec 2017 15:42:25 +0100 Knut Omang wrote: > This patch series implements features to make it easier to run checkers on the > entire kernel as part of automatic and developer testing. > > This is done by replacing the sparse specific setup for the C={1,2}