Re: [PATCH v2 16/23] mm/balloon_compaction: mark remaining functions for having proper kerneldoc

2026-01-15 Thread Lorenzo Stoakes
On Thu, Jan 15, 2026 at 10:20:06AM +0100, David Hildenbrand (Red Hat) wrote:
> Looks like all we are missing for proper kerneldoc is another "*".

Ah nice and easy :) If only it were so easy across the kernel... ;)

>
> Signed-off-by: David Hildenbrand (Red Hat) 

Reviewed-by: Lorenzo Stoakes 

> ---
>  mm/balloon_compaction.c | 10 +-
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c
> index f6e0582bd7ffe..f41e4a179a431 100644
> --- a/mm/balloon_compaction.c
> +++ b/mm/balloon_compaction.c
> @@ -22,7 +22,7 @@ static inline struct balloon_dev_info 
> *balloon_page_device(struct page *page)
>   return (struct balloon_dev_info *)page_private(page);
>  }
>
> -/*
> +/**
>   * balloon_page_insert - insert a page into the balloon's page list and make
>   *the page->private assignment accordingly.
>   * @balloon : pointer to balloon device
> @@ -42,7 +42,7 @@ static inline void balloon_page_insert(struct 
> balloon_dev_info *balloon,
>   list_add(&page->lru, &balloon->pages);
>  }
>
> -/*
> +/**
>   * balloon_page_finalize - prepare a balloon page that was removed from the
>   *  balloon list for release to the page allocator
>   * @page: page to be released to the page allocator
> @@ -140,7 +140,7 @@ size_t balloon_page_list_dequeue(struct balloon_dev_info 
> *b_dev_info,
>  }
>  EXPORT_SYMBOL_GPL(balloon_page_list_dequeue);
>
> -/*
> +/**
>   * balloon_page_alloc - allocates a new page for insertion into the balloon
>   *   page list.
>   *
> @@ -163,7 +163,7 @@ struct page *balloon_page_alloc(void)
>  }
>  EXPORT_SYMBOL_GPL(balloon_page_alloc);
>
> -/*
> +/**
>   * balloon_page_enqueue - inserts a new page into the balloon page list.
>   *
>   * @b_dev_info: balloon device descriptor where we will insert a new page
> @@ -186,7 +186,7 @@ void balloon_page_enqueue(struct balloon_dev_info 
> *b_dev_info,
>  }
>  EXPORT_SYMBOL_GPL(balloon_page_enqueue);
>
> -/*
> +/**
>   * balloon_page_dequeue - removes a page from balloon's page list and returns
>   * its address to allow the driver to release the page.
>   * @b_dev_info: balloon device descriptor where we will grab a page from.
> --
> 2.52.0
>



[PATCH v2 16/23] mm/balloon_compaction: mark remaining functions for having proper kerneldoc

2026-01-15 Thread David Hildenbrand (Red Hat)
Looks like all we are missing for proper kerneldoc is another "*".

Signed-off-by: David Hildenbrand (Red Hat) 
---
 mm/balloon_compaction.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c
index f6e0582bd7ffe..f41e4a179a431 100644
--- a/mm/balloon_compaction.c
+++ b/mm/balloon_compaction.c
@@ -22,7 +22,7 @@ static inline struct balloon_dev_info 
*balloon_page_device(struct page *page)
return (struct balloon_dev_info *)page_private(page);
 }
 
-/*
+/**
  * balloon_page_insert - insert a page into the balloon's page list and make
  *  the page->private assignment accordingly.
  * @balloon : pointer to balloon device
@@ -42,7 +42,7 @@ static inline void balloon_page_insert(struct 
balloon_dev_info *balloon,
list_add(&page->lru, &balloon->pages);
 }
 
-/*
+/**
  * balloon_page_finalize - prepare a balloon page that was removed from the
  *balloon list for release to the page allocator
  * @page: page to be released to the page allocator
@@ -140,7 +140,7 @@ size_t balloon_page_list_dequeue(struct balloon_dev_info 
*b_dev_info,
 }
 EXPORT_SYMBOL_GPL(balloon_page_list_dequeue);
 
-/*
+/**
  * balloon_page_alloc - allocates a new page for insertion into the balloon
  * page list.
  *
@@ -163,7 +163,7 @@ struct page *balloon_page_alloc(void)
 }
 EXPORT_SYMBOL_GPL(balloon_page_alloc);
 
-/*
+/**
  * balloon_page_enqueue - inserts a new page into the balloon page list.
  *
  * @b_dev_info: balloon device descriptor where we will insert a new page
@@ -186,7 +186,7 @@ void balloon_page_enqueue(struct balloon_dev_info 
*b_dev_info,
 }
 EXPORT_SYMBOL_GPL(balloon_page_enqueue);
 
-/*
+/**
  * balloon_page_dequeue - removes a page from balloon's page list and returns
  *   its address to allow the driver to release the page.
  * @b_dev_info: balloon device descriptor where we will grab a page from.
-- 
2.52.0