Re: [PATCH v2 18/23] mm/vmscan: drop inclusion of balloon_compaction.h

2026-01-15 Thread Lorenzo Stoakes
On Thu, Jan 15, 2026 at 10:20:08AM +0100, David Hildenbrand (Red Hat) wrote:
> Before commit b1123ea6d3b3 ("mm: balloon: use general non-lru movable page
> feature"), the include was required because of isolated_balloon_page().
>
> It's no longer required, so let's remove it.
>
> Signed-off-by: David Hildenbrand (Red Hat) 

Seems sensible so:

Reviewed-by: Lorenzo Stoakes 

> ---
>  mm/vmscan.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index a0e3f51de749e..cd9f9a779e89b 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -63,7 +63,6 @@
>  #include 
>
>  #include 
> -#include 
>  #include 
>
>  #include "internal.h"
> --
> 2.52.0
>



[PATCH v2 18/23] mm/vmscan: drop inclusion of balloon_compaction.h

2026-01-15 Thread David Hildenbrand (Red Hat)
Before commit b1123ea6d3b3 ("mm: balloon: use general non-lru movable page
feature"), the include was required because of isolated_balloon_page().

It's no longer required, so let's remove it.

Signed-off-by: David Hildenbrand (Red Hat) 
---
 mm/vmscan.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index a0e3f51de749e..cd9f9a779e89b 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -63,7 +63,6 @@
 #include 
 
 #include 
-#include 
 #include 
 
 #include "internal.h"
-- 
2.52.0