RE: [PATCH v2 net-next 0/1] AccECN packetdrill selftest series

2026-01-15 Thread Chia-Yu Chang (Nokia)
> -Original Message-
> From: Jakub Kicinski  
> Sent: Thursday, January 15, 2026 5:12 AM
> To: Chia-Yu Chang (Nokia) 
> Cc: [email protected]; [email protected]; [email protected]; 
> [email protected]; [email protected]; [email protected]; 
> [email protected]; [email protected]; [email protected]; 
> [email protected]; [email protected]; [email protected]; 
> [email protected]; [email protected]; [email protected]; 
> [email protected]; [email protected]; [email protected]; 
> [email protected]; [email protected]; [email protected]; 
> [email protected]; [email protected]; [email protected]; Koen 
> De Schepper (Nokia) ; 
> [email protected]; [email protected]; 
> [email protected]; cheshire ; [email protected]; 
> [email protected]; Vidhi Goel 
> Subject: Re: [PATCH v2 net-next 0/1] AccECN packetdrill selftest series
> 
> 
> CAUTION: This is an external email. Please be very careful when clicking 
> links or opening attachments. See the URL nok.it/ext for additional 
> information.
> 
> 
> 
> On Wed, 14 Jan 2026 23:25:59 + Chia-Yu Chang (Nokia) wrote:
> > > Missing your own SoB on the patch, but also -- are these supposed to pass 
> > > without the kernel patches? Without going back to check Paolo's message 
> > > my understanding was that you'd repost this as patch 15 of the kernel 
> > > series.
> > >
> > > On the packetdrill side -- is PR #61 the code we need merged?
> > > Doesn't seem like it. Could you please clean that part up and start the 
> > > review process?
> >
> > Thanks, I will add my own SoB in the next version.
> > This patch can NOT pass without the last kernel patch; shall I merge 
> > this series into that kernel series? If yes, I will submit v8 on that 
> > series and add this patch as the last one.
> 
> Yes, please.
> 
> > On the packetdrill, the used packetdrill is commit 
> > 6f2116af6b7e1936a53e80ab31b77f74abda1aaa of the branch:
> > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> > ub.com%2Fminuscat%2Fpacketdrill_accecn&data=05%7C02%7Cchia-yu.chang%40nokia-bell-labs.com%7C4e8d1d517df64fb0e6b008de53ec2d5e%7C5d4717519675428d917b70f44f9630b0%7C0%7C0%7C639040470993547718%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=5%2BP0xyXIjXqfC7B6kuMAaEp%2FYuoPSUkYzKC5PgRZUA4%3D&reserved=0
> >  Shall I create PR? Or above info is ok for merging into packetdrill.
> 
> Please create a PR and let's give Neal a couple of days to look thru it.
> We don't need the packetdrill side to be fully merged upstream but I'd love 
> some indication that it's not going to take long because we need to manually 
> manage the packetdrill build if it's not upstream.

A new PR is now created: PR#96 I google/packetdrill
And the v8 of this patch is also submitted with the updated commit messages.

Thanks.
Chia-Yu



Re: [PATCH v2 net-next 0/1] AccECN packetdrill selftest series

2026-01-14 Thread Jakub Kicinski
On Wed, 14 Jan 2026 23:25:59 + Chia-Yu Chang (Nokia) wrote:
> > Missing your own SoB on the patch, but also -- are these supposed to pass 
> > without the kernel patches? Without going back to check Paolo's message my 
> > understanding was that you'd repost this as patch 15 of the kernel series.
> > 
> > On the packetdrill side -- is PR #61 the code we need merged?
> > Doesn't seem like it. Could you please clean that part up and start the 
> > review process?  
> 
> Thanks, I will add my own SoB in the next version.
> This patch can NOT pass without the last kernel patch; shall I merge
> this series into that kernel series? If yes, I will submit v8 on that
> series and add this patch as the last one.

Yes, please.

> On the packetdrill, the used packetdrill is commit
> 6f2116af6b7e1936a53e80ab31b77f74abda1aaa of the branch:
> https://github.com/minuscat/packetdrill_accecn Shall I create PR? Or
> above info is ok for merging into packetdrill.

Please create a PR and let's give Neal a couple of days to look thru it.
We don't need the packetdrill side to be fully merged upstream but
I'd love some indication that it's not going to take long because
we need to manually manage the packetdrill build if it's not upstream.



RE: [PATCH v2 net-next 0/1] AccECN packetdrill selftest series

2026-01-14 Thread Chia-Yu Chang (Nokia)
> -Original Message-
> From: Jakub Kicinski  
> Sent: Thursday, January 15, 2026 12:14 AM
> To: Chia-Yu Chang (Nokia) 
> Cc: [email protected]; [email protected]; [email protected]; 
> [email protected]; [email protected]; [email protected]; 
> [email protected]; [email protected]; [email protected]; 
> [email protected]; [email protected]; [email protected]; 
> [email protected]; [email protected]; [email protected]; 
> [email protected]; [email protected]; [email protected]; 
> [email protected]; [email protected]; [email protected]; 
> [email protected]; [email protected]; [email protected]; Koen 
> De Schepper (Nokia) ; 
> [email protected]; [email protected]; 
> [email protected]; cheshire ; [email protected]; 
> [email protected]; Vidhi Goel 
> Subject: Re: [PATCH v2 net-next 0/1] AccECN packetdrill selftest series
> 
> 
> CAUTION: This is an external email. Please be very careful when clicking 
> links or opening attachments. See the URL nok.it/ext for additional 
> information.
> 
> 
> 
> On Wed, 14 Jan 2026 17:29:14 +0100 [email protected]
> wrote:
> > Please find the v2 AccECN packetdrill selftest patch series, which 
> > includes 58 test cases used to verify the functionality of Accurate 
> > ECN spec (RFC9768) under a variety of conditions.
> >
> > The used packetdrill is commit 
> > 6f2116af6b7e1936a53e80ab31b77f74abda1aaa
> > of the branch: 
> > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> > ub.com%2Fminuscat%2Fpacketdrill_accecn&data=05%7C02%7Cchia-yu.chang%40
> > nokia-bell-labs.com%7Cbe1f1184a6a5443ee1df08de53c293f4%7C5d47175196754
> > 28d917b70f44f9630b0%7C0%7C0%7C639040292324032411%7CUnknown%7CTWFpbGZsb
> > 3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjo
> > iTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=i0bK%2BtTQnbohn0cLgDDlSh4
> > vHeaa8jLpka7rFy8vo18%3D&reserved=0
> 
> Missing your own SoB on the patch, but also -- are these supposed to pass 
> without the kernel patches? Without going back to check Paolo's message my 
> understanding was that you'd repost this as patch 15 of the kernel series.
> 
> On the packetdrill side -- is PR #61 the code we need merged?
> Doesn't seem like it. Could you please clean that part up and start the 
> review process?

Thanks, I will add my own SoB in the next version.
This patch can NOT pass without the last kernel patch; shall I merge this 
series into that kernel series?
If yes, I will submit v8 on that series and add this patch as the last one.

On the packetdrill, the used packetdrill is commit 
6f2116af6b7e1936a53e80ab31b77f74abda1aaa of the branch: 
https://github.com/minuscat/packetdrill_accecn
Shall I create PR? Or above info is ok for merging into packetdrill.
Thanks.

Chia-Yu



Re: [PATCH v2 net-next 0/1] AccECN packetdrill selftest series

2026-01-14 Thread Jakub Kicinski
On Wed, 14 Jan 2026 17:29:14 +0100 [email protected]
wrote:
> Please find the v2 AccECN packetdrill selftest patch series, which
> includes 58 test cases used to verify the functionality of
> Accurate ECN spec (RFC9768) under a variety of conditions.
> 
> The used packetdrill is commit 6f2116af6b7e1936a53e80ab31b77f74abda1aaa
> of the branch: https://github.com/minuscat/packetdrill_accecn

Missing your own SoB on the patch, but also -- are these supposed to
pass without the kernel patches? Without going back to check Paolo's
message my understanding was that you'd repost this as patch 15 of 
the kernel series.

On the packetdrill side -- is PR #61 the code we need merged?
Doesn't seem like it. Could you please clean that part up and start
the review process?