Re: [PATCH v3 4/4] firmware: remove warning at documentation generation time
On Thu, Dec 01, 2016 at 05:11:54PM +0100, Luis R. Rodriguez wrote: > On Fri, Nov 25, 2016 at 06:50:32PM -0200, Mauro Carvalho Chehab wrote: > > Em Fri, 25 Nov 2016 15:59:47 +0100 > > Silvio Fricke escreveu: > > > > > This patch removes following error at for `make htmldocs`. No functional > > > change. > > > > > > ./drivers/base/firmware_class.c:1348: WARNING: Bullet list ends without > > > a blank line; unexpected unindent. > > > > > > Signed-off-by: Silvio Fricke > > > > Reviewed-by: Mauro Carvalho Chehab > > Acked-by: Luis R. Rodriguez > > Jonathan, > > firmware_class changes have been lately going through Greg's tree, he has a > few > more pending changes on his driver-core-next branch for firmware_class but > this > patch not create a conflict. It can go in first or later as such its > technically fine for it to go either through your tree or Greg's tree. > > I'll let Greg decide. I've bounced him a copy of the patch. I can just take this one in my tree as it's easy to merge as-is. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 4/4] firmware: remove warning at documentation generation time
On Fri, Nov 25, 2016 at 06:50:32PM -0200, Mauro Carvalho Chehab wrote: > Em Fri, 25 Nov 2016 15:59:47 +0100 > Silvio Fricke escreveu: > > > This patch removes following error at for `make htmldocs`. No functional > > change. > > > > ./drivers/base/firmware_class.c:1348: WARNING: Bullet list ends without > > a blank line; unexpected unindent. > > > > Signed-off-by: Silvio Fricke > > Reviewed-by: Mauro Carvalho Chehab Acked-by: Luis R. Rodriguez Jonathan, firmware_class changes have been lately going through Greg's tree, he has a few more pending changes on his driver-core-next branch for firmware_class but this patch not create a conflict. It can go in first or later as such its technically fine for it to go either through your tree or Greg's tree. I'll let Greg decide. I've bounced him a copy of the patch. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 4/4] firmware: remove warning at documentation generation time
Em Fri, 25 Nov 2016 15:59:47 +0100 Silvio Fricke escreveu: > This patch removes following error at for `make htmldocs`. No functional > change. > > ./drivers/base/firmware_class.c:1348: WARNING: Bullet list ends without > a blank line; unexpected unindent. > > Signed-off-by: Silvio Fricke Reviewed-by: Mauro Carvalho Chehab > --- > drivers/base/firmware_class.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c > index 22d1760..37b0221 100644 > --- a/drivers/base/firmware_class.c > +++ b/drivers/base/firmware_class.c > @@ -1345,9 +1345,9 @@ static void request_firmware_work_func(struct > work_struct *work) > * > * Asynchronous variant of request_firmware() for user contexts: > * - sleep for as small periods as possible since it may > - * increase kernel boot time of built-in device drivers > - * requesting firmware in their ->probe() methods, if > - * @gfp is GFP_KERNEL. > + * increase kernel boot time of built-in device drivers > + * requesting firmware in their ->probe() methods, if > + * @gfp is GFP_KERNEL. > * > * - can't sleep at all if @gfp is GFP_ATOMIC. > **/ Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html