RE: [PATCH v4 09/23] iommufd: Abstract iopt_pin_pages and iopt_unpin_pages helpers
> From: Nicolin Chen > Sent: Friday, May 9, 2025 11:03 AM > > The new HW QUEUE object will be added for HW to access the guest queue > for > HW-accelerated virtualization feature. It needs to ensure the guest memory > pages are pinned when HW accesses them and they are contiguous in > physical > address space. 'pin' is the generic requirement but contiguity is vendor specific. Let's make it clear. > > This is very like the existing iommufd_access_pin_pages() that outputs the > pinned page list for the caller to test its contiguity. > > Move those code from iommufd_access_pin/unpin_pages() and related > function > for a pair of iopt helpers that can be shared with the HW QUEUE allocator. > > Rename check_area_prot() to align with the existing iopt_area helpers, and > inline it to the header since iommufd_access_rw() still uses it. > > Reviewed-by: Pranjal Shrivastava > Signed-off-by: Nicolin Chen Reviewed-by: Kevin Tian
Re: [PATCH v4 09/23] iommufd: Abstract iopt_pin_pages and iopt_unpin_pages helpers
On Thu, May 08, 2025 at 08:02:30PM -0700, Nicolin Chen wrote: > The new HW QUEUE object will be added for HW to access the guest queue for > HW-accelerated virtualization feature. It needs to ensure the guest memory > pages are pinned when HW accesses them and they are contiguous in physical > address space. > > This is very like the existing iommufd_access_pin_pages() that outputs the > pinned page list for the caller to test its contiguity. > > Move those code from iommufd_access_pin/unpin_pages() and related function > for a pair of iopt helpers that can be shared with the HW QUEUE allocator. > > Rename check_area_prot() to align with the existing iopt_area helpers, and > inline it to the header since iommufd_access_rw() still uses it. > > Reviewed-by: Pranjal Shrivastava > Signed-off-by: Nicolin Chen > --- > drivers/iommu/iommufd/io_pagetable.h| 8 ++ > drivers/iommu/iommufd/iommufd_private.h | 6 ++ > drivers/iommu/iommufd/device.c | 117 ++-- > drivers/iommu/iommufd/io_pagetable.c| 95 +++ > 4 files changed, 117 insertions(+), 109 deletions(-) Reviewed-by: Jason Gunthorpe Jason
