Basically the enum is not required.
Everything works fine without replacing VIDEO_MODE_xxx by
AV7110_VIDEO_MODE_xxx. (VIDEO_MODE_xxx is defined in videodev.h.)
On the other hand, I like the enum because it defines the interface
between firmware and driver in a clean way. video_tuner-mode
Hi Oliver and Marco,
The patch looked good to me.
Some comments:
IMO, instead of creating an emum for vidmode, I would instead just store
v4l2_std_id there.
if (std-id V4L2_STD_PAL) {
- av7110-vidmode = VIDEO_MODE_PAL;
+ av7110-vidmode =
Mauro Carvalho Chehab wrote:
Hi Oliver and Marco,
The patch looked good to me.
Some comments:
IMO, instead of creating an emum for vidmode, I would instead just store
v4l2_std_id there.
if (std-id V4L2_STD_PAL) {
- av7110-vidmode = VIDEO_MODE_PAL;
+
