Re: [linux-dvb] [Review] Multiproto tree

2007-11-25 Thread Oliver Endriss
Manu Abraham wrote: > Oliver Endriss wrote: > > Card drivers (budget-ci, budget-av) > > --- > > I didn't check the details, but the extensions look ok. > > You might consider whether parts of the stb0899/stb6100 stuff could be > > factored out into a header file. Se

Re: [linux-dvb] [Review] Multiproto tree

2007-11-25 Thread Manu Abraham
Oliver Endriss wrote: > Hi, > > now we had bad weather, and I had some time to review the code. ;-) > > Had an unstable link last week, got fixed. > General note > > Obviously, the multiproto tree has not been updated from master for a > very long time. When merging care must be t

Re: [linux-dvb] [Review] Multiproto tree

2007-11-12 Thread Oliver Endriss
Manu Abraham wrote: > Oliver Endriss wrote: > > ... > > For now I ignored all differences, except for: > > - frontend.h > > - dvb_frontend.[ch] > > - budget-ci.c > > - budget-av.c > > > > > > API extensions (frontend.h) > > --- > > looks fine > > > > > > Card drivers (bu

Re: [linux-dvb] [Review] Multiproto tree

2007-11-11 Thread Manu Abraham
Oliver Endriss wrote: > Hi, > > now we had bad weather, and I had some time to review the code. ;-) > > > General note > > Obviously, the multiproto tree has not been updated from master for a > very long time. When merging care must be taken that no regressions flow > back to the m